Commit Graph

115081 Commits

Author SHA1 Message Date
Rishabh Dave
a246a56776 mon/MDSMonitor: return zero when mds is absent for "mds fail"
... instead of EINVAL.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-16 18:28:36 +05:30
Jason Dillaman
c55e2c8706
Merge pull request #37012 from trociny/wip-46803
librbd: track complete async operation requests

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-11 18:14:46 -04:00
Josh Durgin
05efc0a3ac
Merge pull request #37114 from yuriw/wip-yuriw-crontab-master
qa/tests: running rados with -p 80 to produce better test results on …

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-11 14:42:24 -07:00
Sebastian Wagner
0f90e60faa
Merge pull request #35543 from sebastian-philipp/qa-cephadm-iscsi
qa/cephadm: Add iSCSI

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Georgios Kyratsas <gkyratsas@suse.com>
Reviewed-by: Matthew Oliver <moliver@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-09-11 21:10:37 +02:00
Sebastian Wagner
3a59cd7971
Merge pull request #36936 from mgfritch/cephadm-keyring-rm
mgr/cephadm: remove keyring during daemon post-remove

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 21:09:19 +02:00
Ramana Raja
4b2911fc70
Merge pull request #32581 from rishabh-d-dave/wip-djf-15070
mon, cephfs: Add auth caps for CephFS fsids

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2020-09-12 00:00:52 +05:30
Yuri Weinstein
c261f662c4 qa/tests: running rados with -p 80 to produce better test results on master
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2020-09-11 10:49:35 -07:00
Kefu Chai
a728b9dbbd
Merge pull request #37021 from tchaikov/wip-osd-pass-by-ref
osd: pass pg_log_t by lvalue reference

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-12 01:38:09 +08:00
Casey Bodley
068d46c126
Merge pull request #37011 from tchaikov/wip-rgw-cache-list
rgw: set command desc for "cache list"

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-09-11 13:04:00 -04:00
Kefu Chai
2f2914da5d
Merge pull request #37002 from tchaikov/wip-alpine-cleanup
alpine: remove .editorconfig

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-12 00:43:36 +08:00
Casey Bodley
cd6e535110
Merge pull request #37052 from cbodley/wip-rgw-rest-op-err
rgw: RGWRESTOp no longer tracks separate error code

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2020-09-11 11:33:11 -04:00
Michael Fritch
eea25b5ac7
mgr/cephadm: merge update_keyring_caps -> create_keyring
keyring is removed during daemon remove, which obsoletes the need to
update the keyring caps after get-or-create

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:44 -06:00
Michael Fritch
2266cc1e75
mgr/cephadm: disallow removing the mon keyring
Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:38 -06:00
Michael Fritch
11bbfd5836
mgr/cephadm: remove keyring during daemon post-remove
Fixes: https://tracker.ceph.com/issues/47298
Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:32 -06:00
Michael Fritch
183f7c34a3
mgr/cephadm: pass DaemonDescription during pre/post remove
add more context than simply passing the `daemon_id`

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:26 -06:00
Michael Fritch
a0cefab9e5
mgr/cephadm: add post_remove daemon action
invoked after a daemon has been removed

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-11 08:10:17 -06:00
Mykola Golub
07fbc4b71d librbd: track complete async operation requests
to prevent duplicate maintenance operations due to RPC hiccups.

Fixes: https://tracker.ceph.com/issues/46803
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-09-11 14:48:53 +01:00
Jason Dillaman
251ccb8d95
Merge pull request #36825 from trociny/wip-47068
librbd: task finisher should distinguish quiesce tasks with different ID

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-11 09:25:57 -04:00
Rishabh Dave
995c73639b qa/cephfs: add tests for "fs authorize" subcommand
Make caps FS-specific affects "fs authorize" subcommand. Let's add few
tests to verify its behaviour.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-11 18:04:23 +05:30
Rishabh Dave
4e0f090861 qa/cephfs: backup mount object before running tests
Right now, only client IDs are stashed and restored but with the recent
changes (addition of more attributes to mount objects, specifically),
this is not enough. Saving and restoring these details before and after
tests respectively ensures that mount commands rus smoothly. Not doing
this typically leads to mount command failure for the second test in the
testsuite under execution since the client IDs are saved and restored in
CephFSTestCase.setUp and CephFSTestCase.tearDown respectively but the
rest of the details are not.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-11 18:04:23 +05:30
Rishabh Dave
352a41d1b3 qa/cephfs: add tests for multi-FS auth tests
Add testsuite for testing authorization on Ceph cluster with multiple
file systems and enable it to be executable with Teuthology framework.

Also add helper methods required to setup the test environment for
multi-FS tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-11 18:02:48 +05:30
Sebastian Wagner
1bd86d3316 mgr/cephadm: allow iscsi to be named by teuthology
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 14:18:54 +02:00
Sebastian Wagner
130c7a438e qa/cephadm: Also fetch iscsi logs
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 14:17:09 +02:00
Sebastian Wagner
430f2c5132 qa/cephadm: Add iSCSI
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 14:17:09 +02:00
Sebastian Wagner
f972becdf8
Merge pull request #37094 from adk3798/iscsi-m
cephadm: remove z option from iSCSI dev and configfs mount

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 14:09:52 +02:00
Kefu Chai
bcd01b9195
Merge pull request #37084 from tchaikov/wip-crimson-fmt
crimson/osd: fix fmt::format() errors and cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-11 19:37:12 +08:00
Kefu Chai
5172e0f6a3
Merge pull request #37099 from tchaikov/wip-crimson-cause-sv
crimson/osd: pass the the cause by string_view

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-11 18:55:04 +08:00
Sridhar Seshasayee
af1ab10251
Merge pull request #37031 from sseshasa/wip-pgpush-recovery-class
osd: Introduce new PGOpQueueable class for recovery push/reply messages.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2020-09-11 15:06:04 +05:30
Kefu Chai
2910f973a7
Merge pull request #36745 from ifed01/wip-ifed-bluefs-remove-obsolete
os/bluestore: get rid of obsolete stuff in bluefs.

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>
2020-09-11 17:13:25 +08:00
Sebastian Wagner
49d36740a0
Merge pull request #36822 from sebastian-philipp/cephadm-container-init
cephadm: Add --container-init
2020-09-11 11:12:21 +02:00
Kefu Chai
75bbdeb0c3
Merge pull request #36211 from kshtsk/wip-remote-write-file
qa/tasks: use remote write file

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-11 17:11:10 +08:00
Kefu Chai
7b5fce3521
Merge pull request #37029 from tchaikov/wip-pybind-finer-grainer-test
test/pybind: split aio_test into smaller pieces

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-11 17:10:43 +08:00
Kefu Chai
71f9a8de14
Merge pull request #32169 from zjcmszh/cmpext_op
pybind: add aio_cmpext()

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-11 17:09:47 +08:00
Kefu Chai
3fb7f3118e
Merge pull request #37036 from changchengx/unused_var
common: remove data_dir_option in func global_init

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-11 17:06:44 +08:00
Kefu Chai
23e963bb1a crimson/osd: pass the the cause by string_view
in future, string_view can be used almost every where string can be
used. in this change, `const char*` is instead passed to the constructor
of system_error, as we can ensure that the string_view instances are
always constructed from a `const char*` ended with `\0`.

we need this change for two reasons:

* better performance
* prefer for the world where string_view rules.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-11 16:59:55 +08:00
Adam King
351b92acda cephadm: remove z option from iSCSI dev and configfs mount
selinux complains if you try to deploy iSCSI with the z option
on the /dev and /sys/kernel/config mounts

Signed-off-by: Adam King <adking@redhat.com>
2020-09-10 20:45:28 -04:00
Sebastian Wagner
3713645324
Merge pull request #36935 from mgfritch/cephadm-ceph-service
mgr/cephadm: introduce `CephService` class

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-09-11 00:13:10 +02:00
zdover23
b22cf6da57
Merge pull request #37070 from zdover23/wip-doc-3-hacking-into-docs
doc/dev: add HACKING.rst to Dev Guide

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-11 08:04:24 +10:00
Casey Bodley
4ac040bfe9
Merge pull request #37089 from cbodley/wip-cmake-osd-fifo
cmake: add cls_fifo as a dependency of osd

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
2020-09-10 14:52:27 -04:00
Rishabh Dave
3f0284f272 qa/cephfs: add methods to read/write on CephFS mounts
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-10 23:57:15 +05:30
Rishabh Dave
04ed58fec2 qa/cephfs: modify delete_all_filesystems() in filesystem.py
Modify filesystem.Filesystem.delete_all_filesystems() method to make it
more succinct, move it to class MDSCluster instead and update every call
to it accordingly.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-10 23:56:59 +05:30
Sebastian Wagner
8c47db39b8
Merge pull request #36980 from adk3798/fix-iscsi
cephadm: fix iSCSI unit.run file

Reviewed-by: Matthew Oliver <moliver@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-09-10 20:02:03 +02:00
Neha Ojha
9e81f39733
Merge pull request #36747 from varshar16/wip-doc-update-about-priority-check
doc/developer_guide: Update about '--force-priority' flag

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.de>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-10 10:29:29 -07:00
Casey Bodley
12c145f22b
Merge pull request #36313 from changchengx/fix_warning
rgw: fix vector index warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-09-10 12:59:05 -04:00
Casey Bodley
9fbb31d6be cmake: add cls_fifo as a dependency of osd
otherwise cls_fifo is not built by 'make vstart'

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2020-09-10 12:45:54 -04:00
Casey Bodley
701f019a76 rgw: RGWRESTOp no longer tracks separate error code
RGWOp_Bucket_Remove::execute() was storing failures from
bucket->remove_bucket() in op_ret, but left http_ret=0 so we responded
to the client with '200 OK'

to avoid bugs like this, remove the extra http_ret variable and only use
the op_ret from RGWOp

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2020-09-10 12:34:56 -04:00
Kefu Chai
4ae71a068f
Merge pull request #37075 from tchaikov/wip-doc-dev
doc/dev: fix broken link and fix the codeblocks' formatting

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-09-10 23:29:30 +08:00
Zac Dover
5760cff6e3 doc/dev: add HACKING.rst to Dev Guide
This commit exposes HACKING.rst through the
docs website. Formerly, HACKING.rst was just
a file that existed at /src/pybind/mgr/dashboard/
HACKING.rst. This commit also updates README.rst
to point to the new location of HACKING.rst.

Fixes: https://tracker.ceph.com/issues/47230
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-09-11 01:00:48 +10:00
Sebastian Wagner
57ba572964
Merge pull request #37071 from votdev/cleanup_servicespec_code
cephadm: Remove assignment to member variable in ServiceSpecs

Reviewed-by: Joshua Schmid <jschmid@suse.de>
2020-09-10 16:08:08 +02:00
Sebastian Wagner
e79a7c8c74 Merge PR #37046 into master
* refs/pull/37046/head:
	cephadm: unit.run: create /var/run/ceph/$FSID before doing anything else

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2020-09-10 16:03:48 +02:00