Danny Al-Gaaf
a1be9ef4fe
NewStore.cc: prefer --/++operator for non-primitive iterators
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
534fdd5c8f
ErasureCodeShecTableCache.cc: prefer --operator for non-primitive iterators
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
4a2377c40b
rgw_object_expirer_core.cc: remove left over unused variable
...
Remove unused variable is_next_available and while loop. These
are leftovers from commit #a69a989f.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
b229162e36
client/Client.cc: fix memory leak, free sgids in error case
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
e243aa84c0
mds/MDSDaemon.cc: fix resource leak in MDSDaemon
...
Delete mdsmap in descructor. Remove not needed checks for
mds_rank and objecter before call delete since the C++ standard
allows the deletion of pointer with NULL-value. The check is
redundant.
Fix for:
CID 1316224 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK)
1. alloc_new: Allocating memory by calling new MDSMap.
2. var_assign: Assigning: this->mdsmap = new MDSMap.
3. ctor_dtor_leak: The constructor allocates field mdsmap of MDSDaemon
but the destructor and whatever functions it calls do not free it.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
a29dd45dd8
client/Client.cc: remove only once used variable
...
Fix for:
[src/client/Client.cc:4555]: (style) The scope of the variable
'initial_group_count' can be reduced.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
7a7248d952
ConfigKeyService.cc: move assert before first deref
...
Fix for:
[src/mon/ConfigKeyService.cc:94] -> [src/mon/ConfigKeyService.cc:100]:
(warning) Possible null pointer dereference: m - otherwise it is redundant
to check it against null.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
742feec7bc
mds/MDCache.cc: fix unitialized variable
...
Fix for:
[src/mds/MDCache.cc:8172]: (error) Uninitialized variable: checked_rank
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
897f074969
test_async_compressor.cc: prefer ++operator for non-primitive iterators
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
9d9b305981
os/KeyValueStore.cc: prefer ++operator for non-primitive iterators
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
8810f8f2b8
SnappyCompressor.h: prefer ++operator for non-primitive iterators
...
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
4f98dab99c
client/Client.cc: fix realloc memory leak
...
Fix handling of realloc. If realloc() fails it returns NULL, assigning
the return value of realloc() directly to the pointer without checking
for the result will lead to a memory leak.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Loic Dachary
384d7f4c3c
Merge pull request #5837 from tchaikov/wip-12968
...
mon: disable gmt_hitset if not supported
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-09 13:06:47 +02:00
Kefu Chai
cdca05feb0
Merge pull request #5842 from dzafman/wip-cot-failure
...
test: Fix failure test to find message anywhere in stderr
Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-09 18:12:30 +08:00
Haomai Wang
ae5e961e9d
Merge pull request #5845 from wonzhq/async-rx
...
AsyncMessenger: add instance name in debug log when processing msg
Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
2015-09-09 15:20:01 +08:00
Loic Dachary
ddb5301e7e
Merge pull request #5779 from dzafman/wip-misc-fix-guangyy
...
osd: check the length of the map before accessing the first element
Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-09 09:00:41 +02:00
Josh Durgin
f95174260d
Merge pull request #5843 from dillaman/wip-12885
...
librbd: diff_iterate needs to handle holes in parent images
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-09 02:55:44 -04:00
Josh Durgin
714a091e1a
Merge pull request #5592 from xinxinsh/wip-fix-rbd-metadata
...
fix bugs of rbd metadata operation
Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-09 02:54:45 -04:00
David Zafman
95bd3c2c54
test: Fix failure test to find message anywhere in stderr
...
Consolidate test_failure() and test_failure_tty()
Signed-off-by: David Zafman <dzafman@redhat.com>
2015-09-08 23:44:39 -07:00
David Zafman
b968fb3bce
rados: Fix usage for "notify" command
...
Signed-off-by: David Zafman <dzafman@redhat.com>
2015-09-08 23:44:39 -07:00
Kefu Chai
3868939fbd
Merge pull request #5834 from ceph/wip-leveldb-hang
...
mon: MonitorDBStore: make get_next_key() work properly
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-09 12:46:03 +08:00
Kefu Chai
8e8d529fb3
Merge pull request #4955 from kylinstorage/librados-2read-segmentation-fault-v1
...
bug fix: librados segmentation fault, when two read ops share one Aio…
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-09 12:45:01 +08:00
Kefu Chai
915fd2c9a3
Merge pull request #4925 from XinzeChi/wip-hit-set-size
...
osd: fix hit_set_map size for tier pool
Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-09 12:44:21 +08:00
Kefu Chai
61c7ac1c2b
Merge pull request #5723 from H3C/wip-msg-bugfix1
...
msg: we should set the socket options before connect or listen in order to have it take effect.
Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-09 12:43:28 +08:00
Kefu Chai
120bd680c3
Merge pull request #5829 from dachary/wip-12731-jerasure-warnings
...
erasure-code: fix gf-complete warnings
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-09 12:41:58 +08:00
Zhiqiang Wang
d74135231c
AsyncMessenger: add instance name in debug log when processing msg
...
To better debug.
Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com>
2015-09-09 11:40:48 +08:00
David Zafman
a05c4c00b4
Merge pull request #5781 from dzafman/wip-eccleanup
...
osd, test: Minor clean-up from fast-read and error handling ec changes
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-08 18:25:58 -07:00
Jason Dillaman
3ccc3bb4bd
librbd: diff_iterate needs to handle holes in parent images
...
If a clone's parent image snapshot includes a discarded extent,
this was previously causing an assert failure. Instead, ignore
any discard holes in the parent image.
Fixes : #12885
Backport: hammer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-09-08 15:47:37 -04:00
Jason Dillaman
d5650c9cf8
tests: new test case for librbd diff_iterate over discard extents
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-09-08 15:45:45 -04:00
Sage Weil
c2293104d2
Merge pull request #5838 from ceph/wip-12861
...
qa/workunits/rados/test_alloc_hint.sh: sudo to ls files
Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-08 14:08:18 -04:00
Sage Weil
a7f1a3ac6c
Merge pull request #5396 from XinzeChi/wip-scrub-promote
...
bug fix: osd: requeue_scrub when kick_object_context_blocked
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
2015-09-08 11:41:38 -04:00
Sage Weil
026012fd62
Merge pull request #5772 from yuyuyu101/wip-12912
...
AsyncConnection: Close connection when unregistered connection met WAIT
2015-09-08 11:41:06 -04:00
Yehuda Sadeh
ba0800354e
Merge pull request #5733 from cxwshawn/rgw-fix
...
rgw: init_rados failed leads to repeated delete
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-08 08:39:43 -07:00
Yehuda Sadeh
02eefbf302
Merge pull request #5809 from rzarzynski/wip-rgw_putobj_debug_improvement
...
rgw: improve debugs in RGWPutObj and RGWPutObj_ObjStore_SWIFT.
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-08 08:35:46 -07:00
Orit Wasserman
16adf6c215
Merge pull request #5567 from guce/rgw_check_key_parameter_conflict
...
rgw: add key parameter conflict check for radosgw-admin command line.
2015-09-08 17:33:13 +02:00
Yehuda Sadeh
ce9fd79881
Merge pull request #5819 from rzarzynski/wip-12950
...
rgw: don't append empty ETag HTTP header.
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-08 08:17:24 -07:00
Sage Weil
c979130755
Merge remote-tracking branch 'gh/infernalis'
2015-09-08 11:02:54 -04:00
Kefu Chai
d32a3be1a6
qa/workunits/rados/test_alloc_hint.sh: sudo to ls files
...
The osd data dir is owned by ceph and not readable by other
non-root users.
Fixes : #12861
Signed-off-by: Kefu Chai <kchai@redhat.com>
2015-09-08 20:50:36 +08:00
Loic Dachary
49ee455b35
Merge pull request #5257 from t-miyamae/wip-mshec-fixlogic4
...
erasure code: shec performance optimization by decoding cache
Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-08 13:52:05 +02:00
Xiaowei Chen
ab4232baa7
rgw: init_rados failed leads to repeated delete
...
Fixes : #12978
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
2015-09-08 06:59:00 -04:00
Kefu Chai
ef9283ae90
Merge pull request #5463 from kylinstorage/wip-evict_ops
...
Allow evict operations to be throttled
Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-08 17:29:29 +08:00
Kefu Chai
6cb448daf0
Merge pull request #5745 from ceph/wip-12904
...
osd: sparse reads returning invalid extent map
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-08 17:27:22 +08:00
Kefu Chai
fb2d4f2139
Merge pull request #5580 from xinxinsh/wip-merge-two-setattr
...
merge two continuous OP_SETATTR ops into one OP_SETATTRS
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-08 17:26:28 +08:00
Kefu Chai
e48cec3dc9
mon: disable gmt_hitset if not supported
...
the gmt_hitset is enabled by default in the ctor of pg_pool_t, this
is intentional. because we want to remove this setting and make
gmt_hitset=true as a default in future. but this forces us to
disable it explicitly when preparing a new pool if any OSD does
not support gmt hitset.
Fixes : #12968
Signed-off-by: Kefu Chai <kchai@redhat.com>
2015-09-08 16:56:04 +08:00
Joao Eduardo Luis
02f4461cad
test: mon: mon-scrub.sh: test 'mon scrub'
...
In its current state is used to catch regressions on 'ceph mon scrub'
hanging due to an infinite loop.
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-08 09:48:41 +01:00
Sage Weil
0200403bec
Merge pull request #5785 from liewegas/wip-12861
...
qa/workunits/rados/test_alloc_hint.sh: sudo to list files
2015-09-07 10:40:37 -04:00
Joao Eduardo Luis
70d31082fd
mon: MonitorDBStore: make get_next_key() work properly
...
We introduced a significant bug with 2cc7aee
, when we fixed issue #11786 .
Although that patch would fix the problem described in #11786 , we
managed to not increment the iterator upon returning the current key.
This would have the iterator iterating over the same key, forever and
ever.
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-07 14:12:19 +01:00
Kefu Chai
5f2fca26e9
Merge pull request #5784 from dachary/wip-docker-helper
...
fix docker-test.sh for CentOS 7
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-07 19:45:51 +08:00
Loic Dachary
e8089049c3
tests: drop docker-tests.sh root and /dev support
...
Now that ceph-disk.sh activation tests switched to the ceph-disk suite
as found in https://github.com/ceph/ceph-qa-suite/tree/master/suites/ceph-disk ,
it does not need for root and /dev support from docker-tests.sh. There
currently is no other use case and since it's generally not a good idea
to run anything as root in a container anyway.
Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-09-07 13:26:14 +02:00
Loic Dachary
bfde30db98
tests: CentOS 7 needs systemd-container
...
It is now needed by the Ceph dependencies and won't work unless the fake
version of it is replaced by the actual one.
Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-09-07 13:24:44 +02:00