Commit Graph

123917 Commits

Author SHA1 Message Date
Yingxin Cheng
9ecaeadf61 crimson/onode-staged-tree: cleanup internal_fields_3_t template
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
2258730bee crimson/onode-staged-tree: pass node_size into node_extent_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
f7e77c9bee crimson/onode-staged-tree: extend num_keys_t to support larger nodes
Also adjust the accroding layout related unit tests.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
7e24c625ed crimson/onode-staged-tree: remove hard-coded node_stage_t::EXTENT_SIZE
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
70ced70d04 crimson/onode-staged-tree: check the maximum tree height
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
a28ad7ebb1 crimson/onode-staged-tree: validate safe-split from tree_conf_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
37d721cf69 crimson/onode-staged-tree: add and use node sizes in tree_conf_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
50d1afd7a2 crimson/onode-staged-tree: implement size upper-bounds to value
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
6fb8807678 crimson/onode-staged-tree: implement size upper-bounds to ns/oid
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
431d69ebd6 crimson/onode-staged-tree: introduce compile-time tree_conf_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
1cb6f09d3d crimson/onode-staged-tree: cleanup, decouple test_item_t from TestValue
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
8b6422b49a crimson/seastore: introduce TransactionManager::read_extent(t, offset)
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
88fd967b78 crimson/onode-staged-tree: correct the node size equation
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:58 +08:00
Yingxin Cheng
9e8bb747ca crimson/onode-staged-tree: try merge peer if node has one value
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:43:47 +08:00
Yingxin Cheng
2921f27b97 crimson/onode-staged-tree: cleanup and introduce has_single_value()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-11 22:42:25 +08:00
J. Eric Ivancich
0b43e5f8ed
Merge pull request #38135 from joke-lee/fix-list-parts-show-id-and-displayname
rgw: RGWListMultipart show Owner ID and DisplayName

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2021-06-08 13:20:05 -04:00
J. Eric Ivancich
2b8f0b9684
Merge pull request #40975 from trociny/wip-50415
cls/rgw: look for plain entries in non-ascii plain namespace too

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2021-06-08 13:19:33 -04:00
J. Eric Ivancich
28f644ddf5
Merge pull request #41065 from pponnuvel/tracker_50554
rgw: Improve error message on email id reuse

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2021-06-08 13:19:16 -04:00
J. Eric Ivancich
be32908d57
Merge pull request #41678 from ivancich/wip-multipart-delete-marker
rgw: completion of multipart upload leaves delete marker

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin mbenjamin@redhat.com
2021-06-08 13:18:25 -04:00
zdover23
29d4bd3ceb
Merge pull request #41760 from zdover23/wip-doc-2021-06-09-dev-guide-reposotory-spelling
doc/dev: s/reposotory/repository/ (really)

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-09 02:14:25 +10:00
Zac Dover
298b446c35 doc/dev: s/reposotory/repository/ (really)
This corrects the heinous misspelling described in the
substitution expression in the title. This misspelling is
all the more egregious because it appears in a title, and
therefore would be used to create links if it had not been
caught.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-06-09 01:57:13 +10:00
Ernesto Puerta
90a78befc1
Merge pull request #41523 from rhcs-dashboard/fix-50955-master
mgr/dashboard: introduce separate front-end component for API docs

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-06-08 17:48:25 +02:00
Kefu Chai
c384b04ceb
Merge pull request #41703 from tchaikov/wip-options-mgr-mon
common/options: extract mgr and mon options out

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-06-08 23:33:38 +08:00
Kefu Chai
04fa416472
Merge pull request #41444 from Daniel-Pivonka/cephadm-monitoring-ip-bind
mgr/cephadm: allow monitoring stack ip binding and custom ports

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Adam King <adking@redhat.com>
2021-06-08 23:32:24 +08:00
Kefu Chai
fb25fa722a
Merge pull request #41555 from mgfritch/cephadm-pytest-bootstrap
cephadm: add bootstrap unit tests

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-06-08 23:30:47 +08:00
Kefu Chai
7bb4628e76
Merge pull request #41567 from ybwang0211/listxattr
doc: Added the explanation of the 'listxattr <obj-name>' and 'getxattr <obj-name> attr' commands

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 23:30:13 +08:00
Kefu Chai
a879aadd51
Merge pull request #41724 from tchaikov/wip-cmdparse-cleanup
common/cmdparse: do not create temp string unless necessary

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-08 23:29:27 +08:00
Ernesto Puerta
a9ea94f8f6
Merge pull request #41656 from rhcs-dashboard/49885-fix-bucket-object-lock-fields
mgr/dashboard: simplify object locking fields in 'Bucket Creation' form

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-06-08 16:53:10 +02:00
Kefu Chai
cf4587e654
Merge pull request #41743 from tchaikov/wip-rgw-lua-exception
rgw/rgw_lua_utils: return error using luaL_error()

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2021-06-08 21:33:50 +08:00
Kefu Chai
e2693727ac
Merge pull request #41689 from tchaikov/wip-vstart-restful
vstart.sh: disable restful by default

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-06-08 20:23:40 +08:00
Kefu Chai
873e3fc8dc
Merge pull request #41756 from rzarzynski/wip-crimson-monc-fix-races-in-on_session_opened
crimson/monc: fix races between on_session_opened() and the reset sequence

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 19:40:38 +08:00
Kefu Chai
52600606fa
Merge pull request #41747 from dengchl01/dengchl01-commit
mgr/mgr_module: update docstring of MgrModule.get()

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 19:11:35 +08:00
Radoslaw Zarzynski
b5f3dc4d9d crimson/monc: fix races between on_session_opened() and the reset sequence.
The `active_con` can get invalidated every single time when there is
a preemption point. This includes even the middle connection open
sequence as it's spread across multiple continuations!

Unfortunately, we don't check for `active_con` in the lambdas inside
the `on_session_opened()` method. That was the reason of the following
crash at Sepia [1]:

```
INFO  2021-06-08 09:36:23,992 [shard 0] monc - do_auth_single: connection closed
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-4967-g96cdf983/rpm/el8/BUILD/ceph-17.0.0-4967-g96cdf983/src/crimson/mon/MonClient.cc:399:10: runtime error: member access within null pointer of type 'struct Connection'
Segmentation fault on shard 0.
Backtrace:
 0# 0x000055C3C1CA860F in ceph-osd
 1# FatalSignal::signaled(int, siginfo_t const*) in ceph-osd
 2# FatalSignal::install_oneshot_signal_handler<11>()::{lambda(int, siginfo_t*, void*)#1}::_FUN(int, siginfo_t*, void*) in ceph-osd
 3# 0x00007FAAE1713B20 in /lib64/libpthread.so.0
 4# crimson::mon::Connection::get_conn() in ceph-osd
 5# 0x000055C3C2532DA8 in ceph-osd
 6# 0x000055C3C2535CB5 in ceph-osd
 7# 0x000055C3BBC9FC70 in ceph-osd
 8# 0x000055C3C76FAE5F in ceph-osd
 9# 0x000055C3C77003A0 in ceph-osd
10# 0x000055C3C78B240B in ceph-osd
11# 0x000055C3C740FE8A in ceph-osd
12# 0x000055C3C7419FAE in ceph-osd
13# main in ceph-osd
14# __libc_start_main in /lib64/libc.so.6
15# _start in ceph-osd
Fault at location: 0x98
```

[1]: http://pulpito.front.sepia.ceph.com/rzarzynski-2021-06-08_09:11:05-rados-master-distro-basic-smithi/6159602

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-08 10:57:03 +00:00
dengchl01
ff15d24d4a mgr/mgr_module: add docstring of MgrModule.get()-mgr_map,modified_config_options,service_map,mds_metadata,pg_status,osd_pool_stats,mgr_ips,have_local_config_map
Signed-off-by: dengchl01 <dengchl01@inspur.com>
2021-06-08 15:42:27 +08:00
Kefu Chai
a5fd875665
Merge pull request #41745 from tchaikov/wip-crimson-osd-cleanup
crimson/osd: do not capture unused variable

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-06-08 13:57:03 +08:00
Kefu Chai
02f7a41f9c crimson/osd: do not capture unused variable
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-08 13:12:41 +08:00
Kefu Chai
0182a11670 rgw/rgw_lua*: return unknown field error using luaL_error()
it's found on aarch64, the exception is not caught even if we do
catch exactly the same type of thrown exception, and the uncaught
exception ends up with a std::terminate() call. it could be the ABI
mismatch in aarch64, so the C++ runtime failed to find the catch block.

in this change, luaL_error() is used to populate the error to the
caller instead to workaround this issue.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-08 12:44:43 +08:00
Kefu Chai
9b2e0b6ac2 rgw/rgw_lua_utils: return error using luaL_error()
it's found on aarch64, the exception is not caught even if we do
catch exactly the same type of thrown exception, and the uncaught
exception ends up with a std::terminate() call. it could be the ABI
mismatch in aarch64, so the C++ runtime failed to find the catch block.

in this change, luaL_error() is used to populate the error to the
caller instead to workaround this issue.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-08 12:44:35 +08:00
Kefu Chai
7fc07dd728
Merge pull request #41742 from lmgdlmgd/master
mgr/mgr_module: correct docstring of MgrModule.get()

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 09:26:43 +08:00
Kefu Chai
ed4ef5a3dd
Merge pull request #41736 from rzarzynski/wip-crimson-alienstore-open_collection_dne
crimson/os/alienstore: open_collection() returns nullptr if DNE.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 08:59:36 +08:00
Kefu Chai
191cd95211
Merge pull request #41730 from tchaikov/wip-fc35-python
do_cmake.sh: use python3.10 for fedora 35

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2021-06-08 08:58:48 +08:00
靳登科
24ca308e10 mgr/mgr_module: correct docstring of MgrModule.get()
In annotation, one of param of Mgr_module.get() is "osd_crush_map_text", but in PyObject *ActivePyModules::get_python and selftest, the param is "osdmap_crush_map_text", so update annotation from "osd_crush_map_text" to "osdmap_crush_map_text"

Signed-off-by: lmgdlmgd <1105050771@qq.com>
2021-06-08 08:55:20 +08:00
Andrew Schoen
acaad279c7
Merge pull request #40659 from PepperJo/data_allocate_fraction_v2
ceph-volume,python-common: Data allocate fraction

Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2021-06-07 14:06:52 -05:00
Radoslaw Zarzynski
04c0196b62 crimson/os/alienstore: open_collection() returns nullptr if DNE.
This is an AlienStore's counterpart of 9fbd60131b
which becomes necessary as, since 6b66c30b23,
we call `open_collection()` to check the existence of OSD's superblock.

Without this fix the following crash happens:

```
[rzarzynski@o06 build]$ MDS=0 MGR=0 OSD=1 ../src/vstart.sh -l -n --without-dashboard --crimson
...
crimson-osd: boost/include/boost/smart_ptr/intrusive_ptr.hpp:199: T* boost::intrusive_ptr<T>::operator->() const [with T = ObjectStore::CollectionImpl]: Assertion `px != 0' failed.
Aborting on shard 0.
Backtrace:
 0# print_backtrace(std::basic_string_view<char, std::char_traits<char> >) at /home/rzarzynski/ceph1/build/boost/include/boost/stacktrace/stacktrace.hpp:129
 1# FatalSignal::signaled(int, siginfo_t const*) at /home/rzarzynski/ceph1/build/../src/crimson/common/fatal_signal.cc:80
 2# FatalSignal::install_oneshot_signal_handler<6>()::{lambda(int, siginfo_t*, void*)#1}::operator()(int, siginfo_t*, void*) const at /home/rzarzynski/ceph1/build/../src/crimson/common/fatal_signal.cc:41
 3# FatalSignal::install_oneshot_signal_handler<6>()::{lambda(int, siginfo_t*, void*)#1}::_FUN(int, siginfo_t*, void*) at /home/rzarzynski/ceph1/build/../src/crimson/common/fatal_signal.cc:36
 4# 0x00007F8BF534DB30 in /lib64/libpthread.so.0
 5# gsignal in /lib64/libc.so.6
 6# abort in /lib64/libc.so.6
 7# 0x00007F8BF3948B19 in /lib64/libc.so.6
 8# 0x00007F8BF3956DF6 in /lib64/libc.so.6
 9# boost::intrusive_ptr<ObjectStore::CollectionImpl>::operator->() const at /home/rzarzynski/ceph1/build/boost/include/boost/smart_ptr/intrusive_ptr.hpp:200
10# crimson::os::AlienStore::open_collection(coll_t const&)::{lambda(boost::intrusive_ptr<ObjectStore::CollectionImpl>)#2}::operator()(boost::intrusive_ptr<ObjectStore::CollectionImpl>) const at /home/rzarzynski/ceph1/build/../src/crimson/os/alienstore/alien_store.cc:214
11# seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > seastar::futurize<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > >::invoke<crimson::os::AlienStore::open_collection(coll_t const&)::{lambda(boost::intrusive_ptr<ObjectStore::CollectionImpl>)#2}&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >(crimson::os::AlienStore::open_collection(coll_t const&)::{lambda(boost::intrusive_ptr<ObjectStore::CollectionImpl>)#2}&, boost::intrusive_ptr<ObjectStore::CollectionImpl>&&) at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:2135
12# auto seastar::futurize_invoke<crimson::os::AlienStore::open_collection(coll_t const&)::{lambda(boost::intrusive_ptr<ObjectStore::CollectionImpl>)#2}&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >(crimson::os::AlienStore::open_collection(coll_t const&)::{lambda(boost::intrusive_ptr<ObjectStore::CollectionImpl>)#2}&, boost::intrusive_ptr<ObjectStore::CollectionImpl>&&) at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:2167
13# _ZZN7seastar6futureIN5boost13intrusive_ptrIN11ObjectStore14CollectionImplEEEE4thenIZN7crimson2os10AlienStore15open_collectionERK6coll_tEUlS5_E0_NS0_INS2_INS9_19FuturizedCollectionEEEEEEET0_OT_ENUlDpOT_E_clIJS5_EEEDaSN_ at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:1526
14# _ZN7seastar20noncopyable_functionIFNS_6futureIN5boost13intrusive_ptrIN7crimson2os19FuturizedCollectionEEEEEONS3_IN11ObjectStore14CollectionImplEEEEE17direct_vtable_forIZNS1_ISB_E4thenIZNS5_10AlienStore15open_collectionERK6coll_tEUlSB_E0_S8_EET0_OT_EUlDpOT_E_E4callEPKSE_SC_ at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/util/noncopyable_function.hh:125
15# seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>::operator()(boost::intrusive_ptr<ObjectStore::CollectionImpl>&&) const at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/util/noncopyable_function.hh:210
16# seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > std::__invoke_impl<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> >, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >(std::__invoke_other, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl>&&) at /opt/rh/gcc-toolset-9/root/usr/include/c++/9/bits/invoke.h:60
17# std::__invoke_result<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >::type std::__invoke<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >(seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl>&&) at /opt/rh/gcc-toolset-9/root/usr/include/c++/9/bits/invoke.h:97
18# std::invoke_result<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >::type std::invoke<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >(seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl>&&) at /opt/rh/gcc-toolset-9/root/usr/include/c++/9/functional:83
19# auto seastar::internal::future_invoke<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl> >(seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, boost::intrusive_ptr<ObjectStore::CollectionImpl>&&) at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:1213
20# seastar::future<boost::intrusive_ptr<ObjectStore::CollectionImpl> >::then_impl_nrvo<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>, seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > >(seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&&)::{lambda(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, seastar::future_state<boost::intrusive_ptr<ObjectStore::CollectionImpl> >&&)#1}::operator()(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, seastar::future_state<boost::intrusive_ptr<ObjectStore::CollectionImpl> >&&) const::{lambda()#1}::operator()() const at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:1575
21# void seastar::futurize<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > >::satisfy_with_result_of<seastar::future<boost::intrusive_ptr<ObjectStore::CollectionImpl> >::then_impl_nrvo<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>, seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > >(seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&&)::{lambda(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, seastar::future_state<boost::intrusive_ptr<ObjectStore::CollectionImpl> >&&)#1}::operator()(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, seastar::future_state<boost::intrusive_ptr<ObjectStore::CollectionImpl> >&&) const::{lambda()#1}>(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&&) at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:2120
22# seastar::future<boost::intrusive_ptr<ObjectStore::CollectionImpl> >::then_impl_nrvo<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>, seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > >(seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&&)::{lambda(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, seastar::future_state<boost::intrusive_ptr<ObjectStore::CollectionImpl> >&&)#1}::operator()(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, seastar::future_state<boost::intrusive_ptr<ObjectStore::CollectionImpl> >&&) const at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:1571
23# seastar::continuation<seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>, seastar::future<boost::intrusive_ptr<ObjectStore::CollectionImpl> >::then_impl_nrvo<seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>, seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > >(seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&&)::{lambda(seastar::internal::promise_base_with_type<boost::intrusive_ptr<crimson::os::FuturizedCollection> >&&, seastar::noncopyable_function<seastar::future<boost::intrusive_ptr<crimson::os::FuturizedCollection> > (boost::intrusive_ptr<ObjectStore::CollectionImpl>&&)>&, seastar::future_state<boost::intrusive_ptr<ObjectStore::CollectionImpl> >&&)#1}, boost::intrusive_ptr<ObjectStore::CollectionImpl> >::run_and_dispose() at /home/rzarzynski/ceph1/build/../src/seastar/include/seastar/core/future.hh:771
24# seastar::reactor::run_tasks(seastar::reactor::task_queue&) at /home/rzarzynski/ceph1/build/../src/seastar/src/core/reactor.cc:2237
25# seastar::reactor::run_some_tasks() at /home/rzarzynski/ceph1/build/../src/seastar/src/core/reactor.cc:2646 (discriminator 1)
26# seastar::reactor::run() at /home/rzarzynski/ceph1/build/../src/seastar/src/core/reactor.cc:2805
27# seastar::app_template::run_deprecated(int, char**, std::function<void ()>&&) at /home/rzarzynski/ceph1/build/../src/seastar/src/core/app-template.cc:207 (discriminator 7)
28# seastar::app_template::run(int, char**, std::function<seastar::future<int> ()>&&) at /home/rzarzynski/ceph1/build/../src/seastar/src/core/app-template.cc:115 (discriminator 2)
29# main at /home/rzarzynski/ceph1/build/../src/crimson/osd/main.cc:206 (discriminator 1)
30# __libc_start_main in /lib64/libc.so.6
31# _start in /home/rzarzynski/ceph1/build/bin/crimson-osd
Reactor stalled for 33157 ms on shard 0. Backtrace: 0xb14ab 0xa6cd418 0xa6a496d 0xa54fd22 0xa566e3d 0xa56383c 0xa5639fc 0xa566808 0x12b2f 0x3780e 0x21c44 0x21b18 0x2fdf5 0x7cfdf93 0x7b78622 0x7c3fcb7 0x7c1bcb2 0x7c1bdf1 0x7c4004a 0x7d913c7 0x7d875ed 0x7d777d7 0x7d5f626 0x7d47ca4 0x7d47b5a 0x7d5f770 0x7d47931 0x7d9bb74 0xa5998b5 0xa59e1ff 0xa5a3a95 0xa43546c 0xa433331 0x3f01992 0x237c2 0x3c7f9bd
../src/vstart.sh: line 28: 665993 Aborted                 (core dumped) PATH=$CEPH_BIN:$PATH "$@"
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-07 16:47:47 +00:00
Kefu Chai
e13dbe94b3
Merge pull request #41733 from rzarzynski/wip-crimson-clientreq-cleanup
crimson/osd: clean up mutability and fix log in ClientRequest

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-07 23:24:46 +08:00
Radoslaw Zarzynski
fbb3b40807 crimson/osd: fix debug in ClientRequest::do_process().
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-07 14:30:48 +00:00
Radoslaw Zarzynski
7973ce3e19 crimson/osd: drop unneeded lambda mutability in ClientRequest.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-07 14:30:48 +00:00
Kefu Chai
abca699b59 common/cmdparse: do not create temp string for writing ostream
ostream is able to handle std::string_view, so no need to create
temporary std::string instance for writing to a std::ostream

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-07 22:11:58 +08:00
Kefu Chai
0893d18b4d common/cmdparse: do not create temp string for cmd_getval()
cmd_getval() consumes string_view, so no need to create a temporary
std::string instance for it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-07 22:11:58 +08:00
Sage Weil
3a2f0f0103 Merge PR #41709 into master
* refs/pull/41709/head:
	cephadm: improve is_container_running()

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-07 10:03:09 -04:00