Commit Graph

135706 Commits

Author SHA1 Message Date
Adam C. Emerson
9e67a437a3 cls/fifo: Use spaceship operator to implement comparisons
Except for the version type, where only versions with the same tag are
comparable.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-01-09 13:23:44 -05:00
Adam C. Emerson
f89a6d1833 cls/fifo: Remove all use of part tags
Part tags make part creation and setting the head non-idempotent,
leading to issues where racing RGWs may get confused about the correct
tag for a part. (Or worse, potentially have the metadata header hold
different value for a part than the part's header.)

Consistently only requires that all nodes agree on the number.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-01-09 13:14:46 -05:00
Adam C. Emerson
dae8e78145 cls/fifo: Fix same_or_later() comparison
Fix logic error where disjunction was used instead of conjunction.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-01-09 12:59:57 -05:00
Adam King
c86fc2b859
Merge pull request #48696 from adk3798/agent-testing-binary
cephadm: unit tests for CephadmAgent, MgrListener, AgentGatherer

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-01-09 10:07:59 -05:00
Casey Bodley
066e6745f5
Merge pull request #49495 from BryceCao/wip-fix-result-when-users-topics-is-null
rgw: fix result when user's topics is null

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-01-09 09:45:18 -05:00
Guillaume Abrioux
71c3f8e31b
Merge pull request #49629 from guits/cv-fix-tox-allowlist_externals
ceph-volume/tests: add allowlist_externals to tox.ini
2023-01-09 09:59:25 +01:00
colemitchell
fe4cb1a645
Merge pull request #49665 from zdover23/wip-doc-2023-01-08-glossary-ceph-object-storage
doc/glossary: Clean up "Ceph Object Storage"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-01-08 14:33:46 -05:00
Zac Dover
6bede3505f doc/glossary: Clean up "Ceph Object Storage"
Remove redundant material under the "Ceph Object Storage" headword and
add a "See 'Ceph Object Store'" link. A future PR will provide a couple
of sentences that explain how object storage is what's really supporting
both CephFS and RBD.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-09 03:43:35 +10:00
Anthony D'Atri
c76e8e5538
Merge pull request #49663 from bradfitz/patch-1
doc: fix a typo
2023-01-06 23:44:12 -05:00
Brad Fitzpatrick
c670906b49
doc: fix a typo
Signed-off-by: Brad Fitzpatrick <brad@danga.com>
2023-01-06 19:54:45 -08:00
zdover23
f87801e195
Merge pull request #49658 from zdover23/wip-doc-2023-01-15-h2-scroll-margin-top
doc/css: Add scroll-margin-top to h2 html element

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-01-07 04:02:00 +10:00
zdover23
89768e6738
Merge pull request #49653 from zdover23/wip-doc-2023-01-06-crushtool-options
doc/man: define --num-rep, --min-rep and --max-rep

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2023-01-07 03:57:32 +10:00
Daniel Gryniewicz
8df799f985
Merge pull request #49657 from dang/wip-dang-motr-build
Fix MOTRStore build

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-01-06 11:47:47 -05:00
Zac Dover
af048ca911 doc/css: Add scroll-margin-top to h2 html element
Add "scroll-margin-top: 4em;" to the h2 html element's definition in
custom.css. This moves the text under all h2 html elements out of the
way of the sticky-header-style top bar, which previously obscured the
text.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-07 02:24:39 +10:00
zdover23
c439a11c70
Merge pull request #49643 from zdover23/wip-doc-2023-01-05-add-padding-to-sections
doc/_static: add scroll-margin-top to custom.css

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-01-07 02:13:26 +10:00
Zac Dover
10fa01d075 doc/man: define --num-rep, --min-rep and --max-rep
Explain the "--num-rep", "--min-rep", and "--max-rep" options, which are
required when running "crushtool" commands with the "--show-mappings"
flag. Originally reported by Brad Fitzpatrick.

https://tracker.ceph.com/issues/58374

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-07 02:12:26 +10:00
Casey Bodley
ec15d4fa67
Merge pull request #49373 from inspur-wyq/wip-doc-rgwtar
src/rgw/rgw_tar.h: fix typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2023-01-06 09:42:43 -05:00
Ilya Dryomov
04d80ec543
Merge pull request #49631 from petrutlucian94/rbd_py_test2
qa: test_rbd_wnbd.py - disable PS progress bar

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-01-06 15:35:30 +01:00
Mike Perez
ab218b085d
Merge pull request #49651 from Thingee/update-foundation-20230105
doc: Updating Foundation members for January 2023
2023-01-05 15:49:38 -08:00
Mike Perez
cdfb034a08 doc: Updating Foundation members for January 2023
Signed-off-by: Mike Perez <thingee@gmail.com>
2023-01-05 15:09:05 -08:00
Daniel Gryniewicz
58ef415b65 Fix MOTRStore build
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2023-01-05 14:59:12 -05:00
Zac Dover
5738271498 doc/_static: add scroll-margin-top to custom.css
Add 4em of padding to the class "section", so that linked-to
destinations are not obscured by the top bar.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-06 04:19:12 +10:00
Casey Bodley
ab4dd1a7e7
Merge pull request #49500 from BryceCao/wip-fix-result-when-users-mfas-is-null
rgw: fix result when users mfas is null

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-01-05 10:39:09 -05:00
zdover23
1650525670
Merge pull request #49637 from zdover23/wip-doc-2023-01-05-top-bar-scroll-margin-top-repair
doc/css: add scroll-margin-top to dt elements

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-01-06 01:13:53 +10:00
Zac Dover
5de590b9be doc/css: add scroll-margin-top to dt elements
add "scroll-margin-top: em3;" to custom.css so that the header bar
doesn't obscure the text of headwords in glossary.rst. Note that this
applies only to elements in the documentation that are rendered into
HTML with the dt (which stands for "description term" or "description
list") tag. Other modifications will be necessary in order to ensure
that the anchor points of non-dt elements are not obscured by the header
bar.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-05 23:58:27 +10:00
Lucian Petrut
788dd5e7fb qa: test_rbd_wnbd.py - disable PS progress bar
This test uses certain PS commands that attempt to display
a progress bar. However, this can cause issues when invoked
remotely (e.g. by the jenkins job).

For this reason, we're defining a helper (ps_execute) that runs
PS commands, disabling the progress bars and enabling the non
interactive mode.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-01-05 11:41:48 +02:00
Daniel Gryniewicz
d7cb2dd2e4
Merge pull request #48730 from dang/wip-dang-zipper-chown
Fix chown to unlink

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-01-04 13:34:47 -05:00
Guillaume Abrioux
f932e33ea4 ceph-volume/tests: add allowlist_externals to tox.ini
typical failure seen in the CI:

```
py3-flake8: install_deps> ./tox_install_command.sh flake8
py3-flake8: failed with ./tox_install_command.sh (resolves to ./tox_install_command.sh) is not allowed, use allowlist_externals to allow it
```

Fixes: https://tracker.ceph.com/issues/58377

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2023-01-04 14:18:59 +01:00
Ilya Dryomov
4d8388a3d8
Merge pull request #49618 from petrutlucian94/rbd_py_test2
qa: retry test_rbd_wnbd.py fs operations

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-01-04 13:45:54 +01:00
Lucian Petrut
65544da400 qa: retry test_rbd_wnbd.py fs operations
Certain FS related operations can fail, especially under load
(e.g. initializing partitions, volume formatting, etc).

For this reason, we're going to introduce some retries.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-01-04 07:08:39 +02:00
zdover23
7d4812b52e
Merge pull request #49620 from bradfitz/bradfitz/doc
doc: fix a couple grammatical things

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2023-01-04 02:45:15 +10:00
Brad Fitzpatrick
b9b6011c11 doc: fix a couple grammatical things
Signed-off-by: Brad Fitzpatrick <brad@danga.com>
2023-01-03 08:37:02 -08:00
Anthony D'Atri
ae8065f1d4
Merge pull request #49613 from zdover23/wip-doc-2023-01-02-start-documenting-ceph-49609-followup
doc/start: add Anthony D'Atri's suggestions
2023-01-02 10:15:35 -05:00
Zac Dover
6141c5f061 doc/start: add Anthony D'Atri's suggestions
Add the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/49609.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-02 23:00:55 +10:00
colemitchell
69bfe3bebe
Merge pull request #49609 from zdover23/wip-doc-2023-01-02-start-documenting-ceph-cleanup
doc/start: refine "Quirks of RST"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-01-02 00:25:05 -05:00
Zac Dover
cdc7b60354 doc/start: refine "Quirks of RST"
Refine the language that was added yesterday, language that explains how
certain aspects of RST work.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-02 14:23:22 +10:00
zdover23
a05e06de5d
Merge pull request #49606 from zdover23/wip-doc-2023-01-01-start-documenting-ceph-quirks-of-rst
doc/start: add link-related metadocumentation

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-01-01 22:32:27 +10:00
Zac Dover
7517404f72 doc/start: add link-related metadocumentation
Add two kinds of link-related metadocumentation (documentation about how
to write documentation) to the "Documenting Ceph" section of the "Intro
to Ceph" document: 1. metadocumentation about external links, and 2.
metadocumentation about internal links.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2023-01-01 22:06:54 +10:00
colemitchell
74fb7b95f6
Merge pull request #49602 from zdover23/wip-doc-2022-12-31-glossary-DAS-capitalization
doc/glossary: capitalize "DAS" correctly

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-30 23:51:57 -05:00
Zac Dover
7c70a66414 doc/glossary: capitalize "DAS" correctly
Correctly capitalize "Direct-Attached Storage" in the glossary. (And
test the "Quincy" branch, which seems lately not to have picked up any
docs backports.)

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-31 14:22:26 +10:00
colemitchell
34d23c64ab
Merge pull request #49599 from zdover23/wip-doc-2022-12-30-glossary-releases
doc/glossary: collate "releases" entries

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-29 20:56:26 -05:00
Zac Dover
39377f7db1 doc/glossary: collate "releases" entries
Collect the "Releases"-related entries together under the "Releases"
headword, in order to give readers a sense at a glance of how the
different kinds of releases relate to one another.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-30 11:32:31 +10:00
zdover23
4517367eca
Merge pull request #49488 from zdover23/wip-doc-2022-12-18-rbd-rbd-exclusive-locks-refine
doc/rbd: refine rbd-exclusive-locks.rst

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2022-12-30 01:27:49 +10:00
Zac Dover
62b0012751 doc/rbd: refine rbd-exclusive-locks.rst
Refine grammar (mostly semantics) in rbd-exclusive-locks.rst.

Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-30 01:14:38 +10:00
zdover23
d7d177f5e8
Merge pull request #49593 from zdover23/wip-doc-2022-12-29-glossary-osd-id-each
doc/glossary: s/an/each/ where it's needed

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-30 01:03:32 +10:00
Zac Dover
40a9f1594c doc/glossary: s/an/each/ where it's needed
s/an/each/ in accordance with the suggestion made by Anthony D'Atri
here: https://github.com/ceph/ceph/pull/49590/files#r1058390357

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-29 14:42:25 +10:00
zdover23
f0cf74dcc7
Merge pull request #49584 from zdover23/wip-doc-2022-12-27-glossary-cleanup
doc/glossary: clean OSD id-related entries

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-28 19:08:45 +10:00
Ilya Dryomov
17c214d156
Merge pull request #49587 from zdover23/wip-doc-2022-12-27-rbd-wuold-typo
doc/rbd: s/wuold/would/ in rados-rbd-cmds.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-12-27 23:37:59 +01:00
Adam King
82d07d61e0
Merge pull request #49583 from RanjiniMandyam/RMN-2151232-syntax
doc/dev/cephadm: fix host maintenance enter/exit syntax -

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-27 11:40:58 -05:00
Zac Dover
39c18021d6 doc/rbd: s/wuold/would/ in rados-rbd-cmds.rst
s/wuold/would/ in rados-rbd-cmds.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-27 22:28:49 +10:00