Commit Graph

95866 Commits

Author SHA1 Message Date
Jos Collin
9dace9258f
qa/suites/fs: mon_thrash test for fs
Created a mon.yaml in fs suite that calls mon_thrash test for fs and multimds suites.

Fixes: http://tracker.ceph.com/issues/17309
Signed-off-by: Jos Collin <jcollin@redhat.com>
2019-04-12 10:22:04 +05:30
Jos Collin
10c4f560d3
qa/tasks: Fix typo in the comment
Signed-off-by: Jos Collin <jcollin@redhat.com>
2019-03-11 10:13:18 +05:30
Xie Xingguo
096fcc55d7
Merge pull request #26867 from liewegas/wip-doc-msgr2
doc/rados/configuration/msgr2: some documentation about msgr2

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-03-11 08:36:48 +08:00
Jason Dillaman
b915fcee4f
Merge pull request #26801 from wjwithagen/wjw-fix-use-binutils-ld
build: LLVM ld does not like the versioning scheme

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-03-10 14:24:56 -04:00
Patrick Donnelly
58039163e3
Merge PR #26859 into master
* refs/pull/26859/head:
	qa: ignore slow metadata io wrn during osd thrash

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-03-10 10:38:16 -07:00
Jason Dillaman
2d76acca8f
Merge pull request #26876 from wjwithagen/wjw-fix-src/test/librbd/operation/test_mock_TrimRequest.cc
librbd: avoid aggregate-initializing any static_visitor

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-03-10 10:21:06 -04:00
Willem Jan Withagen
8abfb42856 librbd: avoid aggregate-initializing any static_visitor
This will result in an error complaining about a protected dtor.
also see:
    https://github.com/ceph/ceph/pull/26838

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2019-03-10 11:51:09 +01:00
Sage Weil
60fab64f4c doc/rados/configuration/msgr2: some documentation about msgr2
This doesn't integrate very well into network-config.rst, mostly because
that document is horribly out of data and I don't know where to start.
:(

Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-09 19:10:21 -06:00
Sage Weil
37f5b21b1d Merge PR #26849 into master
* refs/pull/26849/head:
	Revert "msg/async: msgr2: expected tags validation"
	msg/async/ProtocolV2: state machine verifications

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-09 17:38:27 -06:00
Sage Weil
a9075903ef Merge PR #26869 into master
* refs/pull/26869/head:
	qa/standalone/erasure-code/test-erasure-eio.sh: still need to create rbd pool
	qa/standalone/scrub/osd-scrub-repair: fix unfound grep
	qa/standalone/ceph-helpers: fix test_wait_for_clean
	qa/standalone/ceph-helpers.sh: fix test_run_mon
	qa/standalone/osd/osd-rep-recov-eio: fix better

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-03-09 13:22:56 -06:00
Patrick Donnelly
d3faf3240b
Merge PR #26713 into master
* refs/pull/26713/head:
	mds: wait for client to release shared cap when re-acquiring xlock

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-03-09 10:15:26 -08:00
Sage Weil
b07e96978b Merge PR #26828 into master
* refs/pull/26828/head:
	src/tools/kvstore_tool.cc: Move bluestore start-up code

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-09 11:00:57 -06:00
Sage Weil
2ad02fbfe3 qa/standalone/erasure-code/test-erasure-eio.sh: still need to create rbd pool
Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-09 09:34:49 -06:00
Sage Weil
c32921d7ea Merge PR #26660 into master
* refs/pull/26660/head:
	include/intarith: enforce the same type for p2*() arguments

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-09 09:29:33 -06:00
Sage Weil
16bcf65940 Merge PR #26831 into master
* refs/pull/26831/head:
	mon/OSDMonitor: add newline
	mgr/pg_autoscaler: drop undefined variable 'cr_name'

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-09 09:28:18 -06:00
Sage Weil
e69dc62e0d Merge PR #26779 into master
* refs/pull/26779/head:
	mgr/status: fix 'ceph fs status' AttributeError

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-03-09 09:27:56 -06:00
Brad Hubbard
00395f8f1f src/tools/kvstore_tool.cc: Move bluestore start-up code
Move this code into a separate function to avoid ICE.

Fixes: http://tracker.ceph.com/issues/38633

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2019-03-09 15:24:17 +10:00
Sage Weil
10b9626ea7 qa/standalone/scrub/osd-scrub-repair: fix unfound grep
It's now "1/2 unfound":

             1/2 objects unfound (50.000%)

..presumably due to the rbd pool init creating the rbd_directory.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-08 18:23:48 -06:00
Sage Weil
30fc7f5e97 qa/standalone/ceph-helpers: fix test_wait_for_clean
Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-08 18:07:10 -06:00
Sage Weil
1e2b0c7252 qa/standalone/ceph-helpers.sh: fix test_run_mon
- Only create each osd once
- forget the first osdmap dump test; it's pointless

Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-08 17:43:00 -06:00
Sage Weil
bf74c1adc4 qa/standalone/osd/osd-rep-recov-eio: fix better
- no need for the default pool size
- no initial osds or it will collide with setup_osds later
- no need for rbd pool at all

Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-08 17:41:11 -06:00
Patrick Donnelly
5abcc32ff6
qa: ignore slow metadata io wrn during osd thrash
Fixes: http://tracker.ceph.com/issues/38651
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-03-08 10:49:10 -08:00
Ilya Dryomov
c7c4a49d6f Merge PR #26838 into master
* refs/pull/26838/head:
	librbd: avoid aggregate-initializing IsWriteOpVisitor

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-03-08 18:44:48 +01:00
Alfredo Deza
c24631d261
Merge pull request #26826 from ceph/wip-simple-scan-all
ceph-volume: `simple scan` will now scan all running ceph-disk OSDs

Reviewed-by: Alfredo Deza <adeza@redhat.com>
2019-03-08 11:49:07 -05:00
Andrew Schoen
f3707f1ad4 ceph-volume: make systemctl.get_running_osds resilient to garbage output
Makes systemd.systemctl.get_running_osds more resilient to output
that doesn't match what we're expecting to parse. This also handles
the case of a nonzero exit status by retuning an empty list.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:59 -06:00
Andrew Schoen
b59dcd01c2 ceph-volume: remove obsoleted simple unit test
This test is no longer valid because `simple scan`
without any arguments will now attempt to scan all
running OSDs.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:59 -06:00
Andrew Schoen
1881f386d8 ceph-volume: tox tests should ignore the tests/functional directory
Without this the functional testinfra tests try to run when we
are intending to only run the unit tests.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:59 -06:00
Andrew Schoen
87c33f149a ceph-volume: use simple scan and simple activate --all in tests
In a couple of the functional tests for simple we should run `simple
scan` without any arguments and `simple activate --all` to increase
the test coverage. We want to test pointing at a diretory and scanning
all running OSDs.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:59 -06:00
Andrew Schoen
f7943ef600 ceph-volume: update docs and help menu for simple scan
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:59 -06:00
Andrew Schoen
7cb098b689 ceph-volume: adds unit tests for systemd.systemctl.get_running_osd_ids
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:58 -06:00
Andrew Schoen
28e454ec30 ceph-volume: update simple scan to scan all running OSDs
If no argument is passed to `ceph-volume simple scan` it will
inspect any running osds and scan them if they were created by
ceph-disk.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:58 -06:00
Andrew Schoen
15d20e29a2 ceph-volume: add systemd.systemctl.get_running_osd_ids
This is used to retrieve a list of osd ids from the currently
running ceph-osd systemd units.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2019-03-08 09:58:58 -06:00
Patrick Nawracay
f51fcad52e
Merge pull request #26815 from tchaikov/wip-38584
doc/releases/nautilus: dashboard package notes

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-03-08 16:24:18 +01:00
Sage Weil
3e83a6e960 Merge PR #26823 into master
* refs/pull/26823/head:
	qa/suites: disable valgrind leak checks on ceph-mgr
	mgr: skip shutdown and exit

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-03-08 09:04:21 -06:00
Willem Jan Withagen
1d7b291874 librbd: avoid aggregate-initializing IsWriteOpVisitor
Clang 8 complains about missing dtor, and this circumvents this problem.
```
/home/jenkins/workspace/ceph-master/src/librbd/io/ImageDispatchSpec.cc:136:48:
error: temporary of type 'boost::static_visitor<bool>' has protected
destructor
   return boost::apply_visitor(IsWriteOpVisitor{}, m_request);
                                                ^
/home/jenkins/workspace/ceph-master/src/librbd/io/ImageDispatchSpec.cc:152:28:
note: in instantiation of member function
'librbd::io::ImageDispatchSpec<librbd::ImageCtx>::is_write_op' requested
here
template class librbd::io::ImageDispatchSpec<librbd::ImageCtx>;
                            ^
/usr/local/include/boost/variant/static_visitor.hpp:53:5: note: declared
protected here
     ~static_visitor() = default;
     ^
1 error generated.
gmake[2]: *** [src/librbd/CMakeFiles/rbd_internal.dir/build.make:895:
src/librbd/CMakeFiles/rbd_internal.dir/io/ImageDispatchSpec.cc.o] Error 1
```

The details of the problem are explained in more detail in:
09870d7a08

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2019-03-08 15:55:54 +01:00
Ricardo Dias
e0f6e6839f
Revert "msg/async: msgr2: expected tags validation"
This reverts commit e9ac3e0530.

Signed-off-by: Ricardo Dias <rdias@suse.com>
2019-03-08 14:40:35 +00:00
Ricardo Dias
64f7272616
msg/async/ProtocolV2: state machine verifications
Signed-off-by: Ricardo Dias <rdias@suse.com>
2019-03-08 14:35:14 +00:00
Sage Weil
b88a10aef2 Merge PR #26796 into master
* refs/pull/26796/head:
	common/options: osd_memory_target et al are TYPE_SIZE

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-03-08 08:11:47 -06:00
Casey Bodley
139becb6c1
Merge pull request #26827 from adamemerson/wip-doc-s3-op-acl
Document mappings of S3 Operations to ACL grants

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-03-08 08:54:57 -05:00
Sage Weil
b0496c44ed Merge PR #26832 into master
* refs/pull/26832/head:
	msg/async/ProtocolV2: end scope of std::hex properly

Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-08 07:04:35 -06:00
xie xingguo
42abad9632 mon/OSDMonitor: add newline
To be in concert with other pool attributes..

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-03-08 16:07:35 +08:00
xie xingguo
4295b75f62 mgr/pg_autoscaler: drop undefined variable 'cr_name'
```
a/pg_autoscaler/module.py:359: error: Name 'cr_name' is not defined
```

Actually _get_pool_status should have prevented any pool
with a zero-ed capacity from going this far, so it is safe
to simply drop the obviously redundant check here.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-03-08 16:07:27 +08:00
Sage Weil
62136d381a Merge PR #26794 into master
* refs/pull/26794/head:
	mon/MgrMonitor: only try to update always_on_modules if >= NAUTILUS
	qa/standalone/mon/msgr-v2-transition: add some tests for enabling msgr v2
	mon/MonmapMonitor: add 'ceph mon set-addrs <name> <addrvec>' command
	Revert "mon/MonClient: disable ms_bind_msgr2 if NAUTILUS feature not set"
	mon/OSDMonitor: use legacy_equals to compare osd addrs
	msg/msg_types: make legacy_equals() symmetrical
	mon/MDSMonitor: stop using get_orig_source_inst()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-03-07 22:12:52 -06:00
Sage Weil
4d33b6d56a Merge PR #26770 into master
* refs/pull/26770/head:
	qa/standalone/osd/osd-force-create-pg: create more pgs
	qa/standalone: make sure an osd is running before create_rbd_pool

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-03-07 22:10:12 -06:00
Sage Weil
99207b2c35 Merge PR #26504 into master
* refs/pull/26504/head:
	osd: fixup OpTracker destruct assert, waiting_for_osdmap take ref

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
2019-03-07 21:58:01 -06:00
Yanhu Cao
f5350443dc mgr/status: fix 'ceph fs status' AttributeError
Fixes: http://tracker.ceph.com/issues/38122

Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
2019-03-08 07:10:34 +08:00
Sage Weil
cb59866c46 Merge PR #26803 into master
* refs/pull/26803/head:
	msg/async/ProtocolV1: fix locking around authorizer_buf

Reviewed-by: Ricardo Dias <rdias@suse.com>
2019-03-07 16:59:24 -06:00
Patrick Donnelly
a1539b118e
Merge PR #26781 into master
* refs/pull/26781/head:
	mds: avoid calling clientreplay_done() prematurely

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-03-07 14:40:16 -08:00
Patrick Donnelly
9c0495fb58
Merge PR #26773 into master
* refs/pull/26773/head:
	mds: refactor subtree accessors

Reviewed-by: Zheng Yan <zyan@redhat.com>
2019-03-07 14:38:48 -08:00
Sage Weil
a2debbc26b mon/MgrMonitor: only try to update always_on_modules if >= NAUTILUS
Pre-nautilus mgrmap doesn't encode have this field, so we'll just loop.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-03-07 16:35:35 -06:00