Commit Graph

132776 Commits

Author SHA1 Message Date
Laura Flores
9da99242fb doc/releases: add release note about "invalid regex" bug in mgr
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-07-29 09:44:34 -05:00
Casey Bodley
c5975ce85b
Merge pull request #47308 from mdw-at-linuxbox/wip-master-implanon
rgw: better tenant id from the uri on anonymous access

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2022-07-28 17:38:28 -04:00
Guillaume Abrioux
483c7e22e6
Merge pull request #47170 from guits/dep-dev-inventory
ceph-volume: report slave devices in inventory
2022-07-28 22:19:31 +02:00
Guillaume Abrioux
1274ba34b4 ceph-volume/tests: migrate to pyfakefs
ceph-volume unit tests shouldn't actually create contents on the
filesystem from where it runs (even though they are written in a tmp
dir), let's use pyfakefs.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-28 20:14:06 +02:00
Guillaume Abrioux
7ab9d99420 ceph-volume/tests: fix test_path_is_valid()
When ceph-volume tests are run from a host where there's no `/dev/sda`
device, this test fails.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-28 20:14:06 +02:00
Guillaume Abrioux
1ac2a8270c ceph-volume: report slave devices in inventory
`ceph-volume inventory` currently reports the following:

```

Device Path               Size        rotates available Model name
/dev/mapper/mpatha        50.00 GB    True    True
/dev/mapper/mpathaa       6.00 GB     True    True
/dev/mapper/mpathab       6.00 GB     True    True
/dev/mapper/mpathac       6.00 GB     True    True
/dev/mapper/mpathad       6.00 GB     True    True
/dev/mapper/mpathae       6.00 GB     True    True
```

whereas something like following would be useful:

```

Device Path               Size         Device nodes    rotates available Model name
/dev/mapper/mpatha        50.00 GB     sdf,sde         True    True
/dev/mapper/mpathaa       6.00 GB      sdbe,sdat       True    True
/dev/mapper/mpathab       6.00 GB      sdav,sdbf       True    True
/dev/mapper/mpathac       6.00 GB      sdbb,sdbl       True    True
/dev/mapper/mpathad       6.00 GB      sdas,sdbc       True    True
/dev/mapper/mpathae       6.00 GB      sdax,sdbh       True    True
```

Fixes: https://tracker.ceph.com/issues/56624

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-28 20:14:06 +02:00
Guillaume Abrioux
306325a256
Merge pull request #47169 from guits/improve-mpath-reporting
ceph-volume: improve mpath devices reporting
2022-07-28 20:11:30 +02:00
Guillaume Abrioux
3bf846a76e
Merge pull request #46893 from guits/ceph-volume-symlinks-guits
ceph-volume: allow symlinks as devices
2022-07-28 20:11:03 +02:00
Kefu Chai
9a8f20f42e
Merge pull request #47310 from tchaikov/ceph-context-formatting
common/ceph_context: fix the formatting

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-07-28 22:39:33 +08:00
Pere Diaz Bou
473d46161d
Merge pull request #46996 from rhcs-dashboard/html-injection-bug
mgr/dashboard: added pattern validaton for form input

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-07-28 09:38:41 +02:00
Ronen Friedman
18206817b9
Merge pull request #46970 from ronen-fr/wip-rf-unlocked-logs
osd/scrub: pre-prepare the description text of the current state

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-07-28 08:48:37 +03:00
zdover23
89409d6fb8
Merge pull request #46024 from sirtoobii/patch-2
doc/radosgw/STS: sts_key and user capabilities

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2022-07-28 14:38:28 +10:00
Kefu Chai
f362941446
Merge pull request #44039 from richael02/update-isal-crypto-source
.gitmodules: update isa-l_crypto source address

Reviewed-by: Yibo Cai <yibo.cai@arm.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 10:29:28 +08:00
Adam King
eed140c259
Merge pull request #46420 from pcuzner/add-disk-rescan
mgr/cephadm: Add disk rescan feature to the orchestrator

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-07-27 19:50:59 -04:00
Kefu Chai
da14b005b0
Merge pull request #47286 from tchaikov/wip-fmt-ranges
osd: use fmt/ranges.h for printing ranges

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-28 07:50:43 +08:00
Adam King
3f1f862b9c
Merge pull request #46883 from adk3798/custom-config
mgr/cephadm: support for miscellaneous config files for daemons

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-07-27 19:49:44 -04:00
Adam King
dae8b562b8
Merge pull request #46955 from hookak/monitoring-stack
cephadm: Add promtail and loki when bootstrap

Reviewed-by: Adam King <adking@redhat.com>
2022-07-27 19:48:09 -04:00
Adam King
257d259e28
Merge pull request #47088 from adk3798/cephadm-logging
cephadm: reduce spam to cephadm.log

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-07-27 19:47:16 -04:00
Kefu Chai
a49a475403 common/ceph_context: fix the formatting
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:46:55 +08:00
Adam King
6c795c597a
Merge pull request #47178 from adk3798/logrotate-owner
cephadm: add "su root root" to cephadm.log logrotate config

Reviewed-by: Guillaume Abrioux gabrioux@redhat.com
2022-07-27 19:46:04 -04:00
Kefu Chai
d3a7e5e564
Merge pull request #46618 from aclamk/wip-dout-for-alien
crimson/alienstore: Add douts

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-07-28 07:45:39 +08:00
Adam King
f1cbe5225e
Merge pull request #47269 from adk3798/fix-repo-test
qa/workunits/cephadm: update test_repos master -> main

Reviewed-by: Guillaume Abrioux gabrioux@redhat.com
2022-07-27 19:45:11 -04:00
Richael Zhuang
4ad4e1fbc7 .gitmodules: update isa-l_crypto source address
Update address to https://github.com/intel/isa-l_crypto for it's
moved under intel repo.

Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
2022-07-28 07:41:26 +08:00
Kefu Chai
65307131e4
Merge pull request #44499 from SMIL-Infra/fix-missed-lease-ack
osd/PeeringState: fix missed recheck_readable from laggy

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:40:09 +08:00
Kefu Chai
f9aaf7fe15
Merge pull request #45135 from lmlg/fix-32-bit
rgw,test: Fix build errors in 32 bit platforms

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-07-28 07:39:00 +08:00
Kefu Chai
d7fe19d05b
Merge pull request #43005 from wxypro/timeout_conn_msg_opt
msg: Add target_addr to log when connections timed out

Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-07-28 07:38:14 +08:00
Kefu Chai
98c074a93f
Merge pull request #44040 from richael02/update-isal-crypto-version
crypto: update isa-l_crypto version

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:34:59 +08:00
Kefu Chai
9b76560557
Merge pull request #44762 from Zhiwei-Dai/wip-zlib-compressor-isal-for-aarch64
compressor/zlib: isa-l optimization for zlib algorithm on aarch64

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:34:04 +08:00
Marcus Watts
b5880caa50 rgw: better tenant id from the uri on anonymous access
When anonymous tries access public bucket, it gets 404,
because rgw doesn't check tenant correctly.

A previous fix for this broke legacy implicit tenants,
because it didn't check for anonymous access.  This version
restricts its behavior to the anonymous user.

Fixes: https://tracker.ceph.com/issues/48001 https://tracker.ceph.com/issues/48382

Original fix by
Author: Rafał Wądołowski <rafal@rafal.net.pl>
Signed-off-by: Rafał Wądołowski <rwadolowski@cloudferro.com>

This fix
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2022-07-27 16:59:47 -04:00
Jan Sobczak
9ddc5b7737 ceph-volume: support symlinks as devices
This makes ceph-volume support passing symlinks as devices.

Fixes: https://tracker.ceph.com/issues/49103

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-27 16:48:53 +02:00
Guillaume Abrioux
01112ba689 ceph-volume: drop self.abspath in Device()
seems useless to have both self.path and self.abspath attributes.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-27 16:41:26 +02:00
Guillaume Abrioux
e439ada4c2
Merge pull request #47167 from guits/drop-bs-tool-call
ceph-volume: drop `ceph-bluestore-tool` call in Device._parse()
2022-07-27 16:34:08 +02:00
Yingxin
78a23ebcad
Merge pull request #47290 from aisakaki/wip-omap-clear
crimson/os/seastore/omap: remove unnecessary extent loads when clearing

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2022-07-27 17:54:30 +08:00
Guillaume Abrioux
24899a1f8d ceph-volume: fix is_ceph_disk_member()
`dev['NAME']` can't match `part` given that it's the name of the
parent device being compared to the partition name.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-27 09:59:16 +02:00
Ronen Friedman
0ebb32213a osd/scrub: pre-prepare the description text of the current state
The existing code accesses the states of the scrub FSM via the
standard "state iterator", which is definitely not thread-safe.
It is also a bit time consuming.

As it happened, new code that tried to create the state string
while not holding the PG lock - crashed the OSD.
This PR changes the relevant lines to allow for safe and fast
access to the state description text.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2022-07-27 05:48:07 +00:00
Samuel Just
93e15f59de
Merge pull request #46755 from aravind-wdc/zns
Crimson: Update zns support

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2022-07-26 22:08:18 -07:00
Xinyu Huang
1c81d6b50c crimson/os/seastore/omap: remove unnecessary extent loads when clearing.
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
2022-07-27 02:29:58 +00:00
Kefu Chai
e70ca62d9c
Merge pull request #47285 from rzarzynski/wip-crimson-monc-discard_result
crimson/monc: replace then_unpack() with discard_result() if possible

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-27 08:58:42 +08:00
Luciano Lo Giudice
71ab500a2f rgw,test: Fix build errors in 32 bit platforms
When building on 32 bit platforms (tested on armhf), 2 errors were detected:
The first involves the compiler being unable to disambiguate a call to
deserialize an integer (apparently because there isn't a specialization for it).
The second involves invalid usage of the builtin reinterpret_cast.

Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
2022-07-27 08:56:55 +08:00
Kefu Chai
31aa539f26 osd: use fmt/ranges.h for printing ranges
now that fmt/ranges.h provides a generic mechinary for printing
ranges. let's just use it.

the output format is changed a little bit when it comes to
set and map, but as long as it makes sense, and we don't use
a tool to parse the logging messages for extracting information
from the messages printed by fmt::format(), we should be safe.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-07-27 07:16:11 +08:00
Samuel Just
eb6b3ba259
Merge pull request #47287 from tchaikov/wip-crimson-cleanup
crimson/osd: remove unused variable

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-07-26 12:33:00 -07:00
Kefu Chai
a9bc62927d crimson/osd: remove unused variable
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-07-27 00:41:52 +08:00
Radoslaw Zarzynski
f307cae1a1 crimson/monc: replace then_unpack() with discard_result() if possible
More understandable this way.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-26 16:24:23 +00:00
Kefu Chai
9a74fd607a
Merge pull request #47279 from rzarzynski/wip-crimson-fix-repopreply-capture
crimson/osd: don't capture a local, on-stack address of MOSDRepOpReply

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-26 23:24:50 +08:00
Kefu Chai
f8eafce937
Merge pull request #47277 from rzarzynski/wip-crimson-renew_on_auth_reply
crimson/monc: renew tickets and rotating keys on MAuthReply

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-26 23:23:44 +08:00
zdover23
f5857acd68
Merge pull request #47082 from rzarzynski/wip-doc-crimson-cephadm
doc/crimson: document installing crimson with cephadm

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-07-27 00:45:09 +10:00
Guillaume Abrioux
0ee8351e4d ceph-volume: filter out non-existing devices
[1] has broken teuthology tests.

```
[root@smithi097 /]# ls -l /sys/block/
total 0
lrwxrwxrwx 1 root root 0 Jul 25 14:15 dm-0 -> ../devices/virtual/block/dm-0
lrwxrwxrwx 1 root root 0 Jul 25 14:15 dm-1 -> ../devices/virtual/block/dm-1
lrwxrwxrwx 1 root root 0 Jul 25 14:15 dm-2 -> ../devices/virtual/block/dm-2
lrwxrwxrwx 1 root root 0 Jul 25 14:15 dm-3 -> ../devices/virtual/block/dm-3
lrwxrwxrwx 1 root root 0 Jul 25 14:15 dm-4 -> ../devices/virtual/block/dm-4
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop0 -> ../devices/virtual/block/loop0
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop1 -> ../devices/virtual/block/loop1
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop2 -> ../devices/virtual/block/loop2
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop3 -> ../devices/virtual/block/loop3
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop4 -> ../devices/virtual/block/loop4
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop5 -> ../devices/virtual/block/loop5
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop6 -> ../devices/virtual/block/loop6
lrwxrwxrwx 1 root root 0 Jul 25 14:13 loop7 -> ../devices/virtual/block/loop7
lrwxrwxrwx 1 root root 0 Jul 25 14:12 nvme0n1 -> ../devices/pci0000:00/0000:00:02.0/0000:02:00.0/nvme/nvme0/nvme0n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme1c1n1 -> ../devices/virtual/nvme-fabrics/ctl/nvme1/nvme1c1n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme1n1 -> ../devices/virtual/nvme-subsystem/nvme-subsys1/nvme1n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme2c2n1 -> ../devices/virtual/nvme-fabrics/ctl/nvme2/nvme2c2n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme2n1 -> ../devices/virtual/nvme-subsystem/nvme-subsys2/nvme2n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme3c3n1 -> ../devices/virtual/nvme-fabrics/ctl/nvme3/nvme3c3n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme3n1 -> ../devices/virtual/nvme-subsystem/nvme-subsys3/nvme3n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme4c4n1 -> ../devices/virtual/nvme-fabrics/ctl/nvme4/nvme4c4n1
lrwxrwxrwx 1 root root 0 Jul 25 14:18 nvme4n1 -> ../devices/virtual/nvme-subsystem/nvme-subsys4/nvme4n1
lrwxrwxrwx 1 root root 0 Jul 25 14:12 sda -> ../devices/pci0000:00/0000:00:1f.2/ata5/host4/target4:0:0/4:0:0:0/block/sda
[root@smithi097 /]#
```

devices like `nvme1c1n1` exist in `/sys/block` but aren't present in `/dev`

```
[root@smithi097 /]# ls -l /dev/nvme*
crw------- 1 root root  10, 122 Jul 25 14:16 /dev/nvme-fabrics
crw------- 1 root root 240,   0 Jul 25 14:12 /dev/nvme0
brw-rw---- 1 root disk 259,   0 Jul 25 14:15 /dev/nvme0n1
crw------- 1 root root 240,   1 Jul 25 14:16 /dev/nvme1
brw-rw---- 1 root disk 259,   2 Jul 25 15:24 /dev/nvme1n1
crw------- 1 root root 240,   2 Jul 25 14:16 /dev/nvme2
brw-rw---- 1 root disk 259,   4 Jul 25 15:24 /dev/nvme2n1
crw------- 1 root root 240,   3 Jul 25 14:16 /dev/nvme3
brw-rw---- 1 root disk 259,   6 Jul 25 15:24 /dev/nvme3n1
crw------- 1 root root 240,   4 Jul 25 14:16 /dev/nvme4
brw-rw---- 1 root disk 259,   8 Jul 25 15:24 /dev/nvme4n1
[root@smithi097 /]#
```

If a device isn't actually present in `/dev`, `get_block_devs_sysfs()` shouldn't return it.

[1] https://github.com/ceph/ceph/commit/c7f017b21ade3762ba5b7b9688bed72c6b6

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-26 16:24:16 +02:00
Guillaume Abrioux
f5f3117510 ceph-volume: drop ceph-bluestore-tool call in Device._parse()
disk.has_bluestore_label() does the same thing without a subprocess call.

Fixes: https://tracker.ceph.com/issues/56622

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-26 16:24:02 +02:00
Nizamudeen A
42fd81f1bd
Merge pull request #46945 from rhcs-dashboard/rbd-e2e
mgr/dashboard: rbd-mirroring e2e tests

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-07-26 19:51:06 +05:30
Radosław Zarzyński
60b8348a84 doc, crimson: document installing crimson with cephadm
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-26 13:32:19 +00:00