Commit Graph

116668 Commits

Author SHA1 Message Date
Lenz Grimmer
97182ebf5d
Merge pull request #37453 from tspmelo/wip-rbd-change-detection
mgr/dashboard: Improve Change Detection on RBD Snapshot 

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
2020-11-09 15:10:24 +01:00
Lenz Grimmer
610a2426a9
Merge pull request #37641 from henyxia/dev/henyxia/add-mgr-dashboard-prom-ssl-verify
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-11-09 15:07:57 +01:00
Kefu Chai
5c5a038acb
Merge pull request #37983 from tchaikov/wip-crimson-os-co-locate-alien-allocator
crimson/os: do not configure seastar allocator for alien threads

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-09 21:34:20 +08:00
Jan Fajerski
d544dfb549 Merge PR #32777 into master
* refs/pull/32777/head:
	common,log,msg: Fix win32 compiler warnings
	win32,common: provide a default ceph.conf location
	common: add newline before parsing config on Windows
	common: verify unix sockets support on Windows
	common: fix md_config_t::get_cluster_name
	global, common: Print config parse errors
	common: accept config files containing whitespaces
	librbd: avoid broken mingw rng
	common: define DEV_NULL
	tools,common,msg: Use O_BINARY for win32 compatibility
	log: fix timestamps on Windows
	common,librbd: add portable ceph_memzero_s
	common,msg: Fix socket handling
	common: Extend win32 compatbility layer

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-11-09 14:10:36 +01:00
Kefu Chai
dd073a0061
Merge pull request #37984 from tchaikov/wip-fio
cmake: drop WITH_SYSTEM_FIO option

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2020-11-09 21:08:13 +08:00
Lenz Grimmer
75cc8e1213
Merge pull request #37965 from rhcs-dashboard/about-modal-cleanup
mgr/dashboard: Moving copyright variable into the app.constants

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2020-11-09 13:37:55 +01:00
Jason Dillaman
ede99b592c
Merge pull request #37958 from ronen-fr/wip-ronenf-librbd-move1
librbd: removing a "pessimizing move"

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-11-09 07:14:43 -05:00
Kefu Chai
9d2f700731
Merge pull request #37990 from tchaikov/wip-liburing-fPIC
cmake: build liburing with -fPIC

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-09 20:10:05 +08:00
Gregory Farnum
703524119a
Merge pull request #37915 from gregsfortytwo/wip-stretch-fixes
Fix several stretch mode issues

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-09 03:52:07 -08:00
Jan Fajerski
47842715ba Merge PR #37741 into master
* refs/pull/37741/head:
	ceph-volume: remove mention of dmcache from docs and help text

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2020-11-09 11:33:18 +01:00
Jan Fajerski
b5294b7680 Merge PR #37896 into master
* refs/pull/37896/head:
	ceph-volume: implement the --log-level flag

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2020-11-09 11:30:35 +01:00
Lenz Grimmer
a839fab336
Merge pull request #37506 from rhcs-dashboard/fix-47478-master
mgr/dashboard: Improvements in cluster > OSDs

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-11-09 10:45:35 +01:00
Lenz Grimmer
2da2c15304
Merge pull request #37649 from rhcs-dashboard/add-header-tooltip
mgr/dashboard: add description for CRUSH Ruleset

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2020-11-09 10:43:50 +01:00
Kefu Chai
3510433f9c cmake: build liburing with -fPIC
in liburing,
75cad68b95
partially reverts
4e360f7113,
which builds liburing.a with -fPIC.

so we need to pass -fPIC by ourselves. otherwise we'd have

/usr/bin/ld: ../../liburing/src/liburing.a(setup.ol): relocation R_X86_64_PC32 against symbol `io_uring_queue_mmap' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/build.make:154: recipe for target 'lib/libfio_ceph_objectstore.so' failed

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 17:10:59 +08:00
Kefu Chai
c976f142f0 cmake: expose FIO_INCLUDE_DIR via libfio
always use the fio built from source for better consistency.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 16:01:59 +08:00
Kefu Chai
d16f7fb524 cmake: drop WITH_SYSTEM_FIO option
there is no well-known distro packaging fio.h, so drop this option.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 16:01:59 +08:00
Kefu Chai
8e7b9f27c6
Merge pull request #37981 from tchaikov/wip-make-dist
make-dist: add liburing to dist tarball

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2020-11-09 15:58:16 +08:00
Kefu Chai
b6bae7ba13 cmake: use make explicitly to build fio
we cannot assume that user uses "make" as the generator of cmake, if,
for instance, ninja is used, `$(MAKE)` is not a valid variable in the
generated `build.ninja`. so we should use "make" explicitly.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 15:49:26 +08:00
Kefu Chai
cafc6f3575 crimson/os: do not configure seastar allocator for alien threads
4cd2b00d2a allows us to colocate seastar
allocator used by seastar reactors and libc allocator used by alien threads,
there is no need to configure seastar allocator for alien thread
anymore.

this change partially reverts

- f7715b86ef
- b55919071f

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 14:47:39 +08:00
Kefu Chai
4430cec592 crimson/os: do not #include unused headers
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 14:44:36 +08:00
Kefu Chai
68eb5bcdce cmake: use src/liburing for building liburing if it exists
so we can build with liburing enabled if the dist tarball contains
liburing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 13:11:35 +08:00
Kefu Chai
0d21f98d71 make-dist: use a loop to collect the ingredients of the dist tarball
for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 12:33:47 +08:00
Kefu Chai
040d44894d make-dist: add liburing to dist tarball
since liburing is enabled by default, let's included it in the dist
tarball.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 12:33:47 +08:00
Kefu Chai
b77aa9d685 make-dist: extract download_from() out
so we can reuse it

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-09 12:33:47 +08:00
Patrick Donnelly
4052b11f18
Merge PR #36998 into master
* refs/pull/36998/head:
	doc/mgr/volumes: Document authorize/deauthorize cli commands
	qa/tasks/cephfs: test `fs subvolume authorize/deauthorize`
	mgr/volumes: Allow/deny auth IDs access to FS subvolumes
	mon/MonCap: allow 'profile mgr' to create/update/del auth IDs

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-06 20:51:54 -08:00
Patrick Donnelly
0e6f238ce1
Merge PR #37618 into master
* refs/pull/37618/head:
	mds: throttle cap acquisition via readdir

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-06 20:51:06 -08:00
Patrick Donnelly
9bda6b8252
Merge PR #37662 into master
* refs/pull/37662/head:
	mon/MDSMonitor: deal with subscription after being expired

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-06 20:50:28 -08:00
Michael Fritch
33a907ac3f
Merge pull request #37600 from mgfritch/cephadm-nfs-rgw
mgr/cephadm: add RGW support for NFS ganesha

Reviewed-by: Daniel-Pivonka <dpivonka@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-06 18:10:26 -07:00
Michael Fritch
e0fbd49d23
Merge pull request #37792 from p-se/monitoring-prom-many-to-many
mgr/cephadm: many-to-many Prometheus error

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-11-06 18:02:00 -07:00
Matt Benjamin
62b1c21760
Merge pull request #37967 from linuxbox2/wip-rgwfile-zwrite
rgw_file: fix some zipper flow for RGWLibContinuedReq
2020-11-06 12:41:48 -05:00
Kefu Chai
b6daabd256
Merge pull request #37968 from changchengx/paxos
mon/PaxosService: remove unnecessary code

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-06 23:37:27 +08:00
Kefu Chai
cc5ef565d4
Merge pull request #37970 from toabctl/fix-orch-cli-doc-link
mgr/orchestratori: Fix doc link in README.rst

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-06 19:34:03 +08:00
Thomas Bechtold
8495c55134 mgr/orchestrator_cli: Fix doc link in README.rst
Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
2020-11-06 09:42:47 +01:00
Greg Farnum
704dbe9ec2 doc: update stretch mode doc to not be a lie
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-11-06 06:39:33 +00:00
Greg Farnum
1ff3352b3b mon: include stretch mode status in more outputs
It was missing from the monmap dump, and included in OSDMap::dump()
but not the OSDMap::print() which is used for text-based CLI queries.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-11-06 06:39:33 +00:00
Greg Farnum
41d7dcc1b7 mon: retain disallowed leader list on restart
We were only setting this when new monmaps were read from paxos -- whoops!
Pull apart that mechanism a little bit and make sure to set them before
doing elections, as part of bootstrap.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-11-06 06:13:03 +00:00
Greg Farnum
50351eac6a mon: Output the real leader in ::_quorum_status() and get_leader_name()
These functions previously assumed the first mon in the quorum
was the leader. That isn't accurate if the first monitor is
disallowed or it lost a connectivity-mode election, though.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-11-06 06:12:57 +00:00
Greg Farnum
0fd65db3de mon: monmap: print out disallowed_leaders in text form, when non-empty
This is already dumped in the programmatic output, but it got left out of
the direct-user-facing calls (as in "ceph mon dump").

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-11-06 06:12:47 +00:00
Greg Farnum
2e3643647b mon: Do not increase compatv when using monitor location or stretch mode
For mon_info_t, I first wrote things so that when monitors get a location
added in MonMap::mon_info_t, I bumped the struct_v to 5 and also bumped
the min_compat to 5. This made sure that nobody could decode the
struct and lose the location info, which if it were a monitor
would be very bad.

And for the MonMap, when stretch mode is enabled I bumped up the
comptav (in addition to the always-increased struct_v), for the same reason.

But clients also have to decode these structures, and we can't
disallow older clients from connecting to a stretched cluster.

Happily, usage of any stretch modes already requires a feature
bit and sets it as required in the monmap, so these are already
gated. Therefore, just don't set new compat values in these cases.

While at it, also gate setting the location on the monmap indicating
all monitors are updated.

Reported-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-11-06 06:12:39 +00:00
Greg Farnum
0fe26f0ef7 mon: fix erroneous commit of monmap stretch mode when failing to enable
MonmapMonitor::try_enable_stretch_mode() was accidentally writing into the
pending_map even when commit was false. Whoops!

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2020-11-06 06:12:01 +00:00
Kefu Chai
6352099561
Merge pull request #37966 from tchaikov/wip-cmake-uring
cmake: set GIT_SHALLOW and UPDATE_DISCONNECTED

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-06 11:36:24 +08:00
Kefu Chai
3f2a844da4 cmake: set GIT_SHALLOW and UPDATE_DISCONNECTED
* GIT_SHALLOW=TRUE, so we don't pull the full git history,
  as we don't care about it.
* UPDATE_DISCONNECTED=TRUE, to skip the UPDATE step, this change
  somehow works around
  https://gitlab.kitware.com/cmake/cmake/-/issues/19703. otherwise
  cmake keeps building liburing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-06 01:20:25 +08:00
Kefu Chai
eb81ab4d1c blk/kernel/io_uring: bump liburing to v0.7
* use functions exposed by liburing instead of using syscalls
* v0.7 is the latest release at the time of writing, as liburing is under
  active development. it'd be better to use a newer release.
* also use https://git.kernel.dk/liburing instead of
  http://git.kernel.dk/liburing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-06 01:20:06 +08:00
Matt Benjamin
a559cd4cc0 rgw_file: fix some zipper flow for RGWLibContinuedReq
Some bits of the standard Zipper conversions were missed for
the RGWLibContinuedReq case, where the setup is encapsulated in
the request, but execution is broken up in to steps.   This
currently affects only RGWWriteRequest.

Fixes: https://tracker.ceph.com/issues/48136

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2020-11-05 12:17:10 -05:00
Ronen Friedman
a2d3f9bb63 librbd: removing a "pessimizing move"
Silencing a compiler warning ("warning: moving a temporary object
prevents copy elision")

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2020-11-05 18:46:46 +02:00
Nizamudeen A
ff7ea2950d mgr/dashboard: Moving copyright into the app.constants
Move the variable copyright from about.component.ts to the app.constants.ts

https://tracker.ceph.com/issues/48135
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-11-05 21:57:00 +05:30
Kefu Chai
a86df246c6
Merge pull request #37919 from tchaikov/wip-cmake-liburing
cmake: enable LIBURING bluestore backend by default

Reviewed-by: Mark Nelson <mnelson@redhat.com>
2020-11-05 23:32:32 +08:00
Casey Bodley
40bc302a54
Merge pull request #37929 from BryceCao/wip-modify-error-code-of-bucket-info-API
rgw : modify error message to NoSuchBucket when bucket doesn't exist in bucket info API

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-11-05 10:04:30 -05:00
Lenz Grimmer
c6330e71a2
Merge pull request #37913 from rhcs-dashboard/button-disable
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-11-05 14:54:16 +01:00
Kefu Chai
c5f8bb268e
Merge pull request #37832 from tchaikov/wip-doc-slow-ops
doc: reformat health-messages.rst and revise SLOW_OPS section

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-05 21:05:17 +08:00