Remove unused argument test-align
Caused by: 1c8731c31e
Positional arguments are described by usage() because
the parsing code creates descriptions like "--object" for the
object positional argument.
Signed-off-by: David Zafman <dzafman@redhat.com>
Marking the `usage_exit` function as noreturn lets the compiler know
that execution won't continue beyond the statement where it's called,
so the path that would lead to the variables being used uninitialized
doesn't count.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Fixes the coverity issue:
2. uninit_member: Non-static class member op_index is not initialized
in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member req_offset is not initialized
in this constructor nor in any functions that it calls.
CID 1424845 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member req_total_len is not
initialized in this constructor nor in any functions that it calls.
CID 1422461 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member queue is not initialized
in this constructor nor in any functions that it calls.
CID 1422362 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member request is not initialized
in this constructor nor in any functions that it calls
Signed-off-by: Amit Kumar amitkuma@redhat.com
Fixes the coverity issue:
2. uninit_member: Non-static class member offset is not
initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member length is not
initialized in this constructor nor in any functions that it calls.
CID 1424433 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member tgt_offset is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar amitkuma@redhat.com
Fixes the coverity issues:
2. uninit_member: Non-static class member start_offset
is not initialized in this constructor nor in any functions
that it calls.
CID 1424396 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member last_offset is not
initialized in this constructor nor in any functions that it calls.
CID 1424658 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member offset is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
6f9250b4e9 Merge pull request #45 from TaewoongKim/reduce_phasetype_size
343e4105a6 Reduce the size of enum class PhaseType
git-subtree-dir: src/dmclock
git-subtree-split: 6f9250b4e9
Snap inodes that are waiting for flush are auth pinned, they affect
subtree/dirfrag frozen. Force client to do snapflush after waiting
for a period of time.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
When processing a cap flush message that is re-sent, it's possble
that the sender has already released all WR caps. So can't rely on
CEPH_CAP_ANY_WR check in MDCache:cow_inode().
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
This saves space and avoids unnecessary set logic. In particular, we no longer
need to do a heap allocation for each Dentry * in the std::set.
Before:
(gdb) print sizeof(Inode)
$1 = 1336
(gdb) print sizeof(Inode::dn_set)
$2 = 48
After:
(gdb) print sizeof(Inode)
$1 = 1360
(gdb) print sizeof(Inode::dentries)
$2 = 24
I'm not sure why the Inode size increased when the member size decreased (weird
padding by g++)? Anyway, we still get the benefit of no heap allocations for
the Dentry *s.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
