RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-24 03:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

osd,os,io: Initializing C_ProxyChunkRead members,queue,request

Browse Source 
Fixes the coverity issue:

2. uninit_member: Non-static class member op_index is not initialized
in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member req_offset is not initialized
in this constructor nor in any functions that it calls.
CID 1424845 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member req_total_len is not
initialized in this constructor nor in any functions that it calls.

CID 1422461 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member queue is not initialized
in this constructor nor in any functions that it calls.

CID 1422362 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member request is not initialized
in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com
This commit is contained in:
amitkuma 2017-12-05 21:38:35 +05:30
parent 4a0186ee30
commit 223c559e37
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/librbd/io/ReadResult.h
View File

@ -61,7 +61,7 @@ public:
template <typename ImageCtxT = ImageCtx>
struct C_SparseReadRequest : public C_SparseReadRequestBase {
ObjectReadRequest<ImageCtxT> *request;
ObjectReadRequest<ImageCtxT> *request = nullptr;
Extents buffer_extents;
C_SparseReadRequest(AioCompletion *aio_completion, Extents&& buffer_extents,

2
src/os/bluestore/NVMEDevice.cc
View File

@ -227,7 +227,7 @@ struct Task {
IORequest io_request;
std::mutex lock;
std::condition_variable cond;
SharedDriverQueueData *queue;
SharedDriverQueueData *queue = nullptr;
Task(NVMEDevice *dev, IOCommand c, uint64_t off, uint64_t l, int64_t rc = 0)
: device(dev), command(c), offset(off), len(l),
return_code(rc),

6
src/osd/PrimaryLogPG.cc
View File

@ -2756,10 +2756,10 @@ struct C_ProxyChunkRead : public Context {
PrimaryLogPG::ProxyReadOpRef prdop;
utime_t start;
ObjectOperation *obj_op;
int op_index;
uint64_t req_offset;
int op_index = 0;
uint64_t req_offset = 0;
ObjectContextRef obc;
uint64_t req_total_len;
uint64_t req_total_len = 0;
C_ProxyChunkRead(PrimaryLogPG *p, hobject_t o, epoch_t lpr,
const PrimaryLogPG::ProxyReadOpRef& prd)
: pg(p), oid(o), last_peering_reset(lpr),