Merge 22b6c1a531 introduce
5dc990c1ca commit which will lookup "remove"
attr. It shouldn't exist for most of cases but KeyValueStore will crash
if attr isn't exist. It seemed that this assert isn't correct.
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Journal is like a ring buffer. After data wrote to media disk, journal
can overwrite. But for those data, ssd dont't know it's nouse and can
remove. So add discard to tell ssd to remove those data.
This maybe not increase the performance. But it can increase the
lifetime of ssd.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
06a245a added a section def to assembly files; I added it twice to
this file. There's no damage, but a compiler warning (on machines with
yasm installed)
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Docker based tests should be explicit instead of auto-detected. It is
good that they do not run if docker is not available. It would be bad if
they run when the developer does not expect them to create docker
containers.
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
This indirectly tests that partprobe is called after zap because it
would fail to map the partitions to /dev/disk/by-partuuid otherwise.
It also indirectly test the implementation of init=none when using a
block device because the test would fail to put an object into the rbd
pool using the device otherwise.
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
For instance
test/docker-test.sh --os-type ubuntu --os-version 14.04 \
test/ceph-disk.sh
runs test/ceph-disk.sh in a ubuntu 14.04 docker container. Once the
container is populated and ceph compiled, running a test script roughly
requires entering the container and running make TESTS=tests/foo.sh check
* docker build ceph-ubuntu-14.04 using ubuntu.dockerfile as a Dockerfile
* it will run apt-get install ceph compilation / run dependencies
* git clone the-local-clone ceph-ubuntu-14.04
* docker run ceph-ubuntu-14.04 make -j4 in the ceph-ubuntu-14.04 clone
* docker run test/ceph-disk.sh
test/docker-test.sh is the command line interface for
test/docker-test-helper.sh which can be invoked from shell scripts.
test/ubuntu.dockerfile and test/ubuntu.dockerfile are regular
Dockerfiles which allow substitution of environment variables.
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
Not running partprobe after zapping a device can lead to the following:
* ceph-disk prepare /dev/loop2
* links are created in /dev/disk/by-partuuid
* ceph-disk zap /dev/loop2
* links are not removed from /dev/disk/by-partuuid
* ceph-disk prepare /dev/loop2
* some links are not created in /dev/disk/by-partuuid
This is assuming there is a bug in the way udev events are handled by
the operating system.
http://tracker.ceph.com/issues/9665Fixes: #9665
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
In the case of prepare_dev the partx alternative was missing and is not
added because update_partition does it.
http://tracker.ceph.com/issues/9721Fixes: #9721
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
Add the update_partition function to reduce code duplication.
The action is made an argument although it always is -a because it will
be -d when deleting a partition.
Use the update_partition function in prepare_journal_dev
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
Bug: http://tracker.ceph.com/issues/10096
Brief: Unmounting temporary mount point failed due to file being 'busy'.
Root cause could not be easily determined due to timing variances caused
by debug attempts. Race condition exists.
Solution: Implement a retry with incremental backoff as a viable
workaround. This workaround is okay because (1) Finding the root cause
would take a not insignificant amount of time/effort. (2) The workaround
is a more general fix for any process that might cause the exhibited
behavior.
Signed-off-by: Blaine Gardner <blaine.gardner@hp.com>
ghobject::dump must display shard_id + make ceph_objectstore_tool run from make check
Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
In this example of a write of v2 of the object being interrupted, OSD2
would never have any version of the D1 chunk. It only has the old v1
version of the D2 chunk.
Signed-off-by: Adam Spiers <aspiers@suse.com>
Adding testing of xattr for erasure coded shards
Fix error message when finding an unexpected xattr key
Signed-off-by: David Zafman <dzafman@redhat.com>
