John Mulligan
910a2e01f4
cephadm: add daemon_form.py: bases and funcs for daemon forms
...
Create daemon_form.py containing the DaemonForm class and a few
subclasses and utility functions for working with DaemonForms.
In a future commit, DaemonForm will become the base class for
the current assortment of classes named after the daemon or
family of daemon they help manage.
A daemon form, think "form" as in "template" or "mold", assists
in setting up, creating, and managing daemons controlled with
cephadm. Because cephadm supports a variety of services the
DaemonForm is an abstract base class and the module also supports
additional ABCs that may be used by DaemonForms to implement
optional features.
The daemon forms that are expected to be used directly must be
registered using the provided decorator. This is an explicit extra
step so that common bases that inherit from DaemonForm can be
implemented. Plus explicit is better than implicit. :-)
All DeamonForm subclasses are expected to provide a small set
of standard methods so that the types can be chosen, instantiated,
and used a common manner.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
f80c976f8d
cephadm: add some unit test coverage for deploying nfs, snmp
...
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
Nizamudeen A
db8fb4d047
Merge pull request #53436 from rhcs-dashboard/fix-bootstrap-script
...
mgr/dashboard: fix bootstrap script for cephadm installation
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 18:43:09 +05:30
Igor Fedotov
739416b087
Merge pull request #45069 from ifed01/wip-ifed-alloc-stuff
...
os/bluestore: fixing some non-critical bugs for HybridAllocator
Reviewed-by: Adam Kupczyk <akupzyk@ibm.com>
2023-10-04 16:03:42 +03:00
Pedro Gonzalez Gomez
5f532a8dd9
Merge pull request #53642 from rhcs-dashboard/fix-62964-main
...
mgr/dashboard: Fix user/bucket count in rgw overview dashboard
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-10-04 13:03:52 +02:00
zdover23
7f5d9018c5
Merge pull request #53792 from zdover23/wip-doc-2023-10-03-rados-operations-control-2-of-x
...
doc/rados: edit ops/control.rst (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-04 21:51:51 +11:00
avanthakkar
7d4ae2331f
mgr/dashboard: fix bootstrap script for cephadm installation
...
Fixes: https://tracker.ceph.com/issues/62827
Signed-off-by: avanthakkar <avanjohn@gmail.com>
2023-10-04 15:17:06 +05:30
zdover23
73b046f44e
Merge branch 'main' into wip-doc-2023-10-03-rados-operations-control-2-of-x
...
Signed-off-by: zdover23 <zac.dover@proton.me>
2023-10-04 20:33:03 +11:00
zdover23
0deb52e424
Merge pull request #53791 from zdover23/wip-doc-2023-10-03-rados-operations-control-1-of-x
...
doc/rados: edit ops/control.rst (1 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-04 20:30:23 +11:00
Zac Dover
03ed139306
doc/rados: edit ops/control.rst (2 of x)
...
Edit doc/rados/operations/control.rst (2 of x).
Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-04 19:08:02 +10:00
Zac Dover
89c9584f8a
doc/rados: edit ops/control.rst (1 of x)
...
Edit doc/rados/operations/control.rst (1 of x).
Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-04 19:04:56 +10:00
Venky Shankar
c6bff7392e
Merge PR #53494 into main
...
* refs/pull/53494/head:
mds: fix stray CInodes' use-after-free bug when submit ELid entry
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-10-04 13:48:31 +05:30
Venky Shankar
acd7f82846
Merge pull request #53332 from zhsgao/mds_overload_epochs
...
mds: add option mds_bal_overload_epochs
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-10-04 13:46:27 +05:30
Pedro Gonzalez Gomez
fbe9b8369b
Merge pull request #53746 from rhcs-dashboard/enhance-usage-bar
...
mgr/dashboard: rbd image hide usage bar when disk usage is not provided
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-04 09:37:28 +02:00
Nizamudeen A
b02c45b2e8
Merge pull request #53307 from rhcs-dashboard/fix-62721-main
...
mgr/dashboard: Rgw Multi-site naming improvements
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-04 10:30:05 +05:30
Yuri Weinstein
e77aa44f14
Merge pull request #52938 from batrick/mon-loop-refactor
...
mon: refactor loop variable names
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-10-03 12:58:15 -07:00
Yuri Weinstein
50c790830b
Merge pull request #52733 from batrick/i59813
...
osd/OSDMonitor: check svc is writeable before changing pending
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-10-03 12:57:42 -07:00
Laura Flores
1700bf7ae1
Merge pull request #53449 from ljflores/wip-tracker-62833
...
osd: fix read balancer logic to avoid redundant primary assignment
2023-10-03 15:53:21 -04:00
Nizamudeen A
297ca51a5e
Merge pull request #53671 from rhcs-dashboard/fix-protect-if-layering-enabled
...
mgr/dashboard: enable protect option if layering enabled
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Sunil Angadi <Sunil.Angadi@ibm.com>
2023-10-03 18:27:24 +05:30
Nizamudeen A
2a8afa62d1
Merge pull request #53673 from rhcs-dashboard/fix-62984-main
...
mgr/dashboard: show a message to restart the rgw daemons after moving from single-site to multi-site
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-03 18:24:09 +05:30
Adam King
3a38b25239
Merge pull request #53703 from adk3798/cephadm-refactor-ssh
...
cephadm: start ssh.py in cephadmlib
Reviewed-by: Michael Fritch <mfritch@suse.com>
2023-10-03 08:46:30 -04:00
Patrick Donnelly
c743568a93
Merge PR #53600 into main
...
* refs/pull/53600/head:
mds/FSMap: allow upgrades if no up mds
Reviewed-by: Milind Changire <mchangir@redhat.com>
2023-10-03 12:30:20 +00:00
avanthakkar
91be9ecdf5
mgr/dashboard: enable protect option if layering enabled
...
Fixes: https://tracker.ceph.com/issues/63076
Signed-off-by: avanthakkar <avanjohn@gmail.com>
2023-10-03 15:50:52 +05:30
Aashish Sharma
ab06466aa2
mgr/dashboard: show a message to restart the rgw daemons after moving from single-site to multi-site
...
Fixes: https://tracker.ceph.com/issues/62984
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2023-10-03 15:33:44 +05:30
Nizamudeen A
03217d6dc8
Merge pull request #53522 from rhcs-dashboard/landing-page-layout-fix
...
mgr/dashboard: fix the landing page layout issues
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-10-03 15:29:45 +05:30
Pedro Gonzalez Gomez
17d87af98a
mgr/dashboard: rbd image hide usage bar when disk usage is not provided
...
Fixes: https://tracker.ceph.com/issues/63037
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2023-10-03 10:33:07 +02:00
Nizamudeen A
d7c1bc88f5
Merge pull request #53699 from rhcs-dashboard/tls_v1.2_toglle
...
mgr/dashboard: allow tls 1.2 with a config option
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-10-03 13:22:23 +05:30
Nizamudeen A
b95fc36066
Merge pull request #53697 from rhcs-dashboard/mds-number-validator-fix
...
mgr/dashboard: fix cephfs form validator
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-10-03 13:20:39 +05:30
Nizamudeen A
3f904b0a65
mgr/dashboard: fix the landing page layout issues
...
We were following a row-col grid layout for the landing page.
First row includes Details, Status and Capacity
Second row for Inventory and Cluster Utilization
So if one of the item in the first row increases, it pushes the entire
second row downwards.
To fix this, I made a col-row grid.
First col has Details and Inventory in two rows.
Second col has Status and Capacity as a col and Cluster Utilization as a
single row
Fixes: https://tracker.ceph.com/issues/62961
Signed-off-by: Nizamudeen A <nia@redhat.com>
Co-authored-by: cloudbehl <cloudbehl@gmail.com>
2023-10-03 12:01:16 +05:30
Patrick Donnelly
990ca31f10
Merge PR #53754 into main
...
* refs/pull/53754/head:
osd: correct unsigned/signed compiler wrn
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2023-10-03 02:39:09 +00:00
Patrick Donnelly
733a65704f
osd: correct unsigned/signed compiler wrn
...
/home/pdonnell/ceph/src/osd/OSD.cc: In member function ‘void OSD::ShardedOpWQ::stop_for_fast_shutdown()’:
/home/pdonnell/ceph/src/osd/OSD.cc:11143:41: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
11143 | for (int shard_index = 0; shard_index < osd->num_shards; shard_index++) {
Fixes: https://tracker.ceph.com/issues/62851
Fixes: 210dbd4ff1
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2023-10-02 22:03:25 +00:00
Casey Bodley
cc984bebb7
Merge pull request #47148 from NitzanMordhai/wip-nitzan-test-cls-lock-expiered-locks-start
...
test/cls_lock: expired lock before unlock and start check
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-02 20:46:29 +01:00
Casey Bodley
80344a86e7
Merge pull request #53616 from ronen-fr/wip-rf-cnceq
...
rgw/test: fix compiler warning
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-02 20:29:57 +01:00
Patrick Donnelly
7cde5724e6
mds/FSMap: allow upgrades if no up mds
...
This is to support the fail_fs scenario for cephadm where max_mds >= 1
and all MDS are down.
Fixes: https://tracker.ceph.com/issues/62682
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2023-10-02 17:55:38 +00:00
Adam King
8470cecf0d
cephadm: format black cephadmlib/ssh.py
...
Signed-off-by: Adam King <adking@redhat.com>
2023-10-02 11:40:25 -04:00
Adam King
62534317d8
cephadm: start ssh.py in cephadmlib
...
As part of the cephadm refactoring process
to split cephadm into multiple python files,
start "ssh.py" that includes some functions used
for setting up and testing ssh connections,
primarily as part of bootstrap.
Signed-off-by: Adam King <adking@redhat.com>
2023-10-02 11:39:06 -04:00
Ilya Dryomov
6c6f0d3109
Merge pull request #53735 from idryomov/wip-63010
...
qa/suites/krbd: stress test for recovering from watch errors
Reviewed-by: Mykola Golub <mgolub@suse.com>
2023-10-02 17:10:19 +02:00
Casey Bodley
5e4e058a73
Merge pull request #50350 from BBoozmen/oozmen_rgw_beast_log_bucket_name
...
rgw/logging: add bucket and object names to the log line for ops-log
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-02 15:39:11 +01:00
Casey Bodley
12b1a560c6
Merge pull request #52144 from linuxbox2/wip-nochown-bucket
...
rgw/file: make setattr(...) a no-op on buckets
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-10-02 15:38:35 +01:00
Casey Bodley
8da4ba8a35
Merge pull request #52960 from cbodley/wip-62411
...
rgw/lc: remove_bucket_config() doesn't update xattrs on bucket delete
Reviewed-by Matt Benjamin <mbenjamin@redhat.com>
2023-10-02 15:38:16 +01:00
Casey Bodley
3b4ba8b7e9
Merge pull request #53266 from VVoidV/lbr-chunk-upload-buffer-fix
...
rgw: improve buffer list utilization in the chunkupload scenario
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-02 15:37:46 +01:00
Casey Bodley
12bc70b170
Merge pull request #53525 from RickyMaRui/fix-SignatureDoesNotMatch
...
rgw: fix SignatureDoesNotMatch when extra headers start with 'x-amz'
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-02 15:37:25 +01:00
Casey Bodley
7c4c73ad17
Merge pull request #53602 from cbodley/wip-62938
...
rgw: s3website doesn't prefetch for web_dir() check
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-10-02 15:37:08 +01:00
Casey Bodley
9fbb530312
Merge pull request #53614 from xrmeng8756/master
...
rgw: fix rgw rate limiting RGWRateLimitInfo class decode_json max_rea…
Reviewed-by: Jiffin Tony Thottan <jthottan@redhat.com>
2023-10-02 15:36:53 +01:00
Casey Bodley
84dcf80155
Merge pull request #53676 from smanjara/data-sync-fairness-crash
...
rgw/multisite: call drain before flushing markers in incremental sync
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-02 15:36:07 +01:00
Casey Bodley
98cdc09608
Merge pull request #53680 from cbodley/wip-62989
...
rgw/keystone: EC2Engine uses reject() for ERR_SIGNATURE_NO_MATCH
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-10-02 15:35:47 +01:00
Casey Bodley
123c60797e
Merge pull request #53684 from cbodley/wip-rgw-keystone-yield
...
rgw/async: use optional_yield for keystone and kms requests
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
2023-10-02 15:35:20 +01:00
Casey Bodley
c78168d188
Merge pull request #53691 from max-licc/radosgw_start_watcher_crash
...
rgw: fix unwatch crash at radosgw startup
Reviewed-by: Adam Emerson <aemerson@redhat.com>
2023-10-02 15:34:51 +01:00
Casey Bodley
100d81aa06
Merge pull request #53714 from cbodley/wip-63004
...
[CVE-2023-43040] rgw: Fix bucket validation against POST policies
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-10-02 15:34:25 +01:00
Adam King
0bca13c8bf
Merge pull request #53724 from adk3798/rm-get_unit_name_by_instance
...
cephadm: remove get_unit_name_by_instance func
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-10-02 09:46:04 -04:00