Commit Graph

121666 Commits

Author SHA1 Message Date
Kefu Chai
7fb0569ec3
Merge pull request #40124 from adk3798/format-help
pybind/ceph_argparse: print --format flag name in help descs

Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-04-03 22:27:23 +08:00
Kefu Chai
9541a97605
Merge pull request #40316 from batrick/i49605
pybind/mgr/volumes: avoid deadlock in ceph-mgr Finisher thread

Reviewed-by: Kotresh HR <khiremat@redhat.com>
2021-04-03 22:24:22 +08:00
Kefu Chai
9d00ec5bcc
Merge pull request #40555 from jecluis/wip-cephadm-fix-apparmor.master
cephadm: ignore apparmor if profiles file is empty

Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-04-03 22:19:40 +08:00
Kefu Chai
889d850ba6
Merge pull request #38500 from pdvian/wip-print-weight
crush/CrushCompiler: print weight with uniform precision

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:19:07 +08:00
Kefu Chai
f5c859ea06
Merge pull request #38258 from badone/wip-tracker-48336-monmaptool-enforce-ip-better
monmaptool: Don't call set_port on an invalid address

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:18:06 +08:00
Kefu Chai
cf868b7a1b
Merge pull request #40518 from Rethan/fix-client-message-throttle-max
osd: allow osd_client_message_size throttle set to zero

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:16:49 +08:00
Kefu Chai
a661556363
Merge pull request #40444 from TheJJ/ensure-fsck-transactions
os/bluestore: ensure fsck repair transactions succeed

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2021-04-03 22:14:19 +08:00
Kefu Chai
e8fb63cf41
Merge pull request #40457 from lihuibng/crush-bug
crush/CrushLocation: do not print logging message in constructor

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:13:28 +08:00
Kefu Chai
5468c31d29
Merge pull request #40488 from lxbsz/typo
mgr: fix the desc typo for mds PyCFunction methods

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:12:59 +08:00
Kefu Chai
f26515fef7
Merge pull request #40168 from amathuria/wip-amathuria-fix-mon-trimming
mon: Modifying trim logic to change paxos_service_trim_max dynamically

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:12:26 +08:00
Kefu Chai
c644ae1446
Merge pull request #40498 from guits/guits-quick_fix
cephadm: fix a typo

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Adam King <adking@redhat.com>
2021-04-03 22:11:50 +08:00
Kefu Chai
fdb92c3b5b
Merge pull request #40538 from tchaikov/wip-msg-type-cleanup
msg/msg_types: let ceph_entity_name::parse() accept string_view

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2021-04-03 22:10:12 +08:00
Kefu Chai
185b0fd1d2
Merge pull request #40556 from liewegas/mon-no-config-indent
mon/ConfigMonitor: do not indent 'config dump' output

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:08:58 +08:00
Kefu Chai
9d4505eb5c
Merge pull request #40574 from badone/wip-submanager-contatiner-failure-tracker-50118
install-deps: Use dnf config-manager

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-03 22:02:47 +08:00
Brad Hubbard
2e1ee019d2 install-deps: Use dnf config-manager
Using subscription-manager will fail in a container so use dnf
config-manager which should work on bare metal as well as in a
container.

Fixes: https://tracker.ceph.com/issues/50118

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-04-03 16:57:50 +10:00
Kefu Chai
8c6b9e45c9 msg/msg_types: remove entity_name_t::parse(const char*...)
it can be replaced with entity_name_t::parse(string_view)

also refactor entity_name_t::parse(string_view) a little bit, to
embed the logic of `entity_name_t::parse(const char*...)` in it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-03 13:03:43 +08:00
Kefu Chai
af167c074c
Merge pull request #40435 from tchaikov/wip-48893
common/pick_address: Allow binding on loopback iface

Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-03 11:13:45 +08:00
Kefu Chai
7f01d36a2c common/pick_address: Allow binding on loopback iface
in 6147c09171, "lo" is also skipped when
daemon is trying to find an address to bind. but that change reverts the
fix of 201b592043, to address the problem.

an option named "ms_bind_exclude_lo_iface" is added, it defaults to
"true". but it can be changed to false to allow daemon to bind on "lo".

Fixes: https://tracker.ceph.com/issues/50012
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-03 10:06:14 +08:00
Kefu Chai
6d0ed81f79 common/pick_address: pass string by reference
to silence warnings from clang-tidy.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-03 10:06:13 +08:00
Kefu Chai
c3c110b576 common/pick_address: use scope_guard for freeifaddrs()
for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-03 10:06:13 +08:00
Kefu Chai
52785d5a36 common/pick_addr: refactor pick_address.cc and ipaddr.cc
* do not replicate the same logic in IPv4 and IPv6 paths
* use helpers returning bool for filtering the candidate addresses
  for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-03 10:06:13 +08:00
Kefu Chai
b106ec0bbf common/pick_address: document find_ip_in_subnet_list()
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-03 10:06:13 +08:00
zdover23
21b55839a9
Merge pull request #40531 from sseshasa/wip-mclock-config-ref-doc
doc: Add mclock configuration reference documentation

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2021-04-03 06:06:26 +10:00
Kefu Chai
0af1ddb00b
Merge pull request #40456 from wjwithagen/wjw-fix-boost-version
cmake: bump the required boost version to 1.73

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-02 18:20:00 +08:00
Kefu Chai
8baaab85e9
Merge pull request #40565 from tchaikov/wip-crimson-header-cleanup
crimson/osd: include headers at where they are used

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-04-02 18:06:32 +08:00
Kefu Chai
f3814d7a69 crimson/osd: include headers at where they are used
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-02 17:17:38 +08:00
Kefu Chai
780c00f0c9
Merge pull request #40564 from tchaikov/wip-crimson-internal_client_request-lite
crimson/osd: cleanups preparing for InternalClientRequest infrastructure.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-02 15:52:41 +08:00
Radoslaw Zarzynski
f384a5dc34 crimson/osd: pg_backend.h doesn't depend on pg.h anymore.
It's not only unnecessary but it also causes a depedency hell.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:44:17 +08:00
Radoslaw Zarzynski
a8e05fc5a6 crimson/osd: use obc->get_oid() instead of passing hobject_t around.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:36:55 +08:00
Radoslaw Zarzynski
2b8076a7d5 crimson/common: let error handlers to return errorated futures.
Before the change an error handler (a callable passed as second
or further parameters to `safe_then()`) was supposed to return
`seastar::future<..>` if it handled the errors or one of allowed
error types otherwise (like `crimson::ct_error::enoent`). Now
they may return also an erroratored future (`errator<ErrorT>::future<...>`)
and its error-set will fused with other sources of errors to be
included in errorator `safe_then()` returns.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:32:31 +08:00
Radoslaw Zarzynski
076108c9c8 crimson/osd: OpsExecuter::get_target() returns const reference now.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:30:37 +08:00
Radoslaw Zarzynski
3aa62d7ed0 crimson/common: replace UTF-8 with ASCII in errorator's stateful_error_t.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:30:17 +08:00
Radoslaw Zarzynski
15bea95883 crimson/common: stateful_error_t allows for void-taking handlers.
Before this commit there was an inconsistencty between
`unthrowable_wrapper::handle()` and `stateful_error_t::handle()`
in the regard of parameters the provided handler had to accept.
The former was fine with void-taking handlers while the latter
was not.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:29:58 +08:00
Radoslaw Zarzynski
5c78bebca1 crimson/osd: drop the never used ctors of osd_op_params_t.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:26:50 +08:00
Radoslaw Zarzynski
0e731e6c08 crimson/osd: std::move func in pg::with_*_obc().
Well, likely all the commit does is just appending a couple
of extra bytes. Though, strictly juding, a func should be
`std::move()`d before calling in those cases. Otherwise we
can miss e.g. the `operator() &&` overload.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:26:42 +08:00
Radoslaw Zarzynski
62f00e45b8 crimson/osd: use the alias for OpsExecuter in PG::do_osd_ops().
It's already defined there. We've just missed this fact in
one place.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:24:43 +08:00
Radoslaw Zarzynski
287e65ab1d crimson/osd: fix a thinko in the comment about OpsExecuter.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:22:22 +08:00
Radoslaw Zarzynski
5ef7194c68 crimson/osd: drop ObjectContext::loaded as it's never read.
The `PG::with_obc*` machinery uses the `existed` marker
provided by the LRU cache subsystem.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-02 15:17:00 +08:00
Kefu Chai
0cda06a30b
Merge pull request #40533 from Seong-yeop/master
src/rgw/rgw_client_io.h: fix a typo

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-02 15:03:58 +08:00
Kefu Chai
787c28f936
Merge pull request #40540 from tchaikov/wip-stop.sh
stop.sh: restructure stop logic

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-02 10:17:05 +08:00
zdover23
783b9407ba
Merge pull request #40454 from zdover23/wip-doc-cephadm-osd-remove-main-text-rewrite-2021-Mar-26
doc/cephadm: rewrite osd.rst "Remove an OSD"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-02 07:53:50 +10:00
Sage Weil
e0ff3bf889 mon/ConfigMonitor: do not indent 'config dump' output
The indentation is misleading.  For example,

  mgr                                  advanced  mgr/telemetry/last_opt_revision       3                                                                                  *
  osd                                  advanced  osd_max_backfills                     10
  osd                                  basic     osd_memory_target                     6442450944
  osd                                  advanced  osd_scrub_auto_repair                 true
    mds.ar                             basic     mds_join_fs                           ar
    client.rgw.foo                     basic     rgw_frontends                         beast port=8080                                                                    *

The indentation kind of implies that mds.ar (or client.whatever) is
beneath 'osd', which it is not, and there rarely a 'client' scoped
option to make it look right.  Same problem for osd.foo etc.

Also, it is IMO easier to see the nesting structure when things align
naturally. e.g.

global
osd
osd.1
osd.2
mds
mds.foo
mds.foo.bar
client.foo.bar
...

Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-01 14:22:07 -05:00
Adam C. Emerson
777304220a
Merge pull request #39092 from adamemerson/wip-datalog-genbacking
rgw: Fixes and Improvements for Datalog

Reviewed-By: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-By: Casey Bodley <cbodley@redhat.com>
2021-04-01 15:16:01 -04:00
Joao Eduardo Luis
8395885794
cephadm: ignore apparmor if profiles file is empty
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
2021-04-01 19:11:59 +00:00
Josh Durgin
812fc60d91
Merge pull request #40548 from tchaikov/wip-doc-tweaks
doc: tweak .admonition.important and command line block formatting tweaks

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-01 10:19:23 -07:00
Kefu Chai
73eb992c18 doc/rbd: tweak the format of command line blocks
to use the "prompt" directive for better rendering.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-02 00:46:00 +08:00
Kefu Chai
1c8654a3d7 doc/_themes: tweak .admonition.important
do not render the links in "important" block in gray, it's not
readable in light red background. so use the blue and purple colors
specified by sphinx_rtd_theme.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-02 00:46:00 +08:00
Patrick Donnelly
8893f292e9
Merge PR #40524 into master
* refs/pull/40524/head:
	doc: document CephFS Snapshot Mirroring

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-01 08:13:05 -07:00
Kefu Chai
80482fed5f
Merge pull request #40535 from tchaikov/wip-dashboard-pytest
pybind/mgr/dashboard: move pytest into requirements.txt

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-04-01 22:58:04 +08:00
Sage Weil
c4948717b6 Merge PR #40504 into master
* refs/pull/40504/head:
	doc/security: no gpg keys yet
	doc/security: restructure a bit
	doc/security: add security section

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-01 10:49:47 -04:00