Commit Graph

122649 Commits

Author SHA1 Message Date
Kefu Chai
7c0ed157d7 common/util: enable cgroup only on linux
cgroups, i.e. control groups, are a linux kernel feature. this is not
available on FreeBSD, Win32 or MacOS. furthermore, we are reading the
information of it by accessing files exposed using a tmpfs filesystem
mounted at /sys/fs/cgroup, which is not available on other systems.

in this change, instead of guarding it using `#ifndef _WIN32`, it is now
guraded using `defined(__linux__)`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:16:12 +08:00
Kefu Chai
08034454e1 include/compat.h: declare cpu_set_t for MacOS
to appease the compiler as it needs to compile numa.cc

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:16:12 +08:00
Kefu Chai
d34aae8c86 common/Throttle: remove unused member variable
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:16:12 +08:00
Kefu Chai
fab337c1d0 common/compat: detect memset_s() using check_function_exists()
more robust this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:16:12 +08:00
Kefu Chai
a938108197 common/ceph_time: do not include non-existent header file
i have following error when building on MacOS

ceph/src/common/ceph_time.cc:29:10: fatal error: 'ostringstream' file not found
         ^~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:16:12 +08:00
Kefu Chai
aeb1ef57f0 common/StackStringStream: make override method with "final"
this change also silences the warnings like:

src/common/StackStringStream.h:75:7: warning: 'overflow' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  int overflow(int c)
      ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:16:12 +08:00
Kefu Chai
731ec94831 cmake: detect suseconds_t using CHECK_TYPE_SIZE
instead assuming it's a macro use CHECK_TYPE_SIZE to check it.

on Darwin, it's defined as `__darwin_suseconds_t`

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:16:07 +08:00
Kefu Chai
78d4990ac4 cmake: do not build libblk if libblk_srcs is empty
if we don't or just not able to buld libblk, let's skip it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:15:15 +08:00
Kefu Chai
7471fbfa4b cmake: require lua if WITH_CEPHFS is enabled
in src/mds/Mantle.cc, the lua C binding APIs are used, so we should only
require lua if WITH_CEPHFS is enabled.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:15:15 +08:00
Kefu Chai
d275875b0e cmake: check for empty string by its value
the behavior of cmake 3.17 is a little bit different as it consider

NOT _library STREQUAL ""

as true, if ${_library} is "".

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-02 08:15:15 +08:00
Kefu Chai
5093c6f36e
Merge pull request #41116 from tchaikov/wip-in_addr_t
common/pick_address: define in_addr_t if it is not defined

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-05-02 08:09:03 +08:00
Kefu Chai
7e6a653dea
Merge pull request #41117 from tchaikov/wip-doc-cephfs-conf
doc/cephfs/mds-config-ref: remove duplicated confval

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-05-01 23:34:11 +08:00
Kefu Chai
a06f8edeca common/pick_address: define in_addr_t if it is not defined
neither mingw not not have in_addr_t defined, see
https://docs.microsoft.com/en-us/windows/win32/api/winsock2/ns-winsock2-in_addr,
so define it if it is not defined.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-01 23:30:53 +08:00
Kefu Chai
92ca8bbe38 doc/cephfs/mds-config-ref: remove duplicated confval
this change addresses the warning of:

/home/jenkins-build/build/workspace/ceph-pr-docs/doc/cephfs/mds-config-ref.rst:2: WARNING: duplicate confval_option description of mds_cache_memory_limit, other instance in cephfs/cache-configuration
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/cephfs/mds-config-ref.rst:2: WARNING: duplicate confval_option description of mds_cache_reservation, other instance in cephfs/cache-configuration

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-01 23:05:37 +08:00
Kefu Chai
960b6e034d
Merge pull request #41043 from ifed01/wip-ifed-fix-use-ratio
osd: compute OSD's space usage ratio via raw space utilization

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-05-01 12:59:41 +08:00
Patrick Donnelly
b9c7d52987
Merge PR #41012 into master
* refs/pull/41012/head:
	doc/cephfs/cache-config: use config item macros

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-30 21:03:17 -07:00
Kefu Chai
2fb01d3f62
Merge pull request #40961 from tchaikov/wip-50456
common/pick_address: filter out loopback addresses

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-05-01 09:11:30 +08:00
Kefu Chai
8ba7087585
Merge pull request #41071 from tchaikov/wip-cmake-disable-vta
cmake: disable "variable tracking" when building rados python binding

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-05-01 09:09:05 +08:00
Patrick Donnelly
325bebc021
Merge PR #41091 into master
* refs/pull/41091/head:
	doc/cephfs/nfs: add section about ganesha logs
	doc/cephfs/nfs: Replace volume/nfs with nfs
	doc/cephfs/nfs: add note about export management with volume/nfs interface only

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-30 17:15:55 -07:00
Sridhar Seshasayee
0ad2b2c8ee
Merge pull request #41004 from sseshasa/wip-mclock-max-backfill-misc-fix
osd: Override recovery, backfill and sleep related config options during OSD and mclock scheduler initialization.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
2021-04-30 22:58:21 +05:30
Daniel Gryniewicz
6110c687a6
Merge pull request #40967 from dang/wip-dang-zipper-user
RGW Zipper consistent load/store APIs for User
2021-04-30 10:03:58 -04:00
Kefu Chai
29a613bfe2
Merge pull request #40946 from ifed01/wip-ifed-dump-pool-statfs
osd: admin cmd to dump pools statfs for a specific OSD

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-30 19:43:18 +08:00
Kefu Chai
fee3028abc
Merge pull request #41014 from smithfarm/wip-mempool-cacheline-49781
qa: verify the benefits of mempool cacheline optimization

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-30 19:36:17 +08:00
Samuel Just
964acc6dd9
Merge pull request #40998 from cyx1231st/wip-seastore-onode-tree-delete
crimson/onode-staged-tree: implement/validate features to erase values from tree

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-04-29 23:22:42 -07:00
Varsha Rao
6ff3c1da87 doc/cephfs/nfs: add section about ganesha logs
Fixes: https://tracker.ceph.com/issues/50008
Signed-off-by: Varsha Rao <varao@redhat.com>
2021-04-30 11:16:48 +05:30
Varsha Rao
ff11cdb4bc doc/cephfs/nfs: Replace volume/nfs with nfs
Recently, nfs related code was moved out of volumes plugin[1]. So using the
name volume/nfs for the interface is not appropriate.

[1] https://github.com/ceph/ceph/pull/40526

Signed-off-by: Varsha Rao <varao@redhat.com>
2021-04-30 11:09:23 +05:30
Varsha Rao
923e689e08 doc/cephfs/nfs: add note about export management with volume/nfs interface only
Signed-off-by: Varsha Rao <varao@redhat.com>
2021-04-30 11:09:23 +05:30
Loïc Dachary
7fe0ac7c11 qa: verify the benefits of mempool cacheline optimization
There already is a test to verify the mempool sharding works, in the sense that
it uses at least half of the variables available to count the number of
allocated objects and their total size. This new test verifies that, with
sharding, object counting is at least twice faster than without sharding. It
also collects cacheline contention data with the perf c2c tool. The manual
analysis of this data shows the optimization gain is indeed related to cacheline
contention.

Fixes: https://tracker.ceph.com/issues/49896

Signed-off-by: Loïc Dachary <loic@dachary.org>
2021-04-30 12:11:13 +08:00
zdover23
462c121653
Merge pull request #40502 from zdover23/wip-doc-podman-version-octopus-note-2021-30-Mar
doc/cephadm: add podman version note to install

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-04-30 05:53:58 +10:00
Ernesto Puerta
381685f17f
Merge pull request #40072 from wornet-mwo/dashboard--grafana-hostname-corrections
mgr/dashboard: Fixed name clash when hostname similar to another

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: p-se <NOT@FOUND>
2021-04-29 19:40:57 +02:00
Daniel Gryniewicz
f330b50f7a RGW Zipper - Permenant User storage API
The load/store/remove APIs for User are needed, so make them consistent
and permenant.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-04-29 12:56:35 -04:00
Kefu Chai
9e3aa76f4a
Merge pull request #41040 from tchaikov/wip-doc-mds-conf
doc/cephfs/mds-config-ref: render options using confval directive

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-30 00:33:41 +08:00
Mark Kogan
48ce5bb6c3
Merge pull request #41028 from mkogan1/wip-rgw-tracker-50467
rgw: fix segfault related to explicit object manifest handling
2021-04-29 18:48:54 +03:00
Ernesto Puerta
b0c0815e9d
Merge pull request #41083 from rhcs-dashboard/fix-50580-master
mgr/dashboard: OSDs placement text is unreadable

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-04-29 17:42:38 +02:00
Kefu Chai
a64b623537
Merge pull request #41082 from tchaikov/wip-50558
os/bluestore: Revert" Optimizing the lock of bluestore writing process"

Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2021-04-29 22:59:02 +08:00
Kefu Chai
4fa8b4aa53
Merge pull request #41064 from petrutlucian94/win_at_removedir
include: define AT_REMOVEDIR on Windows

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-29 22:58:16 +08:00
Kefu Chai
59624b0fd9
Merge pull request #41038 from tchaikov/wip-cmake-liburing
cmake: pass "CC" using configure when building liburing

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2021-04-29 22:20:09 +08:00
Aashish Sharma
543b02436f mgr/dashboard:OSDs placement text is unreadable
While displaying the host pattern in the OSDs placement tab, it gets splited with semi-colons. Also adjusted the column size of Container Image ID and Placement columns.

Fixes: https://tracker.ceph.com/issues/50580
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2021-04-29 19:26:17 +05:30
Kefu Chai
2627f3204e os/bluestore: Revert" Optimizing the lock of bluestore writing process"
This reverts commit e80d3f7a89.

Fixes: https://tracker.ceph.com/issues/50571
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-29 20:03:33 +08:00
Yingxin Cheng
cf9f1c80e6 crimson/onode-staged-tree: implement erase for perf-staged-tree
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:38 +08:00
Yingxin Cheng
80868b8359 crimson/onode-staged-tree: implement synthetic tests for value erase
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:38 +08:00
Yingxin Cheng
c6427de4db crimson/onode-staged-tree: fix ownership issues at node-level
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:38 +08:00
Yingxin Cheng
47b67ec417 crimson/onode-staged-tree: allow to insert item to an empty node
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:38 +08:00
Yingxin Cheng
04fbaa036a crimson/onode-staged-tree: move try_downgrade_root() into fix_index()
Specifically, apply_children_merge() doesn't know whether it will be
retired due to fix_parent_index().

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:37 +08:00
Yingxin Cheng
e0a9bfbcfa crimson/onode-staged-tree: don't validate child when it's outdated
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:37 +08:00
Yingxin Cheng
9f821d0ee2 crimson/onode-staged-tree: pass origin_left_addr to apply_children_merge()
rebuild_extent() may change the address of the left child, we need to
pass the origin_left_addr in order to validate if it is correct.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:37 +08:00
Samuel Just
86ad429d8d crimson/.../node_extent_manager: replay extents may be dirty
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-04-29 16:03:37 +08:00
Yingxin Cheng
fbf4d71d20 crimson/onode-staged-tree: cleanup tree_utils.h
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:37 +08:00
Yingxin Cheng
d0998d3a75 crimson/onode-staged-tree: test fix_index() in internal node
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:37 +08:00
Yingxin Cheng
6ece760c38 crimson/onode-staged-tree: test merge in internal node
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-29 16:03:37 +08:00