RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-20 01:51:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
116,006 Commits 216 Branches 394 Tags 1.8 GiB
7acd445fcc
Commit Graph

116006 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Xiubo Li
7acd445fcc qa/tasks: tear down the background process before unmounting 
If the background process keeps running by opening the mountpoint
directory, the unmount will fail with BUSY.

Fixes: https://tracker.ceph.com/issues/46883
Signed-off-by: Xiubo Li <xiubli@redhat.com>
 2020-10-21 04:02:38 -04:00
Xiubo Li
def177ff3b qa/tasks: switch to _kill_background() helper to terminate the daemons 
Fixes: https://tracker.ceph.com/issues/46883
Signed-off-by: Xiubo Li <xiubli@redhat.com>
 2020-10-21 04:01:35 -04:00
Mykola Golub
b94369f7c1
Merge pull request #37699 from dillaman/wip-47880 
journal: possible race condition between flush and append callback

Reviewed-by: Mykola Golub <mgolub@suse.com>
 2020-10-18 15:43:51 +03:00
Kefu Chai
def1b6cd53
Merge pull request #37698 from tchaikov/wip-crimson-do-until 
crimson/common: schedule action only if the future is not available

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
 2020-10-17 09:32:23 +08:00
Kefu Chai
b8068df1a3
Merge pull request #37695 from tchaikov/wip-dashboard-pep8 
mgr/dashboard: do not use "l" for variable name

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
 2020-10-17 01:32:59 +08:00
Mykola Golub
fc483304ed
Merge pull request #37645 from dillaman/wip-librbd-aio-completion-race 
librbd: update AioCompletion return value before evaluating pending count

Reviewed-by: Mykola Golub <mgolub@suse.com>
 2020-10-16 18:45:32 +03:00
Mykola Golub
8af1e38365
Merge pull request #37643 from dillaman/wip-47840 
librbd: ignore -ENOENT error when disabling object-map

Reviewed-by: Mykola Golub <mgolub@suse.com>
 2020-10-16 18:45:04 +03:00
Mykola Golub
f90daf7495
Merge pull request #37444 from dillaman/wip-librbd-copyup-api 
librbd: support the ability to process parent data prior to copyup

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Or Ozeri <oro@il.ibm.com>
 2020-10-16 18:44:36 +03:00
Jason Dillaman
458ab997fe journal: possible race condition between flush and append callback 
When notifying the journal recorder of an overflow or if the object
close request has completed due to no more in-flight IO, it was
possible for a race between a flush request and the processing of
an append completion to attempt to kick off duplicate notifications.
Since the overflowed and closed callbacks are properly protected from
duplicates, use a counter instead of a boolean to track possible
in-flight handler callbacks.

Fixes: https://tracker.ceph.com/issues/47880
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
 2020-10-16 11:29:54 -04:00
Kefu Chai
1c422d2f2a crimson/common: schedule action only if the future is not available 
otherwise we could call do_until() recursively if we have other tasks
which need to prempt the reactor and current future's state is actually
always available.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2020-10-16 22:08:03 +08:00
Kefu Chai
710128607b mgr/dashboard: do not use "l" for variable name 
see also https://www.flake8rules.com/rules/E741.html

also silences flake8 warnings like:

2: {tty:'./controllers/home.py:90:26: E741 ambiguous variable name 'l'':'./controllers/home.py:90:26: E741 ambiguous variable name 'l''}
2: {tty:'./controllers/logs.py:52:13: E741 ambiguous variable name 'l'':'./controllers/logs.py:52:13: E741 ambiguous variable name 'l''}
2: {tty:'./services/ganesha.py:36:40: E741 ambiguous variable name 'l'':'./services/ganesha.py:36:40: E741 ambiguous variable name 'l''}
2: 3     E741 ambiguous variable name 'l'

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2020-10-16 18:56:09 +08:00
Kefu Chai
f5adeeb621
Merge pull request #37687 from tchaikov/wip-crimson-errorator 
crimson/common: do not take from a future twice

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
 2020-10-16 16:50:10 +08:00
Kiefer Chang
d9e62340b1
Merge pull request #37602 from tspmelo/wip-flake8-ignore 
mgr/dashboard: Remove some Flake8 ignore rules

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
 2020-10-16 15:27:35 +08:00
Kefu Chai
5d80c545a9 crimson/common: do not take from a future twice 
before this change, in our specialization of seastar::do_until(),
we access `f` after calling `f.get()`, this is not correct. as `f.get()`
actually moves `f._state` away and detaches the associated promise if any.
so we cannot call `f._then()` anymore after calling `f.get()`. as
`f._then()` schedules `f` by detaching the future from promise and
attaching the scheduled task to the promise. but `future_base::detach_promise()`
does not check `_promise` before accessing it, hence the segfault.

after this change, the order of the checks is rearranged so that
`f.get()` is called at the end. and also use `f.get0()` to be more
explicit, as we are accessing the only element of the returned
value.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2020-10-16 14:36:58 +08:00
J. Eric Ivancich
ff342f2f02
Merge pull request #37684 from ivancich/rgw-yummy-orphan-testing 
rgw: use yum rather than dnf for teuthology testing of rgw-orphan-list

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
 2020-10-15 16:14:07 -04:00
J. Eric Ivancich
11a08a5bb8 rgw: use yum rather than dnf for testing rgw-orphan-list 
The teuthology testing for rgw-orphan-list needs to install
`s3cmd`. Switch from using dnf to yum to work on a wider variety of
platforms.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
 2020-10-15 15:08:45 -04:00
Adam C. Emerson
46661cae98
Merge pull request #37660 from adamemerson/wip-datalog-fix 
cls/fifo: Switch use CLS_ERR for errors
rgw/fifo: Fix a few missed return value assignments
rgw/fifo: Add some error logging
rgw/fifo: Catch two instances journaling a new part
rgw/fifo: Use unique_ptr and explicit release for callbacks

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
 2020-10-15 12:03:13 -04:00
Joshua Schmid
eb94d2b325
Merge pull request #37575 from bk201/wip-47742 
qa/suites/rados/cephadm/dashboard: fix creating OSD failure
 2020-10-15 15:02:50 +02:00
Jason Dillaman
93eccc15f4
Merge pull request #37669 from lixiaoy1/fix_cache_state_ut_1015 
rbd/cache: fix UTs related to image cache state

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
 2020-10-15 08:47:57 -04:00
lixiaoy1
367c1bb122 rbd/cache: fix UTs related to image cache state 
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
 2020-10-15 07:00:07 -04:00
Kefu Chai
72ddbd3e2b
Merge pull request #37633 from tchaikov/wip-pybind-rados-cleanup 
pybind/rados: add more type hintings and cleanup

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
 2020-10-15 18:54:38 +08:00
Kefu Chai
1d15e8c2d1
Merge pull request #37624 from lxbsz/cram 
qa/tasks: add a 'parallel' option support for the cram task

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
 2020-10-15 18:53:38 +08:00
Kefu Chai
28133d7322
Merge pull request #37621 from dsavineau/cephadm_ntpsec 
cephadm: allow ntpsec service

Reviewed-by: Joshua Schmid <jschmid@suse.de>
 2020-10-15 18:16:19 +08:00
Kefu Chai
2724a73743
Merge pull request #37601 from tspmelo/wip-rm-wait-for-expected-get-result 
qa/mgr: Remove _wait_for_expected_get_result

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
 2020-10-15 18:12:54 +08:00
Jason Dillaman
715e83aa9b
Merge pull request #37609 from lixiaoy1/remove_writelog 
rbd/cache: remove unnecessary WriteLogCache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
 2020-10-14 20:31:17 -04:00
Jason Dillaman
74332259ce
Merge pull request #37625 from lixiaoy1/rwl_path 
rbd/cache: store full cache path to image metadata

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
 2020-10-14 20:29:41 -04:00
Adam C. Emerson
f035b7e3d3 rgw/fifo: Use unique_ptr and explicit release for callbacks 
To simplify and clarify memory allocation in AIO cases.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2020-10-14 16:18:38 -04:00
Adam C. Emerson
9a323cf8b1 rgw/fifo: Catch two instances journaling a new part 
If we see another part journaled, just run the journal ourselves.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2020-10-14 16:18:38 -04:00
Adam C. Emerson
6900d0e9dc rgw/fifo: Add some error logging 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2020-10-14 16:18:38 -04:00
Adam C. Emerson
d8f0ac2fa4 rgw/fifo: Fix a few missed return value assignments 
Slipped in when I converted from call-back based to sequential.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2020-10-14 16:18:38 -04:00
Adam C. Emerson
4008f1e57f cls/fifo: Switch use CLS_ERR for errors 
So things going wrong show up in the log by default. Also use
__PRETTY_FUNCTION__ instead of __func__ and print some more context.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2020-10-14 16:18:38 -04:00
Patrick Donnelly
cbcdb8eeeb
Merge PR #34702 into master 
* refs/pull/34702/head:
	doc: Make time-related osd default values in documentation big-endian.

Reviewed-by: Kefu Chai <kchai@redhat.com>
 2020-10-14 11:11:15 -07:00
zdover23
8624f6f93d
Merge pull request #37587 from anthonyeleven/yet-more-doc-polishing 
doc: clarity, detail, modernization, capitalization

Reviewed-by: Zac Dover <zac.dover@gmail.com>
 2020-10-15 02:48:25 +10:00
Kefu Chai
b43f26f9af
Merge pull request #37168 from ifed01/wip-ifed-fix-compress-csum 
os/bluestore: attach csum for compressed blobs

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>
 2020-10-14 22:19:03 +08:00
Kefu Chai
afd232a110
Merge pull request #37611 from tchaikov/wip-cmake-tox 
cmake: do not always add py3 to TOX_ENVS

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
 2020-10-14 22:02:36 +08:00
Jason Dillaman
6e2e8d57ae
Merge pull request #37594 from trociny/wip-rbd-quiesce-cancel 
librbd: fix race on watcher unregister

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
 2020-10-14 09:59:58 -04:00
Joshua Schmid
3bac7dd987
Merge pull request #37650 from jschmid1/gs 
mgr/cephadm: adapt <placement> usage string
 2020-10-14 14:45:27 +02:00
Kefu Chai
1b8393f85d mgr/dashboard: add an empty line to appease flake8 
silence the warnings like

./controllers/mgr_modules.py:38:5: E301 expected 1 blank line, found 0'
./controllers/user.py:69:5: E301 expected 1 blank line, found 0

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2020-10-14 16:24:57 +08:00
Kefu Chai
585f6467ca
Merge pull request #37394 from rosinL/cleanup-queue-option 
common/options: remove unavailable values of osd_op_queue

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
 2020-10-14 16:08:04 +08:00
Kefu Chai
c3e699483c
Merge pull request #37627 from changchengx/msg 
msg: remove stale comment and unnecessary code

Reviewed-by: Kefu Chai <kchai@redhat.com>
 2020-10-14 16:05:51 +08:00
Kefu Chai
b0b3e32d04
Merge pull request #37626 from tchaikov/wip-drop-std-iterator 
include/interval_set: do not inherit from std::iterator

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
 2020-10-14 16:04:14 +08:00
Kefu Chai
ade1a6e394
Merge pull request #37455 from smithfarm/wip-spec-file-cleanup 
rpm: three spec file cleanups

Reviewed-by: Tim Serong <tserong@suse.com>
 2020-10-14 15:43:30 +08:00
Kefu Chai
31db9ce5dc pybind/rados: correct the declarations of C APIs 
so they are consistent with the ones declared in include/rados/librados.h

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2020-10-14 15:41:03 +08:00
Kefu Chai
e7e375fdb8 pybind/rados: add more type hintings 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2020-10-14 15:41:03 +08:00
Kefu Chai
7c1544c04c cmake: do not always add py3 to TOX_ENVS 
before this change add_tox_test() always add "py3" to testenv, even the
caller specifies TOX_ENVS explicitly.

after this change, py3 is added only if the caller does not specify any
TOX_ENVS.

this change helps with the readability.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2020-10-14 15:30:37 +08:00
Patrick Donnelly
493f216c1e
Merge PR #37583 into master 
* refs/pull/37583/head:
	mgr/volumes/nfs: Fix wrong error message for pseudo path

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
 2020-10-13 10:27:02 -07:00
Patrick Donnelly
bd7a847734
Merge PR #37585 into master 
* refs/pull/37585/head:
	doc/cephfs/nfs: Remove outdated doc related to rook

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
 2020-10-13 10:26:02 -07:00
zdover23
9822fb49a7
Merge pull request #37610 from anthonyeleven/doc-rados-troubleshooting 
doc/rados/troubleshooting: clarity and modernization

Reviewed-by: Zac Dover <zac.dover@gmail.com>
 2020-10-14 02:32:24 +10:00
Patrick Donnelly
c2be93c981
Merge PR #36537 into master 
* refs/pull/36537/head:
	qa/cephfs: update ephemeral pin tests
	mds: distribute dirfrags for ephemeral distributed directory

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
 2020-10-13 09:29:04 -07:00
Yan, Zheng
e76abf517b qa/cephfs: update ephemeral pin tests 
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
 2020-10-13 20:52:40 +08:00