Michael Fritch
7ac0479726
cephadm: line break after binary operator (W504)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
06e02b73c7
cephadm: blank line contains whitespace (W293)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
1870056fa5
cephadm: trailing whitespace (W291)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
ec56db113f
cephadm: local variable 'e' is assigned to but never used (F841)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
bb03318414
cephadm: 'select' imported but unused (F401)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
c58701642d
cephadm: ambiguous variable name 'l' (E741)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
8eb4c38f10
cephadm: do not use bare 'except' (E722)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
6237df7527
cephadm: statement ends with a semicolon (E703)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
9bbb35958c
cephadm: module level import not at top of file (E402)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
6c8ea9fb65
cephadm: expected 1 blank line before a nested definition (E306)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
cf9e974284
cephadm: expected 2 blank lines after end of function or class (E305)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
f1af846c60
cephadm: too many blank lines (E303)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
dea7798034
cephadm: expected 2 blank lines, found 1 (E302)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
858b55c3ac
cephadm: expected 1 blank line, found 0 (E301)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
3dcb56e3e3
cephadm: too many leading '#' for block comment (E266)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
20c5f3d186
cephadm: block comment should start with '# ' (E265)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
6d937393f8
cephadm: at least two spaces before inline comment (E261)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
d47b26d792
cephadm: unexpected spaces around keyword / parameter equals (E251)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
d2bb74a896
cephadm: multiple spaces after ',' (E241)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
3e3ace6f31
cephadm: missing whitespace after ':' (E231)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
549258b4c6
cephadm: missing whitespace around arithmetic operator (E226)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
2af78e9358
cephadm: missing whitespace around operator (E225)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
f2f76a2517
cephadm: whitespace before ':' (E203)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
9e4fd38f32
cephadm: whitespace after '{' (E201)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
5ba2b30f78
cephadm: continuation line unaligned for hanging indent (E131)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
4611df9669
cephadm: continuation line under-indented for visual indent (E128)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
460e6e84aa
cephadm: continuation line over-indented for visual indent (E127)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
fa2b17c8ec
cephadm: continuation line over-indented for hanging indent (E126)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
0d57f5496e
cephadm: continuation line with same indent as next logical line (E125)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
91b54fcabc
cephadm: closing bracket does not match visual indentation (E124)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
0b3943a87c
cephadm: ... does not match indentation of opening bracket's line (E123)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
15e4b78abb
cephadm: continuation line missing indentation or outdented (E122)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
75cf5fc676
cephadm: continuation line under-indented for hanging indent (E121)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
8187eb97c7
cephadm: over-indented (E117)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
78916a499c
cephadm: introduce flake8
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Sebastian Wagner
86b25bc0be
Merge pull request #39789 from zdover23/wip-doc-cephadm-convert--bash-shells-2021-Mar-03
...
doc/cephadm: add prompts to adoption.rst
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-03 16:45:00 +01:00
Casey Bodley
fc03ae8f12
Merge pull request #39794 from cbodley/wip-qa-rgw-valgrind-supp-librados-delete
...
valgrind: suppress operator delete[] for tcmalloc
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-03 10:38:36 -05:00
Sebastian Wagner
089938a1af
Merge pull request #39558 from sebastian-philipp/doc-rados-rm-toctree-cephadm
...
doc/rados: avoid including cephadm into the toctree
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2021-03-03 16:17:51 +01:00
Daniel Gryniewicz
bfde964cf0
Merge pull request #39399 from dang/wip-dang-zipper-10
...
RGW - Zipper 10: The Great Zippening
2021-03-03 08:56:04 -05:00
Sage Weil
5290ed3777
Merge PR #38909 into master
...
* refs/pull/38909/head:
PendingReleaseNotes: document option osd_fast_shutdown_notify_mon
osd: add osd_fast_shutdown_notify_mon option (default false)
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-03-03 08:38:58 -05:00
Sage Weil
67e842d519
Merge PR #39654 into master
...
* refs/pull/39654/head:
common/options: drop ms_async_max_op_threads
msg/async: drop Stack::num_workers
msg/async: s/num_workers/workers.size()/
msg/async: use range-based loop in NetworkStack
msg/async: do not pass worker id to Stack::spawn_worker()
async/Stack: pass Worker* to NetworkStack::add_thread()
async/rdma: do not reference worker id in RDMAStack::spawn_worker()
async/dpdk: do not use worker id when creating worker
async/PosixStack: do not reference worker id in ctor
async/rdma: initialize worker in RDMAStack::create_worker()
async/rdma: move RDMAStack::create_worker() to .cc
Reviewed-by: luo runbing <luo.runbing@zte.com.cn>
Reviewed-by: Haomai Wang <haomai@xsky.com>
2021-03-03 08:38:21 -05:00
Sage Weil
bdff94a09d
Merge PR #39665 into master
...
* refs/pull/39665/head:
qa/rados/dashbord use "random" objectore
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-03-03 08:35:51 -05:00
Sage Weil
86b824ec60
Merge PR #39689 into master
...
* refs/pull/39689/head:
src/global/signal_handler.h: fix preprocessor logic for alpine
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-03-03 08:33:28 -05:00
Sage Weil
cb98159b12
Merge PR #39750 into master
...
* refs/pull/39750/head:
mgr: create client messenger using ms_public_type
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-03-03 08:32:41 -05:00
Sebastian Wagner
d4292afebf
Merge pull request #39770 from liewegas/bug-46745
...
cephadm: add docker.service dependency in systemd units
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-03 10:51:47 +01:00
Mykola Golub
7c214b24ce
Merge pull request #39795 from dillaman/wip-migration-import-docs
...
doc/rbd: clarify QCOW2 migration support
Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-03-03 10:45:35 +02:00
Kefu Chai
163f3b81b9
Merge pull request #39555 from tchaikov/wip-drop-pre-nautilus
...
*: drop backward compatibility with pre-nautilus versions
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-03-03 16:39:46 +08:00
Kefu Chai
de049079fb
Merge pull request #39798 from tchaikov/wip-crimson-monc-copy-sent
...
crimson/mon: keep a copy of sent MMonCommand messages
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-03-03 12:31:39 +08:00
Kefu Chai
a977061602
crimson/mon: keep a copy of sent MMonCommand messages
...
as per Yingxin Cheng,
> The send process can be asynchronous (there is a conn.out_q, or if the
> underlying socket lives in a different core in the m:n model to be
> ordered there). If user really wants to reuse a message, they must be
> careful not to modify it because it may result in modifing the pending
> messages.
>
> I think the best way is to copy the message if user want to resend it,
> and keep the ceph_assert(!msg->get_seq()). It may looks good to reuse a
> message under lossy policy, but the correctness is now up to user not to
> modify it inplace.
see also https://github.com/ceph/ceph/pull/39786
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-03-03 11:41:38 +08:00
Jason Dillaman
68fda590cf
doc/rbd: clarify QCOW2 migration support
...
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2021-03-02 17:29:41 -05:00