Jianpeng Ma
755c7c2c26
os/bluestore: don't round_up_to in apply_for_bitset_range.
...
I met the following error messages:
>sceph7: /home/Jianpeng/ceph/src/os/bluestore/bluestore_common.h: In function 'void apply_for_bitset_range(uint64_t, uint64_t, uint64_t, Bitset&, Func) [with Bitset = boost::dynamic_bitset<long unsigned int>; Func = BlueFS::_replay(bool, bool)::<lambda(uint64_t, boost::dynamic_bitset<long unsigned int>&)>; uint64_t = long unsigned int]' thread 7f7d55a3dd40 time 2019-11-27T23:26:05.949827+0800
>sceph7: /home/Jianpeng/ceph/src/os/bluestore/bluestore_common.h: 28: FAILED ceph_assert(end <= bitset.size())
>sceph7: ceph version 15.0.0-7747-g22a9a28e28 (22a9a28e28
) octopus (dev)
>sceph7: 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x14f) [0x56322c4440ef]
>sceph7: 2: (()+0x50d2d9) [0x56322c4442d9]
>sceph7: 3: (BlueFS::_replay(bool, bool)+0x5639) [0x56322cb51e49]
>sceph7: 4: (BlueFS::mount()+0x269) [0x56322cb53289]
>sceph7: 5: (BlueStore::_open_bluefs(bool)+0x29e) [0x56322ca6e38e]
>sceph7: 6: (BlueStore::_open_db(bool, bool, bool)+0x59b) [0x56322ca6e9cb]
>sceph7: 7: (BlueStore::mkfs()+0x749) [0x56322caaa259]
>sceph7: 8: (OSD::mkfs(CephContext*, ObjectStore*, uuid_d, int)+0x1c8) [0x56322c5099e8]
>sceph7: 9: (main()+0x1787) [0x56322c4ab117]
>sceph7: 10: (__libc_start_main()+0xeb) [0x7f7d55b5fb6b]
>sceph7: 11: (_start()+0x2a) [0x56322c4de71a]
>sceph7: *** Caught signal (Aborted) **
>sceph7: in thread 7f7d55a3dd40 thread_name:ceph-osd
If bdev[i]->get_size() / alloc_size[i] != 0, round_up_to(off+lengh,alloc_size[i])/alloc_size is larger than(one)
ownend_blocks[i].size().
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-11-28 16:23:01 +08:00
Patrick Donnelly
22a9a28e28
Merge PR #31756 into master
...
* refs/pull/31756/head:
pybind / cephfs: remove static typing in LibCephFS.chown
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-11-26 15:53:48 -08:00
Sage Weil
4e9f6c2205
Merge PR #31828 into master
...
* refs/pull/31828/head:
mgr/orchestrator: include container_image in 'service ls' output
ceph-daemon: include container_image_name and container_image_id in 'ls' output
common/options: default to ceph/ceph:latest-master-devel (for now)
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-26 16:18:44 -06:00
Sage Weil
b62e23aaa6
Merge PR #31854 into master
...
* refs/pull/31854/head:
mgr/orchestrator_cli: print table for 'host ls'
mgr/ssh: populate labels
mgr/orchestrator: add 'labels' property to InventoryNode
mgr/ssh: add/remove labels
mgr/orchestrator: orchestrator host label {add,rm}
mgr/ssh: add explicit host list
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-26 16:18:28 -06:00
Sage Weil
e062af5bd0
Merge PR #31864 into master
...
* refs/pull/31864/head:
osd/PeeringState: clear LAGGY and WAIT states on exiting Started
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2019-11-26 16:17:51 -06:00
Sage Weil
5aa2eca166
Merge PR #31865 into master
...
* refs/pull/31865/head:
cls/rbd: improve efficiency of mirror image status queries
Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-11-26 16:17:05 -06:00
Sage Weil
9b6c850fab
Merge PR #31866 into master
...
* refs/pull/31866/head:
osd/SnapMirror: no need to record purged_snaps every epoch
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-11-26 16:16:33 -06:00
Patrick Donnelly
f1e3fec83d
Merge PR #27467 into master
...
* refs/pull/27467/head:
cephfs-shell: add snapshot management
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-11-26 09:47:40 -08:00
Nathan Cutler
ba3f31612e
Merge pull request #31871 from smithfarm/wip-43021
...
doc: mention --namespace option in rados manpage
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
2019-11-26 18:42:58 +01:00
Nathan Cutler
4353b5548e
doc: mention --namespace option in rados manpage
...
Fixes: https://tracker.ceph.com/issues/43021
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-11-26 15:39:42 +01:00
Sage Weil
f06366836f
mgr/orchestrator_cli: print table for 'host ls'
...
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-26 08:01:26 -06:00
Sage Weil
1d2b1bfa30
mgr/ssh: populate labels
...
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-26 08:01:26 -06:00
Sage Weil
b5484710c9
mgr/orchestrator: add 'labels' property to InventoryNode
...
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-26 08:01:26 -06:00
Sage Weil
42a95e03d0
mgr/ssh: add/remove labels
...
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-26 07:31:06 -06:00
Sage Weil
292a9927a4
mgr/orchestrator: orchestrator host label {add,rm}
...
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-26 07:31:06 -06:00
Sage Weil
454906fceb
mgr/ssh: add explicit host list
...
Keep the host list in an explicit 'inventory' key, and provide a dict for
each host so that we can keep other metadata (like labels).
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-26 07:31:06 -06:00
Sage Weil
47d2e54164
Merge PR #31837 into master
...
* refs/pull/31837/head:
ceph-daemon: add additional debug logging
Reviewed-by: Sage Weil <sage@redhat.com>
2019-11-26 07:11:05 -06:00
Kefu Chai
cb0bb2042a
Merge pull request #31874 from tchaikov/wip-crimson-cyanstore-restructure
...
crimson: move os/cyan_* down to os/cyanstore/*
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-11-26 20:13:40 +08:00
Kefu Chai
58604f7c8e
crimson: move os/cyan_* down to os/cyanstore/*
...
prepare for bluestore and seastore
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-11-26 16:56:47 +08:00
Kefu Chai
a6481f6b6f
Merge pull request #31859 from rzarzynski/wip-crimson-drop_dup_failed
...
crimson/osd/osd_operation.h: clean up duplicative check.
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-26 16:06:46 +08:00
Jan Fajerski
d591cbea57
Merge pull request #31252 from wjwithagen/wjw-doc-ceph_volume_zfs_inventory
...
doc/ceph-volume: initial docs for zfs/inventory and zfs/api
2019-11-26 08:58:31 +01:00
Jan Fajerski
076abcc21b
Merge pull request #31821 from mgfritch/c-v-scan-help
...
ceph-volume: minor clean-up of `simple scan` subcommand help
2019-11-26 07:46:48 +01:00
Michael Fritch
ea1d7042a5
ceph-daemon: add additional debug logging
...
Adds additional detail before invoking subprocess for the
`run`, `shell, `enter`, and `logs` commands
Signed-off-by: Michael Fritch <mfritch@suse.com>
2019-11-25 21:23:03 -07:00
Sage Weil
398323904f
Merge PR #31567 into master
...
* refs/pull/31567/head:
common: move gen_rand_alphanumeric() helpers into common
test: add unit tests for gen_rand_alphanumeric helpers
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2019-11-25 21:54:16 -06:00
Sage Weil
cf676c73ab
Merge PR #31781 into master
...
* refs/pull/31781/head:
cmake/modules: look for GNU make first instead of BSD make
cmake: support parallel build for rocksdb
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-25 21:49:31 -06:00
Sage Weil
0e0a3853c9
Merge PR #31579 into master
...
* refs/pull/31579/head:
cmake: add cppcheck and iwyu static analysis targets
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2019-11-25 21:49:18 -06:00
Patrick Donnelly
57d62d438d
Merge PR #31775 into master
...
* refs/pull/31775/head:
mds: remove the incorrect comments
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2019-11-25 16:45:57 -08:00
Patrick Donnelly
1072ff507d
Merge PR #31762 into master
...
* refs/pull/31762/head:
mgr/ssh: improve logging for mds removal
mgr/volumes: move up 'confirm' validation
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2019-11-25 16:43:28 -08:00
Sage Weil
f2763fca96
osd/SnapMirror: no need to record purged_snaps every epoch
...
These keys were a mirror of the mon's purged_epoch keys. We were writing
them, but never looking at them. We only need the per-pool keys that
are indexed by snapid for lookups, so we should stop storing the per-epoch
records.
Note that the OSDSuperblock has the purged_snaps_last that serves as our
position/cursor for ingesting the mon keys.
Fixes: https://tracker.ceph.com/issues/42012
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-25 13:31:30 -06:00
Jason Dillaman
3ce8543c78
cls/rbd: improve efficiency of mirror image status queries
...
The removal of remote mirror image status records no longer
(accidentally) searches through nearly the full omap database and
getting the status of a single image no longer involves duplicate
lookups (to pull the fsid keys and then to read the data).
Fixes: https://tracker.ceph.com/issues/42576
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-11-25 14:28:57 -05:00
Casey Bodley
05d07282b8
Merge pull request #28625 from zhangsw/rgw-fix-get-object
...
rgw: ignore If-Unmodified-Since if If-Match exists, and ignore If-Modified-Since if If-None-Match exists.
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-11-25 14:22:54 -05:00
Sage Weil
7bbc724d99
osd/PeeringState: clear LAGGY and WAIT states on exiting Started
...
These flags were not getting cleared except in recheck_readable(), which
meant that a flag from a prior interval could bleed into a new interval.
More dangerously, in a mixed-version cluster, one interval might include
all octopus+ OSDs while the next might include a pre-octopus OSD, bypassing
most of the laggy recheck code. This could lead to a stalled request
and/or requeue ordering bug when release_object_locks() looked at
is_laggy() and put a lock waiter on the waiting_for_readable list.
Fixes: https://tracker.ceph.com/issues/42978
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-25 13:15:24 -06:00
Michael Fritch
0d7b61d204
ceph-volume: minor clean-up of simple scan
subcommand help
...
Fixes: https://tracker.ceph.com/issues/43017
Signed-off-by: Michael Fritch <mfritch@suse.com>
2019-11-25 11:39:42 -07:00
Patrick Donnelly
67c96be4f6
Merge PR #31780 into master
...
* refs/pull/31780/head:
mgr/volumes: remove unsed variable
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-11-25 08:49:43 -08:00
Sage Weil
4d2a06e9ea
Merge PR #31824 into master
...
* refs/pull/31824/head:
cls/rbd: sanitize the mirror image status peer address after reading from disk
Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-11-25 10:28:20 -06:00
Lenz Grimmer
177bbddb64
mgr/dashboard: Update translations ( #31435 )
...
mgr/dashboard: Update translations
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-11-25 16:02:13 +00:00
Sage Weil
6bcf505485
mgr/orchestrator: include container_image in 'service ls' output
...
Rearrange the columns a bit too.
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-25 10:01:01 -06:00
Sage Weil
6b319b9dc7
ceph-daemon: include container_image_name and container_image_id in 'ls' output
...
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-25 10:00:53 -06:00
Sage Weil
966cc9a80f
common/options: default to ceph/ceph:latest-master-devel (for now)
...
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-25 10:00:53 -06:00
Radoslaw Zarzynski
8c1e4e3493
crimson/osd/osd_operation.h: clean up duplicative check.
...
`seastar::future<T>::available()` already verifies whether
a future instance stores exception inside. It's unnecessary
to ensure that with further call to `failed()`.
This tiny clean-up removes the duplicative check in
`with_blocking_future()`.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-11-25 16:41:04 +01:00
Sage Weil
61ba2d7b66
Merge PR #31677 into master
...
* refs/pull/31677/head:
qa/standalone/ceph-helpers.sh: remove osd down check
qa/standalone/ceph-helpers.sh: destroy_osd: mark osd down
osd: add osd_fast_shutdown option (default true)
Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-11-25 08:54:45 -06:00
Sage Weil
fd5a82e3cd
Merge PR #31823 into master
...
* refs/pull/31823/head:
ceph-daemon: fix logrotate su line
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-25 08:12:41 -06:00
Sage Weil
a8451ba0c3
Merge PR #31835 into master
...
* refs/pull/31835/head:
mgr/ssh: add TemporaryDirectory impl for py2 compat
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-25 08:07:53 -06:00
Casey Bodley
a704488510
Merge pull request #31325 from cbodley/wip-rgw-sync-concurrent-versions
...
rgw multisite: fixes for concurrent version creation
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2019-11-25 09:03:18 -05:00
Deepika Upadhyay
abf3dc0cf9
cmake/modules: look for GNU make first instead of BSD make
...
* BuildDPDK.cmake, BuildSPDK.cmake:
* give priority to build with gmake
* throw error if make not found
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2019-11-25 13:16:04 +05:30
Deepika Upadhyay
a930706aa6
cmake: support parallel build for rocksdb
...
* cmake/modules/BuildRocksDB.cmake: if "make" detected
use concurrent processing, by passing the jobserver to
sub-make using `$(MAKE)`
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2019-11-25 13:14:22 +05:30
Patrick Donnelly
d7821ce8ec
Merge PR #30972 into master
...
* refs/pull/30972/head:
mds: move 'traverse to auth' logic into MDCache::path_traverse
mds: cleanup Capability initialization
mds: cleanup code that kills session requests
mds: cleanup Server::try_open_auth_dirfrag()
mds: restrict path that walks into snapdir
mds: use single map to track pinned & auth_pinned objects
mds: define operator<(...) for MutationImpl::LockOp
mds: cleanup Locker::acquire_locks()
mds: introduce Locker::wrlock_try()
mds: explictly specify if MDCache::path_traverse() needs to check null dentry
mds: cleanup dentry non-readable check in MDCache::path_traverse()
mds: change MDCache::path_traverse()'s 'onfail' argument to flags
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2019-11-24 18:53:20 -08:00
Sage Weil
2c06beb5ec
Merge PR #31786 into master
...
* refs/pull/31786/head:
mgr: fix errors on using a reference in a Lambda function
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-24 12:45:26 -06:00
Sage Weil
3a62d166a7
qa/standalone/ceph-helpers.sh: remove osd down check
...
A kill doesn't induce a mark-down of the OSD with osd_fast_shutdown=true.
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-24 12:19:33 -06:00
Sage Weil
73511c489a
mgr/ssh: add TemporaryDirectory impl for py2 compat
...
This didn't get copied over in 4bfcb5db6b
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-24 12:15:49 -06:00