Sage Weil
71b8e4b21d
Merge pull request #19864 from rzarzynski/wip-bs-no-blobrefing-in-do_read
...
os/bluestore: avoid unneeded BlobRefing in _do_read().
Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
2018-01-10 07:00:06 -06:00
Sage Weil
588516fa20
Merge pull request #19866 from liewegas/wip-bluestore-error-injection
...
os/bluestore: fix data read error injection in bluestore
Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
2018-01-10 06:59:40 -06:00
Sage Weil
0d263b2591
Merge pull request #19869 from liewegas/wip-log-desc
...
common/options: long description for log_stderr_prefix
Reviewed-by: Joao Eduardo Luis <joao@suse.de>
2018-01-10 06:59:16 -06:00
Patrick Donnelly
1f32d63e6d
Merge PR #18424 into master
...
* refs/pull/18424/head:
mds: create snaprealm for quota enabled inode
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-09 16:56:32 -08:00
Patrick Donnelly
6a97e25497
Merge PR #19572 into master
...
* refs/pull/19572/head:
client: add log when we got unexpected flush ack
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-09 16:56:27 -08:00
Patrick Donnelly
e73e5edbdc
Merge PR #19672 into master
...
* refs/pull/19672/head:
ceph-fuse: ::rmdir() uses a deleted memory structure of dentry leads a core
Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-09 16:56:22 -08:00
Patrick Donnelly
2cdf087d29
Merge PR #19693 into master
...
* refs/pull/19693/head:
mds: use session.get_client()
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-09 16:56:17 -08:00
Patrick Donnelly
8b24b57b62
Merge PR #19696 into master
...
* refs/pull/19696/head:
client: avoid adding checked inode to the delayed_caps
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-09 16:56:13 -08:00
Patrick Donnelly
8ab4c18ec1
Merge PR #19702 into master
...
* refs/pull/19702/head:
client: avoid remove same cap twice
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-09 16:56:08 -08:00
Patrick Donnelly
a2feda1845
Merge PR #19703 into master
...
* refs/pull/19703/head:
client: make mark_caps_clean and mark_caps_dirty as member function to Inode
client: fix dirty caps might never be flushed
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-09 16:56:03 -08:00
Patrick Donnelly
117c9ec913
Merge PR #19723 into master
...
* refs/pull/19723/head:
mds: clean up log's function name for CDir.cc and Beacon.cc
mds: clean up log's function name for CDentry.cc
mds: clean up log's function name for CInode.cc
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-09 16:55:59 -08:00
Patrick Donnelly
6143563b0d
Merge PR #19730 into master
...
* refs/pull/19730/head:
mds: Using stl min | max, MIN | MAX macros instead
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-09 16:55:54 -08:00
Patrick Donnelly
5f595143f6
Merge PR #19762 into master
...
* refs/pull/19762/head:
mds: fix dump last_sent
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-09 16:55:50 -08:00
Patrick Donnelly
1bb91f41f5
Merge PR #19767 into master
...
* refs/pull/19767/head:
client: enhance log for _closed_mds_session
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-09 16:55:45 -08:00
Yuri Weinstein
a5159a4566
Merge pull request #18788 from amitkumar50/cov-mon-1
...
mon: NULL check of logger before use
Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-09 09:30:43 -08:00
Yuri Weinstein
c231b9c836
Merge pull request #19054 from cbodley/wip-librados-asio
...
librados: add async interfaces for use with Networking TS
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
2018-01-09 09:30:22 -08:00
Orit Wasserman
28b2079eeb
Merge pull request #19852 from yaozongyou/rgw-remove-unused-function
...
rgw: remove unused function get_system_obj_attrs
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2018-01-09 19:16:23 +02:00
Yuri Weinstein
ad3502f4a6
Merge pull request #16383 from mikulely/1-ban-change-swift-obj-placement
...
rgw: drop the unnecessary handling of Swift's X-Storage-Policy on objects
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-01-09 09:11:56 -08:00
Yuri Weinstein
ee5c1c3071
Merge pull request #17683 from shashalu/fix-lc-xml
...
rgw: RGWPutLC return ERR_MALFORMED_XML when missing <Rule> tag in lifecycle.xml
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Amit Kumar <amitkuma@redhat.com>
2018-01-09 09:10:29 -08:00
Yuri Weinstein
43378e3a86
Merge pull request #17873 from amitkumar50/cov-rgw-8
...
rgw: Returning when dst_ioctx.operate() returns error
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-09 09:05:32 -08:00
Yuri Weinstein
4e3a9c9c65
Merge pull request #18861 from gaosibei/wip-fix-null-pointer
...
rgw: fix null pointer crush
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2018-01-09 09:04:57 -08:00
Yuri Weinstein
1f1c4451f4
Merge pull request #19061 from Leeshine/wip-rgw-bug-21583
...
rgw: fix the bug of radowgw-admin zonegroup set requires realm
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2018-01-09 09:04:22 -08:00
Casey Bodley
cb0f1aa086
Merge pull request #19854 from fangyuxiangGL/doc-sync-err
...
rgw: add radosgw-admin sync error trim to trim sync error log
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-09 11:15:15 -05:00
Kefu Chai
877cd68717
Merge pull request #19809 from liu-chunmei/fix_dpdk_mzname_setting_issue
...
osd: fix dpdk memzon mz_name setting issue
Reviewed-By: Kefu Chai <kchai@redhat.com>
2018-01-09 23:16:43 +08:00
Casey Bodley
f473d57013
librados: add async interfaces for use with Networking TS
...
Defines asynchronous librados operations that satisfy all of the
"Requirements on asynchronous operations" imposed by the C++ Networking
TS [1] in section 13.2.7. These operations are implemented in terms of
boost::asio, but the interfaces themselves are free of boost types -
this makes the transition to std::net trivial when it's available.
These interfaces conform to the Extensible Asynchronous Model [2] that
originated in boost::asio. This model allows the last 'handler' argument
to either be a callback that gets the result, a coroutine yield_context
that will suspend until completion, or a 'use_future' tag to request the
result in a std::future (see the unit tests for examples of each). The
'Extensible' part also enables further integration with new frameworks.
For now, only async_read(), async_write(), and the read/write variants
of async_operate() are provided.
[1] Working Draft, C++ Extensions for Networking
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/n4711.pdf
[2] "Library Foundations for Asynchronous Operations"
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n3896.pdf
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2018-01-09 09:58:18 -05:00
Sage Weil
0cdb6a74e7
Merge pull request #19616 from ifed01/wip-ifed-revert-extents
...
osd: get rid off extent map in object_info
Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-09 08:44:52 -06:00
Sage Weil
e1cd4b5a6e
Merge pull request #19764 from ifed01/wip-ifed-storetest-cempty
...
objectstore/store_test: fix lack of flush prior to collection_empty()…
Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-09 08:44:28 -06:00
Sage Weil
ddd5a6a7b1
Merge pull request #19841 from rzarzynski/wip-bs-dump-onode-by-ref
...
os/bluestore: _dump_onode() don't prolongate Onode anymore.
Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-09 08:44:14 -06:00
Sage Weil
3b2f7a0a90
common/options: long description for log_stderr_prefix
...
Signed-off-by: Sage Weil <sage@redhat.com>
2018-01-09 08:24:54 -06:00
Sage Weil
be32d15a04
os/bluestore: fix data read error injection in bluestore
...
Signed-off-by: Sage Weil <sage@redhat.com>
2018-01-09 07:20:50 -06:00
Radoslaw Zarzynski
3e2bbdfab1
os/bluestore: avoid unneeded BlobRefing in _do_read().
...
The hottest place in the terms of CPU cycles according to `perf annotate`:
```
| intrusive_ptr(intrusive_ptr const & rhs): px( rhs.px )
0,04 | 365: mov 0x28(%rax),%r12
| {
| if( px != 0 ) intrusive_ptr_add_ref( px );
0,41 | test %r12,%r12
| ↓ je 37c
| _ZNSt13__atomic_baseIiEppEv():
0,04 | lock addl $0x1,(%r12)
19,75 | mov 0xa8(%rsp),%rax
| _ZN9BlueStore8_do_readEPNS_10CollectionEN5boost13intrusive_ptrINS_5OnodeEEEmmRN4ceph6buffer4listEj():
| }
| BlobRef bptr = lp->blob;
| unsigned l_off = pos - lp->logical_offset
| 37c: mov 0xa0(%rsp),%rdx
| sub 0x18(%rax),%edx
| unsigned b_off = l_off + lp->blob_offset;
0,08 | mov 0x1c(%rax),%ecx
```
With the patch applied:
```
| T * operator->() const
| {
| BOOST_ASSERT( px != 0 );
| return px;
| mov 0x28(%rcx),%rax
| mov 0x8(%rax),%rax
| _ZN9BlueStore8_do_readEPNS_10CollectionEN5boost13intrusive_ptrINS
| unsigned b_len = std::min(left, lp->length - l_off);
|
| ready_regions_t cache_res;
| interval_set<uint32_t> cache_interval;
| bptr->shared_blob->bc.read(
17,78 | lea 0x18(%rax),%rdi
| _ZNK5boost13intrusive_ptrIN9BlueStore10CollectionEEcvbEv():
| #if !defined( BOOST_NO_CXX11_EXPLICIT_CONVERSION_OPERATORS ) && !
| && !(defined(__SUNPRO_CC) && BOOST_WORKAROUND(__SUNPRO_CC, <=
|
| explicit operator bool () const BOOST_NOEXCEPT
| {
| return px != 0;
0,07 | mov 0x8(%rax),%rax
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2018-01-09 13:03:35 +01:00
fang yuxiang
233a4d237d
rgw: add radosgw-admin sync error trim to trim sync error log
...
Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
2018-01-09 14:24:42 +08:00
Patrick Donnelly
7829d22689
Merge PR #19791 into master
...
* refs/pull/19791/head:
doc: misc fixes
doc: fix heading
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-08 20:45:32 -08:00
Jos Collin
ecacd1078d
doc: misc fixes
...
misc fixes for best-practices.
Signed-off-by: Jos Collin <jcollin@redhat.com>
2018-01-09 10:09:09 +05:30
Kefu Chai
9d788c6a5b
Merge pull request #19662 from tchaikov/wip-denc-cxx-17
...
denc: use constexpr-if to replace some SFINAE impls
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-09 11:34:15 +08:00
Yao Zongyou
a60e7f3b99
rgw: remove unused function get_system_obj_attrs
...
Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>
2018-01-09 11:31:54 +08:00
Kefu Chai
09f68052cb
denc: use constexpr-if to replace some SFINAE impls
...
more readable this way IMO.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-01-09 09:54:50 +08:00
Patrick Donnelly
cdea54757b
Merge PR #19807 into master
...
* refs/pull/19807/head:
mds: warn for mds_cache_memory_limit bug in doc
Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-01-08 14:27:36 -08:00
Patrick Donnelly
733d21f592
mds: warn for mds_cache_memory_limit bug in doc
...
Fixes: http://tracker.ceph.com/issues/22599
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2018-01-08 14:14:53 -08:00
Adam C. Emerson
5ddc90ebe1
Merge pull request #19657 from adamemerson/wip-hypermodern
...
The Day Has Come!
Update language standard version to C++17 and remove backported standard library features.
Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Kefu Chai <kchai@redhat.com>
2018-01-08 16:31:57 -05:00
Jason Dillaman
e747d24c2e
Merge pull request #19823 from trociny/wip-ggate-list-xml
...
rbd-ggate: make list command produce valid xml format output
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2018-01-08 16:18:41 -05:00
Casey Bodley
ad62acef9d
Merge pull request #19846 from fangyuxiangGL/compress-info
...
rgw: make radosgw object stat RGW_ATTR_COMPRESSION dump readable
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-01-08 15:54:41 -05:00
Yuri Weinstein
b63708c762
Merge pull request #19732 from shinobu-x/using_find_primarylogpg
...
osd: Making use of find to reduce computational complexity
Reviewed-by: Sage Weil <sage@redhat.com>
2018-01-08 12:51:11 -08:00
Yuri Weinstein
c30eca51a4
Merge pull request #19765 from liewegas/wip-force-backfill-cleanups
...
qa: tolerate failure to force backfill
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-01-08 12:50:18 -08:00
Yuri Weinstein
5784779305
Merge pull request #19786 from dillaman/wip-osd-class-cap
...
osd: support class method whitelisting within caps
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2018-01-08 12:49:51 -08:00
Adam C. Emerson
79b19aacf0
{common,osd,mds,rbd}: Remove unused captures
...
If we aren't referencing a variable, don't capture it. (This makes the
lambdas smaller, too, modulo Sufficiently Smart Compiler.)
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
6580d0a6d9
dout: Remove VLA sanity check
...
This doesn't seem to be able to work for C++17 under both GCC and
Clang. Maybe there's a better way to do it. I might try routing
that argument through a constexpr function in the macro later.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
22d52655c3
common: Remove backport_std.h entirely
...
And use the experimental ostream joiner provided with the library.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
3a9ec5fc9e
common: Remove backported C++17 functions
...
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00
Adam C. Emerson
ad038df0fd
common: Remove backported typedefs
...
Since they're no longer needed.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2018-01-08 15:30:05 -05:00