Commit Graph

133720 Commits

Author SHA1 Message Date
Xiubo Li
6bbb29cb3a qa: the default CEPH_ASOK_DIR is asok/ now
Or the find_admin_socket() couldn't find the correct asok path.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-09-13 13:49:22 +08:00
Ilya Dryomov
7c73866e7d
Merge pull request #47987 from idryomov/wip-52810
librbd: retry ENOENT in V2_REFRESH_PARENT as well

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2022-09-06 20:17:15 +02:00
Casey Bodley
d465f17d38
Merge pull request #47783 from soumyakoduri/wip-skoduri-sync-flow
radosgw-admin: fix crash with 'sync flow' cmd without 'flow-type'

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2022-09-06 12:29:53 -04:00
Yuri Weinstein
747d1d39bb
Merge pull request #45883 from ifed01/wip-ifed-fix-bluefs-truncate
os/bluestore: fix no metadata update on truncate+fsync 

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2022-09-06 09:12:29 -07:00
Sridhar Seshasayee
b6e36cb4a9
Merge pull request #47630 from sseshasa/wip-add-mclk-cpu-util-rel-note
PendingReleaseNotes: Note the fix for high CPU utilization during recovery

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-09-06 20:45:02 +05:30
Daniel Gryniewicz
1d08d8c124
Merge pull request #47908 from dang/wip-dang-zipper-cleanup
RGW - Sal - remove unused default constructors

Reviewed-by: Casey Bodley <cbodley@redat.com>
2022-09-06 09:48:49 -04:00
Casey Bodley
0676cabb31
Merge pull request #47907 from cbodley/wip-57195
rgw: fix d3n crash in StoreManager::get_config()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
2022-09-06 07:52:34 -04:00
Kefu Chai
bd8b7aa4da
Merge pull request #46823 from lightmelodies/librados-c-api-stat2
librados: export stat2 in C API

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-09-06 08:40:46 +08:00
Kefu Chai
1217c9eb98
Merge pull request #47962 from tchaikov/wip-3rd-time-is-a-charm
test/{librbd, rgw}: retry when bind fail with port 0

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-06 08:37:45 +08:00
Ilya Dryomov
36f1d515ca librbd: make RefreshRequest tests compatible with clone v1
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00
Ilya Dryomov
bd885d75b2 librbd: retry ENOENT in V2_REFRESH_PARENT as well
With auto-deletion of trashed snapshots, it is relatively easy to lose
a race to "rbd flatten" as follows:

- when V2_GET_PARENT runs, the image is technically still a clone
- when V2_REFRESH_PARENT runs, the image is fully flattened and the
  snapshot in the parent image is deleted

This results in a spurious ENOENT error, mainly when trying to open the
image (e.g. for "rbd info").  This race condition has always been there
but auto-deletion of trashed snapshots makes it much worse.

Retry ENOENT in V2_REFRESH_PARENT the same way as in V2_GET_SNAPSHOTS.

Fixes: https://tracker.ceph.com/issues/52810
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00
Ilya Dryomov
8570194b13 librbd: limit the number of ENOENT retries in RefreshRequest
If the image header is corrupt, ENOENT error may be persistent.  Avoid
an infinite loop in that case.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00
Ilya Dryomov
6bd89ea119 librbd: fix a bunch of issues with restarting RefreshRequest
Make RefreshRequest properly restartable, at least up until and including
V2_REFRESH_PARENT step:

- clear m_migration_spec when skipping GET_MIGRATION_HEADER
- don't rely on potentially stale m_incomplete_update on retry
- reset m_legacy_parent when retrying more than just V2_GET_PARENT
- don't rely on potentially stale m_parent_md.overlap and
  m_head_parent_overlap on retry
- clear m_metadata before fetching image metadata (but not before
  fetching pool metadata)
- clear m_op_features when skipping V2_GET_OP_FEATURES
- clear m_group_spec on EOPNOTSUPP error in V2_GET_GROUP
- reset m_legacy_snapshot when retrying more than just V2_GET_SNAPSHOTS
- don't rely on potentially stale m_snap_parents on retry

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:39 +02:00
Ilya Dryomov
ce6dff89c0 librbd: check *result consistently in RefreshRequest
Stick to *result >= 0 checks everywhere and add missing checks for
op_features_get_finish() and image_group_get_finish() errors.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:02:32 +02:00
Ilya Dryomov
ca36ffa347 librbd: reflect V2_GET_SNAPSHOTS ENOENT retry in state diagram
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-09-05 23:00:35 +02:00
Casey Bodley
9c828b72ad
Merge pull request #47964 from yuvalif/wip-yuval-fix-57418
rgw/lua: handle null lua manager in librgw

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-05 14:17:07 -04:00
Yuri Weinstein
99f42bfba7
Merge pull request #47456 from sseshasa/wip-fix-mon-cmd-nack
osd: Implement Context based completion for mon cmd to set a config option

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-09-05 11:16:00 -07:00
Yuri Weinstein
41dd298743
Merge pull request #37767 from shun-s/add-mons-ms-tos-support
msg: add min delay packets support for mons

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2022-09-05 11:14:33 -07:00
Kefu Chai
aa7885f7cc test/{librbd, rgw}: retry when bind fail with port 0
there is chance that the bind() call may fail if we have another test
happen to pick the free port picked by operating system. in this case,
we just retry up to 42 times.

in theory, this change does not fully address the racing, but it should
help to alleviate this issue.

See-also: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-09-05 21:04:34 +08:00
Pere Diaz Bou
b4957d6203
Merge pull request #47250 from nSedrickm/progress-bar-accessibility-update
mgr/dashboard: Improve level A accessibility for usagebar

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-05 13:02:00 +02:00
Yuval Lifshitz
41e1f9a482
Merge pull request #47507 from zenomri/wip-omri-fix-tracer-provider
common/tracer: fix for tracer provider destruction

reviewed-by: yuvalif
2022-09-05 12:19:56 +03:00
Yuval Lifshitz
eac3e96c50
Merge pull request #47905 from cbodley/wip-57326
rgw: avoid string_view to temporary in RGWBulkUploadOp

reviewed-by: dang, yuvalif
2022-09-05 10:33:27 +03:00
Yingxin
226b6b8f36
Merge pull request #47518 from aravind-wdc/zns-wip
crimson/os/seastore: improve ZNS support for SeaStore

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-09-05 11:34:31 +08:00
Yuval Lifshitz
5177d7d1cb rgw/lua: handle null lua manager in librgw
Fixes: https://tracker.ceph.com/issues/57418

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-09-04 16:11:36 +03:00
Nizamudeen A
a873546c0d
Merge pull request #47571 from rhcs-dashboard/nfs-form-squash-norequired
mgr/dashboard: fix nfs exports form issues with squash field 

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-09-04 13:00:17 +05:30
Nizamudeen A
d3a03afa28
Merge pull request #47634 from rhcs-dashboard/kcli-fedora-36
mgr/dashboard: fix "can't read .ssh/known_hosts: No such file or directory

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2022-09-04 09:56:19 +05:30
zdover23
555f0590dd
Merge pull request #47871 from zdover23/wip-doc-2022-08-30-start-documenting-ceph-branch-name-update
doc/start: update documenting-ceph branch names

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-09-04 12:10:37 +10:00
J. Eric Ivancich
929e96fbe9
Merge pull request #47906 from ivancich/wip-bad-move-s3-getobj
rgw: fix bug where variable referenced after data moved out

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2022-09-03 18:26:42 -04:00
Adam King
1aac56e007
Merge pull request #47941 from adk3798/tp-no-overwrite-doc2
doc/cephadm: add info about --no-overwrite to note about tuned-profiles

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-09-03 15:47:21 -04:00
Adam King
d879c5098f doc/cephadm: add info about --no-overwrite to note about tuned-profiles
Follow up to fix to this flag in
028cb031dd

Signed-off-by: Adam King <adking@redhat.com>
2022-09-03 12:19:54 -04:00
Adam King
648618f2c0
Merge pull request #47733 from adk3798/prometheus-retention
mgr/cephadm: allow setting prometheus retention time

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2022-09-03 11:59:32 -04:00
Adam King
a725a7c573
Merge pull request #47815 from rkachach/fix_issue_57032
cephadm/mgr: adding logic to handle --no-overwrite for tuned profiles

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-09-03 11:58:01 -04:00
Adam King
eaac7b7c80
Merge pull request #47859 from pcuzner/fix-gather-facts-disk-size
cephadm: Fix disk size calculation

Reviewed-by: Adam King <adking@redhat.com>
2022-09-03 11:55:05 -04:00
Adam King
41ac5cab4c
Merge pull request #47882 from rkachach/fix_issue_57060
mgr/cephadm: Fix how we check if a host belongs to public network

Reviewed-by: Adam King <adking@redhat.com>
2022-09-03 11:53:23 -04:00
J. Eric Ivancich
550196c104
Merge pull request #47904 from cbodley/wip-57329
rgw: avoid use-after-move in RGWDataSyncSingleEntryCR ctor

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2022-09-03 11:21:11 -04:00
Adam King
34d0977861
Merge pull request #47921 from rkachach/fix_issue_56953
doc/cephadm/services: fix example for specifying rgw placement

Reviewed-by: Adam King <adking@redhat.com>
2022-09-02 14:36:22 -04:00
Ronen Friedman
a4f3561146
Merge pull request #47388 from ronen-fr/wip-rf-snapper
osd/scrub: verify SnapMapper consistency

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2022-09-02 21:31:59 +03:00
J. Eric Ivancich
f070376b0b
Merge pull request #44589 from xijiacun/lc-transition
rgw: Get canonical storage class when storage class is empty in lifecycle configuration

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-02 12:38:56 -04:00
J. Eric Ivancich
ddf1ccab16
Merge pull request #44610 from xijiacun/append-object
rgw: Use STANDARD storage class in objects appending operation when the

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-02 12:37:10 -04:00
J. Eric Ivancich
f8a76e4ea6
Merge pull request #46930 from zealot-xzd/wip-rgw-list-optimization2
rgw: bucket list operation slow down in special scenario

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2022-09-02 12:36:27 -04:00
Casey Bodley
03d8457694
Merge pull request #47831 from a16bitsysop/libaio-musl
rgw: rgw_d3n_datacache.cc add check for musl

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2022-09-02 12:29:48 -04:00
Casey Bodley
ef458ab281
Merge pull request #47819 from yehudasa/wip-cloud-sync-fixes
rgw: cloud sync fixes

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2022-09-02 12:26:47 -04:00
Casey Bodley
9f870f8527
Merge pull request #47527 from shraddhaghatol/shr/etag_cosmetic_change
rgw: Added Cosmetic change in etag of copyObjectResult

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-09-02 11:20:10 -04:00
Casey Bodley
303689fac1
Merge pull request #47667 from AISHU-Technology/fix-rgw-data-corruption
rgw: fix data corruption due to network jitter

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Or Friedmann <ofriedma@redhat.com>
2022-09-02 11:18:37 -04:00
David Galloway
af4906e084
Merge pull request #47818 from petrutlucian94/fix_is_err
include: fix IS_ERR on Windows
2022-09-02 09:41:40 -04:00
Ernesto Puerta
c228491636
Merge pull request #47916 from rhcs-dashboard/applitools-master-main
mgr/dashboard: s/master/main in applitools config

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-02 15:05:14 +02:00
Adam King
e9a8fc8ecc
Merge pull request #47796 from adk3798/test_cephadm_fix
qa/cephadm: remove fsid dir before bootstrap in test_cephadm.sh

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2022-09-02 08:57:15 -04:00
Rishabh Dave
831344e3ac
Merge pull request #47620 from lxbsz/wip-56249
client: stop the remount_finisher thread in the Client::unmount()

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2022-09-02 17:54:22 +05:30
Rishabh Dave
bc264a9812
Merge pull request #47593 from lxbsz/wip-57126
client: abort the client if we couldn't invalidate dentry caches

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2022-09-02 17:53:07 +05:30
Rishabh Dave
d5ab255225
Merge pull request #46988 from rishabh-d-dave/qa-suites-upgraded-client
qa/cephfs: clean up evicted client in 4-compat_client.yaml

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2022-09-02 17:51:25 +05:30