the 'sudo netstat | grep radosgw' command is causing failures:
File "qa/workunits/rgw/test_rgw_reshard.py", line 53, in get_radosgw_port
x = out.decode('utf8').split(" ")
AttributeError: 'bool' object has no attribute 'decode'
because when valgrind is enabled, the process name is 'valgrind' instead
of 'radosgw'
Signed-off-by: Casey Bodley <cbodley@redhat.com>
crimson/osd: do not pass oop as a const ref and cleanups
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
To be explicit that string_kew_view_t::MIN and MAX are not valid
string lengths. They are reserved as markers.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
structured binding does not define variables, let's capture the bound
"variables" using variables defined in the capture list.
Signed-off-by: Kefu Chai <kchai@redhat.com>
to silence -Wfinal-dtor-non-final-class warnings like
operation.h:461:20: warning: class with destructor marked 'final' cannot
be inherited from [-Wfinal-dtor-non-final-class]
~ExitBarrier() final {
^
Signed-off-by: Kefu Chai <kchai@redhat.com>
instead of using a local lambda which tries to have a single point
for handling both the happy path and failure path, it'd be simpler
to just early return if we fail to handle a request,
Signed-off-by: Kefu Chai <kchai@redhat.com>
before this change, std::move(oop) will create a copy of oop.
after this change, std::move(oop) actually moves oop.
Signed-off-by: Kefu Chai <kchai@redhat.com>
the order of evaluation of function arguments is unspecified with some
exceptions. but in this case, the reason why ops is still valid is that
the parameter type of `osd_op_p` is `const osd_op_params_t&`. so a copy
is passed to it.
to enable us to actually move `osd_op_p`, in this change, the
osd_op_p.req->ops is used instead.
Signed-off-by: Kefu Chai <kchai@redhat.com>
as we should expose the internals using the name of interface, and there
is no need to differentiate rep_repair_primary_object() from another
repair method.
Signed-off-by: Kefu Chai <kchai@redhat.com>
it errors while building without lua_packages:
+ -DBOOST_J=102 -DWITH_GRAFANA=ON
/var/tmp/rpm-tmp.aq2X3J: line 91: -DBOOST_J=102: command not found
Signed-off-by: luo.runbing <luo.runbing@zte.com.cn>
structured-binding does not define variables, so we cannot use "[=]" to
implicitly capture them. define variables in the capture list instead.
Signed-off-by: Kefu Chai <kchai@redhat.com>
to silence warnings like:
crimson/common/operation.h:394:20: warning: class with destructor marked
'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
~ExitBarrier() final {
^
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/orchestrator: minor improvements to orch status
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
crimson/osd: make sure ox be removed after all continuations are finished in PG::do_osd_ops
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
this change addresses a regression introduced by
fe4f4402fb, which was tested before
abd9287db0 got merged. and the former was
merged after abd9287db0. hence the
regression.
Signed-off-by: Kefu Chai <kchai@redhat.com>
