Commit Graph

137115 Commits

Author SHA1 Message Date
Anthony D'Atri
68df405e53
Merge pull request #50660 from zdover23/wip-doc-2023-03-25-rados-operations-bluestore-migration-prompt-fix
doc/operations: fix prompt in bluestore-migration
2023-03-24 13:54:06 -04:00
Zac Dover
5e54641aec doc/operations: fix prompt in bluestore-migration
Fix a single prompt in bluestore-migration.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-25 03:47:10 +10:00
Ilya Dryomov
b89782a369
Merge pull request #50302 from weirdwiz/rbd-perf-counters
rbd-mirror: switch to labeled perf counters

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-03-24 13:00:10 +01:00
Rishabh Dave
76177ab1a9
Merge pull request #50497 from rishabh-d-dave/fs-qa-caps-helper
qa/cephfs: add more helper methods to caps_helper.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-24 16:28:38 +05:30
Ilya Dryomov
4431be49fc
Merge pull request #49302 from petrutlucian94/adapter_resets
rbd-wnbd: optionally handle wnbd adapter restart events

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-03-24 11:41:04 +01:00
Avan
5976b1f21d
Merge pull request #50369 from rhcs-dashboard/exporter-labeled-counters
exporter: add support for exposing labeled perf counters
2023-03-24 14:56:28 +05:30
Lucian Petrut
98a7aff741 rbd-wnbd: consistently use negative error codes in rbd-wnbd
The rbd-wnbd iterators return positive errors, which is why
in certain cases we may end up with both positive and negative
error codes.

This change ensures that we'll consistently use negative
error codes.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-03-24 09:00:21 +00:00
Lucian Petrut
3d8afc0021 common, rbd-wnbd: bump Windows log level
We're increasing the log level for certain Windows operational log
messages.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-03-24 08:59:49 +00:00
Lucian Petrut
0c25ca6564 rbd-wnbd: optionally handle wnbd adapter restart events
The WNBD adapter may be reset in certain situations (e.g. driver
upgrade, MS WHQL tests, etc).

We're going to monitor the WNBD adapter using WMI[1] events, restarting
the rbd-wnbd disk mappings whenever necessary. Adapter monitoring can be
enabled by passing the --adapter-monitoring-enabled flag to the service.

This feature is optional for the following reasons:

* it's mainly used during development / driver certification
* we had to use a relatively small polling interval, which might imply
  additional resource usage. WMI quotas also have to be considered.

While at it, we're updating two lambdas that are submitted to thread pools,
avoiding default reference capturing and explicitly specifying the variables
that get copied.

[1] https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmi-start-page

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-03-24 08:58:15 +00:00
Rishabh Dave
969a93d0dc qa/cephfs: add more helper methods to caps_helper.py
Add methods that will accept read/write permissions, CephFS names and
CephFS mount point and in return will generate string form of MON, OSD
and MDS caps exactly as it is reported in Ceph keyrings.

Replace similar code in test_multifs_auth.py with calls to these helper
methods.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-03-24 11:32:58 +05:30
Anthony D'Atri
b5d6ca7a8f
Merge pull request #50649 from Thingee/foundation-mem-update-20230323
doc/foundation: Update Foundation members
2023-03-23 20:11:04 -04:00
Mike Perez
73aa44aa44 doc/foundation: Update Foundation members
Removing EasyStack, Vexxhost and adding 42on

Signed-off-by: Mike Perez <thingee@gmail.com>
2023-03-23 15:52:12 -07:00
J. Eric Ivancich
f086510440
Merge pull request #50545 from ivancich/wip-fix-bi-restore-script-installation
rgw: install rgw scripts with common files rather than radosgw files

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-03-23 15:29:19 -04:00
J. Eric Ivancich
4e9b8fa4bd
Merge pull request #50617 from ivancich/wip-add-unordered-list-restore-index
rgw: add unordered listing to reindex to force stats update

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-03-23 15:17:34 -04:00
avanthakkar
c4da9021f4 exporter: export labeled perf-counters as prometheus metrics
Fixes: https://tracker.ceph.com/issues/59063
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2023-03-23 20:07:00 +05:30
zdover23
6c5f719418
Merge pull request #50634 from zdover23/wip-doc-2023-03-23-rados-operations-user-management-1-of-x
doc/rados: edit user-management.rst (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-23 23:05:28 +10:00
Zac Dover
3f90958909 doc/rados: edit user-management.rst (1 of x)
Edit doc/rados/operations/user-management.rst. (1 of x)

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-23 22:43:13 +10:00
Yingxin
b73579531d
Merge pull request #50555 from myoungwon/wip-rbm-get-stat
crimson/os/seastore: implement get_stat() for RBM

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-03-23 17:23:01 +08:00
myoungwon oh
3c21cff441 crimson/os/seastore/rbm: implement get_stat()
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2023-03-23 07:06:05 +00:00
Yuri Weinstein
173d5a56ec
Merge pull request #50334 from kamoltat/wip-ksirivad-fix-autoscale-warn
pybind/mgr/pg_autoscaler: Reorderd if statement for the func: _maybe_adjust

Reviewed-by: Laura Flores <lflores@redhat.com>
2023-03-22 16:24:51 -07:00
Yuri Weinstein
369aaa7aea
Merge pull request #49748 from ifed01/wip-ifed-bound-rm-range-keys
kv/RocksDBStore: use bounded iterators in rm_range_keys

Reviewed-by: Cory Snyder <csnyder@iland.com>
2023-03-22 16:23:56 -07:00
Yuri Weinstein
2042e95458
Merge pull request #49380 from Matan-B/wip-matanb-lrod-logs
osd/PeeringState: Add logs around can_serve_replica_read() / last_complete_ondisk()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2023-03-22 16:23:10 -07:00
Casey Bodley
08b8e03952
Merge pull request #50510 from cbodley/wip-rgw-server-name
rgw: add default Server response header

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2023-03-22 13:24:44 -04:00
Casey Bodley
bd0eee3a9e
Merge pull request #50504 from cbodley/wip-59048
rgw/s3: DeleteObjects response uses correct delete_marker flag

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2023-03-22 13:22:33 -04:00
Lucian Petrut
a47caa156a common: add win32/wstring.h
Windows APIs heavily use wchar. ceph-dokan and rbd-wnbd
have some duplicated helpers that convert wstrings to/from
utf8 strings.

To avoid duplication and allow reusing those helpers, we're moving
them to common/win32/wstring.h.

We're using the "win32" subfolder because it's unlikely that this
will ever be used on other platforms.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-03-22 14:34:52 +00:00
Matan
389ea16663
Merge pull request #50492 from Matan-B/wip-matanb-c-logging-levels
crimson/common/log: Fix debug logging macros

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-03-22 16:26:53 +02:00
Matan
2e5a7f3339
Merge pull request #50491 from Matan-B/wip-matanb-c-snaps-tests
test/librados/snapshots*: Enable Crimson supported tests

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-03-22 16:25:18 +02:00
Matan
e967a1479a
Merge pull request #50546 from Matan-B/wip-matanb-crimson-only-order-snap
crimson/osd: Support librados::OPERATION_ORDERSNAP

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-03-22 16:24:02 +02:00
Casey Bodley
504ff07cda
Merge pull request #49328 from BryceCao/wip-fix-python-script-using-s3cmd-with-error-code-403
rgw : fix python script using s3cmd with error code 403

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-03-22 08:59:19 -04:00
zdover23
6e67bf80aa
Merge pull request #50606 from zdover23/wip-doc-2023-03-21-rados-operations-erasure-code
doc/rados: line-edit erasure-code.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-22 08:09:20 +10:00
J. Eric Ivancich
71b2c2a6dd rgw: add unordered listing to reindex to force stats update
By including an unordered listing in the script, we will complete
placing objects in the bucket index and allow stats to be updated
rather than waiting for this to happen organically at a user's
request. Unordered is preferred as it can run more efficiently.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2023-03-21 18:01:56 -04:00
Casey Bodley
fa7394f797
Merge pull request #50486 from linuxbox2/wip-dedup-opsqs
Do not duplicate query-string in ops-log

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-03-21 17:52:28 -04:00
Laura Flores
f826514091
Merge pull request #50468 from aclamk/wip-aclamk-harmonize-bluefs-log
os/bluestore: BlueFS: harmonize log read and writes modes
2023-03-21 15:42:52 -05:00
Mark Kogan
2cb9441180 rgw : fix python script using s3cmd with error code 403 w/https
Fixes: https://tracker.ceph.com/issues/54104

Signed-off-by: Mark Kogan <mkogan@redhat.com>
2023-03-21 18:30:12 +02:00
Zac Dover
2ff9965e02 doc/rados: line-edit erasure-code.rst
Line-edit doc/rados/operations/erasure-code.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-21 23:53:35 +10:00
Divyansh Kamboj
1a1477b9fd rbd-mirror: add and rename perf counters for journal and snapshot mirroring
This commit renames the existing snapshot and journal based performance
counters in the rbd-mirror daemon to better reflect their purpose.
Additionally, new perf counters have been added to provide more detailed
information about the synchronization of snapshots between the source
and destination clusters.

This commit also switches to use labels instead of having the image spec
in the name of the counter.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
2023-03-21 16:30:53 +05:30
Yingxin
b0615fd368
Merge pull request #50602 from xxhdx1985126/wip-invalid-clean-pending-extents
crimson/os/seastore: don't set INVALID extents to CLEAN when reading extents

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-03-21 15:55:27 +08:00
Xuehan Xu
729dabd8ff crimson/os/seastore: don't set INVALID extents to CLEAN when reading
extents

CLEAN_PENDING extents may be invalidated before read completes:

1. transaction A retired an laddr, which lead to a RetirePlaceHolder in
   Cache
2. transaction B try to read that extent, and replace A's
   RetirePlaceHolder with it;
3. transaction A commits and invalidate that extent;
4. transaction B complete reading that extent;

In this case, we shouldn't set the extent's state to CLEAN

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2023-03-21 06:01:35 +00:00
zdover23
e1587eed91
Merge pull request #50488 from zdover23/wip-doc-2023-03-13-rados-bluestore-migration-2-of-x
doc/rados: edit operations/bs-migration (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-20 10:59:21 +10:00
zdover23
7f61cd80d5
Merge pull request #50487 from zdover23/wip-doc-2023-03-12-rados-bluestore-migration
doc/rados: edit operations/bs-migration (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-20 10:58:55 +10:00
zdover23
3faae31813
Merge pull request #50579 from zdover23/wip-doc-2023-03-18-rados-configuration-mon-lookup-dns
doc/rados: line edit mon-lookup-dns top matter

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-19 17:56:22 +10:00
Zac Dover
ed5919964b doc/rados: line edit mon-lookup-dns top matter
Improve the syntax of the top matter of
doc/rados/operations/mon-lookup-dns.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-19 17:34:58 +10:00
Casey Bodley
ee1ae6cbd0
Merge pull request #49443 from cbodley/wip-qa-supported-distros
qa/distros: add ubuntu 22 as supported distro

Reviewed-by: Yuri Weinstein <yuriw@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-17 15:36:41 -04:00
Rishabh Dave
3203d6005e
Merge pull request #50498 from rishabh-d-dave/fs-qa-caps-helper-minor
qa/cephfs: minor corrections in caps_helper.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-17 23:53:27 +05:30
Yingxin
736b382767
Merge pull request #50556 from aravind-wdc/fix-header
crimson: fix build error

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2023-03-17 22:07:40 +08:00
Ilya Dryomov
15c86b7448
Merge pull request #50559 from petrutlucian94/improve_win32_clock_check
common: avoid redefining clock type on Windows

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-03-17 13:30:12 +01:00
Venky Shankar
544635a3ef Merge PR #50544 into main
* refs/pull/50544/head:
	test/libcephfs: skip flaky timestamp assertion on Windows

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2023-03-17 14:25:42 +05:30
Nizamudeen A
ab730ef5e1
Merge pull request #50106 from rhcs-dashboard/new-landing-page-and-toggle-button
mgr/dashboard: add button toggle to switch between landing pages
2023-03-17 14:01:29 +05:30
Lucian Petrut
489fd85847 common: avoid redefining clock type on Windows
mingw >= 8.0.1 defines CLOCK_REALTIME_COARSE, so we'll avoid
overriding it if already set.

Clock precision [1]:

mingw < 8.0.1:
  * CLOCK_REALTIME: ~10-55ms (GetSystemTimeAsFileTime)
mingw >= 8.0.1:
  * CLOCK_REALTIME: <1us (GetSystemTimePreciseAsFileTime)
  * CLOCK_REALTIME_COARSE: ~10-55ms (GetSystemTimeAsFileTime)

* CLOCK_MONOTONIC: <1us if TSC is usable, ~10-55ms otherwise
                   (QueryPerformanceCounter)

[1] dcd990ed42

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-03-17 07:38:16 +00:00
zdover23
5da240be17
Merge pull request #50563 from zdover23/wip-doc-2023-03-17-rados-operations-upmap
doc/rados: line-edit upmap.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-17 15:54:32 +10:00