RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-21 18:17:42 +00:00
Code Issues Packages Projects Releases Wiki Activity
119,534 Commits 216 Branches 395 Tags 1.4 GiB
68af4a9f12
Commit Graph

119534 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kefu Chai
68af4a9f12 crimson/osd: do not pass oop as a const ref 
before this change, std::move(oop) will create a copy of oop.
after this change, std::move(oop) actually moves oop.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 11:38:22 +08:00
Kefu Chai
3c17ea9010 crimson/osd: do not pass ops to submit_transaction() separately 
the order of evaluation of function arguments is unspecified with some
exceptions. but in this case, the reason why ops is still valid is that
the parameter type of `osd_op_p` is `const osd_op_params_t&`. so a copy
is passed to it.

to enable us to actually move `osd_op_p`, in this change, the
osd_op_p.req->ops is used instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 11:38:22 +08:00
Kefu Chai
e730737e8b crimson/osd: extract methods out of ClientRequest::process_op() 
* do_recover_missing()
* do_process()

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 11:38:22 +08:00
Kefu Chai
c6dd356e4c crimson/osd: do not move op_params_p in fill_op_params_bump_pg_version() 
it's confusing to move the parameter for updating it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 11:38:22 +08:00
Kefu Chai
9eca9243f4 crimson/osd: do not add parentheses unless necessary 
do not use the notation of

[]() -> return_type {

unless it helps with readability or we have to do so.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 11:38:22 +08:00
Kefu Chai
f37e915e9f crimson/osd: remove no-op func passed to OpsExecuter::flush_changes() 
no need to create an empty func for an request which creates no
transactions.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 11:38:22 +08:00
Kefu Chai
28712f215d crimson/osd: rename PG::rep_repair_primary_object() to repair_object() 
as we should expose the internals using the name of interface, and there
is no need to differentiate rep_repair_primary_object() from another
repair method.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 11:38:22 +08:00
Kefu Chai
1f6f9b24e4
Merge pull request #39361 from sebastian-philipp/orch-fix-flake8 
mgr/orch: Fix flake8 error

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
 2021-02-09 10:15:36 +08:00
Samuel Just
83d3ac1b03
Merge pull request #39332 from cyx1231st/wip-seastore-range-query 
crimson/onode-staged-tree: implement Cursor::get_next() and comparators for range query

Reviewed-by: Samuel Just <sjust@redhat.com>
 2021-02-08 12:04:31 -08:00
Sebastian Wagner
be9b98a4a3 mgr/orch: Fix flake8 error 
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
 2021-02-08 17:37:52 +01:00
Sebastian Wagner
602a91327d
Merge pull request #37729 from mgfritch/cephadm-podman-logdriver 
cephadm: configure journald as the logdriver

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
 2021-02-08 17:34:10 +01:00
Sebastian Wagner
f635555fe7
Merge pull request #37764 from mgfritch/cephadm-no-container-init 
cephadm: run containers using `--init` by default

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
 2021-02-08 17:33:16 +01:00
Sebastian Wagner
d4d3d17b23
Merge pull request #39153 from mgfritch/cephadm-flake8 
mgr/cephadm: introduce flake8

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
 2021-02-08 17:32:04 +01:00
Kefu Chai
46493eb748
Merge pull request #39331 from ceph/revert-37954-wip-F46226-log-dq-throttle-limit-new 
Revert "msg,mon,common: log when DispatchQueue throttle limit is reached"

Reviewed-by: Neha Ojha <nojha@redhat.com>
 2021-02-09 00:04:51 +08:00
Kefu Chai
22e68cd6c0
Merge pull request #39359 from tchaikov/wip-crimson-clang-build 
crimson/os: fix build with clang

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
 2021-02-08 23:03:16 +08:00
Kefu Chai
fab5910b3f crimson/os: capture labels using a new variable 
structured-binding does not define variables, so we cannot use "[=]" to
implicitly capture them. define variables in the capture list instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 22:09:46 +08:00
Kefu Chai
eadc2bce48 crimson/os: mark unused variable [[maybe_unused]] 
to silence warning like

key_layout.h:516:10: warning: unused variable 'nspace_masked'
[-Wunused-variable]
    auto nspace_masked = string_view_masked_t::decode(nspace, delta);
         ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 22:09:46 +08:00
Kefu Chai
876737f92e crimson/os: do not define assignment operator for Value 
we cannot assign a reference.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 22:09:46 +08:00
Kefu Chai
0d7242917b crimson/os: do not capture unused variable 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 22:09:46 +08:00
Kefu Chai
244a7db3c3 crimson/common: mark ExitBarrier final 
to silence warnings like:

crimson/common/operation.h:394:20: warning: class with destructor marked
'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
    ~ExitBarrier() final {
                   ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 22:09:46 +08:00
Sebastian Wagner
8df1956d16
Merge pull request #39350 from tchaikov/wip-cephadm-unicode 
cephadm: do not cast subnet to unicode

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
 2021-02-08 11:47:11 +01:00
Sebastian Wagner
44b912b626
Merge pull request #39266 from sebastian-philipp/cephadm-rm-keyring-on-failed-deploy 
mgr/cephadm: cleanup daemon keyring on failed daemon deploy

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
 2021-02-08 11:46:35 +01:00
Sebastian Wagner
4db6aebee0
Merge pull request #38695 from pcuzner/orch-status-changes 
mgr/orchestrator: minor improvements to orch status

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
 2021-02-08 11:15:19 +01:00
Kefu Chai
318ddc521c
Merge pull request #39347 from xxhdx1985126/wip-crimson-pg-bug-fix 
crimson/osd: make sure ox be removed after all continuations are finished in PG::do_osd_ops

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
 2021-02-08 18:08:57 +08:00
Kefu Chai
5ca820fb9e Revert "msg,mon,common: log when DispatchQueue throttle limit is reached" 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 18:03:14 +08:00
Kefu Chai
b585164877 cephadm: do not cast subnet to unicode 
this change addresses a regression introduced by
fe4f4402fb, which was tested before
abd9287db0 got merged. and the former was
merged after abd9287db0. hence the
regression.

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 16:29:55 +08:00
Xuehan Xu
005534856a crimson/osd: make sure ox be removed after all continuations are finished in PG::do_osd_ops 
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
 2021-02-08 15:01:59 +08:00
Kefu Chai
b64e2479b0
Merge pull request #39193 from tchaikov/wip-cephadm-py3 
cephadm: drop support to python<3.3

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
 2021-02-08 12:20:03 +08:00
Kefu Chai
3d012222fa
Merge pull request #38897 from Daniel-Pivonka/mgroktostop 
mgr/cephadm: ok-to-stop for mgr

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
 2021-02-08 11:57:21 +08:00
Kefu Chai
b0eb012256
Merge pull request #39082 from ifed01/wip-ifed-meta-in-objectstore-tool 
tools/ceph-objectstore-tool: allow object operations on meta pgid

Reviewed-by: Kefu Chai <kchai@redhat.com>
 2021-02-08 11:55:17 +08:00
Kefu Chai
708de33295
Merge pull request #39273 from tchaikov/wip-timer-mono 
common/Timer: use mono_clock for clock_t

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
 2021-02-08 11:54:03 +08:00
Kefu Chai
385db1c5a2
Merge pull request #39295 from tchaikov/wip-mgr-balancer-ann 
pybind/mgr/balancer: add type annotations

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
 2021-02-08 11:52:21 +08:00
Kefu Chai
c7aa97628e
Merge pull request #39164 from tchaikov/wip-crimson-push-mov 
crimson/osd: consume the push payload

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
 2021-02-08 09:39:35 +08:00
Ali Maredia
88cc6f2231
Merge pull request #39204 from TRYTOBE8TME/wip-rgw-create-bucket-dpp 
src/rgw: Dpp addition to create bucket log
 2021-02-07 12:07:14 -05:00
root
a53c206f63 rgw: Dpp addition to create bucket log 
This commit adds dpp to the create bucket log.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
 2021-02-07 20:46:49 +05:30
Kefu Chai
6448226ccc pybind/mgr/balancer: flake8 cleanups 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 20:18:42 +08:00
Kefu Chai
0d48b03db2 pybind/mgr/balancer: define Plan.{dump,show}() 
as they are called by the commands

Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 20:18:42 +08:00
Kefu Chai
51ee3926d7 pybind/mgr/alerts: flake8 cleanups 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 20:18:42 +08:00
Kefu Chai
af3f49d981 pybind/mgr/balancer: define options using Option 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 20:18:42 +08:00
Kefu Chai
376939d8d8 pybind/mgr/balancer: add type annotations 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 20:18:41 +08:00
Kefu Chai
46f00b3da2 pybind/mgr/balancer: define commands using CLICommand 
Signed-off-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 20:17:58 +08:00
Kefu Chai
e06bf9157e
Merge pull request #39336 from AlexWangD/patch-4 
doc: fix the spelling mistake of “Topicd”

Reviewed-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 20:07:01 +08:00
Alex Wang
357e1b2c84
doc: fix the spelling mistake of “Topicd” 
“Topicd” is a spelling mistake of "Topics".
 2021-02-07 15:26:04 +08:00
Kefu Chai
b3e1a0c122
Merge pull request #37566 from AmnonHanuhov/wip-ObjectStore_EIO_Handling 
crimson/osd: Recover missing object on read error

Reviewed-by: Kefu Chai <kchai@redhat.com>
 2021-02-07 12:18:01 +08:00
Yingxin Cheng
4f556014b0 crimson/onode-staged-tree: cleanup -- switch to get_*_slot() interfaces 
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
 2021-02-07 10:19:41 +08:00
Mykola Golub
7bafcfbb01
Merge pull request #39303 from dillaman/wip-49173 
librbd/io: conditionally disable move optimization

Reviewed-by: Mykola Golub <mgolub@suse.com>
 2021-02-06 11:23:45 +02:00
J. Eric Ivancich
36a208f287
Merge pull request #39312 from ivancich/wip-orphan-list-binary-data 
rgw: allow rgw-orphan-list to handle intermediate files w/ binary data

Reviewed-by: Michael Kidd <linuxkidd@gmail.com>
 2021-02-05 14:46:56 -05:00
Michael Fritch
80990f5bdc
mgr/cephadm: Redefinition of unused name from line n (F811) 
Signed-off-by: Michael Fritch <mfritch@suse.com>
 2021-02-05 11:20:58 -07:00
Michael Fritch
2e2b419daf
mgr/cephadm: Module imported but unused (F401) 
Signed-off-by: Michael Fritch <mfritch@suse.com>
 2021-02-05 11:20:58 -07:00
Michael Fritch
6658c53d6f
mgr/cephadm: Local variable name is assigned to but never used (F841) 
add error handling when `CompletedProcess` fails during rgw relam,
zongroup create et al.

Signed-off-by: Michael Fritch <mfritch@suse.com>
 2021-02-05 11:20:57 -07:00