Commit Graph

124174 Commits

Author SHA1 Message Date
Yingxin Cheng
6673bf88a4 crimson/onode-staged-tree: print NodeExtent with the header
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-21 10:08:46 +08:00
Yingxin Cheng
860ddba0f0 crimson/onode-staged-tree: validate node header when load
Add logs to detect corruptions when load nodes. assert() is not
informative enough to understand the context.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-21 10:08:44 +08:00
Yingxin Cheng
366efc403e crimson/onode-staged-tree: delete copy constructor of DummyNodeExtent
Dummy backend is used for unit tests without transactions, so there
should be no copy-on-write behavior.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-21 10:05:28 +08:00
Yingxin Cheng
512dac2c6e crimson/onode-staged-tree: add trace logs when start to load nodes
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-21 10:05:20 +08:00
Kefu Chai
a6d60dc4b2
Merge pull request #41894 from tchaikov/wip-crimson-sigint
crimson/{osd,store_nbd}: handle SIGINT

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-17 10:31:27 +08:00
Kefu Chai
647eab4088
Merge pull request #41895 from ceph/wip-cacephcom
MIRRORS: Add ca.ceph.com

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-17 08:13:49 +08:00
Sage Weil
3c870731a7 Merge PR #41890 into master
* refs/pull/41890/head:
	doc/cephadm: removing "Octopus" from procedure

Reviewed-by: Sage Weil <sage@redhat.com>
2021-06-16 14:01:26 -04:00
David Galloway
6cc502854c MIRRORS: Add ca.ceph.com
Signed-off-by: David Galloway <dgallowa@redhat.com>
2021-06-16 13:25:15 -04:00
Kefu Chai
a1d5ded993 crimson/osd: use stop_signal from seastar
and disable app_cfg.auto_handle_sigint_sigterm, otherwise app template
handles SIGINT and SIGTERM by itself, and calls app.stop(). but we don't
use this mechinary at all. we use seastar::defer() instead of
seastar::at_exit() for doing graceful shutdown and cleanup.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-17 01:13:24 +08:00
Kefu Chai
11c439d5f0 crimson/tools/store_nbd: update example usage in comment
--total-device-size is not supported any more.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-17 01:13:24 +08:00
Kefu Chai
0689b128e1 crimson/tools/store_nbd: add graceful shutdown support
we could have more sophisticate mechinary for interrupting fio job,
but so far it is able to stop itself if it idle by handling ctrl-C.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-17 01:13:24 +08:00
Yingxin Cheng
3faea72b70 crimson/seastore/nbd: destruct the store before create
Otherwise the store will register the conflicting metrics and result in
double_registration.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-06-17 00:23:58 +08:00
Zac Dover
1036edd69a doc/cephadm: removing "Octopus" from procedure
This PR removes "Octopus" from the curl-based installation
procedure.

After we moved on to Pacific, referring to Octopus looks wrong.
It looks wrong because it now is wrong.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-06-17 00:34:10 +10:00
Kefu Chai
08661e6f57
Merge pull request #41882 from tchaikov/wip-crimson-int-safty
crimson/osd: guard non-pg-op handling with with_sequencer()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-16 22:09:28 +08:00
Kefu Chai
cd0bb38b2b
Merge pull request #41885 from tchaikov/wip-crimson-os-cleanups
crimson/os: cleanups and reformat

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-06-16 20:36:32 +08:00
Kefu Chai
d8ee9e4f68 crimson/osd: reindent
for less indent, hence better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 20:30:03 +08:00
Kefu Chai
3e28e640de crimson/osd: wrap line at 80
for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 20:28:10 +08:00
Kefu Chai
728fc4a0f0 crimson/osd: guard non-pg-op handling with with_sequencer()
because we should only ensure the ordering of the requests touching
the objects, the other requests like pgls should not be ordered along
with them. so as the second step, guard the non-pg-op handling with
with_sequencer().

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 20:28:01 +08:00
Kefu Chai
84c71bc22f crimson/os: use reference for loop variable
for better performance, also silences the warning like:

../src/crimson/os/seastore/random_block_manager/nvme_manager.cc:444:23: warning: loop variable ‘b’ creates a copy from type ‘const crimson::os::seastore::rbm_alloc_delta_t’ [-Wrange-loop-construct]
  444 |       for (const auto b : alloc_blocks) {
      |                       ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 19:58:50 +08:00
Sebastian Wagner
6ce6874bae
Merge pull request #41859 from sebastian-philipp/mypy-constrains.txt
global,tox.ini: add mypy-constrains.txt

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
2021-06-16 13:54:31 +02:00
Kefu Chai
11216507aa crimson/os: return seastar::now() in "finally()" block
so finally() is able to identify the return is a future, and discard it
manually.
otherwise the return value will be discarded even the future is marked
[[nodiscard]], hence the C++ compiler warns.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 19:09:04 +08:00
Kefu Chai
2e66a657ae crimson/os: remove unnecessary now()
the previous continuation in the chain already returns a future, no need
to hook up another now().

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 19:09:04 +08:00
Kefu Chai
bb253d769b crimson/os: remove unnecessary parentheses
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 19:09:04 +08:00
Kefu Chai
44863f48aa crimson/os: fix the indent
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 19:09:04 +08:00
Kefu Chai
e41f7e3b41 crimson/os: do not capture unused variables
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 19:09:04 +08:00
Sebastian Wagner
04e586f90a
global,tox.ini: add mypy-constrains.txt
let's avoid getting new versions of those packages by accident.
Unfortunately this means we have to manually update those
packages regurarly.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-06-16 12:37:46 +02:00
Kefu Chai
1a44046339 crimson/osd: extract with_sequencer() method out
because we should only ensure the ordering of the requests touching
the objects, the other requests like pgls should not be ordered along
with them, so as the first step, let's extract with_sequencer() method
out, so we can differentiate these two cases with minimal repeatings.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 18:29:10 +08:00
Kefu Chai
57aefd9250
Merge pull request #41881 from tchaikov/wip-crimson-alien
crimson: adapt to the new alien API

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-16 18:28:33 +08:00
Kefu Chai
e53ea0886f crimson: adapt to the new alien API
since seastar now deprecates the old alien::submit_to() API, and
replaced it with a variant which requires a new parameter of "alien"
instance, let's pick it up, to amortize the cost to catch up with
the seastar master HEAD.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-16 17:14:40 +08:00
Igor Fedotov
0a44cd16a9
Merge pull request #41825 from tchaikov/wip-avl-cleanup
os/bluestore/AvlAllocator: specialize _block_picker() and cleanups

Reviewed-by: Igor Fedotov <ifedotov@suse,com>
2021-06-16 12:02:38 +03:00
Sebastian Wagner
2381725447
Merge pull request #41346 from adk3798/enough-mds-upgrade
mgr/cephadm: skip ok-to-stop for mds in upgrade if not enough mds daemons

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-06-16 10:53:33 +02:00
Sebastian Wagner
deadde21af
Merge pull request #41813 from adk3798/repo
cephadm: Use gpg rather than asc key for add-repo

Reviewed-by: Sage Weil <sage@newdream.net>
2021-06-16 10:51:53 +02:00
Sebastian Wagner
c2b7b68598
Merge pull request #41820 from mgfritch/cephadm-not-a-mon-ip
cephadm: raise Error() when unable to bind to an ip

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-06-16 10:51:38 +02:00
Samuel Just
845d430abc
Merge pull request #41041 from myoungwon/wip-randomblockmanager-part1
seastore: RandomBlockManager part1

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-06-16 00:29:18 -07:00
Kefu Chai
6f58a26281
Merge pull request #27465 from tchaikov/wip-38219
ceph-monstore-tool: use a large enough paxos/{first,last}_committed

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-06-16 09:38:45 +08:00
Kefu Chai
395fdaeca7
Merge pull request #41873 from bobbyphilip/patch-1
doc/start/hardware-recommendations.rst: Corrected typo

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-16 07:44:00 +08:00
Patrick Donnelly
319b578b14
Merge PR #40972 into master
* refs/pull/40972/head:
	doc: add missing note about restoring allow_standby_replay
	doc: clarify distributed ephemeral pins new mechanism
	doc: update mds_autoscaler documentation to reflect recent changes

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2021-06-15 14:57:44 -07:00
Bobby Alex Philip
0a87c47d4d doc/start/hardware-recommendations.rst: Corrected typo
129GB - >128GB
Signed-off-by: Bobby Philip bobbyphilip@gmail.com
2021-06-15 22:53:27 +02:00
Sage Weil
091a32e130 Merge PR #41844 into master
* refs/pull/41844/head:
	qa/suites/orch/cephadm/dashboard: remove remaining bits

Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-06-15 15:42:26 -04:00
Patrick Donnelly
174b8ad30b
Merge PR #41840 into master
* refs/pull/41840/head:
	qa: update cli syntax to conventional

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2021-06-15 10:34:18 -07:00
Patrick Donnelly
03674f5197
Merge PR #41821 into master
* refs/pull/41821/head:
	qa: specify distro for fs:bugs

Reviewed-by: Rishabh Dave <ridave@redhat.com>
2021-06-15 10:33:38 -07:00
Patrick Donnelly
dc772fa348
Merge PR #41773 into master
* refs/pull/41773/head:
	test/pybind/test_ceph_argparse: add a test where args contains comma
	cmake: run nose test using "python3 -m nose"
	test/pybind/test_ceph_argparse: check for expected argument
	test/pybind/test_ceph_argparse: decorate helper method with @nottest
	test/pybind: do not test obsoleted command
	test/pybind: drop forward and readforward from test
	test/pybind: do not use tab for indent
	pybind/ceph_argparse: validate csv if desc.N
	test/pybind: pep8 cleanups

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2021-06-15 10:32:49 -07:00
Patrick Donnelly
8cb34b3849
Merge PR #41771 into master
* refs/pull/41771/head:
	qa: update scrub start code to use comma sep scrubopts

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-15 10:32:06 -07:00
myoungwon oh
2dedb397ef seastore/rbm: remove changes related to transaction/cache
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-06-16 00:43:34 +09:00
Kefu Chai
e3c7234771
Merge pull request #41864 from rzarzynski/wip-crimson-iointrcond-fix-debug
crimson/osd: fix debug in IOInterruptCondition::new_interval_created().

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-15 23:34:01 +08:00
Kefu Chai
31380f1f3b
Merge pull request #41865 from rzarzynski/wip-crimson-opseq-fix-dropped-abort
crimson/osd: fix missed OpSequencer::abort() on primary change.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-15 23:05:11 +08:00
Radoslaw Zarzynski
2b14df40ef crimson/osd: fix missed OpSequencer::abort() on primary change.
Commit b5efdc6f1c has unified
the interruption handling among `InternalClientRequest` and
`ClientRequest`. Unfortunately, a call to `abort()` of
`OpSequencer` has been overlooked and dropped. This was causing
crashes at Sepia after after fixing the ordering issues in
`ClientRequest`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-15 14:32:39 +00:00
Radoslaw Zarzynski
f40109f64b crimson/osd: fix debug in IOInterruptCondition::new_interval_created().
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-15 14:29:06 +00:00
Samuel Just
c323e59930
Merge pull request #41801 from liu-chunmei/seastore-fix-get-retired-extent
crimson/seastore: fix cache::get_extent got retired extent

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-06-15 07:01:07 -07:00
Sebastian Wagner
0667a70c60
Merge pull request #41854 from sebastian-philipp/fix-mypy-yaml-representation
mgr/orch: fix mypy errors

Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
2021-06-15 13:59:54 +02:00