Commit Graph

143552 Commits

Author SHA1 Message Date
Rishabh Dave
c656228efa
Merge pull request #55365 from kotreshhr/ceph-mds-replica-debug-logs
mds: Add debug messages in replica handling

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2024-02-09 12:24:00 +05:30
Rishabh Dave
fadd7860b1
Merge pull request #55411 from rishabh-d-dave/qa-cephfs-caps_helper
qa/cephfs: declare f-string to get values to substitute variable names

Reviewed-by: Jos Collin <jcollin@redhat.com>
2024-02-09 12:20:13 +05:30
Venky Shankar
d56402f830 Merge PR #55493 into main
* refs/pull/55493/head:
	client: remove unused/undefined fake_write_size()

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2024-02-09 10:03:08 +05:30
Casey Bodley
2d61900c60
Merge pull request #55499 from cbodley/wip-squid-deprecate-blkin
doc: deprecate blkin tracing

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2024-02-08 22:14:54 +00:00
Radoslaw Zarzynski
72be1f4a8a
Merge pull request #55332 from athanatos/sjust/wip-crush-multi-choose
crush: add multistep retry rules

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2024-02-08 22:56:55 +01:00
Casey Bodley
16acfe0213
Merge pull request #54624 from cbodley/wip-cmake-qat
cmake: add ExternalProjects to enable QAT by default

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2024-02-08 21:13:52 +00:00
zdover23
e160811c5f
Merge pull request #55490 from eroldan/patch-2
doc/start: fix typo in hw-recs

Reviewed-by: Zac Dover <zac.dover@proton.me>
2024-02-09 05:38:48 +10:00
Kamoltat
9762656160 qa/tasks/ceph_manager.py: Added more loggings for all_active_or_peered()
Signed-off-by: Kamoltat <ksirivad@redhat.com>
2024-02-08 18:52:51 +00:00
Kamoltat
8c4768ecb3 qa/tasks/ceph_manager.py: Rewrite test_pool_min_size
Problem:

Failed the test in EC Pool configuration because PGs are
not going into active+clean (our fault for over thrashing and checking the wrong thing).
Also, PG would not go into active because we thrash below min_size
in an EC pool config, not enough shards in the acting set.
Therefore, failed the wait_for_recovery check.
Moreover, When we revive osds, we didn't add the osd back in the cluster,
this messes up true count for live_osds in the test.

Solution:

Instead of randomly choosing OSDs to thrash,
we randomly select a PG from each pool and
thrash the OSDs in the PG's acting set until
we reach min_size, then we check to see if the
PG is still active. After that we revive all
the OSDs to see if the PG recovered cleanly.

We removed some of the unnecessary part such
as `min_dead`, `min_live`, `min_out` and etc.

Also, we refractored the part of where we are
assigning k,m for the EC pools so that we get
better code readablility.

Fixes: Fixes: https://tracker.ceph.com/issues/59172

Signed-off-by: Kamoltat <ksirivad@redhat.com>
2024-02-08 18:52:41 +00:00
Eduardo Roldan
b80c12d080 doc:start.rst fix typo in hw-recs
s/power less/power loss/

Signed-off-by: Eduardo Roldan <trazor@gmail.com>
2024-02-09 03:06:32 +10:00
Roy Sahar
5c613b3788 nvmeof: Add mount for log location
Signed-off-by: Roy Sahar <royswi@gmail.com>
2024-02-08 17:58:43 +02:00
Casey Bodley
de57824519 doc: deprecate blkin tracing
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-08 10:56:03 -05:00
Kefu Chai
8ac5645372
Merge pull request #55267 from athos-ribeiro/cmake-empty-submodules
cmake: quote variable to allow empty values

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2024-02-08 23:14:09 +08:00
Guillaume Abrioux
dc8bb268c1
Merge pull request #55398 from ifed01/wip-ifed-fix-ceph-vol-migrate-wal
ceph-volume: Fix migration from WAL to data with no DB
2024-02-08 15:26:38 +01:00
Dhairya Parmar
7bcd0b0354 client: remove unused/undefined fake_write_size()
there are no usages of this function in entire codebase

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2024-02-08 17:58:42 +05:30
Pere Diaz Bou
de6840ce37 os/bluestore: set shared_blob to nullptr on unshare
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:36 +01:00
Pere Diaz Bou
ed64db2110 os/bluestore: get_shared_blob in test_bluestore_types
private shared_blob member access needed to be changed

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:36 +01:00
Pere Diaz Bou
4f6245fe1b os/bluestore: set to nullptr sharedblob on unshare
set_shared_blob requires shared_blob to be a nullptr to ensure
it's correct operation.

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:36 +01:00
Pere Diaz Bou
d5510b0f62 os/bluestore: test unshare blob + clone errors
This will ensure deleting and then cloning the same blob works.

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:36 +01:00
Pere Diaz Bou
6574407890 os/bluestore: make shared_blob access private
introduce const and non const accessors:
  const SharedblobRef& get_shared_blob
  SharedblobRef& get_dirty_shared_blob

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:36 +01:00
Pere Diaz Bou
07f08183a9 os/bluestore: create dummy blob on dummy onodes
dummy onodes don't have a collection, consequentially, we need to create
a blob without a collection.

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:36 +01:00
Pere Diaz Bou
e3bd4527a1 os/bluestore: remove unnecessary set_shared_blob in tests
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
17e5e3ad5c os/bluestore: blob's collection initialization in ctor
Set collection on blob creation instead of setting it manually after
creation

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
0dacebf563 os/bluestore: move blob and sharedblob on cache splitting
Collection is a member of Blob after previous changes, making it necessary for rehome_blob
to move both Blob and SharedBlob

Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
13b378b6cc os/bluestore: assert shared_blob->collection == blob->collection
Instead of setting blob collection to the same as shared blob, we ensure
we were in the same collection instead.

Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
dd9be33a04 os/bluestore: use add_blob and set collection bluestore_types_unittest
Use new_blob and set collection in Blob in bluestore unittests as per
latest changes

Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
d98ca007e4 os/bluestore: rename SharedBlob coll to collection
Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
e56fd0eaa9 os/bluestore: run rm_blob before shared_blob check
Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
8961e2cca3 os/bluestore: add missing add_blobs
Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
4515c51f63 os/bluestore: rehome Blob AND SharedBlob
split_cache requires moving from one collection to another in a
sharedblob. Therefore, with the new refactor we need collection inside
blob to be moved too.

Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Pere Diaz Bou
798d64d0ab os/bluestore: dont make SharedBlob always
Instead of creating a SharedBlob for each Blob instance, we just move
necesary fields like Collection to Blob and create SharedBlob only when
necessary.

Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
2024-02-08 12:16:35 +01:00
Afreen
5247d7d194 mgr/dashboard: fix error while accessing roles tab when policy attached
Fixes https://tracker.ceph.com/issues/64270

Issue:
======
Accessing Object->Users-Roles tab causing 500 internal servor error.
This is due to the "PermissionPolicies" which are attached to role and
backend was not handling this field for rgw roles.

Fix:
====
Added "PermissionPolicies" as the valid field in backend and updated
frontend to render the attached policy in formatted JSON

Signed-off-by: Afreen <afreen23.git@gmail.com>
2024-02-08 14:52:37 +05:30
Ivo Almeida
c1da4c673c
Merge pull request #55416 from ivoalmeida/snapshot-schedule-edit
mgr/dashboard: added edit functionality

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2024-02-08 05:51:46 -03:00
neeraj pratap singh
079f722c37 mgr/volumes: support to reject CephFS clones if cloner threads are not available
CephFS clone creation have a limit of 4 parallel clones by default at a time and rest
of the clone create requests are queued. This makes CephFS cloning very slow when
there is large amount of clones being created.After this patch clone requests won't be accepeted
when the requests exceed the `max_concurrent_clones` config value.

Fixes:  https://tracker.ceph.com/issues/59714
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2024-02-08 11:10:38 +05:30
Venky Shankar
f9d771f002
Merge pull request #55465 from neesingh-rh/wip-63991
doc: add description of metric fields for cephfs-top

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2024-02-08 11:01:04 +05:30
Casey Bodley
6fce88edb0 qa/rgw: hadoop-s3a uses supported-random-distro$
without this, teuthology-suite tries to schedule against centos8 which
is not supported for squid

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 16:08:51 -05:00
Casey Bodley
d4bdde9e7d
Merge pull request #55479 from ronen-fr/wip-rf-fifolegacy
rgw: mark maybe_unused variables

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 20:47:23 +00:00
Jane Zhu
c7ad4c1e70 rgw: do not copy olh attributes in versioning suspended bucket
Signed-off-by: Juan Zhu <jzhu4@dev-10-34-20-139.pw1.bcc.bloomberg.com>
2024-02-07 14:17:01 -05:00
zdover23
608a5b2b92
Merge pull request #55475 from zdover23/wip-doc-2024-02-07-radosgw-admin-confval
doc/radosgw: add confval directives

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2024-02-08 05:04:35 +10:00
Adam King
583a355d5e
Merge pull request #55149 from rkachach/fix_issue_63992
mgr/prometheus: fix orch check to prevent Prometheus from crashing 

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2024-02-07 13:54:19 -05:00
Casey Bodley
84af8357d1 cmake: WITH_QATLIB/ZIP disabled on aarch64
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:13:21 -05:00
Casey Bodley
5d2560762e compressor: move QatAccel out of common
move the QatAccel instance out of the Compressor base class and into
the zlib and lz4 compressors that can use it

this avoids having to link QAT into the ceph-common library, and only
the plugins where it's necessary

had to add LZ4Compressor.cc to store the new static variable

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:13:21 -05:00
Casey Bodley
ec2e4b62a9 build/win32: disable qat options
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:13:21 -05:00
Casey Bodley
7710719dec rpm: add system_qat option, default on for centos9
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:13:21 -05:00
Casey Bodley
15046cf1ad cmake: enable WITH_QATLIB and WITH_QATZIP by default
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:13:21 -05:00
Casey Bodley
4e159853d2 cmake: WITH_QATZIP requires WITH_QATLIB or WITH_QATDRV
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:13:21 -05:00
Casey Bodley
1df11fd17c cmake: build from qatzip submodule
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:13:20 -05:00
Casey Bodley
e4e7dfd472 cmake: build qatzip from source when WITH_SYSTEM_QATZIP=OFF
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:12:45 -05:00
Casey Bodley
74c437a0c8 cmake: build from qatlib submodule
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:10:41 -05:00
Casey Bodley
3068123667 cmake: build qat from source when WITH_SYSTEM_QATLIB=OFF
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-07 11:09:49 -05:00