Commit Graph

143552 Commits

Author SHA1 Message Date
neeraj pratap singh
dbdc161f74 qa: add test cases for the support to reject clones feature
Fixes: https://tracker.ceph.com/issues/59714
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2024-02-13 14:45:46 +05:30
Vallari Agrawal
c8116c65df
Merge pull request #54959 from VallariAg/wip-nvmeof-test-v2
qa: add qa/tasks/nvmeof.py
2024-02-13 13:20:42 +05:30
Aashish Sharma
a85baa89da
Merge pull request #55314 from cloudbehl/rgw-dashboard-json
mgr/dashboard: Fixing RGW graph panels


Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2024-02-13 12:00:33 +05:30
Pritha Srivastava
7a31137ec7 dashboard/rgw: changes to use 'full_user_id' from rgw
user info as 'uid' in dashboard. 'full_user_id' includes
tenant and user id, and also namespace wherever it is non
empty.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2024-02-13 10:52:12 +05:30
zdover23
137ea0f873
Merge pull request #55546 from zdover23/wip-doc-2024-02-13-glossary-crush
doc/glossary: Add link to CRUSH paper

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2024-02-13 10:00:52 +10:00
Adam King
c521681980
Merge pull request #53527 from rhcs-dashboard/add-rgw-perf-counter-cache
cephadm/rgw: make rgw perf counters cache and it's size configurable

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
2024-02-12 18:34:48 -05:00
Adam King
0ce0344d43
Merge pull request #55355 from adk3798/cephadm-nvmeof-version-bug
cephadm: fix get_version for nvmeof

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2024-02-12 18:21:25 -05:00
Radoslaw Zarzynski
284e8c43a7
Merge pull request #50422 from rzarzynski/wip-bug-58915
osd: don't send stale hb msgr's addresses in MOSDBoot

Reviewed-by: Laura Flores <lflores@redhat.com>
2024-02-12 20:22:47 +01:00
Ali Maredia
54cae2cebd
Merge pull request #55156 from alimaredia/wip-rgw-add-cap-user-without-keys
rgw: add new cap user-info-without-keys

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-12 13:35:09 -05:00
Radoslaw Zarzynski
b2fcc556a2 fixup: don't store ref-to-on-stack-temporary in RecoveryBackend::coll
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2024-02-12 17:45:01 +00:00
Casey Bodley
4cc75f8f6d
Merge pull request #55487 from cbodley/wip-qa-rgw-hadoop-distro
qa/rgw: hadoop-s3a uses supported-random-distro$

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2024-02-12 17:05:33 +00:00
Casey Bodley
a8739fc186
Merge pull request #55360 from shreyanshjain7174/fix_2252048
RGW: Getting an RGW service Segfault when assigning an attribute to an IAM role.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-12 17:05:02 +00:00
Casey Bodley
3366f5fd5e
Merge pull request #55486 from jzhu116-bloomberg/wip-64340
rgw: do not copy olh attributes in versioning suspended bucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-12 17:04:33 +00:00
Casey Bodley
6430679162
Merge pull request #55458 from tobias-urdin/cors-signature
rgw/auth: ignoring signatures for HTTP OPTIONS calls

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-12 17:03:49 +00:00
Ivo Almeida
48e41aaf4f mgr/dashboard: added subvolume and translations
This commit adds support for subvolume snap scheduling and translations for snap schedule repeat schedules and retention policies

Fixes: https://tracker.ceph.com/issues/64372
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
2024-02-12 17:03:11 +00:00
Yuri Weinstein
6e71bac636
Merge pull request #55347 from lightmelodies/mon
mon: fix health store size growing infinitely

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
2024-02-12 08:05:33 -08:00
Yuri Weinstein
d52417b8d9
Merge pull request #55251 from rzarzynski/wip-bug-64104
tools/cot: respect generic, Ceph-wide argvs

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2024-02-12 08:04:54 -08:00
Zac Dover
aa1e6352d0 doc/glossary: Add link to CRUSH paper
Add a link in the CRUSH definition to the original CRUSH paper.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-02-13 01:06:05 +10:00
Seena Fallah
5999196f37 cephadm: remove restriction for crush device classes
A restriction has been introduced here (6c6cb2f513) which doesn't let OSDs be created with custom crush device classes.
Crush Device Class is the key that helps the crush distinguish between multiple storage classes, so it must accept any custom names.

Fixes: https://tracker.ceph.com/issues/64382
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
2024-02-12 10:47:04 +01:00
Vallari Agrawal
1713c4852c
qa: add qa/tasks/nvmeof.py and rbd/nvmeof_basic_task and fio workunits
This is v2 of the rbd/nvmeof test: It deploys 1 gateway and 1 initiator.
Then does basic verification on nvme commands and runs fio.

This commit creates:
1. qa/tasks/nvmeof.py: adds a new 'Nvmeof' task which deploys
    the gateway and shares config with the initiator hosts.
    Sharing config was previously done by 'nvmeof_gateway_cfg' task
    in qa/tasks/cephadm.py (that task is removed in this commit).
2. qa/workunits/rbd/nvmeof_basic_tests.sh:
    Runs nvme commands (discovery, connect, connect-all, disconnect-all,
    and list-subsys) and does basic verification of the output.
3. qa/workunits/rbd/nvmeof_fio_test.sh:
    Runs fio command. Also runs iostat in parallel if IOSTAT_INTERVAL
    variable is set. This variable configures the delay between each iostat
    print.

nvmeof-cli upgrade from v0.0.6 to v0.0.7 introduced major changes
to all nvmeof commands. This commit changes v0.0.6 commands to
v0.0.7 in qa/workunits/rbd/nvmeof_initiator.sh

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
2024-02-12 13:00:09 +05:30
Aashish Sharma
4a87939b9c
Merge pull request #55467 from rhcs-dashboard/rgw-s3-analytics-grafana-dashboard
mgr/dashboard: Add RGW per user/bucket panels in  grafana


Reviewed-by: Nizamudeen A <nia@redhat.com>
2024-02-12 12:46:48 +05:30
Nizamudeen A
e2b2e038b8
Merge pull request #55494 from ivoalmeida/snapshot-schedule-delete-activate
mgr/dashboard: added delete and activation actions

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2024-02-12 11:58:03 +05:30
Kefu Chai
6c275abe19
Merge pull request #55529 from tchaikov/cmake-cap
cmake: find_package(cap) before linking against it

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-12 09:23:21 +08:00
Ivo Almeida
e0bb711703 mgr/dashboard: added delete and activation actions
Fixes: https://tracker.ceph.com/issues/64355
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
2024-02-11 20:00:24 +00:00
Ronen Friedman
5ad6f16562 doc/osd: update the documentation of several scrub-related options
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-02-11 21:30:05 +02:00
Kefu Chai
ce8c2f3124
Merge pull request #55528 from tchaikov/cmake-boost-debug
cmake: build boost debug variant when CMAKE_BUILD_TYPE is Debug

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-12 00:39:04 +08:00
Casey Bodley
f394e08415
Merge pull request #55199 from igomon-bloomberg/wip-publish-commit-async
rgw/s3-notifications: async commit to persistent notification queue

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2024-02-11 16:15:17 +00:00
Casey Bodley
0151e6a554
Merge pull request #55371 from pritha-srivastava/wip-rgw-correct-err-msg
rgw/auth: correcting the error message to indicate

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-11 16:14:42 +00:00
Casey Bodley
f0de0424d7
Merge pull request #55250 from cbodley/wip-64084
rgw/auth/s3: validate x-amz-content-sha256 for empty payloads

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2024-02-11 16:12:48 +00:00
Ronen Friedman
f912e9045a
Merge pull request #55478 from ronen-fr/wip-rf-update-times
osd: restoring timely collection of PG stats

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2024-02-11 13:25:47 +02:00
Kefu Chai
0de5755531 cmake: find_package(cap) before linking against it
before this change, we link against libcap without finding it. this
works fine as long as libcap-devel or libcap-dev is installed in the
system. but if it is not, the source would fail to build due to missing
`sys/capability.h`. this is not a great developer experience.

in this change, a `Findcap.cmake` is added to find the capability
library. which would fail the build at the configure phase.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2024-02-11 16:57:38 +08:00
Kefu Chai
c7155c3db7 cmake: build boost debug variant when CMAKE_BUILD_TYPE is Debug
boost has some different predefined  build variants. they are quite
like CMake's CMAKE_BUILD_TYPE. in which, "debug" enables some
features related features. so it would be nice if we can have it
enabled for the Debug build, if the boost is built from source.
see also
https://www.boost.org/build/doc/html/bbv2/overview/builtins/features.html

before this change, we always build the "release" variant.  in this
change, "debug" variant is built if Ceph's is built with
CMAKE_BUILD_TYPE=Debug. please note, this change does not change
the way how boost is built when packaging Ceph, as our debian/rpm
receipts do not define CMAKE_BUILD_TYPE and respect the distros'
settings, in that case, the "release" variant is still built.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2024-02-11 15:48:54 +08:00
zdover23
8bbeeb80a5
Merge pull request #55525 from zdover23/wip-doc-2024-02-11-radosgw-55524-rollback
doc/radosgw: undo 55524

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-02-11 00:47:59 +10:00
Zac Dover
284e99ebc6 doc/radosgw: undo 55524
Roll back the docs changes made in
https://github.com/ceph/ceph/pull/55524, in accordance with Casey
Bodley's instructions to me here:
https://github.com/ceph/ceph/pull/55524#issuecomment-1937020543.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-02-11 00:36:29 +10:00
Anthony D'Atri
6c52f1ab47
Merge pull request #55524 from zdover23/wip-doc-2024-02-10-radosgw-lua-scripting-options
doc/radosgw: remove invalid LUA context options
2024-02-10 06:30:41 -05:00
Laura Flores
228dab8510
Merge pull request #55507 from ljflores/wip-tracker-64343 2024-02-09 23:36:21 -06:00
Zac Dover
8bfe2d1ae6 doc/radosgw: remove invalid LUA context options
Remove "background", "getdata", and "putdata" from the list of LUA
context options. Passing these options throws the following error:
"ERROR: invalid script context: background. must be one of: preRequest,
postRequest".

Fixes: https://tracker.ceph.com/issues/64327

Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-02-10 13:14:59 +10:00
Laura Flores
00fc7960f6 qa/suites/orch: whitelist warnings that are expected in test environments
Fixes: https://tracker.ceph.com/issues/64343
Signed-off-by: Laura Flores <lflores@ibm.com>
2024-02-09 13:52:47 -06:00
Casey Bodley
692c2e4d55 rgw/datalog: RGWDataChangesLog::add_entry() uses null_yield
work around a deadlock under RGWDataChangesLog::add_entry() with
multi-object delete by making the push() call synchronous

this is a partial revert of d38a69b6e1

Fixes: https://tracker.ceph.com/issues/63373

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-09 13:38:51 -05:00
Casey Bodley
3e6e36c9cc test/rgw: add multisite test case for DeleteObjects
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-09 12:49:10 -05:00
J. Eric Ivancich
575362d826 rgw: if head object does not have data, still include in object manifest
In order to enable users who might like to use `radosgw-admin object
manifest ...` to get a complete list of raw objects that comprise the
RGW object, we'll include the head object when it includes not
data. It will be indicated with an "index" of -1.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2024-02-09 12:47:15 -05:00
J. Eric Ivancich
cd068b831d rgw: add new object manifest sub-command
Adds a new sub-command to radosgw-admin to list the manifest, which
are the rados objects that contain the RGW object's data.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2024-02-09 11:22:35 -05:00
Aashish Sharma
a572a0c167 mgr/dashboard: Add RGW per user/bucket panels in grafana
Fixes: https://tracker.ceph.com/issues/64359

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2024-02-09 21:14:27 +05:30
Kefu Chai
f8e4e33149
Merge pull request #53521 from xxhdx1985126/wip-62857
crimson/osd/replicated_backend: don't put pg's metadata updates in repops

Reviewed-by: Samuel Just <sjust@redhat.com>
2024-02-09 23:11:18 +08:00
Adam Kupczyk
0855adb8fd
Merge pull request #54650 from pereman2/buffer_map-noptr
os/bluestore: use buffer values instead of pointers in buffer_map
2024-02-09 16:07:17 +01:00
Casey Bodley
463f463d50 rgw/user: add 'active' flag to RGWAccessKey
inactive keys are removed from the key pool so can't be used to
authenticate. the 'key create' admin op now takes an 'active' option

Fixes: https://tracker.ceph.com/issues/59186

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-02-09 09:23:08 -05:00
Ronen Friedman
d706cecb41 osd: no 'legacy' form for two configuration options
also - fixing review comments not addressed in the original PR.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-02-09 04:14:10 -06:00
Ronen Friedman
d828847b51 osd: restoring timely collection of PG stats
500 seconds is way too long, e.g. when compared to the 5s
default configuration option for the manager collection of the OSD data.

Fixes tracker issue 53342 note 5 (a specific scenario leading
to 'not all pgs scrubbed')

Fixes: https://tracker.ceph.com/issues/53342 - partial fix

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-02-09 04:14:10 -06:00
Nizamudeen A
ff6d095713
Merge pull request #55462 from afreen23/fix-64270
mgr/dashboard: fix error while accessing roles tab when policy attached

Reviewed-by: Nizamudeen A <nia@redhat.com>
2024-02-09 12:35:47 +05:30
Aishwarya Mathuria
56c681c39a osd: Remove check on osd_pg_delete_cost change
With the new cost estimation technique, we don't need osd_pg_delete_cost to be hard-coded to one particular value.
Hence we can now remove the check we had previously added to prevent users from modifying deletion cost with mClock.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2024-02-09 07:01:35 +00:00