Commit Graph

141577 Commits

Author SHA1 Message Date
Rishabh Dave
5d471c2712
Merge pull request #54308 from rishabh-d-dave/mgr-vol-flake-warnings
mgr/vol: fix flake8 warnings

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2023-11-30 00:49:28 +05:30
Adam King
f82d87980d
Merge pull request #54424 from phlogistonjohn/jjm-cephadm-daemon-to-container
cephadm: add a more generic daemon_to_container function

Reviewed-by: Adam King <adking@redhat.com>
2023-11-29 13:48:46 -05:00
Casey Bodley
090e92a18d
Merge pull request #54619 from cbodley/wip-rgw-sal-get-stats-async
rgw/sal: clean up read_stats_async() callbacks

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-11-29 16:24:26 +00:00
Adam King
d58c7d0c08
Merge pull request #54582 from phlogistonjohn/jjm-cephadm-more-template-error
cephadm: add a custom template not found exception with diagnostic info

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2023-11-29 10:55:54 -05:00
Casey Bodley
67ffb05d71
Merge pull request #54618 from alimaredia/wip-remove-vstart-runner-radosgw-admin-task
qa: remove vstart runner from radosgw_admin task

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-11-29 15:18:57 +00:00
Ronen Friedman
94e40c80f3
Merge pull request #54578 from ronen-fr/wip-rf-dedup-clang
tools: modify ceph_dedup_tool to maintain Clang 15 compatibility

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2023-11-29 15:39:37 +02:00
Venky Shankar
58e7e13214
Merge pull request #48483 from batrick/i48673
mds: revert standby-replay trimming changes

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-29 15:43:54 +05:30
Matan Breizman
3d760f113b
Merge pull request #54287 from Matan-B/wip-matanb-crimson-do_osd_ops_execute-v3
crimson/osd: execute `submit_error_log` as an ExclusivePhase

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-11-29 10:13:41 +02:00
Vallari Agrawal
b896bebf38
Merge pull request #54209 from VallariAg/wip-xml-scanner
qa: use Remote.run_unit_test and ValgrindScanner
2023-11-29 12:21:02 +05:30
zdover23
a0312323e6
Merge pull request #54685 from zdover23/wip-doc-2023-11-28-rados-tshooting-log-and-debug-small-repair
doc/rados: improve "Ceph Subsystems"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-11-29 05:39:10 +01:00
zdover23
ff796bfe73
Merge pull request #54684 from zdover23/wip-doc-2023-11-28-rados-ops-pgs-typo
doc/rados: ops/pgs: s/power of 2/power of two

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-11-29 05:34:43 +01:00
Zac Dover
7bca5f57cc doc/rados: improve "Ceph Subsystems"
Improve the English in the subsection "Ceph Subsystems" in the section
"Subsystem, Log and Debug Settings" [sic] in
doc/rados/troubleshooting/log-and-debug.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-11-29 03:01:53 +01:00
Zac Dover
ca81963321 doc/rados: ops/pgs: s/power of 2/power of two
Change "power of 2" to "power of two" in
doc/rados/operations/placement-groups.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-11-29 02:50:29 +01:00
Daniel Gryniewicz
785c1083fa
Merge pull request #51229 from jsoref/spelling-rgw
rgw: Fix spelling
2023-11-28 09:38:01 -05:00
Venky Shankar
b9b6c42eed
Merge pull request #53456 from petrutlucian94/dokan_case_insensitive
dokan: simple case insensitive emulation

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-28 19:28:20 +05:30
Ali Maredia
a44fd94b96 qa: remove vstart runner from radosgw_admin task
Fixes: https://tracker.ceph.com/issues/63583

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2023-11-28 02:58:49 -05:00
Casey Bodley
1f34c2706d
Merge pull request #54621 from cbodley/wip-rgw-posix-warning
rgw/posix: fix unused variable warning

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-11-27 17:16:05 +00:00
Josh Soref
ed70d843df rgw: fix spelling errors
* access
* acquire
* across
* algorithm
* alternatively
* ambiguous
* attributes
* authenticated
* automatically
* based
* between
* beware
* bootstrap
* bucket
* cache
* character
* check
* cleanup
* combinations
* committed
* comparison
* compatibility
* concurrent
* conditions
* conjunction
* connections
* considered
* contains
* correct
* creates
* crypto
* dependencies
* dequeued
* dequeuing
* derivative
* described
* determine
* deterministic
* detritus
* discrepancy
* display
* either way
* elements
* entirely
* entries
* error
* everything
* expected
* explicitly
* extend
* false
* fclose
* feature
* following
* foreign
* format
* forward
* functionality
* functions
* generated
* getting
* gracefully
* happened
* hashicorp
* healthcheck
* hierarchy
* however
* http
* identify
* idleness
* ignored
* incremental
* information
* initialization
* length
* locally
* macros
* malformed
* means
* mechanism
* multipart
* multiple
* must
* namespace
* necessary
* nonexistent
* notifications
* occurred
* official
* outputs
* outputted
* overridden
* ownership
* parallelism
* partition
* passthrough
* pause
* penguin
* perform
* permission
* populated
* position
* preferably
* prefixes
* presumably
* previous
* print
* quadruple
* reference
* regardless
* registry
* renewed
* request
* requires
* reshard
* resource
* result to
* satisfy
* secret
* separate
* separator
* setting
* shouldn't
* skipping
* some
* somehow
* something
* specific
* struct
* succeeded
* success
* successful
* successfully
* syntax
* testing
* truncated
* unambiguously
* unittest
* unmodified
* unnecessary
* valid_action
* verifying
* versioning
* visible
* whatever
* whenever

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-11-27 10:27:32 -05:00
Josh Soref
82ec01e208 rgw: rewrite rgw_admin help text
* The line wrapping was fairly random.
* There were cases where words appeared to be doubled.
  - In fact one was an argument
  - the other was the start of the help text.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-11-27 10:26:58 -05:00
Casey Bodley
f6bc1a8ef8
Merge pull request #54626 from cbodley/wip-cmake-rocksdb-uring
cmake/rocksdb: make sure dependencies build before rocksdb

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-11-27 14:20:31 +00:00
Nizamudeen A
68ab0ed81a
Merge pull request #54531 from rhcs-dashboard/port-manipulation-rgw
mgr/dashboard: get rgw port from ssl_endpoint

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-11-27 17:48:33 +05:30
Ali Masarwa
c51a3bff0a
Merge pull request #54459 from AliMasarweh/wip-alimasa-2pc-remove-issue
RGW: make new rados support old RGW 2pc remove

Reviewed-by: yuvalif, cbodley
2023-11-27 12:43:46 +02:00
zdover23
83001860de
Merge pull request #54664 from zdover23/wip-doc-2023-11-27-rados-troubleshooting-troubleshooting-mon-everything-failed
doc/rados: edit "Everything Failed! Now What?"

Reviewed-by: Antony D'Atri <anthony.datri@gmail.com>
2023-11-27 15:57:01 +10:00
Zac Dover
d8cd49259d doc/rados: edit "Everything Failed! Now What?"
Edit the section "Everything Failed! Now what?" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthoy D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-11-27 06:27:28 +01:00
Ali Masarwa
855098f191 RGW: make new rados support old RGW 2pc remove
Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
2023-11-26 21:57:51 +02:00
Kefu Chai
e577734645
Merge pull request #53290 from ThomasLamprecht/debian-fix-ceph-mgr-requires
debian: add missing bcrypt to ceph-mgr .requires to fix resulting package dependencies

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2023-11-26 16:28:55 +08:00
zdover23
e989e5729b
Merge pull request #54656 from zdover23/wip-doc-2023-11-25-rados-troubleshooting-mon-mon-store-failures-1-of-x
doc/rados: edit "monitor store failures"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-11-26 14:04:20 +10:00
Thomas Lamprecht
adc501c2ce debian: add missing bcrypt to manager .requires
The `ceph-mgr` package lost its dependency on `python3-bcrypt` when
the dependencies got moved from d/control to a dh_python3 compatible
requires file. Add it again as the bcrypt module is still used there.

Otherwise one gets errors when, e.g., calling `ceph -s` after a fresh
installation:

> 13 mgr modules have failed dependencies
> Module 'balancer' has failed dependency: No module named 'bcrypt'
> Module 'crash' has failed dependency: No module named 'bcrypt'
> Module 'devicehealth' has failed dependency: No module named 'bcrypt'
> Module 'iostat' has failed dependency: No module named 'bcrypt'
> Module 'nfs' has failed dependency: No module named 'bcrypt'
> Module 'orchestrator' has failed dependency: No module named 'bcrypt'
> Module 'pg_autoscaler' has failed dependency: No module named 'bcrypt'
> Module 'progress' has failed dependency: No module named 'bcrypt'
> Module 'rbd_support' has failed dependency: No module named 'bcrypt'
> Module 'restful' has failed dependency: No module named 'bcrypt'
> Module 'status' has failed dependency: No module named 'bcrypt'
> Module 'telemetry' has failed dependency: No module named 'bcrypt'
> Module 'volumes' has failed dependency: No module named 'bcrypt'

Fixes: https://tracker.ceph.com/issues/63637
Fixes: ef19547e83 ("debian: add .requires for specifying python3 deps")
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-11-25 12:59:55 +01:00
Zac Dover
0a1ce00168 doc/rados: edit "monitor store failures"
Edit the section "Monitor Store Failures" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-11-25 16:50:32 +10:00
zdover23
68e0d99aa0
Merge pull request #54625 from zdover23/wip-doc-2023-11-23-rados-troubleshooting-mon-client-cant-connect
doc/rados: edit "client can't connect..."

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2023-11-25 07:06:53 +10:00
Yuval Lifshitz
213923165c
Merge pull request #52931 from yuvalif/wip-yuval-lua-teuthology
rgw/test/lua: add lua integration tests suite

reviewed-by: TRYTOBE8TME, cbodley
2023-11-24 11:38:51 +02:00
Yuval Lifshitz
6a42ec5435
Merge pull request #54637 from yuvalif/wip-yuval-62136
rgw/test/kafka: let consumer read events from the beginning

reviewed-by: thotz
2023-11-24 11:36:03 +02:00
Casey Bodley
2c43e1d3aa
Merge pull request #54516 from cbodley/wip-63537
rgw: object lock avoids 32-bit truncation of RetainUntilDate

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-11-24 02:47:55 +00:00
Casey Bodley
b33e08657e encoding: use concepts for chrono encoding
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-11-23 19:16:38 -05:00
Casey Bodley
1fd4309fbb rgw: object lock uses 64-bit encoding for RetainUntilDate
the default encoding of ceph::real_time truncates seconds to uint32_t,
so stores the wrong timestamp for object lock enforcement

Fixes: https://tracker.ceph.com/issues/63537

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-11-23 19:16:38 -05:00
Casey Bodley
b7aa16da4b encoding: add round_trip_encode()/decode() for chrono types
the default encodings for chrono types were made to be
backward-compatible with utime_t, so truncated seconds to 32 bits

adds new functions that encode these chrono types using their underlying
representation, which for ceph::real_time and ceph::timespan is
'nanoseconds as uint64_t'

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-11-23 19:16:38 -05:00
Casey Bodley
54eec5bf8f
Merge pull request #54600 from cbodley/wip-rgw-period-realm-name-encode
rgw: fix RGWPeriod encoding after removing realm_name

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2023-11-24 00:15:53 +00:00
Casey Bodley
424b794bd1
Merge pull request #54297 from linuxbox2/wip-librgw-tcmalloc
rgw: link only radosgw with ALLOC_LIBS

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-11-24 00:15:02 +00:00
Casey Bodley
55d5116d64
Merge pull request #53504 from davidhall586/Bug62105
rgw: SignatureDoesNotMatch for certain RGW Admin Ops endpoints w/v4 auth

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-11-24 00:14:08 +00:00
Casey Bodley
e342927ec9
Merge pull request #50148 from cbodley/wip-58750
rgw: Head/GetObject support partNumber

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-11-24 00:13:17 +00:00
Casey Bodley
ac7e285fb4
Merge pull request #50790 from jzhu116-bloomberg/wip-51772
rgw/swift: preserve dashes/underscores in swift user metadata names

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-11-24 00:10:01 +00:00
Jane Zhu
a4553f0351 rgw: fix the ret cond check CreateBucket::Execute()
Signed-off-by: Juan Zhu <jzhu4@dev-10-34-20-139.pw1.bcc.bloomberg.com>
2023-11-23 17:40:30 -05:00
Ali Maredia
0540cc65ef rgw: modify ret cond in middle of CreateBucket::Execute()
Return prevents swift metadata from being removed
if bucket already exists.

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2023-11-23 17:40:30 -05:00
Jane Zhu
72065c9c71 rgw/swift: convert underscores to hyphens in swift user metadata names
Signed-off-by: Juan Zhu <jzhu4@dev-10-34-20-139.pw1.bcc.bloomberg.com>
2023-11-23 17:40:28 -05:00
Jane Zhu
96ca98a169 rgw/swift: preserve dashes/underscores in swift user metadata names
Signed-off-by: Juan Zhu <jzhu116@bloomberg.net>
2023-11-23 17:40:04 -05:00
Anthony D'Atri
f232219159
Merge pull request #54641 from likid0/ceph_session_tags_fixes
doc/radosgw: Fix JSON typo in Principal Tag example code snippet
2023-11-23 17:38:42 -05:00
Daniel Parkes
68729c951d doc/radosgw: Fix JSON typo in Principal Tag example code snippet
Signed-off-by: Daniel Parkes <dparkes@redhat.com>
2023-11-23 22:15:52 +01:00
Casey Bodley
9b1aed0838 rgw/quota: remove base class AsyncRefreshHandler
instead of using a virtual `allocate_refresh_handler()` to create an
object to call the virtual `AsyncRefreshHandler::init_fetch()` on, just
provide one virtual `init_refresh()` to start the operation. this avoids
the need for `AsyncRefreshHandler` altogether

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-11-23 14:47:15 -05:00
Casey Bodley
24de70f597 rgw/quota: use intrusive_ptr for RefCountedWaitObject
instead of relying on async_refresh_response/fail to manage ref counts
manually, just stash an intrusive_ptr in AsyncRefreshHandler for the
duration of the async operation

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-11-23 14:47:14 -05:00
Casey Bodley
131d49a985 cls/rgw: cls_bucket_head_async uses intrusive_ptr for RGWGetDirHeader_CB
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-11-23 14:47:08 -05:00