Commit Graph

132794 Commits

Author SHA1 Message Date
Guillaume Abrioux
5a10e3e9e8 ceph-volume: fix simple scan
When the class `Device` is instantiated with a path instead of a
block device, it fails like following.

```
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/ceph_volume/util/device.py", line 130, in __init__
    self._parse()
  File "/usr/lib/python3.6/site-packages/ceph_volume/util/device.py", line 233, in _parse
    self.ceph_device = disk.has_bluestore_label(self.path)
  File "/usr/lib/python3.6/site-packages/ceph_volume/util/disk.py", line 906, in has_bluestore_label
    with open(device_path, "rb") as fd:
IsADirectoryError: [Errno 21] Is a directory: '/var/lib/ceph/osd/ceph-0/'
```

passing a path instead of a block device is valid, `simple scan` needs it.

Fixes: https://tracker.ceph.com/issues/56969

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-29 16:15:08 +02:00
zdover23
5515138425
Merge pull request #47347 from anthonyeleven/anthonyeleven/essthree
doc/radosgw: Uppercase s3

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2022-07-29 19:03:37 +10:00
Anthony D'Atri
73f0d5707d doc/radosgw: Uppercase s3
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-07-29 00:11:22 -07:00
Nizamudeen A
1e46a223c1
Merge pull request #47260 from rhcs-dashboard/fix-frontend-monitor-port-fields
mgr/dashboard: add required validation for frontend and monitor port

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-07-29 12:37:01 +05:30
Anthony D'Atri
ac0e45656e
Merge pull request #47284 from anthonyeleven/anthonyeleven/prom-localrules-tweaks
monitoring/ceph-mixin: clean up prometheus_alerts.yml
2022-07-29 00:06:06 -07:00
Liu-Chunmei
e55f8fe637
Merge pull request #47328 from liu-chunmei/crimson-cmpext
crimson: for cmp_fail error, return -MAX_ERRNO-index

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-07-28 20:06:47 -07:00
Anthony D'Atri
9b65974468 monitoring/ceph-mixin: clean up prometheus_alerts.yml
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-07-28 19:17:51 -07:00
Yingxin
a73b295d6b
Merge pull request #47291 from cyx1231st/wip-seastore-journal-head
crimson/os/seastore: fixes to trimming

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-07-29 09:31:19 +08:00
Kefu Chai
8a0832701c
Merge pull request #47275 from myoungwon/wip-rbm-cleanup
seastore: RBM clean-ups

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-07-29 08:10:22 +08:00
chunmei-liu
895188987d crimson: for cmp_fail error, return -MAX_ERRNO-index
instead of cmp_fail error code.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-07-28 16:59:15 -07:00
Casey Bodley
c5975ce85b
Merge pull request #47308 from mdw-at-linuxbox/wip-master-implanon
rgw: better tenant id from the uri on anonymous access

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2022-07-28 17:38:28 -04:00
Guillaume Abrioux
483c7e22e6
Merge pull request #47170 from guits/dep-dev-inventory
ceph-volume: report slave devices in inventory
2022-07-28 22:19:31 +02:00
Guillaume Abrioux
1274ba34b4 ceph-volume/tests: migrate to pyfakefs
ceph-volume unit tests shouldn't actually create contents on the
filesystem from where it runs (even though they are written in a tmp
dir), let's use pyfakefs.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-28 20:14:06 +02:00
Guillaume Abrioux
7ab9d99420 ceph-volume/tests: fix test_path_is_valid()
When ceph-volume tests are run from a host where there's no `/dev/sda`
device, this test fails.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-28 20:14:06 +02:00
Guillaume Abrioux
1ac2a8270c ceph-volume: report slave devices in inventory
`ceph-volume inventory` currently reports the following:

```

Device Path               Size        rotates available Model name
/dev/mapper/mpatha        50.00 GB    True    True
/dev/mapper/mpathaa       6.00 GB     True    True
/dev/mapper/mpathab       6.00 GB     True    True
/dev/mapper/mpathac       6.00 GB     True    True
/dev/mapper/mpathad       6.00 GB     True    True
/dev/mapper/mpathae       6.00 GB     True    True
```

whereas something like following would be useful:

```

Device Path               Size         Device nodes    rotates available Model name
/dev/mapper/mpatha        50.00 GB     sdf,sde         True    True
/dev/mapper/mpathaa       6.00 GB      sdbe,sdat       True    True
/dev/mapper/mpathab       6.00 GB      sdav,sdbf       True    True
/dev/mapper/mpathac       6.00 GB      sdbb,sdbl       True    True
/dev/mapper/mpathad       6.00 GB      sdas,sdbc       True    True
/dev/mapper/mpathae       6.00 GB      sdax,sdbh       True    True
```

Fixes: https://tracker.ceph.com/issues/56624

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-28 20:14:06 +02:00
Guillaume Abrioux
306325a256
Merge pull request #47169 from guits/improve-mpath-reporting
ceph-volume: improve mpath devices reporting
2022-07-28 20:11:30 +02:00
Guillaume Abrioux
3bf846a76e
Merge pull request #46893 from guits/ceph-volume-symlinks-guits
ceph-volume: allow symlinks as devices
2022-07-28 20:11:03 +02:00
Kefu Chai
9a8f20f42e
Merge pull request #47310 from tchaikov/ceph-context-formatting
common/ceph_context: fix the formatting

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-07-28 22:39:33 +08:00
Pere Diaz Bou
473d46161d
Merge pull request #46996 from rhcs-dashboard/html-injection-bug
mgr/dashboard: added pattern validaton for form input

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-07-28 09:38:41 +02:00
Ronen Friedman
18206817b9
Merge pull request #46970 from ronen-fr/wip-rf-unlocked-logs
osd/scrub: pre-prepare the description text of the current state

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-07-28 08:48:37 +03:00
zdover23
89409d6fb8
Merge pull request #46024 from sirtoobii/patch-2
doc/radosgw/STS: sts_key and user capabilities

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2022-07-28 14:38:28 +10:00
myoungwon oh
c4fedd1901 seastore/rbm: rename nvme_device to random_block_device
rename nvme_device namespace to random_block_device, and
introduce random_block_device::nvme

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-07-28 13:27:44 +09:00
Kefu Chai
f362941446
Merge pull request #44039 from richael02/update-isal-crypto-source
.gitmodules: update isa-l_crypto source address

Reviewed-by: Yibo Cai <yibo.cai@arm.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 10:29:28 +08:00
Adam King
eed140c259
Merge pull request #46420 from pcuzner/add-disk-rescan
mgr/cephadm: Add disk rescan feature to the orchestrator

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-07-27 19:50:59 -04:00
Kefu Chai
da14b005b0
Merge pull request #47286 from tchaikov/wip-fmt-ranges
osd: use fmt/ranges.h for printing ranges

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-07-28 07:50:43 +08:00
Adam King
3f1f862b9c
Merge pull request #46883 from adk3798/custom-config
mgr/cephadm: support for miscellaneous config files for daemons

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-07-27 19:49:44 -04:00
Adam King
dae8b562b8
Merge pull request #46955 from hookak/monitoring-stack
cephadm: Add promtail and loki when bootstrap

Reviewed-by: Adam King <adking@redhat.com>
2022-07-27 19:48:09 -04:00
Adam King
257d259e28
Merge pull request #47088 from adk3798/cephadm-logging
cephadm: reduce spam to cephadm.log

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-07-27 19:47:16 -04:00
Kefu Chai
a49a475403 common/ceph_context: fix the formatting
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:46:55 +08:00
Adam King
6c795c597a
Merge pull request #47178 from adk3798/logrotate-owner
cephadm: add "su root root" to cephadm.log logrotate config

Reviewed-by: Guillaume Abrioux gabrioux@redhat.com
2022-07-27 19:46:04 -04:00
Kefu Chai
d3a7e5e564
Merge pull request #46618 from aclamk/wip-dout-for-alien
crimson/alienstore: Add douts

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-07-28 07:45:39 +08:00
Adam King
f1cbe5225e
Merge pull request #47269 from adk3798/fix-repo-test
qa/workunits/cephadm: update test_repos master -> main

Reviewed-by: Guillaume Abrioux gabrioux@redhat.com
2022-07-27 19:45:11 -04:00
Richael Zhuang
4ad4e1fbc7 .gitmodules: update isa-l_crypto source address
Update address to https://github.com/intel/isa-l_crypto for it's
moved under intel repo.

Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
2022-07-28 07:41:26 +08:00
Kefu Chai
65307131e4
Merge pull request #44499 from SMIL-Infra/fix-missed-lease-ack
osd/PeeringState: fix missed recheck_readable from laggy

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:40:09 +08:00
Kefu Chai
f9aaf7fe15
Merge pull request #45135 from lmlg/fix-32-bit
rgw,test: Fix build errors in 32 bit platforms

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-07-28 07:39:00 +08:00
Kefu Chai
d7fe19d05b
Merge pull request #43005 from wxypro/timeout_conn_msg_opt
msg: Add target_addr to log when connections timed out

Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-07-28 07:38:14 +08:00
Kefu Chai
98c074a93f
Merge pull request #44040 from richael02/update-isal-crypto-version
crypto: update isa-l_crypto version

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:34:59 +08:00
Kefu Chai
9b76560557
Merge pull request #44762 from Zhiwei-Dai/wip-zlib-compressor-isal-for-aarch64
compressor/zlib: isa-l optimization for zlib algorithm on aarch64

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-07-28 07:34:04 +08:00
Marcus Watts
b5880caa50 rgw: better tenant id from the uri on anonymous access
When anonymous tries access public bucket, it gets 404,
because rgw doesn't check tenant correctly.

A previous fix for this broke legacy implicit tenants,
because it didn't check for anonymous access.  This version
restricts its behavior to the anonymous user.

Fixes: https://tracker.ceph.com/issues/48001 https://tracker.ceph.com/issues/48382

Original fix by
Author: Rafał Wądołowski <rafal@rafal.net.pl>
Signed-off-by: Rafał Wądołowski <rwadolowski@cloudferro.com>

This fix
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2022-07-27 16:59:47 -04:00
Jan Sobczak
9ddc5b7737 ceph-volume: support symlinks as devices
This makes ceph-volume support passing symlinks as devices.

Fixes: https://tracker.ceph.com/issues/49103

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-27 16:48:53 +02:00
Guillaume Abrioux
01112ba689 ceph-volume: drop self.abspath in Device()
seems useless to have both self.path and self.abspath attributes.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-27 16:41:26 +02:00
Guillaume Abrioux
e439ada4c2
Merge pull request #47167 from guits/drop-bs-tool-call
ceph-volume: drop `ceph-bluestore-tool` call in Device._parse()
2022-07-27 16:34:08 +02:00
myoungwon oh
92ca9c082c seastore/rbm: rename works
1. rename NVMeBlockDevice to RBMDevice
2. rename PosixNVMeDevice to NVMeBlockDevice

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-07-27 21:09:30 +09:00
Yingxin
78a23ebcad
Merge pull request #47290 from aisakaki/wip-omap-clear
crimson/os/seastore/omap: remove unnecessary extent loads when clearing

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2022-07-27 17:54:30 +08:00
Yingxin Cheng
133b1f83f8 crimson/os/seastore: set tail to the last-known journal head under the full trim
Rather than setting to the start_seq of the current record during replay
time.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-07-27 16:24:06 +08:00
Yingxin Cheng
d4c80b9a1b crimson/os/seastore/async_cleaner: abort when the alloc_tail goes backwards
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-07-27 16:22:12 +08:00
Yingxin Cheng
db7a484eb2 crimson/os/seastore: distinguish from commit-time and submit-time sequences
Also, the committed journal head should be updated atomically with the
rest of the complete-commit logics.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-07-27 16:20:40 +08:00
Guillaume Abrioux
24899a1f8d ceph-volume: fix is_ceph_disk_member()
`dev['NAME']` can't match `part` given that it's the name of the
parent device being compared to the partition name.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-07-27 09:59:16 +02:00
Ronen Friedman
0ebb32213a osd/scrub: pre-prepare the description text of the current state
The existing code accesses the states of the scrub FSM via the
standard "state iterator", which is definitely not thread-safe.
It is also a bit time consuming.

As it happened, new code that tried to create the state string
while not holding the PG lock - crashed the OSD.
This PR changes the relevant lines to allow for safe and fast
access to the state description text.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2022-07-27 05:48:07 +00:00
myoungwon oh
163b51f2ef seastore/rbm: rename NVMeManager to BlockRBManager
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-07-27 14:24:36 +09:00