This reverts 693bd23851, which was
added in response to http://tracker.ceph.com/issues/18126. But
we updated the Ubuntu packages in sepia so it should be good to go.
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Instead of using a string, use the defined CEPH_RELEASE_* values. This
is simpler.
We allow decoding of post-kraken pre-luminous maps that use the string
values.
Signed-off-by: Sage Weil <sage@redhat.com>
The assembly file name suffix was changed from .S to .s,
which caused a build break on ppc64le architecture.
To fix this issue, the suffix will be changed back to .S
for ppc64le assembly files only. The x86 assembly files
can retain the .s suffix.
Fixes: http://tracker.ceph.com/issues/20106
Signed-off-by: Andrew Solomon <asolomon@us.ibm.com>
There were lot of commented code inside src/test/old/testcrush.cc. This was found while doing
the PR#15364. Removed them.
Signed-off-by: Jos Collin <jcollin@redhat.com>
build/ops: conditionalize rgw Beast frontend so it isn't built on s390x architecture
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Kefu Chai <kchai@redhat.com>
The following warning appears during make:
ceph/src/test/msgr/test_msgr.cc: In member function ‘virtual void MessengerTest_MarkdownTest_Test::TestBody()’:
ceph/src/test/msgr/test_msgr.cc:1474:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
CHECK_AND_WAIT_TRUE(srv_dispatcher.count > last + 1);
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
ceph/src/test/msgr/test_msgr.cc:54:9: note: in definition of macro ‘CHECK_AND_WAIT_TRUE’
if (expr) \
^~~~
ceph/src/test/msgr/test_msgr.cc:1475:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (srv_dispatcher.count == last) {
~~~~~~~~~~~~~~~~~~~~~^~~~~~~
Signed-off-by: Jos Collin <jcollin@redhat.com>
The following warning appears during make:
ceph/src/test/test_denc.cc:669:5: required from here
ceph/src/googletest/googletest/include/gtest/gtest.h:1530:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
ceph/src/googletest/googletest/include/gtest/gtest.h:1510:7:
if (val1 op val2) {\
Signed-off-by: Jos Collin <jcollin@redhat.com>
In particular, we want the attrs (map<string,bufferptr>) to be a deep
decode so that we do not pin this buffer, and so that any changed attr
will free the previous memory.
Signed-off-by: Sage Weil <sage@redhat.com>
Otherwise we can assert out when we try to join a thread that
hasn't started.
- move everything into _kv_start() and _kv_stop()
- separate stop bools for each thread
- wait until thread starts before signalling stop (and potentially calling
join()).
Signed-off-by: Sage Weil <sage@redhat.com>
_deferred_replay needs the kv_sync_thread to complete IOs; start them
just for that, but then shut them down again. (We might revisit that
later if/when fsck does any sort of repair.)
Signed-off-by: Sage Weil <sage@redhat.com>
