RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-23 19:17:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
128,355 Commits 216 Branches 395 Tags 1.4 GiB
58cb9bace4
Commit Graph

128355 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kefu Chai
58cb9bace4 crimson/osd: s/seastar::fprint()/fmt::print()/ 
otherwise, we'd have warnings like:

./src/crimson/osd/main.cc:106:16: error: 'fprint<const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > &>' is deprecated: use std::format_to() or fmt::print() [-Werror,-Wdeprecated-declarations]
      seastar::fprint(std::cerr, "already have key in keyring: %s\n", path);
               ^

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
 2021-12-08 15:39:49 +08:00
Kefu Chai
918eef4f61 seastar: pick up change to fix FTBFS with old cryptopp 
Signed-off-by: Kefu Chai <kefu@xsky.com>
 2021-12-08 14:53:08 +08:00
Kefu Chai
b03d3d9165
Merge pull request #44147 from rzarzynski/wip-crimson-new-seastar 
crimson: bump up Seastar to recent master and fix FTBFS

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
 2021-12-08 08:56:11 +08:00
Neha Ojha
3304a82bfd
Merge pull request #44095 from Matan-B/wip-matanb-local-workunits 
doc/dev: Running workunits locally

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
 2021-12-07 13:34:15 -08:00
Yuval Lifshitz
365bfd1437
Merge pull request #43940 from TRYTOBE8TME/wip-rgw-empty-config 
src/rgw: Empty configuration support
 2021-12-07 21:20:33 +02:00
Yuval Lifshitz
a2d9f222bb
Merge pull request #43665 from zenomri/wip-omri-multipart-trace 
rgw/tracer: Multipart upload trace
 2021-12-07 21:19:27 +02:00
Samuel Just
0ded1b2b6a
Merge pull request #44156 from rzarzynski/wip-crimson-fix-process_op-sequencing 
crimson/osd: fix sequencing issues in ClientRequest::process_op.

Reviewed-by: Samuel Just <sjust@redhat.com>
 2021-12-07 07:53:21 -08:00
Samuel Just
d029e2e989
Merge pull request #44223 from rzarzynski/wip-crimson-fix-pullinfo-on-push 
crimson/osd: don't assume a pull must happen if there is no push.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
 2021-12-07 07:52:41 -08:00
Samuel Just
d4ad98c15f
Merge pull request #44224 from rzarzynski/wip-crimson-clean-msghs 
crimson/osd: clean the recovery message-related header inclusion.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
 2021-12-07 07:52:02 -08:00
Samuel Just
b7dfff6cf1
Merge pull request #44184 from rzarzynski/wip-crimson-internal_client_request-fix-hobj 
crimson/osd: fix assertion failure in InternalClientRequest.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
 2021-12-07 07:49:08 -08:00
Alfonso Martínez
6628f444b3
Merge pull request #44145 from rhcs-dashboard/fix-frontend-vulnerabilities 
mgr/dashboard: fix frontend deps' vulnerabilities

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
 2021-12-07 15:02:42 +01:00
Radoslaw Zarzynski
be0ba67623 crimson/osd: fix sequencing issues in ClientRequest::process_op. 
The following crash has been observed in one of the runs at Sepia:

```
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8898-ge57ad63c/rpm/el8/BUILD/ceph-17.0.0-8898-ge57ad63c/src/crimson/osd/osd_operation_sequencer.h:123: void crimson::osd::OpSequencer::finish_op_in_order(crimson::osd::ClientRequest&): Assertion `op.get_id() > last_completed_id' failed.
Aborting on shard 0.
Backtrace:
Reactor stalled for 1807 ms on shard 0. Backtrace: 0xb14ab 0x46e57428 0x46bc450d 0x46be03bd 0x46be0782 0x46be0946 0x46be0bf6 0x12b1f 0x137341 0x3fdd6a92 0x3fddccdb 0x3fdde1ee 0x3fdde8b3 0x3fdd3f2b 0x3fdd4442 0x3fdd4c3a 0x12b1f 0x3737e 0x21db4 0x21c88 0x2fa75 0x3b769527 0x3b8418af 0x3b8423cb 0x3b842ce0 0x3b84383d 0x3a116220 0x3a143f31 0x3a144bcd 0x46b96271 0x46bde51a 0x46d6891b 0x46d6a8f0 0x4681a7d2 0x4681f03b 0x39fd50f2 0x23492 0x39b7a7dd
 0# gsignal in /lib64/libc.so.6
 1# abort in /lib64/libc.so.6
 2# 0x00007FB9FB946C89 in /lib64/libc.so.6
 3# 0x00007FB9FB954A76 in /lib64/libc.so.6
 4# 0x00005595E98E6528 in ceph-osd
 5# 0x00005595E99BE8B0 in ceph-osd
 6# 0x00005595E99BF3CC in ceph-osd
 7# 0x00005595E99BFCE1 in ceph-osd
 8# 0x00005595E99C083E in ceph-osd
 9# 0x00005595E8293221 in ceph-osd
10# 0x00005595E82C0F32 in ceph-osd
11# 0x00005595E82C1BCE in ceph-osd
12# 0x00005595F4D13272 in ceph-osd
13# 0x00005595F4D5B51B in ceph-osd
14# 0x00005595F4EE591C in ceph-osd
15# 0x00005595F4EE78F1 in ceph-osd
16# 0x00005595F49977D3 in ceph-osd
17# 0x00005595F499C03C in ceph-osd
18# main in ceph-osd
19# __libc_start_main in /lib64/libc.so.6
20# _start in ceph-osd
```

The sequence of events provides at least two clues:
  - the op no. 32 finished before the op no. 29 which was waiting
    for `ObjectContext`,
  - the op no. 29 was a short-living one -- it wasn't waiting even
    on `obc`.

```
rzarzynski@teuthology:/home/teuthworker/archive/rzarzynski-2021-11-22_22:01:32-rados-master-distro-basic-smithi$ less ./6520106/remote/smithi115/log/ceph-osd.3.log.gz
...
DEBUG 2021-11-22 22:32:24,531 [shard 0] osd - client_request(id=29, detail=m=[osd_op(client.4371.0:36 4.d 4.f0fb5e1d (undecoded) ondisk+retry+read+rwordered+known_if_redirected+supports_pool_eio e23) v8]): start
DEBUG 2021-11-22 22:32:24,531 [shard 0] osd - client_request(id=29, detail=m=[osd_op(client.4371.0:36 4.d 4.f0fb5e1d (undecoded) ondisk+retry+read+rwordered+known_if_redirected+supports_pool_eio e23) v8]): in repeat
...
DEBUG 2021-11-22 22:32:24,546 [shard 0] osd - client_request(id=29, detail=m=[osd_op(client.4371.0:36 4.d 4.f0fb5e1d (undecoded) ondisk+retry+read+rwordered+known_if_redirected+supports_pool_eio e23) v8]) same_interval_since: 21
DEBUG 2021-11-22 22:32:24,546 [shard 0] osd - OpSequencer::start_op: op=29, last_started=27, last_unblocked=27, last_completed=27
...
DEBUG 2021-11-22 22:32:24,621 [shard 0] osd - client_request(id=32, detail=m=[osd_op(client.4371.0:49 4.d 4.81addbad (undecoded) ondisk+retry+write+known_if_redirected+supports_pool_eio e23) v8]): start
DEBUG 2021-11-22 22:32:24,621 [shard 0] osd - client_request(id=32, detail=m=[osd_op(client.4371.0:49 4.d 4.81addbad (undecoded) ondisk+retry+write+known_if_redirected+supports_pool_eio e23) v8]): in repeat
...
DEBUG 2021-11-22 22:32:24,626 [shard 0] osd - client_request(id=32, detail=m=[osd_op(client.4371.0:49 4.d 4.81addbad (undecoded) ondisk+retry+write+known_if_redirected+supports_pool_eio e23) v8]) same_interval_s
ince: 21
DEBUG 2021-11-22 22:32:24,626 [shard 0] osd - OpSequencer::start_op: op=32, last_started=29, last_unblocked=29, last_completed=27
<note that op 32 is very short living>
DEBUG 2021-11-22 22:32:24,669 [shard 0] osd - OpSequencer::finish_op_in_order: op=32, last_started=32, last_unblocked=32, last_completed=27
...
DEBUG 2021-11-22 22:32:24,671 [shard 0] osd - client_request(id=32, detail=m=[osd_op(client.4371.0:49 4.d 4:b5dbb581:::smithi11538976-13:head {write 601684~619341 in=619341b, stat} snapc 0={} RETRY=1 ondisk+retry+write+known_if_redirected+supports_pool_eio e23) v8]): destroying
...
DEBUG 2021-11-22 22:32:24,722 [shard 0] osd - client_request(id=29, detail=m=[osd_op(client.4371.0:36 4.d 4:b87adf0f:::smithi11538976-9:head {read 0~1} snapc 0={} RETRY=1 ondisk+retry+read+rwordered+known_if_redirected+supports_pool_eio e23) v8]): got obc lock
...
INFO  2021-11-22 22:32:24,723 [shard 0] osd - client_request(id=29, detail=m=[osd_op(client.4371.0:36 4.d 4:b87adf0f:::smithi11538976-9:head {read 0~1} snapc 0={} RETRY=1 ondisk+retry+read+rwordered+known_if_redirected+supports_pool_eio e23) v8]) obc.get()=0x6190000d5780
...
DEBUG 2021-11-22 22:32:24,753 [shard 0] osd - OpSequencer::finish_op_in_order: op=29, last_started=32, last_unblocked=32, last_completed=32
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8898-ge57ad63c/rpm/el8/BUILD/ceph-17.0.0-8898-ge57ad63c/src/crimson/osd/osd_operation_sequencer.h:123: void crimson::osd::OpSequencer::finish_op_in_order(crimson::osd::ClientRequest&): Assertion `op.get_id() > last_completed_id' failed.
Aborting on shard 0.
```

This could be explained in a scenario where:
  - op no. 29 skipped stages of the execution pipeline while
  - it wrongly informed `OpSequencer` the execution was in-order.

Static analysis shows there are multiple problems of this genre
in the `ClientRequest::process_op()` and its callees with the most
recently merged one being the path for `PG::already_complete()`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
 2021-12-07 09:36:24 +00:00
Samuel Just
347d7d0f26
Merge pull request #44231 from xxhdx1985126/wip-cpu-profile 
crimson/os/seastore: fix compiler error for gcc > 9 and clang13

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
 2021-12-06 22:21:55 -08:00
Xuehan Xu
5829e03a3d crimson/os/seastore: fix compiler error for gcc > 9 and clang13 
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
 2021-12-07 12:27:14 +08:00
David Galloway
92404026b1
Merge pull request #44222 from ceph/wip-m2r 
doc: Use older mistune
 2021-12-06 12:58:22 -05:00
Radoslaw Zarzynski
72e1ab8c2e crimson/osd: clean the recovery message-related header inclusion. 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
 2021-12-06 17:46:02 +00:00
Radoslaw Zarzynski
3f745b9eed crimson/osd: don't assume a pull must happen if there is no push. 
In the classical OSD the `ReplicatedRecoveryBackend::recover_object()`
divides into two main flows: pull and push:

```cpp
int ReplicatedBackend::recover_object(
  const hobject_t &hoid,
  // ...
  )
{
  dout(10) << __func__ << ": " << hoid << dendl;
  RPGHandle *h = static_cast<RPGHandle *>(_h);
  if (get_parent()->get_local_missing().is_missing(hoid)) {
    ceph_assert(!obc);
    // pull
    prepare_pull(
      v,
      hoid,
      head,
      h);
  } else {
    ceph_assert(obc);
    int started = start_pushes(
      hoid,
      obc,
      h);
    // ...
  }
  return 0;
}
```

Pulls may also enter the push path (`C_ReplicatedBackend_OnPullComplete`)
but push handling doesn't draw any assumption on that. What's important,
`recover_object()` may result in no pulls and pushes.

This isn't the case of crimson as its implementation of the push path
asserts that, if no push is scheduled, `PullInfo` must be allocated.
This patch reworks this logic to reflects the classical one and to avoid
crashes like the following one:

```
DEBUG 2021-12-01 18:43:00,220 [shard 0] osd - recover_object: loaded obc: 3:4e058a2e:::smithi13839607-45:head
WARN  2021-12-01 18:43:00,220 [shard 0] none - intrusive_ptr_add_ref(p=0x6190000d7f80, use_count=3)
WARN  2021-12-01 18:43:00,220 [shard 0] none - intrusive_ptr_release(p=0x6190000d7f80, use_count=4)
TRACE 2021-12-01 18:43:00,220 [shard 0] osd - call_with_interruption_impl clearing interrupt_cond: 0x60300012b210,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 18:43:00,220 [shard 0] osd - call_with_interruption_impl: may_interrupt: false, local interrupt_condintion: 0x60300012b210, global interrupt_cond: 0x0,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 18:43:00,220 [shard 0] osd - set: interrupt_cond: 0x60300012b210, ref_count: 1
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8902-g52fd47fe/rpm/el8/BUILD/ceph-17.0.
0-8902-g52fd47fe/src/crimson/osd/replicated_recovery_backend.cc:84: ReplicatedRecoveryBackend::maybe_push_shards(const hobject_t&, eversion_t)::<lambda()>: Assertion `recovery.pi' failed.
Aborting on shard 0.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
 2021-12-06 17:34:20 +00:00
David Galloway
ed2ad24a4b doc: Use older mistune 
https://github.com/miyakogi/m2r/issues/66

Signed-off-by: David Galloway <dgallowa@redhat.com>
 2021-12-06 10:32:56 -05:00
benhanokh
ac826d1665
Merge pull request #43870 from benhanokh/restore_alloc_file 
NCB::refresh allocation-file after FSCK remove
 2021-12-05 09:47:49 +02:00
Gabriel BenHanokh
cc87bef99e BlueStore: Fix a bug when FSCK is invoked in mount()/umount()/mkfs() with DEEP option 
Fixes: https://tracker.ceph.com/issues/53185
NCB mishandles fsck DEEP in mount()/umount()/mkfs() case causing it to remove the allocation-file without destaging a new copy (which will cost us a full rebuild on startup)
There are also few confiliting calls to open_db()/close_db() passing inconsistent read-only flag

We fix both issues by storing open-db type (read-only/read-write) and using it for close-db (which won't pass read-only flag anymore)
We also move allocation-file destage to close-db so it will be refreshed after being removed by fsck and such

Signed-off-by: Gabriel Benhanokh <gbenhano@redhat.com>
 2021-12-04 23:59:39 +02:00
Sage Weil
a3b02a64f7 Merge PR #44155 into master 
* refs/pull/44155/head:
	mgr: limit changes to pg_num

Reviewed-by: Neha Ojha <nojha@redhat.com>
 2021-12-04 12:52:45 -05:00
Sage Weil
6e5e1a34c5 Merge PR #44108 into master 
* refs/pull/44108/head:
	mgr: fix locking for MetadataUpdate::finish

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
 2021-12-04 12:52:09 -05:00
Mykola Golub
8fd6c05336
Merge pull request #44204 from songtongshuai/sts_ceph 
test/librbd: add get_group test

Reviewed-by: Mykola Golub <mgolub@suse.com>
 2021-12-04 18:25:02 +02:00
zdover23
9e8bc32cdd
Merge pull request #44189 from zdover23/wip-doc-2021-12-02-documenting-ceph 
doc/start: update documenting-ceph.rst (1 of x)

Reviewed-by: Laura Flores <lflores@redhat.com>
 2021-12-04 15:53:42 +10:00
Sage Weil
5ae87e38b2 Merge PR #44017 into master 
* refs/pull/44017/head:
	mgr/cephadm: Do not propogate access logs from cherrypy

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
 2021-12-03 12:42:57 -05:00
Matt Benjamin
8a966d5d6d
Merge pull request #44139 from linuxbox2/wip-rgw-lcselect 
rgwlc: permit lifecycle processing for a single bucket
 2021-12-03 12:22:20 -05:00
Sage Weil
130b332a52 Merge PR #44132 into master 
* refs/pull/44132/head:
	mgr/prometheus: define module options for standby

Reviewed-by: Laura Flores <lflores@redhat.com>
 2021-12-03 12:05:13 -05:00
songtongshuai_yewu
c04e8c3374 test/librbd: add get_group test 
Signed-off-by: songtongshuai_yewu <songtongshuai_yewu@cmss.chinamobile.com>
 2021-12-03 11:20:04 -05:00
Zac Dover
63e5d0f545 doc/start: update documenting-ceph.rst (1 of x) 
This PR updates the content on documenting-ceph,
which is, as of December 2021, in need of an
update.

This is the first of what I estimate to be three
to five PRs against this .rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
 2021-12-04 02:20:03 +10:00
Deepika Upadhyay
6ea3a6b008
Merge pull request #44103 from majianpeng/librbd-pwl-flush-by-blockgurad 
librbd/cache/pwl: Using BlockGuard control overlap ops order when flu…

Reviewed-by: Mykola Golub mgolub@suse.com
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
 2021-12-03 15:05:12 +05:30
Deepika Upadhyay
7fe2573510
Merge pull request #44144 from majianpeng/librbd-fix-discard-granularity 
librbd: fix discard granularity for pwl cache

Reviewed-by: mgolub@suse.com
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
 2021-12-03 11:51:08 +05:30
zdover23
18f6ae77a7
Merge pull request #43848 from dvanders/doc_bench 
doc: add disk benchmarking and cache tuning recommendations

Reviewed-by: Zac Dover <zac.dover@gmail.com>
 2021-12-03 09:37:51 +10:00
Yuri Weinstein
ae17c0a0c3
Merge pull request #43691 from curtbruns/use_optimal_for_min_alloc 
os/bluestore: Set min_alloc_size to optimal io size

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
 2021-12-02 15:28:17 -08:00
Yuri Weinstein
d942a1688c
Merge pull request #43578 from ronen-fr/wip-rf-log-options 
common: hide internal logger configuration strings from clients

Reviewed-by: Laura Flores <lflores@redhat.com>
 2021-12-02 15:27:18 -08:00
Yuri Weinstein
6951d3a94f
Merge pull request #43493 from myoungwon/wip-52872 
test: increase retry duration when calculating manifest ref. count

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
 2021-12-02 15:26:24 -08:00
Yuri Weinstein
de3c339648
Merge pull request #43944 from aclamk/wip-aclamk-fix-crush-location-hook-50659 
crush: Fix segfault in update_from_hook

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
 2021-12-02 15:25:10 -08:00
Yuri Weinstein
4d9755a098
Merge pull request #44194 from ceph/wip-yuriw-crontab-master 
qa/tests: switch all gibba machines to smithi

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
 2021-12-02 12:23:28 -08:00
Daniel Gryniewicz
e8c4da5a08
Merge pull request #44178 from Huber-ming/admin_lc_fix 
radosgw-admin: fix error message of OPT::LC_RESHARD_FIX
 2021-12-02 14:59:21 -05:00
Yuri Weinstein
880f5ab7f9 qa/tests: switch all gibba machines to smithi 
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
 2021-12-02 11:10:47 -08:00
Neha Ojha
89d5b2a79e
Merge pull request #43336 from ifed01/wip-fix-bluefs-volumes-ops 
qa/osd-bluefs-volume-ops: fix bluefs volumes ops test case

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
 2021-12-02 08:39:41 -08:00
Adam King
5449b30541 mgr/cephadm: Do not propogate access logs from cherrypy 
The only messages we're really interested in are errors that
would come from the error logs. The acces logs only provide
messages like

- [18/Nov/2021:23:55:32] "POST /data HTTP/1.1" 200 - "" "Python-urllib/3.8"

which we don't want spammed to the log, especially since they are
logged at INFO level

Signed-off-by: Adam King <adking@redhat.com>
 2021-12-02 10:02:23 -05:00
Sage Weil
978537608e Merge PR #44035 into master 
* refs/pull/44035/head:
	mgr/cephadm: less log noise when config checks fail

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
 2021-12-02 09:57:40 -05:00
Alfonso Martínez
f08c0db689 mgr/dashboard: fix frontend deps' vulnerabilities 
- Remove npm-force-resolutions: no resolution needed anymore and this is modifying package-lock.json every time it is run (striping last empty line).
- Add .npmrc: save exact version by default; do not launch audit report when installing.

Fixes: https://tracker.ceph.com/issues/48005
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
 2021-12-02 15:05:23 +01:00
benhanokh
bcf71b0c9e
Merge pull request #44089 from benhanokh/ncb_fsck_fix 
os/bluestore: bug-fix for NCB-FSCK
 2021-12-02 15:49:50 +02:00
Radoslaw Zarzynski
43e36773a2 crimson/osd: fix assertion failure in InternalClientRequest. 
```
DEBUG 2021-12-01 07:55:10,541 [shard 0] osd - internal_client_request(id=1, detail=): in repeat
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - with_interruption_cond: interrupt_cond: 0x0
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - call_with_interruption_impl: may_interrupt: false, local interrupt_condintion: 0x603000b5d270, global interrupt_cond: 0x0,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - set: interrupt_cond: 0x603000b5d270, ref_count: 1
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - call_with_interruption_impl clearing interrupt_cond: 0x603000b5d270,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - call_with_interruption_impl: may_interrupt: false, local interrupt_condintion: 0x603000b5d270, global interrupt_cond: 0x0,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - set: interrupt_cond: 0x603000b5d270, ref_count: 1
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - call_with_interruption_impl clearing interrupt_cond: 0x603000b5d270,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - call_with_interruption_impl: may_interrupt: false, local interrupt_condintion: 0x603000b5d270, global interrupt_cond: 0x0,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - set: interrupt_cond: 0x603000b5d270, ref_count: 1
TRACE 2021-12-01 07:55:10,541 [shard 0] osd - call_with_interruption_impl clearing interrupt_cond: 0x603000b5d270,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 07:55:10,542 [shard 0] osd - call_with_interruption_impl: may_interrupt: false, local interrupt_condintion: 0x603000b5d270, global interrupt_cond: 0x0,N7crimson3osd20IOInterruptConditionE
TRACE 2021-12-01 07:55:10,542 [shard 0] osd - set: interrupt_cond: 0x603000b5d270, ref_count: 1
DEBUG 2021-12-01 07:55:10,542 [shard 0] osd - do_recover_missing check for recovery, MIN
ERROR 2021-12-01 07:55:10,542 [shard 0] none - /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8902-g52fd47fe/rpm/el8/BUILD/ceph-17.0.0-8902-g52fd47fe/src/crimson/osd/pg.cc:1195 : In function 'bool crimson::osd::PG::is_degraded_or_backfilling_object(const hobject_t&) const', ceph_assert(%s)
!get_acting_recovery_backfill().empty()
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
 2021-12-02 11:16:36 +00:00
Dan van der Ster
27fa51234a doc: add disk benchmarking and cache recommendations 
Advise operators on how to benchmark devices for BlueStore, and how to
tune the volatile write cache for optimal OSD performance.

Fixes: https://tracker.ceph.com/issues/53161
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
 2021-12-02 10:44:26 +01:00
Venky Shankar
4d2791a786
Merge pull request #44063 from vshankar/tr-52487 
qa: wait for purge queue operations to finish

Reviewed-by: Venky Shankar <vshankar@redhat.com>
 2021-12-02 10:44:55 +05:30
Huber-ming
9b2bac5798 radosgw-admin: fix error message of OPT::LC_RESHARD_FIX 
Signed-off-by: Huber-ming <zhangsm01@inspur.com>
 2021-12-02 09:18:19 +08:00
Sage Weil
b23a5eb030 Merge PR #44125 into master 
* refs/pull/44125/head:
	qa/suites/rados/thrash-old-clients: use better-support cephadm distro/podman

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
 2021-12-01 17:18:06 -05:00
Sage Weil
5096685cd6 mgr: fix locking for MetadataUpdate::finish 
We need to hold the DaemonState lock here since we are both reading and
writing its content.

Fixes: https://tracker.ceph.com/issues/53393
Signed-off-by: Sage Weil <sage@newdream.net>
 2021-12-01 17:17:34 -05:00