Commit Graph

135018 Commits

Author SHA1 Message Date
Nizamudeen A
559f1513a0
Merge pull request #48525 from rhcs-dashboard/fix-PgImbalance-alert
mgr/dashboard: fix CephPGImbalance alert

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2022-11-29 18:29:39 +05:30
Nizamudeen A
3f1c1b6376
Merge pull request #48526 from rhcs-dashboard/fix-cephPoolGrowth-alert
mgr/dashboard: Fix CephPoolGrowthWarning alert

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-11-29 18:29:01 +05:30
zdover23
b197423020
Merge pull request #49107 from zdover23/wip-doc-2022-11-29-rados-balancer-prompts
doc/rados: add prompts to balancer.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-29 17:43:48 +10:00
Zac Dover
e7fd6e75da doc/rados: add prompts to balancer.rst
Add unselectable prompts to doc/rados/operations/balancer.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-29 15:43:09 +10:00
Venky Shankar
199dcea5d2
Merge pull request #49015 from batrick/meta-doc
doc/cephfs: correct names for fs/meta

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-29 09:37:04 +05:30
Yuri Weinstein
daa7502b37
Merge pull request #48490 from aclamk/wip-aclamk-fix-deferred
[bluestore] Improve deferred write decision

Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2022-11-28 10:38:12 -08:00
Samuel Just
c379296ec4
Merge pull request #49053 from tchaikov/wip-crimson-fmt-v9
crimson: various fmt related changes and fixes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-11-28 08:43:12 -08:00
Mark Nelson
85e2757e85
Merge pull request #47221 from markhpc/wip-faster-rocksdb
[WIP] kv/RocksDBStore: Improved RocksDB Settings and Tombstone behavior
2022-11-28 10:32:16 -06:00
Yuval Lifshitz
e207e3e7a2
Merge pull request #48875 from yuvalif/wip-yuval-fix-58014
rgw/notifications: sending metadata in COPY and CompleteMultipartUpload
2022-11-28 18:01:32 +02:00
Ilya Dryomov
aba5c2a368
Merge pull request #49082 from zdover23/wip-doc-2022-11-28-rbd-isci-monitoring-prompts
doc/rbd: add prompts to iscsi-monitoring.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-11-28 10:29:00 +01:00
Yuval Lifshitz
47ba3e7c00
Merge pull request #48598 from yuvalif/wip-yuval-fix-57899
rgw/admin/notifications: support admin operations on topics with tenants
2022-11-28 08:01:06 +02:00
zdover23
a6cf07f77c
Merge pull request #49079 from zdover23/wip-doc-2022-11-28-glossary-ceph-system-remove
doc/glossary: s/Ceph System/Ceph Cluster/

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-28 10:16:58 +10:00
Zac Dover
8108c4b0ac doc/rbd: add prompts to iscsi-monitoring.rst
Add unselectable prompts to doc/rbd/iscsi-monitoring.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-28 10:11:04 +10:00
Zac Dover
ff6bc1b664 doc/glossary: s/Ceph System/Ceph Cluster/
Remove "Ceph System" and replace it with "Ceph Cluster".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-28 09:45:25 +10:00
zdover23
51a537b158
Merge pull request #49074 from zdover23/wip-doc-2022-11-27-dev-guide-basic-workflow-local-working-copy
doc/dev: improve Basic Workflow wording

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-28 09:35:17 +10:00
Zac Dover
488ca03690 doc/dev: improve Basic Workflow wording
Make several semantic and syntactic improvements to basic-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-28 09:27:13 +10:00
Ilya Dryomov
af6ed506f2
Merge pull request #48680 from pkalever/snap-id
rbd: add --snap-id option to "rbd device map" to allow mapping arbitrary snapshots

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-11-27 14:10:31 +01:00
zdover23
09809ea98b
Merge pull request #49066 from zdover23/wip-doc-2022-11-26-glossary-ceph-system-remove
doc/glossary: remove "Ceph System"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-27 14:06:18 +10:00
zdover23
c6e44f523f
Merge pull request #49065 from zdover23/wip-doc-2022-11-26-rados-ops-add-or-rm-osds-prompts
doc/rados: add prompts to add-or-remove-osds

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-27 08:00:28 +10:00
zdover23
56a53d12fe
Merge pull request #49045 from zdover23/wip-doc-2022-11-25-rbd-iscsi-initiator
doc/rbd: update iSCSI gateway info

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2022-11-27 06:59:55 +10:00
Zac Dover
fdb1685f86 doc/rbd: update iSCSI gateway info
Update iSCSI gateway info in the RBD documentation.

https://tracker.ceph.com/issues/58080

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-27 06:41:35 +10:00
Zac Dover
f665c25ede doc/glossary: remove "Ceph System"
"Ceph System" appears only in definitions where "Ceph Cluster" should
be, so I'm removing the headword. A future commit will scrub the
glossary of the phrase "Ceph System".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-26 23:16:18 +10:00
Ilya Dryomov
4a7150cd36 qa/workunits/rbd-nbd: clear DEV after detach tests
Otherwise we attempt to unmap it in cleanup(), needlessly.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-11-26 13:27:33 +01:00
Zac Dover
5bedee0d92 doc/rados: add prompts to add-or-remove-osds
Add unselectable prompts to add-or-rm-osds.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-26 17:44:22 +10:00
zdover23
2bb1aa269d
Merge pull request #49062 from zdover23/wip-doc-2022-11-26-glossary-ceph-manager
doc/glossary: link to "Ceph Manager"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-11-26 10:16:42 +10:00
Zac Dover
e469a169a8 doc/glossary: link to "Ceph Manager"
Add link to "Ceph Manager" material.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-26 10:06:34 +10:00
Soumya Koduri
661af2bb3e
Merge pull request #48761 from soumyakoduri/wip-skoduri-cloudtier-fixes
rgw/cloud-transition: Fix issues with MCG endpoint

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-11-25 20:43:19 +05:30
Kefu Chai
d8d93b0fe3 crimson/osd: correct the fmt::formatter<WatchTimeoutRequest>
it was introduced by c9569f8eb0

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-25 21:20:58 +08:00
Kefu Chai
be6ac0f9a4 crimson: print exceptions using e.what()
see also e6223872c5

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-25 21:20:58 +08:00
Kefu Chai
71b9344f29 crimson/os: specialize fmt::formatter<> for StagedIterator
StagedIterator is a nested class of stage_t, which is in turn a template
class. it would be impossible to partial specialize fmt::formatter<> for
a nested class of a template class. to workaround this, we specialize
fmt::formatter<> for a type which has `do_format_to()` method, and
define this method for StagedIterator.

since seastar::logger is the only user of the operator<<() operator,
the original operator<<() operator is replaced with this new helper
method.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-25 21:20:58 +08:00
Ilya Dryomov
f2f5ca5150
Merge pull request #49036 from idryomov/wip-52932
mgr/rbd_support: avoid wedging the task queue if pool is removed

Reviewed-by: Mykola Golub <mgolub@suse.com>
2022-11-25 11:48:42 +01:00
Ilya Dryomov
a6df6e77aa
Merge pull request #49042 from idryomov/wip-rbd-support-flake8
mgr/rbd_support: clean up and enable flake8

Reviewed-by: Mykola Golub <mgolub@suse.com>
2022-11-25 11:47:38 +01:00
Kefu Chai
32e207da3f crimson/os: include fmt/os.h for printing std::error_code
this is required by {fmt} v9 and up.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-25 17:09:25 +08:00
Kefu Chai
85830863fa crimson: specialize fmt::formatter<> for formatting using {fmt}
so the specialized types can be formatted using {fmt} v9.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-25 17:09:25 +08:00
zdover23
385bbd5144
Merge pull request #49046 from zdover23/wip-doc-2022-11-25-rados-ops-erasure-code-profiles
doc/rados: cleanup "erasure code profiles"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-11-25 17:12:05 +10:00
Zac Dover
ae7337bf5e doc/rados: cleanup "erasure code profiles"
Improve the grammar of "Erasure Code Profiles".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-11-25 04:41:12 +10:00
Venky Shankar
25c18c5eba
Merge pull request #48927 from neesingh-rh/fix_58028
cephfs-top: Fix unresposive sorting in some cases

Reviewed-by: Jos Collin <jcollin@redhat.com>
2022-11-24 22:55:17 +05:30
Ilya Dryomov
211d101caa
Merge pull request #48542 from CongMinYin/fix-inconsistent-pwl-status
librbd/cache/pwl: fix clean vs bytes_dirty cache state inconsistency

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-11-24 16:12:36 +01:00
Neeraj Pratap Singh
2da139d5bb cephfs-top: Fix unresposive sorting in some cases
Sorting is not working properly in case of change
in the number of clients or after removing and
creating the same filesystem again.

Fixes: https://tracker.ceph.com/issues/58028
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2022-11-24 19:21:02 +05:30
Venky Shankar
8e01b5817a
Merge pull request #49026 from neesingh-rh/fix_58031
cephfs-top: sorting excepts when the filesystems are removed and created

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2022-11-24 19:06:17 +05:30
Ilya Dryomov
99b0fdf5e4 mgr/rbd_support: clean up and enable flake8
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-11-24 13:37:44 +01:00
Kefu Chai
962fe28526
Merge pull request #49029 from Matan-B/wip-matanb-EIO-flag
crimson/osd: Support Pool EIO flag

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-11-24 20:34:47 +08:00
Kefu Chai
40955f6049
Merge pull request #48932 from aisakaki/wip-crimson-loop
crimson/common: re-implement do_for_each

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-11-24 17:12:51 +08:00
Kefu Chai
b6e58d947c
Merge pull request #49040 from tchaikov/wip-cephadm-flake8
cephadm: pin flake8 to 5.0.4

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2022-11-24 16:29:26 +08:00
Kefu Chai
7894e7bdd1 pybind/mgr: use annotation style without comment
* use annotation style without comment
* add noqa to import statement to prevent flake8 from complaining
  those which import typing modules

to silence the warnings like:

```
flake8 run-test: commands[0] | flake8 --config=tox.ini alerts balancer cephadm cli_api crash devicehealth diskprediction_local hello iostat localpool nfs orchestrator prometheus selftest
cephadm/schedule.py:5:1: F401 'typing.Callable' imported but unused
cephadm/schedule.py:8:1: F401 'ceph.deployment.service_spec.ServiceSpec' imported but unused
cephadm/tests/fixtures.py:17:1: F401 'orchestrator.OrchResult' imported but unused
orchestrator/module.py:4:1: F401 'typing.Set' imported but unused
orchestrator/module.py:17:1: F401 'ceph.deployment.inventory.Device' imported but unused
prometheus/module.py:17:1: F401 'typing.DefaultDict' imported but unused
6     F401 'typing.Callable' imported but unused
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/flake8/bin/flake8 --config=tox.ini alerts
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-24 14:47:00 +08:00
Kefu Chai
2413da8c85 qa/tasks/cephfs: annotate variable without comment
to silence the warning like
```
flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_full.py:6:5: F401 'typing.Optional' imported but unused
```

since we've migrated to python3.6 and up, there is no need to be
compatible with Python 2 anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-24 14:06:24 +08:00
Kefu Chai
ecb3fb1903 cephadm: pin flake8 to 5.0.4
to workaround https://github.com/zheller/flake8-quotes/issues/110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-11-24 14:06:19 +08:00
Neeraj Pratap Singh
fd40f76366 cephfs-top: sorting excepts when the filesystems are removed and created
Fixes: https://tracker.ceph.com/issues/58031
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2022-11-24 10:49:26 +05:30
Kefu Chai
625781807f
Merge pull request #49022 from cyx1231st/wip-seastar-msgr-fix-yielded-closing
crimson/net: fix use-after-free during yielded closing

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-11-24 07:45:45 +08:00
Ilya Dryomov
5a425927ed mgr/rbd_support: avoid wedging the task queue if pool is removed
rados.ObjectNotFound exception handler was referencing ioctx variable
which is assigned only if the pool exists and rados.open_ioctx() call
succeeds.  This lead to a fatal error

  mgr[rbd_support] Failed to locate pool mypool
  mgr[rbd_support] execute_task: [errno 2] error opening pool 'b'mypool''
  mgr[rbd_support] Fatal runtime error: local variable 'ioctx' referenced before assignment

and wedged the task queue.  No other commands were processed until
ceph-mgr daemon restart.

Fixes: https://tracker.ceph.com/issues/52932
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-11-23 23:11:42 +01:00