Commit Graph

121977 Commits

Author SHA1 Message Date
J. Eric Ivancich
505b3f2108
Merge pull request #40801 from ivancich/wip-radoslist-incomplete-multipart-parts-marker
rgw: radoslist incomplete multipart parts marker

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2021-04-12 10:34:50 -04:00
Kefu Chai
7b385894ba
Merge pull request #40806 from rhcs-dashboard/fix-mailmap-master
mailmap: sort alphabetically & add Pere and Waad

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-12 21:47:04 +08:00
Kefu Chai
6676cf92e1
Merge pull request #40656 from tchaikov/wip-qa-upgrade-focal
qa/suites: test upgrade/octopus-x on focal instead bionic

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-12 21:42:43 +08:00
Kefu Chai
1ee844f579
Merge pull request #40811 from tchaikov/wip-gen-corpus
script/gen-corpus.sh: set CEPH_CONF

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-12 21:40:29 +08:00
Kefu Chai
00379cc418
Merge pull request #40795 from wjwithagen/wjw-fix-ceph-dencoder
tools: do not unload plugins during destruction.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-12 19:47:02 +08:00
Kefu Chai
5242487486 qa/workunits/cls: add executable bit to script
all the scripts except for test_cls_cas.sh under qa/workunits/cls
are executable. to be more consistent, add the executable bit to
test_cls_cas.sh as well.

also, these scripts are launched by src/script/gen-corpus.sh directly,
so it's convenient just call them.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-12 19:28:47 +08:00
Kefu Chai
fdb4f83448 script/gen-corpus.sh: set CEPH_CONF
if we happen to run this script on a host where /etc/ceph/ceph.conf is
available, ceph CLI would use it instead. so, point it to $PWD/ceph.conf
instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-12 19:28:47 +08:00
Kefu Chai
6a1c173773
Merge pull request #40797 from wjwithagen/wjw-fix-monmap-retval
test: Undo the FreeBSD specific retval test

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-12 18:35:47 +08:00
Ernesto Puerta
73b8373899
mailmap: add Dashboard members: Waad and Pere
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2021-04-12 11:22:36 +02:00
Ernesto Puerta
ab458dc29c
mailmap: sort alphabetically
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2021-04-12 11:19:25 +02:00
Kefu Chai
8fd3607a0a
Merge pull request #40794 from wjwithagen/wjw-fix-promtool
test: Run Dockers only on Linux platforms

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-12 17:06:47 +08:00
Kefu Chai
caf364db5e
Merge pull request #38120 from kiizawa/wip-cls-remote-read
osd: allow remote read by calling cls method from within cls context

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-04-12 16:42:52 +08:00
Willem Jan Withagen
130dbc7725 test: Undo the FreeBSD specific retval test
Changes to the socket code now result in returning EINVAL
In the past ENOENT was returned which is the FreeBSD error code
if DNS lookup does not work.

And that change is probably because somewhere in the code that
errorcode is not passed verbatim from the systemcall, but is
rewritten in extra evaluation.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2021-04-12 10:36:28 +02:00
Willem Jan Withagen
78d301098f tools: do not unload plugins during destruction.
FreeBSD ceph-dencoder crashes in the exit() calls, due to
invalid pointer references during the release process of
the loaded libraries.

Often this is signaled by libc reporting:
  __cxa_thread_call_dtors: dtr 0x47efc0 from unloaded dso, skipping

The cause for this is different behaviour between FreeBSD and Linux:
https://groups.google.com/g/bsdmailinglist/c/22ncTZAbDp4/m/Dii_pII5AwAJ
_The FreeBSD implementation here looks racy. If one thread dlcloses an
object while another thread is exiting, we can end up calling a
function at an invalid memory address. It also looks as if it may
be possible to unload one library, load another at the same address,
and end up executing entirely the wrong code, which would have some
serious security implications.

The GNU/Linux equivalent of this function locks the DSO in memory
until all references to it have gone away. A call to dlclose() on
GNU/Linux will not actually unload the library until all threads
with destructors in that library have been unloaded. I believe
that this reuses the same reference counting mechanism that
allows the same library to be dlopened and dlclosed multiple times.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2021-04-12 10:27:02 +02:00
Kefu Chai
9d9eb283dd
Merge pull request #37016 from zhangdaolong/subcommon-bulefs-import
os/bluestore:Add subcommand bluefs-import in ceph-bluestore-tool.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-12 16:26:34 +08:00
Kefu Chai
dcdd790dd6
Merge pull request #40644 from SMIL-Infra/cleanup-slash
cephadm: cleanup extra slash in runtime dir

Reviewed-by: Adam King <adking@redhat.com>
2021-04-12 16:23:48 +08:00
Kefu Chai
7a158fcb2b
Merge pull request #40658 from tchaikov/wip-systemd
cmake: s/HAVE_MSGHDR/WITH_SYSTEMD/

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
2021-04-12 16:09:33 +08:00
pcuzner
fd63c45a97
Merge pull request #40635 from pcuzner/prometheus_add_pool_metadata
mgr/prometheus:Improve the pool metadata
2021-04-12 12:02:03 +12:00
Yuval Lifshitz
91d20a48b9
Merge pull request #39944 from yuvalif/wip-yuval-fix-49650
rgw/notifications: delete bucket notification object when empty
2021-04-11 21:52:06 +03:00
Willem Jan Withagen
2386023ca8 test: Run Dockers only on Linux platforms
Running a docker alternative only works if the platform
   is Linux

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2021-04-11 20:44:24 +02:00
Kefu Chai
c4e8185b52
Merge pull request #40786 from tchaikov/wip-script-bit
build-integration-branch: retry when running into network failures

Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-12 00:43:46 +08:00
Kefu Chai
34e4e4870e build-integration-branch: retry when running into network failures
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-11 22:28:05 +08:00
zhangdaolong
39118421dc os/bluestore/bluestore_tool: Add subcommand blufs-import
Examples
 ceph-bluestore-tool bluefs-import --path /var/lib/ceph/osd/ceph-1 --input-file ./db/CURRENT --dest-file db/CURRENT

Signed-off-by: zhang daolong <zhangdaolong@fiberhome.com>
2021-04-11 17:10:48 +08:00
Kefu Chai
83eb7a3dff build-integration-branch: define variables for pr_number and friends
so they can be reused later.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-11 12:00:07 +08:00
Sage Weil
d9497684f7 Merge PR #40577 into master
* refs/pull/40577/head:
	cephadm: normalize unqualified repo digests to docker.io
	mgr/cephadm/upgrade: normalize unqualified target image

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
2021-04-10 09:01:58 -04:00
Sage Weil
542b81b8f1 Merge PR #40537 into master
* refs/pull/40537/head:
	cephadm:persist the grafana.db file

Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-10 09:01:27 -04:00
J. Eric Ivancich
d76e65bcd3 rgw: test radosgw-admin radoslist and incomplete multiparts better
Make sure there are more than 1000 incomplete multiparts and also make
sure one of the incomplete multiparts has at least 1000 parts. This
test is done indirectly through rgw-orphan-list, which invokes
`radosgw-admin radoslist`.

Also, clean up shell flags, so script output is less verbose.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2021-04-10 02:07:53 -04:00
Patrick Donnelly
4803e9f5d5
Merge PR #40653 into master
* refs/pull/40653/head:
	mon: check mdsmap is resizeable before promoting standby-replay

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-09 20:08:51 -07:00
Patrick Donnelly
3e849e7349
Merge PR #40642 into master
* refs/pull/40642/head:
	client: don't allow access to MDS-private inodes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2021-04-09 20:06:21 -07:00
Patrick Donnelly
4d29e591dd
Merge PR #40481 into master
* refs/pull/40481/head:
	qa: test standby-replay with fs:workloads

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-09 20:04:32 -07:00
Patrick Donnelly
76ac006875
Merge PR #40431 into master
* refs/pull/40431/head:
	qa/cephfs: remove create_keyring_file from cephfs_test_case.py
	qa/cephfs: don't use sudo to write files in /tmp

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2021-04-09 20:02:27 -07:00
Patrick Donnelly
d302b72691
Merge PR #40389 into master
* refs/pull/40389/head:
	mds: reject lookup ino requests for mds dirs
	test: add test for invalid lookup of mdsdir

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
2021-04-09 19:58:40 -07:00
Neha Ojha
b4f291a6b4
Merge pull request #40723 from zdover23/wip-doc-second-attempt-mclock-rewrite-second-half-2021-Apr-09
doc/rados: rewrite mclock docs (2 of 2)

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-09 17:24:41 -07:00
Josh Durgin
91104375cd
Merge pull request #40738 from jdurgin/wip-librados-docs
include/librados: fix doxygen syntax for docs build

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-09 16:48:13 -07:00
Josh Durgin
70b8f16a2c include/librados: fix doxygen syntax for docs build
The docs build is now warning about these like:

WARNING: Unparseable C cross-reference: '[in]'
Invalid C declaration: Expected identifier in nested name.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2021-04-09 18:01:35 -04:00
Sage Weil
e07a738304 cephadm: normalize unqualified repo digests to docker.io
A RepoDigests returned by docker|podman image inspect can either include
the docker.io/ prefix or not.  For reasons that aren't entirely clear,
this may vary between hosts in a cluster.  However, ceph/ceph@sha256:abc...
is the same thing as docker.io/ceph/ceph@sha256:abc..., and should be
treated as such.  Otherwise, upgrade can get into a loop where it pulls
the image on a new host, finds the other variant of the repodigests,
sees no overlap, updates target_digests, and restarts.  (It will then
find the first variant again on the first host and loop.)

Avoid this by normalizing any docker.io digests by always including the
docker.io/ prefix.

Note that it is technically possible that this assumption is wrong: it
may be that the image that already exists on the local host is from a
different registry in registries.conf's unqualified-search-registries.
However, we don't know which, since this is a search list.  In practice,
it should be exceeding rare that an image that *we* are installing using
a fully-qualified image name will end up having an unqualified repodigest
in the local registry.  Hopefully!

Fixes: https://tracker.ceph.com/issues/50114
Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-09 16:53:37 -04:00
Sage Weil
38f84520ee mgr/cephadm/upgrade: normalize unqualified target image
If we get an unqualified target image, assume it's docker.io.  This
ensures that we're passing a fully-qualified target to docker|podman on
the various hosts and don't end up with something different based on the
per-host search path for unqualified image names.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-09 16:53:37 -04:00
Zac Dover
f3180ad722 doc/rados: rewrite mclock docs (2 of 2)
This is my second attempt to rewrite the
second half of the mclock docs. The first attempt
is enshrined in https://github.com/ceph/ceph/pull/40571,
in which I got cute with git and got burned.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-04-10 06:49:43 +10:00
Samuel Just
055ebe381d
Merge pull request #39216 from myoungwon/wip-manifest-dedup-test
osd, test: reworks for manifest dedup test cases

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-04-09 12:42:18 -07:00
J. Eric Ivancich
098eddaeee rgw: fix radoslist stuck loop
When an incomplete multipart upload has in excess of 1000 parts,
looping over those parts was not handled property causing an infinite
loop. The paging/marker is now handled correctly.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2021-04-09 15:28:01 -04:00
Kefu Chai
b026037d44 qa/suites: test upgrade/octopus-x on focal instead bionic
so we can solely build on focal in future once all other bionic facets
in qa/ is removed or replaced.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-10 00:51:40 +08:00
Yuri Weinstein
5f2f793af2
Merge pull request #40623 from ronen-fr/wip-ronenf-revert-40077
osd: Revert "osd: Try other PGs when reservation failures occur"

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-09 07:45:55 -07:00
Yuri Weinstein
63a3452248
Merge pull request #40606 from myoungwon/wip-49427-2
osd: recover unreadable snapshot before reading refcount info

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-04-09 07:44:42 -07:00
Josh Durgin
e734c2d123
Merge pull request #40510 from aclamk/wip-bluestore-sharding-rst
doc: Add BlueStore sharding documentation

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-08 15:36:27 -07:00
Patrick Donnelly
682a55e8a2
mds: reject lookup ino requests for mds dirs
Fixes: https://tracker.ceph.com/issues/49922
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 12:21:42 -07:00
Patrick Donnelly
4702be4f47
qa: test standby-replay with fs:workloads
Fixes: https://tracker.ceph.com/issues/50045
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:37:56 -07:00
Patrick Donnelly
9d7a42e709
Merge PR #40486 into master
* refs/pull/40486/head:
	mds: trim cache regularly for standby-replay
	mds: remove extra heap release

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
2021-04-08 11:35:05 -07:00
Patrick Donnelly
1cfc753e9a
Merge PR #40520 into master
* refs/pull/40520/head:
	mds/scrub: background scrub error fixes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:34:21 -07:00
Patrick Donnelly
2f1d3aa629
Merge PR #40633 into master
* refs/pull/40633/head:
	mds: ensure export_pin rank < max_mds

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:33:41 -07:00
Patrick Donnelly
b02fa8b9de
Merge PR #40638 into master
* refs/pull/40638/head:
	mds: do not show the default auth if it's unambiguous
	mds: switch to rank number instead

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:33:08 -07:00