Commit Graph

76698 Commits

Author SHA1 Message Date
Jason Dillaman
4e1b834d2d rbd-mirror: simplify resync handling within image replayer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
028847cb33 rbd-mirror: pre-register image id before creating image
This fixes a potential race condition that could occur previously
if rbd-mirror daemon failed between creating an image and recording
the image id to the remote journal.

Fixes: http://tracker.ceph.com/issues/15764
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
2a6cfd8373 rbd-mirror: clean up bootstrap recovery from missing local image
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
5dcd9ed0d5 rbd-mirror: image replayer should query remote mirror uuid / image id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
b3dba1c876 rbd-mirror: helper state machine for querying remote peer uuid / image id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:31 -04:00
Jason Dillaman
697c1d7a4a rbd-mirror: helper state machine for retrieving image id from global id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:09:21 -04:00
Sage Weil
4f01c8fc91 Merge pull request #16851 from xiexingguo/wip-doc-update-class-cli
doc/release-notes: update device class cli
2017-08-07 08:26:35 -05:00
Yuri Weinstein
59a0f3c532 Merge pull request #16551 from fangyuxiangGL/data-notifier-interval
rgw: add a separate configuration for data notify interval

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-08-07 05:48:54 -07:00
Yuri Weinstein
93a7ae801a Merge pull request #16726 from theanalyst/rgw-crypt-debug-log
rgw_crypt: log error messages during failures

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@mirantis.com>
2017-08-07 05:48:14 -07:00
Yuri Weinstein
1c63af1286 Merge pull request #16770 from tianshan/fix_create_bucket
rgw: should not restrict location_constraint same when user not provide

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 05:45:52 -07:00
Jos Collin
e5da05f8f7 Merge pull request #16862 from scienceluo/wip-luo-check-fix-branch
common/cmdparse.cc: remove unused variable 'argnum' in dump_cmd_to_json()

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 09:30:48 +00:00
Luo Kexue
5d6d22997a Common: remove variable 'argnum' that is modified but its new value is never used.
Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>
2017-08-07 16:21:16 +08:00
xie xingguo
d066ab2fe6 doc/release-notes: update device class cli
These commands are nearly stable and are unlikely to change for now...

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-07 12:28:53 +08:00
Jos Collin
6f00f9a71d Merge pull request #16847 from amitkumar50/cov-1054870
rgw: Initialize of member variable admin_specified in RGWUserAdminOpState

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 04:01:36 +00:00
Sage Weil
311bfcaf04 Merge pull request #16822 from liewegas/wip-20849
os/bluestore: _do_remove: dirty shard individually as each blob is unshared

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-06 21:43:22 -05:00
Sage Weil
fce8d83fdf Merge pull request #16844 from xiexingguo/wip-bluestore-core
os/bluestore: default journal media to store media if bluefs is disabled

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 20:17:57 -05:00
Sage Weil
1a9363596d Merge pull request #14053 from jdurgin/wip-19191
osd/PG: reset the missing set when restarting backfill

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 14:08:34 -05:00
Sage Weil
96f3ef6fd1 Merge pull request #16837 from xiexingguo/wip-still-more-class-fixes
crush: more class fixes

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 14:07:33 -05:00
Sage Weil
db47061327 Merge pull request #16838 from xiexingguo/wip-fix-purge
mon/OSDMonitor: sanity check osd before performing 'osd purge'

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 14:07:15 -05:00
Sage Weil
0b5267e428 Merge pull request #16832 from liewegas/wip-20915
rpm,deb: fix ceph-volume

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2017-08-06 13:41:21 -05:00
amitkuma
1a6bc40881 rgw: Initilzation of admin_specified
Fixes the coverity issue:

** 1054870 Uninitialized scalar field
CID 1054870 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member admin_specified is not
initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-06 22:55:07 +05:30
Sage Weil
c275379348 os/bluestore: _do_remove: dirty shard individually as each blob is unshared
Two problems with old code:

1- dirty_shard range is inclusive, so we might dirty the shard after b_end
2- we might unshare blobs in two shards with an unloaded shard in between,
which would mean dirtying a shard that isn't loaded.

Fix by ensuring the shard for each unshared blob is dirty individually.

Fixes: http://tracker.ceph.com/issues/20849
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 10:32:01 -04:00
Sage Weil
95a0288368 Merge pull request #16849 from liewegas/wip-jewel-x
qa/suites/upgarde/jewel-x/parallel: more whitelisting
2017-08-06 09:15:35 -05:00
Sage Weil
ed2d984ad1 qa/suites/upgarde/jewel-x/parallel: more whitelisting
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 10:04:14 -04:00
Sage Weil
18b06bc04f Merge pull request #16830 from liewegas/wip-jewel-x
upgrade/jewel-x: a few fixes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-08-06 08:57:55 -05:00
Sage Weil
58f15d2b98 qa/suites/upgrade/jewel-x/parallel: more whitelisting
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
622e950e43 qa/suites/upgrade/*-x/parallel: whitelist more stuff
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
2d260443f0 qa/suites/upgrade/*/parallel: disable POOL_APP_NOT_ENABLED
There is some other random workload running (that creates pools)
while we upgrade and wait for healthy.  Just disable the warning
for these tests.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
7908552cc3 mon: add mon_warn_on_pool_no_app option
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
f4c2863999 qa/suites/upgrade/jewel-x/parallel: whitelist OSD_DOWN
We restart OSDs during the upgrade.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
d7848f9358 mon/MgrMonitor: use static mgr commands if none defined yet
During upgrade, we may get a command (like 'pg dump') before we
pass our first post-upgrade paxos round embedding the static mgr
commands.  Until then, use the static mgr commands (that's what
we're proposing anyway).

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
xie xingguo
0fc6a5feb3 os/bluestore: default journal media to store media if bluefs is disabled
So we won't prevent bluestore-without-bluefs backed OSDs from booting:
0> 2017-08-06 18:28:07.431316 7ffa1c95fd00 -1 /home/xxg/build/ceph-dev/src/os/bluestore/BlueStore.cc: In function
'virtual bool BlueStore::is_journal_rotational()' thread 7ffa1c95fd00 time 2017-08-06 18:28:07.428503
/home/xxg/build/ceph-dev/src/os/bluestore/BlueStore.cc: 4401: FAILED assert(bluefs)

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-06 18:58:14 +08:00
Jos Collin
f1b1e94494 Merge pull request #16780 from amitkumar50/cov-1414521
libradosstriper: Initialize member variable m_writeRc in WriteCompletionData

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-06 09:05:34 +00:00
Jos Collin
fd974ffa66 Merge pull request #16781 from amitkumar50/cov-1414516
msg: Initialize member variables in Infiniband

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-06 06:47:59 +00:00
amitkuma
52b6890459 msg: Initilization of uninitialized class Infiniband members
Fixes coverity issues:

1414516 Uninitialized pointer field
2. uninit_member: Non-static class member max_send_wr is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member max_recv_wr is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member max_sge is not initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member ib_physical_port is not initialized in this constructor nor in any functions that it calls.
10. uninit_member: Non-static class member memory_manager is not initialized in this constructor nor in any functions that it calls.
12. uninit_member: Non-static class member srq is not initialized in this constructor nor in any functions that it calls.
14. uninit_member: Non-static class member device is not initialized in this constructor nor in any functions that it calls.
CID 1414516 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
16. uninit_member: Non-static class member pd is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-06 00:11:53 +05:30
Sage Weil
dbb4c1cd9b Merge pull request #16662 from ivancich/wip-dmclock-options-doc
doc: op queue and mclock related options

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-05 13:36:37 -05:00
Sage Weil
d9a0145f8f Merge pull request #16824 from liewegas/wip-more-scrub-time
qa/tasks/ceph: wait longer for scrub
2017-08-05 13:35:55 -05:00
Sage Weil
bc9997fe47 Merge pull request #16841 from liewegas/wip-debug-ceph
qa/tasks/ceph: debug osd setup
2017-08-05 13:35:13 -05:00
Sage Weil
f766842fcf Merge pull request #16633 from dillaman/wip-bootstrap-rbd-mirror
mon: added bootstrap-rbd auth profile

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-05 13:27:32 -05:00
Sage Weil
3612e5eecf Merge pull request #16704 from dillaman/wip-20644
rbd-mirror: assertion failure during pool replayer shut down

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2017-08-05 13:24:09 -05:00
Sage Weil
62482ce82c qa/tasks/ceph: debug osd setup
I've seen a couple rbd runs that seem to skip the next block :/

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-05 13:53:26 -04:00
Sage Weil
ab28f7a23e ceph.spec.in: ceph_volume but not ceph_volume_client in ceph-base
Fixes: http://tracker.ceph.com/issues/20915
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-05 13:42:00 -04:00
Jos Collin
2065ca6583 Merge pull request #16784 from amitkumar50/cov-1244200
test: Initialize pointer msg in MonClientHelper

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-05 15:41:15 +00:00
Jos Collin
ad5b56163a Merge pull request #16839 from amitkumar50/cov-messages-3
messages: Initialize member variables

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-05 15:35:22 +00:00
amitkuma
363b46625c messages: Initializing variables various classes
Fixes the coverity Issues:

** 1019615 Uninitialized scalar field
2. uninit_member: Non-static class member service_type is not initialized
 in this constructor nor in any functions that it calls.
CID 1019615 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member service_op is not initialized
 in this constructor nor in any functions that it calls.

** 1019618 Uninitialized scalar field
2. uninit_member: Non-static class member op is not initialized in this
 constructor nor in any functions that it calls.
4. uninit_member: Non-static class member cookie is not initialized in
 this constructor nor in any functions that it calls.
CID 1019618 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member last_committed is not initialized
 in this constructor nor in any functions that it calls.

** 1019620 Uninitialized scalar field
2. uninit_member: Non-static class member epoch is not initialized in this
 constructor nor in any functions that it calls.
CID 1019620 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member request_ack is not initialized
in this constructor nor in any functions that it calls.

** 1019621 Uninitialized scalar field
2. uninit_member: Non-static class member epoch is not initialized in this
constructor nor in any functions that it calls.
CID 1019621 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member round is not initialized in this
constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-06 00:34:46 +05:30
Jos Collin
bb190215e9 Merge pull request #16819 from amitkumar50/cov-messages-1
messages: Initialize member variables

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-08-05 15:15:45 +00:00
amitkuma
d31ac65e26 messages: Initializing member variables of module messages
Fixes coverity Issue:

CID 717307 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717308 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member query_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717310 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717311 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717312 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717313 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member query_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717314 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717315 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717316 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717317 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member min_epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member repair is not initialized in this constructor nor in any functions that it calls.
CID 717318 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member deep is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member acks_wanted is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member old_exists is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member old_size is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member first is not initialized in this constructor nor in any functions that it calls.
CID 717319 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member complete is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member ack_type is not initialized in this constructor nor in any functions that it calls.
CID 717320 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member result is not initialized in this constructor nor in any functions that it calls.
CID 717321 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls
uninit_member: Non-static class member pool is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member auid is not initialized in this constructor nor in any functions that it calls.
CID 717322 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member crush_rule is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member replyCode is not initialized in this constructor nor in any functions that it calls.
CID 717323 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-05 23:38:03 +05:30
Jos Collin
31e66270d2 Merge pull request #16785 from amitkumar50/cov-1274326
test: Initialize pointer variables in TestMemIoCtxImpl

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-05 13:56:07 +00:00
amitkuma
6078f6923f rados: Initializing uninitialized pointer variables
Fixes the coverity issue:

1274326 Uninitialized pointer field
2. uninit_member: Non-static class member m_client is not initialized in
this constructor nor in any functions that it calls.
CID 1274326 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
4. uninit_member: Non-static class member m_pool is not initialized in
this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-05 23:56:38 +05:30
xie xingguo
bfd1d4ef9a mon/OSDMonitor: sanity check osd before performing 'osd purge'
This will pervent OSDMonitor from crashing on purging a very large
non-existent osd id as below:

osd e11 prepare_command_osd_purge purging osd.8
    -1> 2017-08-05 18:59:44.994319 7f6076968700 10 mon.a@0(leader).osd e11 prepare_command_osd_destroy osd.8 does not exist.
     0> 2017-08-05 18:59:45.002309 7f6076968700 -1 /home/xxg/build/ceph-dev/src/osd/OSDMap.h: In function 'int OSDMap::get_state(int) const'
 thread 7f6076968700 time 2017-08-05 18:59:44.994336
/home/xxg/build/ceph-dev/src/osd/OSDMap.h: 690: FAILED assert(o < max_osd)

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-05 19:43:39 +08:00