Commit Graph

128729 Commits

Author SHA1 Message Date
Venky Shankar
4d372e9557
Merge pull request #43236 from mchangir/mgr/snap_schedule-fix-db-connection-concurrent-usage
mgr/snap_schedule: fix db connection concurrent usage

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-01-04 14:36:07 +05:30
Alfonso Martínez
f0c8fd73a0
Merge pull request #44407 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard/frontend/swagger-ui-4.1.3
build(deps): bump swagger-ui from 4.1.2 to 4.1.3 in /src/pybind/mgr/dashboard/frontend 

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-01-03 17:47:13 +01:00
Kefu Chai
902bb28127
Merge pull request #44354 from tchaikov/cmake-cleanup
cmake: use new CMP0127 policy

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-01-03 23:31:24 +08:00
Laura Flores
fa20cb8b63
Merge pull request #43337 from ljflores/wip-bluestore-zero-detection
os/bluestore: detect unnecessary zeroes in bufferlist when data is written
2022-01-03 09:16:32 -06:00
Alfonso Martínez
046cbec6a0
Merge pull request #44187 from rhcs-dashboard/wip-configure_dependabot-master
mgr/dashboard: configure dependabot

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-01-03 14:17:27 +01:00
Ilya Dryomov
a72c56388d
Merge pull request #44130 from LittleFox94/wip-doc-rbd-default-object-size
doc: how to change default rbd object size

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-01-03 10:06:06 +01:00
Nizamudeen A
a2f5a3c1db
Merge pull request #44398 from rhcs-dashboard/e2e-script-improvement
mgr/dashboard: dashboard cephadm e2e improvement

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2021-12-30 11:25:58 +05:30
Nizamudeen A
26f86f6cd3 mgr/dashboard: dashboard cephadm e2e improvement
Fixes: https://tracker.ceph.com/issues/53742
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-12-29 22:06:27 +05:30
Yingxin
d70fdd74b9
Merge pull request #44403 from cyx1231st/wip-fix-crimson-args
crimson/osd: fix and improve args processing

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-12-29 13:01:50 +08:00
Kefu Chai
2925e34887
Merge pull request #44396 from cyx1231st/wip-seastore-fix-seastar-runner
crimson/test: fix SeastarRunner when app is not started

Reviewed-by: Xuehan Xu <xuxuehan@360.cn>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-12-29 00:31:03 +08:00
Kefu Chai
efd2002b6a
Merge pull request #44274 from fengchunsong/dpdk-dfx
msg/async/dpdk: add commands to obtain the NIC status and statistics

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-12-28 19:55:41 +08:00
Chunsong Feng
43b5f96093 msg/async/dpdk:add commands to obtain the NIC status and statistics
Commands are added to obtain the network adapter status and statistics
for debugging network adapter packet loss and mbuf insufficiency issues.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe  <hanfengzhe@hisilicon.com>
2021-12-28 02:01:25 +00:00
fengchunsong
cc55af8828
Merge pull request #44276 from fengchunsong/dpdk-affinity
common/numa: Skip the DPDK thread when setting NUMA affinity
2021-12-28 07:53:19 +08:00
Mara Sophie Grosch
5d872f3a28 doc: add docs for rbd_default_order
Adds documentation how to change default rbd object size. With the
previous option `--order` it was easy to guess the config name for the
default value, with the current option name `--object-size` thats hard
to guess.

Also extends the documentation for rbd_default_order to include
* how object-size is derived from the configured value
* allowed range of the value

In the first version of this commit I also added min and max for this
parameter (12/25, matching the object size range in `man 8
rbd`/Striping/object-size), but this made some tests fail, since some
seem to set values outside this range (and probably are fine since
included for some time already). To have this a doc-change only, I
removed the range.

Signed-off-by: Mara Sophie Grosch <littlefox@lf-net.org>
2021-12-27 19:58:56 +01:00
Patrick Donnelly
135be96971
Merge PR #44342 into master
* refs/pull/44342/head:
	mds: trigger stray reintegration when loading dentry
	qa: test that scrub causes reintegration

Reviewed-by: Xiubo Li <xiubli@redhat.com>
2021-12-27 12:55:30 -05:00
Chunsong Feng
6411cbe2dd common/numa: Skip the DPDK thread when setting NUMA affinity
The CPU affinity of the DPDK thread has been set during DPDK initialization.
Do not modify the DPDK affinity when setting NUMA affinity.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe  <hanfengzhe@hisilicon.com>
2021-12-27 13:09:33 +00:00
Chunsong Feng
8015cb8bb4 msg/async: refactory rename_thread for DPDKStack
The thread_name of the DPDK thread has been set during DPDK initialization.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe  <hanfengzhe@hisilicon.com>
2021-12-27 13:04:56 +00:00
Ilya Dryomov
8fe3a1be37
Merge pull request #44243 from ideepika/wip-deepika-iscsi
qa/rbd: update the cephadm required distro

Reviewed-by: Melissa Li <melissali@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2021-12-27 12:29:07 +01:00
Yingxin Cheng
373828e381 crimson/osd: print message when customize parameters
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-12-27 19:07:30 +08:00
Yingxin Cheng
f508a45b95 crimson/osd: allow seastar application to print its helps
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-12-27 19:07:30 +08:00
Yingxin Cheng
051224bbac crimson/osd: --help-seastar does no longer belong to unknown_args
Now that app_template handles --help-seastar, and prints out all
app-level usages if --help is included in command line options. There is
no need to add a dedicated --help-seastar by ourselves and translate it
to --help.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-12-27 19:06:47 +08:00
Kefu Chai
15bb0517c1
Merge pull request #44411 from tchaikov/wip-crimson-doc
doc: remove references to SEASTAR_DEFAULT_ALLOCATOR

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-12-27 17:14:58 +08:00
Kefu Chai
85e30b4dfd
Merge pull request #44333 from rzarzynski/wip-crimson-fix-recovery-discarding
crimson/osd: implement op discarding for pglog-based recovery. 

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2021-12-26 21:46:41 +08:00
Kefu Chai
9690ad85a7
Merge pull request #44275 from fengchunsong/dpdk-nic
msg/async/dpdk: add NIC whitelist configuration

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-12-26 20:41:33 +08:00
Kefu Chai
e8e49d3c82
Merge pull request #44285 from fengchunsong/dpdk-rte-init
msg/async/dpdk: handle DPDK initialization failure properly

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-12-26 20:04:40 +08:00
Chunsong Feng
a5df6794e1 msg/async/dpdk:add the handling of DPDK initialization failure
If rte_eal_init returns with failure,the waiting msgr-worker thread is
woken up for exception handling.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe  <hanfengzhe@hisilicon.com>
2021-12-26 05:54:36 +00:00
Kefu Chai
3b250938bc doc: remove references to SEASTAR_DEFAULT_ALLOCATOR
now that 067681b701
has been merged upstream, and our src/seastar submodule includes
this commit. there is no need to worry that the seastar's lockless
allocator does not work with seastar::alien anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2021-12-26 13:13:56 +08:00
Yingxin Cheng
f802c15a1e crimson/test: fix SeastarRunner when app is not started
Support the case when the SeastarRunner isn't able to start the app,
for example, when start with --help.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-12-25 23:18:35 +08:00
Chunsong Feng
95743d510e msg/async/dpdk: add NIC whitelist configuration
Each DPDK process uses some exclusive network adapters.The network adapters to
be used are specified in the whitelist to prevent data sharing between multiple
DPDK process.The following is an example:
1)Configure a single NIC.
-a 0000:7d:010 or --allow=0000:7d:010
2)Configure the Bond Network Adapter
ms_dpdk_port_options=--allow=0000:7d:01.0 --allow=0000:7d:02.6
--vdev=net_bonding0,mode=2,slave=0000:7d:01.0,slave=0000:7d:02.6

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe  <hanfengzhe@hisilicon.com>
2021-12-25 13:10:01 +00:00
Kefu Chai
31afabe6f2
Merge pull request #44404 from inspur-wyq/wip-doc-mgr-zabbix
doc/mgr/zabbix.rst: fix typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-12-25 16:44:07 +08:00
dependabot[bot]
d8514fcf3f
build(deps): bump swagger-ui in /src/pybind/mgr/dashboard/frontend
Bumps [swagger-ui](https://github.com/swagger-api/swagger-ui) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/swagger-api/swagger-ui/releases)
- [Commits](https://github.com/swagger-api/swagger-ui/compare/v4.1.2...v4.1.3)

---
updated-dependencies:
- dependency-name: swagger-ui
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-12-24 15:39:49 +00:00
wangyunqing
f838e2e207 doc/mgr/zabbix.rst: fix typos
Signed-off-by: wangyunqing <wangyunqing@inspur.com>
2021-12-24 17:10:11 +08:00
Yingxin
2ec4a586a8
Merge pull request #44378 from cyx1231st/wip-seastore-onode-cleanup
crimson/os/seastore: fix potential leak for onodes to live across transactions

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2021-12-24 11:41:02 +08:00
Laura Flores
3b8bf06b41 test/objectstore: write unit tests for zero block detection
Unit tests include ZeroBlockDetectionSmall{Append/Overwrite} and ZeroBlockDetectionBig{Append/Overwrite}.

Signed-off-by: Laura Flores <lflores@redhat.com>
2021-12-24 01:19:43 +00:00
Laura Flores
914debdd4a os/bluestore: detect unnecessary zeros in _do_write_big()
Bluestore's `_do_write()` method handles writing data from bufferlists. Currently, it writes data from bufferlists without checking for unnecessary zeros. The lack zero detection may negatively impact performance.

In _do_write_big, we also check if a bufferlist is made up of zeros and avoid writing it if so.
Two new counters, `l_bluestore_write_big_skipped_blobs` and `l_bluestore_write_big_skipped_bytes`, have been introduced to help us count how many zero blocks and bytes from _do_write_big() have been skipped.

Signed-off-by: Laura Flores <lflores@redhat.com>
2021-12-24 01:18:13 +00:00
Laura Flores
15cd355032 os/bluestore: detect unnecessary zeros in _do_write_small()
Bluestore's `_do_write()` method handles writing data from bufferlists. Currently, it writes data from bufferlists without checking for unnecessary zeros. The lack zero detection may negatively impact performance.

In _do_write_small(), we check if a bufferlist is made up of zeros and avoid writing it if so.
Two new counters, `l_bluestore_write_small_skipped` and l_bluestore_write_small_skipped_bytes`, have been introduced to help us count how many zero blocks and bytes from _do_write_small() have been skipped.

Signed-off-by: Laura Flores <lflores@redhat.com>
2021-12-24 01:15:33 +00:00
Yuri Weinstein
7659877b16
Merge pull request #44311 from ifed01/wip-ifed-cleanup-onode-pin
os/bluestore: get rid of fake onode nref increment for pinned entry

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2021-12-23 16:44:43 -08:00
Yuri Weinstein
9a8cdd0f50
Merge pull request #44303 from 5cs/fix-new-state-weight
mon/OSDMonitor: fix incorrect op between osd state and weight

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2021-12-23 16:44:06 -08:00
Neha Ojha
ee3fd519cf
Merge pull request #44391 from anthonyeleven/anthonyeleven/correct-quay-url
doc/install: Update quay.io URL for ceph-ci builds

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-12-23 15:34:22 -08:00
Anthony D'Atri
ff96092cf0 doc/install: Update quay.io URL for ceph-ci builds
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2021-12-23 15:04:52 -08:00
Yuri Weinstein
ac6564538b
Merge pull request #44352 from SMIL-Infra/journald
common: fix fmt::format_to deprecated warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-12-23 14:02:39 -08:00
Yuri Weinstein
1e2f0c6222
Merge pull request #42896 from ifed01/wip-ifed-bluefs-improve-log
os/bluestore: dump alloc unit size on bluefs allocation failure.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2021-12-23 14:02:16 -08:00
Yuri Weinstein
8339b5846e
Merge pull request #44353 from tchaikov/wip-str-map
common/str_map: reimplement get_str_list() using for_each_pair

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-12-23 14:00:25 -08:00
Yuri Weinstein
9deb56cdac
Merge pull request #44330 from rzarzynski/wip-osd-drop-includes
osd: drop unnecessary recovery / scrub includes from OSD.cc.

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-12-23 13:59:36 -08:00
Ernesto Puerta
fdd6b79855
Merge pull request #44364 from rhcs-dashboard/e2e-fixups
mgr/dashboard: fix timeout error in dashboard cephadm e2e job

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-12-23 17:23:18 +01:00
Patrick Donnelly
91a1d81eff
Merge PR #44322 into master
* refs/pull/44322/head:
	mds: skip directory size checks for reintegration
	qa: test reintegration with directory limits

Reviewed-by: Xiubo Li <xiubli@redhat.com>
2021-12-23 08:52:10 -05:00
Kefu Chai
714bb3aa64
Merge pull request #44375 from wjwithagen/wjw-fix-missing-utility
common: add missing #include <utility>

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-12-23 21:22:37 +08:00
Nizamudeen A
fed358d7c5 mgr/dashboard: fix timeout error in dashboard cephadm e2e job
1. Fix the timeout error happening in the dashboard e2e job
2. Take care of the flaky force maintenance check

Most of the time our test is getting timed out while searching for an item
in the table. Its because `.clear().type()` is not clearing the content
in the search field sometimes and that creates a wrong data to be
entered into the search field and it starts searching based on this
wrong name. To avoid this I am explicitly clearing the search area
before typing.

Fixes: https://tracker.ceph.com/issues/53672
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-12-23 18:05:58 +05:30
Kefu Chai
b07ba034d4
Merge pull request #44365 from tchaikov/wip-seastar
seastar: pick up upstream change which includes cryptopp fix

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2021-12-23 10:31:32 +08:00
Patrick Donnelly
08194cb2a5
Merge PR #44324 into master
* refs/pull/44324/head:
	qa: set quincy require-osd-release to avoid health warning

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-12-22 14:08:26 -05:00