Commit Graph

117168 Commits

Author SHA1 Message Date
Kefu Chai
4b940cfb97
Merge pull request #38216 from rzarzynski/wip-crimson-no-pg-in-opsexecuter
crimson: make OpsExecuter unaware about the giant PG class

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-20 23:52:24 +08:00
Daniel Gryniewicz
e3013cb091 Remove copy from ceph::static_ptr
The copy functionality of ceph::static_ptr is unused, and it means that
nothing containing a std::unique_ptr (or any other non-copyable type)
can be put into a static_ptr.

Remove the copy functionality, so that unique_ptr can be used in
static_ptr.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2020-11-20 10:28:30 -05:00
Daniel Gryniewicz
c590759da0 Zipper - Assorted cleanups
- Move cluste stat into public header, allowing more zipper cleanup
- Swift versioning
- Implement a MPSerializer for Zipper.
- Add Lifecycle APIs to Zipper.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2020-11-20 10:28:30 -05:00
Daniel Gryniewicz
0905425cf1 Zipper - WriteOp
Add WriteOp to the Zipper API, and use it.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2020-11-20 10:28:30 -05:00
Jason Dillaman
2ea32d3524
Merge pull request #38122 from lxbsz/rbdmap_init
rbd: drop initd-based systems for rbdmap

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-11-20 10:17:20 -05:00
Sebastian Wagner
d9879eb001
Merge pull request #37576 from p-se/doc-cephadm-custom-monitoring-templates
mgr/cephadm: document setting custom monitoring templates for configuration files

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-11-20 16:15:39 +01:00
Sebastian Wagner
66f647b00b
Merge pull request #37696 from p-se/cephadm-monitoring-grafana-tls
doc/cepham: instructions for custom Grafana TLS certs

Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2020-11-20 15:42:28 +01:00
Kefu Chai
4070fb546d
Merge pull request #38210 from rzarzynski/wip-crimson-fix-warning-in-with_locked_obc
crimson: fix a warning in PG::with_lock_obc().

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-20 22:14:51 +08:00
Radoslaw Zarzynski
d10d267224 crimson: OpsExecuter stores only const reference to MOSDOp.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-20 14:49:01 +01:00
Radoslaw Zarzynski
0136695af5 crimson: make OpsExecuter unaware about PG.
`PG` is heavy-weight class with many responsibilities.
Exposing it to lower-layer may suggest there is far more
coupling between them than in reality.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-20 14:49:01 +01:00
Radoslaw Zarzynski
2aa627caea crimson: drop the declared but undefined PG::do_pgnls().
`PgOpsExecuter` takes care; it's not not a responsibility
of `PG` anymore.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-20 14:48:15 +01:00
Radoslaw Zarzynski
784a798374 crimson: drop the declared but undefined PG::do_osd_op().
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-20 14:48:15 +01:00
Radoslaw Zarzynski
9f27a83274 crimson: comment on why OpsExecuter needs PG.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-20 14:45:59 +01:00
Lucian Petrut
bfb0dbf006 rbd: update "rbd-wnbd show" error handling
We'll update the "rbd-wnbd show" command to return -ENOENT
when the specified mapping doesn't exist, instead of returning
-EINVAL. At the moment, it's impossible to tell if the operation
failed because of an error or the mapping simply doesn't exist.

Worth mentioning that on Windows, we can use 32b for the exit code,
which is a bit more flexible.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2020-11-20 12:42:18 +00:00
Kefu Chai
178ac34c7c
Merge pull request #38061 from tchaikov/wip-48012
mgr/dashboard: use http://docs.ceph.com/en/${release}/ for the domain…

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
2020-11-20 20:27:00 +08:00
Radoslaw Zarzynski
f9d69d4524 crimson: fix a warning in PG::with_lock_obc().
Without the fix, on a build with `NDEBUG` set,
GCC complains:

```
crimson/osd/pg.cc:869:35: warning: control reaches end of non-void function [-Wreturn-type]
  869 |   const hobject_t oid = get_oid(*m);
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-20 12:54:12 +01:00
lixiaoy1
8be1718f73 librbd/plugin: delete field m_image_ctx
librbd::plugin::ParentCache may be shared by more than one images.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
2020-11-20 06:06:15 -05:00
Kefu Chai
568baa761d
Merge pull request #38177 from jhonxue/fix-test-objectstore-allocator
test/objectstore: handle -ENOSPC returned by allocate()

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-20 18:52:46 +08:00
Guillaume Abrioux
02e6f33f08 ceph-volume: fix test_setup_device_device_name_is_none
Let's call this function by using the same syntax than other tests.
This will make it work with py2 in nautilus branch.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-11-20 11:46:51 +01:00
jhonxue
23cdcb1b47 test/objectstore: handle -ENOSPC returned by allocate()
Fixes: https://tracker.ceph.com/issues/48288

Signed-off-by: Xue Yantao <jhonxue@tencent.com>
2020-11-20 17:29:57 +08:00
Anthony D'Atri
84757fc202 doc/rados/troubleshooting: description of upgrade procedure - stopping/starting OSDs
Fixes: https://tracker.ceph.com/issues/14730
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-11-19 23:39:42 -08:00
Anthony D'Atri
3e2e3e3735 doc/rados/operations: Add description of new auth profiles 2020-11-19 23:34:32 -08:00
Anthony D'Atri
4aa98df043 doc/dev/developer_guide: "What Is Merged and When?" could be less colloquial
Fixes: https://tracker.ceph.com/issues/46364
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-11-19 23:12:02 -08:00
Anthony D'Atri
73435185a3 doc/dev/developer_guide: verb disagreement on "Testing: Unit Tests" page
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
Fixes: https://tracker.ceph.com/issues/46367
2020-11-19 23:08:23 -08:00
Anthony D'Atri
9c67b80495 doc/mgr: Fix msgr2 TCP port in a couple of examples
Fixes: https://tracker.ceph.com/issues/47976
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-11-19 22:58:10 -08:00
Anthony D'Atri
154d05fe11 doc: object -> file -> disk is wrong for bluestore
Address tracker 23443

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>

doc: object -> file -> disk is wrong for bluestore

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-11-19 22:43:59 -08:00
Kefu Chai
a74f8de1c3 mgr/dashboard: use http://docs.ceph.com/en/${release}/ for the domain of the docs
* use the URL of RTD, where the locale is encoded in it.
* s/http/https/
* add test accordingly

Fixes: https://tracker.ceph.com/issues/48012
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-20 10:31:07 +08:00
Kefu Chai
9863aa99a8
Merge pull request #38179 from tchaikov/wip-github-labeler-manpage
github/labeler: label manpages changes with related component labels

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-11-20 09:21:34 +08:00
Kefu Chai
d9f820c247
Merge pull request #38192 from rzarzynski/wip-crimson-backfill-improve-debugs
crimson: improve debugs in the backfill code

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-20 09:19:21 +08:00
Kefu Chai
fc9b8686ca
Merge pull request #38191 from rzarzynski/wip-crimson-fix-typo-in-errorator
crimson: fix a typo in errorator-related comment.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-20 09:18:34 +08:00
Kefu Chai
060016904d
Merge pull request #38197 from dillaman/wip-github-rbd-label
github/labeler: add rbd label to pybind/mgr/rbd_support

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-20 09:17:31 +08:00
Kefu Chai
5dec5c7a7f
Merge pull request #38153 from tchaikov/wip-cmake-silence-warning
cmake: set advice.detachedHead=false when cloning liburing

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-20 09:14:08 +08:00
Kefu Chai
ed15ed5196
Merge pull request #38169 from ktdreyer/cephadm-noarch
rpm: cephadm package is noarch

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-20 09:10:40 +08:00
Kefu Chai
21c8ccc3f5 github/labeler: label manpages changes with related component labels
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-20 09:04:32 +08:00
Kefu Chai
b472281184
Merge pull request #38183 from tchaikov/wip-doc-peering-diagram
doc: build peering state diagram using sphinx

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-11-20 08:59:29 +08:00
Xiubo Li
9084e6bbd2 rbd: drop initd-based systems for rbdmap
Ceph versions jewel and above only support systemd.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-11-20 08:58:11 +08:00
Jason Dillaman
2f5f16a041
Merge pull request #33750 from petrutlucian94/windows.10
rbd: add Windows RBD support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 18:47:22 -05:00
Jason Dillaman
365cb2f9ee github/labeler: add rbd label to pybind/mgr/rbd_support
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 16:13:28 -05:00
Jan Fajerski
969010da7e Merge PR #38147 into master
* refs/pull/38147/head:
	ceph-volume: cover devices.lvm.prepare.setup_device
	ceph-volume: fix filestore/dmcrypt activate

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
2020-11-19 22:09:55 +01:00
Jason Dillaman
c0069b00e4 pybind/mgr/rbd_support: delay creation of progress event
Create the progress module event upon receipt of the first
progress callback from the librbd API. This will help to ensure
that all prereqs have been validated for retryable errors like
scheduling an image to be removed while it still has attached
cloned children.

Fixes: https://tracker.ceph.com/issues/48296
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 16:09:22 -05:00
Jason Dillaman
66ddfee859 pybind/mgr/rbd_support: include retryable error message in task
If a retryable error occurs, include the reason message in the
task JSON structure that is exposed via the "rbd task list"
MGR command.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 16:09:22 -05:00
Jason Dillaman
b8a4685cf9 pybind/mgr/rbd_support: add linear backoff to retried tasks
When a task fails but will be retried, linearly increase the
delay for the next retry up to a maximum of 5 minutes.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 15:25:52 -05:00
Radoslaw Zarzynski
6403cef750 crimson: fix a debug in BackfillState::Enqueuing::Enqueuing.
Printed messages were messed up due to the erroneous comma.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-19 17:55:31 +01:00
Radoslaw Zarzynski
dd91fc1285 crimson: add a debug in update_on_peers() of the backfill code.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-19 17:55:31 +01:00
Radoslaw Zarzynski
08b9f03800 crimson: fix a typo in errorator-related comment.
It was introduced in dca575992b.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-19 17:50:57 +01:00
Adam C. Emerson
e5b74af4b5
Merge pull request #37586 from cbodley/wip-rgw-bilog-layout
rgw: add bucket index log layout structure

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2020-11-19 10:56:43 -05:00
Casey Bodley
aaf644daa9
Merge pull request #37914 from IlsooByun/rgw_invalid_resp
rgw: fix invalid payload issue when serving s3website error page

Reviewed-by: Or Friedmann <ofriedma@redhat.com>
2020-11-19 10:23:22 -05:00
Jason Dillaman
e60ff50052
Merge pull request #38182 from orozery/librbd-crypto-image-dispatch-fixes
librbd: fix crypto prepare_copyup to use new remap_extents api

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 10:01:17 -05:00
Guillaume Abrioux
9e2a0a3edd ceph-volume: cover devices.lvm.prepare.setup_device
Add some unit tests to cover setup_device() in devices.lvm.prepare

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-11-19 15:46:25 +01:00
Guillaume Abrioux
ee3aece808 ceph-volume: fix filestore/dmcrypt activate
The uuid set for tags['ceph.journal_uuid'] should point to its
corresponding lv_uuid instead of the uuid generated for the lv_name.

The variable name 'uuid' used so far was probably too confusing so let's
change it to make it more clear.

Closes: https://tracker.ceph.com/issues/48271

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-11-19 15:45:50 +01:00