* refs/pull/41314/head:
qa/tasks/nfs: add test to check if cmds fail on not passing required arguments
mgr/nfs: fix flake8 missing whitespace around parameter equals error
mgr/nfs: annotate _cmd_nfs_* methods return value
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
mgr/cephadm: fix missing prometheus alerts
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
The prometheus yaml file shouldn't use "tab" character but only spaces.
Fixes: https://tracker.ceph.com/issues/50717
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
the purposes of this change are:
* faster compilation, so the cmake generator can process .yaml.in files
in parallel.
* allow daemons to include a subset of options which it is interested
in.
* better maintainability. by grouping options in different .yaml.in
files, developers understand who are the consumers of an option.
in this change, options only read by mgr are extracted into mgr.yaml.in,
and options only read by osd are extracted into osd.yaml.in.
so all options in mgr.yaml.in should have "services: mgr" in their
definition by default. the ones in osd.yaml.in have "services: osd".
in the case where options are consumed by multiple services or tools,
the option should add "common" to its "services" if it is supposed to be
consumed by a tool, or "mon" if it is read by monitor as well.
but it takes time to audit all the options, so only part of them are
processed.
Signed-off-by: Kefu Chai <kchai@redhat.com>
This reverts commit 4e58b5899e.
the list of .yaml.in file might change over time before we finish the
.yaml.in file split, but cmake would fail to figure out the list without
rerunning "cmake", so when a new .yaml.in file is introduced, developer
might end up with a FTBFS after pulling the change from remote repo.
so, we need to revert the file(GLOB ..) change, until all .yaml.in file
are created.
Signed-off-by: Kefu Chai <kchai@redhat.com>
crimson/net: Set add_ref to false when creating a MessageRef in conn::send()
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
we should not increase the ref count when transferring the ownership from a
MessageURef instance to a MessageRef instance.
to address the memory leak introduced by
1f6e664705.
Signed-off-by: Amnon Hanuhov <ahanukov@redhat.com>
the copy constructor of seastar::gate is deleted explicitly. so we
cannot reset FixedCPUServerSocket::shutdown_gate by assigning a new
seastar::gate to it.
since we don't reuse a FixedCPUServerSocket after calling
FixedCPUServerSocket::destroy(), it's safe to leave a closed gate after
calling FixedCPUServerSocket::reset()
Signed-off-by: Kefu Chai <kchai@redhat.com>
* refs/pull/39550/head:
mgr/cephadm: induce retune of osd memory on osd creation
qa/tasks/cephadm.conf: autotune osd memory by default
mgr/cephadm: do not autotune when _no_autotune_memory label is present
mgr/cephadm: autotune osd memory
common: add osd_memory_target_autotune
mgr/cephadm: report memory usage, request (limit) in 'orch ps'
doc/cephadm/host-management: document _admin group
mgr/orchestrator: fix help formatting
Reviewed-by: Adam King <adking@redhat.com>
