Commit Graph

102318 Commits

Author SHA1 Message Date
Kefu Chai
451470e134
Merge pull request #30449 from tchaikov/wip-37884
mon,mgr: pass MessageRef to monc.send_mon_message()  …

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-09-22 11:42:43 +08:00
Kefu Chai
349e01fb42
Merge pull request #30413 from vumrao/wip-vumrao-41875
tools/rados: call pool_lookup() after rados is connected.

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-09-22 11:41:38 +08:00
Kefu Chai
2b801c26fc
Merge pull request #30409 from uweigand/cleanup-endian
src/: Clean up endian handling

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-09-22 11:38:41 +08:00
Kefu Chai
a5160be989
Merge pull request #30383 from vumrao/wip-vumrao-tools-rados-add-pgid-in-help
tools/rados: add --pgid in help

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-09-22 11:37:41 +08:00
Kefu Chai
e2c901b93f
Merge pull request #30211 from majianpeng/msg-clear-payload
msg/async: clear_payload when requeue_sent.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
2019-09-22 11:36:43 +08:00
Kefu Chai
b278284bb4
Merge pull request #30445 from tchaikov/wip-41320
mgr/dashboard: do not log tokens

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2019-09-22 11:34:58 +08:00
Kefu Chai
5e7d740bfd
Merge pull request #29947 from iotcg/nosrq
support RDMA NIC without SRQ in msg/async/rdma

Reviewed-by: Roman Penyaev <rpenyaev@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-09-22 11:33:48 +08:00
Ilya Dryomov
7bbd290de3
Merge pull request #30502 from idryomov/wip-krbd-avoid-hexdump-s
qa: avoid hexdump skip and length options

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-09-21 11:12:28 +02:00
Xie Xingguo
81764b5190
Merge pull request #30489 from liuchang0812/kill-compile-warning
rgw: kill compile warnning in rgw_object_lock.h

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-09-21 13:56:52 +08:00
Ilya Dryomov
d1b69136b0 qa: avoid hexdump skip and length options
On Debian-based distros, hexdump(1) comes from FreeBSD in bsdmainutils
package (other distros ship a Linux version from util-linux).  It turns
out that '-s skip' for anything but a regular file has been broken for
ages in FreeBSD -- instead of calling fseek(), it consumed the input
byte by byte with getchar().  This was fixed in commit 7cd5ae492557
"hexdump(1): Speed up -s flag on devices" last year, but it hasn't made
it to the Debian world yet.

bsdmainutils_9.0.6ubuntu3 in xenial had a custom patch for that, but
it's no longer there in bsdmainutils_11.1.2ubuntu1 in bionic.  hexdump
-s <large offset> is now a fancy infinite loop!

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2019-09-20 21:43:49 +02:00
Chang Liu
eb5ee0a331 rgw: kill compile warnning in rgw_object_lock.h
Signed-off-by: Chang Liu <liuchang0812@gmail.com>
2019-09-20 12:51:09 +00:00
Jason Dillaman
057547fadb
Merge pull request #30484 from trociny/wip-handle_start_replay_interrupted
rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-09-20 07:55:00 -04:00
Kefu Chai
12d301a199 mgr: pass MessageRef to monc.send_mon_message()
less chance to leak memory

see also: https://tracker.ceph.com/issues/37884

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-20 18:21:56 +08:00
Kefu Chai
7df36081d1 mon/MonClient: include necessary #includes
ideally, a header file should be self-contained.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-20 18:21:56 +08:00
Kefu Chai
a144cacdd8 mon/MonClient: add send_mon_message(MessageRef)
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-20 18:21:56 +08:00
Kefu Chai
cb9127ab92 messages/MLog: pass rvalue ref instead const ref to ctor
easier to use this way. and so far, there is no caller of this function
yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-20 18:21:56 +08:00
Lenz Grimmer
b2ca51a8bf
mgr/dashboard Adds multiple selection in osd table (#29662)
mgr/dashboard Adds multiple selection in osd table

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-09-20 09:21:28 +00:00
Mykola Golub
72076d3a0c
Merge pull request #30438 from dillaman/wip-41833
cls/rbd: sanitize entity instance messenger version type

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-09-20 11:59:27 +03:00
Mykola Golub
a01597b00f rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay
Signed-off-by: Mykola Golub <mgolub@suse.com>
2019-09-20 09:25:01 +01:00
Kefu Chai
a363dea882
Merge pull request #30474 from tchaikov/wip-discard-future
crimson: run in foreground if possible, silence warnings

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-09-20 10:51:54 +08:00
Yuval Lifshitz
751c4514e0
Merge pull request #28971 from yuvalif/wip-yuval-pubsub-api2
rgw/pubsub: add S3 compliant API to master zone
2019-09-20 01:35:02 +03:00
Alfredo Deza
41e456a4d6
Merge pull request #30101 from rishabh-d-dave/cv-minor
ceph-volume: api/lvm: check if list of LVs is empty

Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2019-09-19 15:10:49 -04:00
Casey Bodley
bd94272cd2
Merge pull request #19020 from zhangsw/feature-rgw-bucketsync-api
rgw: add admin rest api for bucket sync

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:33:47 -04:00
Casey Bodley
125ab97d88
Merge pull request #29637 from liuchang0812/rgw-es7
rgw: sync with elastic search v7

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 14:24:47 -04:00
Casey Bodley
3993a72412
Merge pull request #29897 from tianshan/fix_list_start_with_null_marker
rgw: fix list versions starts with version_id=null

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:23:31 -04:00
Casey Bodley
30b3ecbcc6
Merge pull request #29909 from cbodley/wip-40935
rgw: fix default storage class for get_compression_type

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 14:22:18 -04:00
Casey Bodley
d5d0d7fef3
Merge pull request #30127 from zhangsw/rgw-fix-adminuser
rgw: add missing admin property when sync user info.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:21:37 -04:00
Casey Bodley
026eed47d2
Merge pull request #30163 from zhangsw/feature-rgw-opslog-transid
rgw: add transaction id to ops log.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:20:50 -04:00
Casey Bodley
b087c4eacd
Merge pull request #30175 from tianshan/improve-data-sync-retry
rgw: improve data sync restart after failure

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:18:59 -04:00
Casey Bodley
20159f03e0
Merge pull request #30189 from linuxbox2/wip-rgw-ss3lite
rgw: crypt: permit RGW-AUTO/default with SSE-S3 headers

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:18:14 -04:00
Casey Bodley
2c82b290e9
Merge pull request #30194 from vumrao/wip-vumrao-41589
radosgw-admin: add --uid check in bucket list command

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-09-19 14:17:35 -04:00
Casey Bodley
49d0395317
Merge pull request #30332 from linuxbox2/wip-ldap-denied
rgw: ldap auth: S3 auth failure should return InvalidAccessKeyId

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 14:16:29 -04:00
Casey Bodley
c18db0c40b
Merge pull request #30384 from ZVampirEM77/bucket-create-time
rgw: add creation time information into bucket stats

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:15:33 -04:00
Abhishek L
89945b1bf3
Merge pull request #29680 from liuchang0812/s3-lock-bugfix
rgw: DefaultRetention requires either Days or Years

Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 19:41:00 +02:00
Venky Shankar
7cdad344b9
Merge pull request #30451 from ajarr/fix-41903
mgr/volumes: return string type to ceph-manager
2019-09-19 18:58:32 +05:30
Lenz Grimmer
bbb580e938
mgr/dashboard: Add smartctl data as an details tab of an OSD (#30324)
mgr/dashboard: Add smartctl data as an details tab of an OSD

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-09-19 12:48:51 +00:00
Samuel Just
c30fa85f1d crimson/osd: suppress warnings about unused future<> return values
These are dropped on purpose, suppress warnings.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
e541750959 crimson/osd: ShardServices::send_pg_temp() returns future
it should not run in background unless necessary.

please note, we don't have a caller of this method yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
1a8841cfe3 crimson/osd: evict object state in foreground
when doing error handling, we need to make sure the stale object state
is evicted before we return.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
c345b593da crimson/osd: add_peer() in parallel
we should not add peers in background, and we can do this in parallel!

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
6d5f5ed69c crimson/osd: Heartbeat::add_reporter_peers() returns future
the sole caller `Heartbeat::update_peers()` also returns future, so
there is no reason that `add_reporter_peers()` runs in background.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
4aed49b626 crimson/osd: fix the order in OSD::update_heartbeat_peers()
before this chance, we do following things in background and in
parallel:

* add peers from pg map
* and peers from whole osdmap
* remove dead peers

but we should prioritize the peer candidates, apparently, the ones from
pgmap should have higher priority. as they are more likely to be used in
cluser and they are more important to current OSD, as they serve the
same set of PGs.

so we need to do these things in a proper order:

1. add peers from pg map
2. and peers from whole osdmap
3. remove dead peers

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
b102c44291 crimson/osd/heartbeat: avoid racing when connecting to peer
before this change, we could initialize connections to newly added peers
in parallel repeatly, if an OSD is listed in up/acting of multiple PGs
served by current OSD.

after this change, we try to add the peer to `Heartbeat.peers` first,
and then try to connect to it with the hb front/back addresses, to avoid
potential repeatly connecting to peer.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Ricardo Dias
efe91beccf
Merge pull request #30270 from ricardoasmarques/wip-41727
mgr/dashboard: Check if `num_sessions` is available

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-09-19 11:08:48 +01:00
Venky Shankar
88aa0576a6 mgr/volumes: return string type to ceph-manager
The 'volumes' ceph-mgr module returns a byte type instead of a string
type as the stdout result of commands, `fs subvolume getpath` and
`fs subvolumegroup getpath` to the ceph-mgr. This causes the commands
to hang and the ceph-mgr to utilize 100% CPU. Fix the 'volumes'
ceph-mgr module to return string type to ceph-mgr as the stdout
result of the commands.

Introduced-by: 3d63cd947f
Fixes: https://tracker.ceph.com/issues/41903
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-09-19 14:56:26 +05:30
Kefu Chai
b82fd0320d crimson/osd: do not cluster_msgr.set_myaddrs() in background
we should do the initialization in foreground

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 16:31:26 +08:00
Samuel Just
bb2bd5f42a crimson/net: avoid warning about signed comparison with enum classes
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-09-19 15:16:23 +08:00
Kefu Chai
3d7e5b0e3f
Merge pull request #30410 from tchaikov/wip-debian-g++
debian/control: Build-Depends on g++

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
2019-09-19 10:02:02 +08:00
Kefu Chai
e7287257ef
Merge pull request #30405 from p-se/wip-pna-ubuntu-disco-deps
install-deps.sh: add support for Ubuntu Disco Dingo

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-09-19 10:01:07 +08:00
Kefu Chai
51dd3740db
Merge pull request #30453 from tchaikov/wip-doc-crimson
doc/dev/crimson: transpose options of compare.py

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-09-19 09:22:19 +08:00