Commit Graph

104806 Commits

Author SHA1 Message Date
Kefu Chai
42579be473 mgr/orchestrator: add optional "format" param for "orchestrator host ls"
and update the test accordingly

Fixes: https://tracker.ceph.com/issues/43078
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-12-02 19:27:57 +08:00
Sage Weil
c6dd4228e2 Merge PR #31900 into master
* refs/pull/31900/head:
	mgr: fix debug typo

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-12-01 20:16:31 -06:00
Sage Weil
98c09315d9 Merge PR #31442 into master
* refs/pull/31442/head:
	kv/RocksDBStore: Add minimum key limit before invoking DeleteRange.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-12-01 20:12:00 -06:00
Laura Paduano
2fdc518941
Merge pull request #31165 from votdev/improve_py_unittests
mgr/dashboard: Refactor Python unittests and controller

Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2019-11-29 11:04:57 +01:00
Kefu Chai
656c8e8049
Merge pull request #31856 from rzarzynski/wip-crimson-errorator-handle_error
crimson/common/errorator.h: add handle_error() method.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-29 13:49:26 +08:00
Kefu Chai
22160a6854
Merge pull request #31853 from liewegas/fix-rn-typo
PendingReleaseNotes: fix typo

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-29 10:27:36 +08:00
Kefu Chai
bfc34b2456
Merge pull request #31918 from rzarzynski/wip-crimson-errorator-simplify_safe_then
crimson/common/errorator.h: simplify the compound safe_then() variant.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-29 08:24:01 +08:00
Sage Weil
fa689411d1 Merge PR #31838 into master
* refs/pull/31838/head:
	ceph-daemon: chown uid/gid files during `adopt`
	ceph-daemon: use 'iglob' instead of 'glob'
	ceph-daemon: Fix handling for symlinks on python2

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-28 15:28:47 -06:00
Radoslaw Zarzynski
7518cf91c2 crimson/common/errorator.h: simplify the compound safe_then() variant.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-11-28 16:39:23 +01:00
Radoslaw Zarzynski
33e0dba013 crimson/common/errorator.h: add handle_error() method.
In contrast to `safe_then` it deals only with errors
and, on return, leaves the value type `future<ValueT>`
embodies unchanged.
While being basically a specialization of `safe_then`,
it's also a convenience method to squeeze boilerplate.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-11-28 16:36:08 +01:00
Sage Weil
be6dd892e4 Merge PR #31914 into master
* refs/pull/31914/head:
	mgr/orchestrator: set node labels to empty list if none specified

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
2019-11-28 08:54:19 -06:00
Volker Theile
0cde6a0e6f
mgr/dashboard: support creating OSDs on spare devices (#30921)
mgr/dashboard: support creating OSDs on spare devices

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2019-11-28 13:18:22 +01:00
Laura Paduano
041a71b3e8
Merge pull request #31785 from votdev/cleanup_remove_useless_var
mgr/dashboard: Remove unused variable

Reviewed-by: Kiefer Chang kiefer.chang@suse.com
Reviewed-by: Stephan Müller <smueller@suse.com>
2019-11-28 11:44:50 +01:00
Laura Paduano
b0057c02ba
Merge pull request #31720 from rhcs-dashboard/fix-42708-master
mgr/dashboard: remove traceback/version assertions

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-11-28 11:36:32 +01:00
Laura Paduano
fdf0829d3a
Merge pull request #31843 from votdev/rename_list_pipe
mgr/dashboard: Rename pipe list -> join

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
2019-11-28 11:28:20 +01:00
Tim Serong
49659746e2 mgr/orchestrator: set node labels to empty list if none specified
f06366836f tries to ' '.join(node.labels), which raises an exception
if labels is None, so we need to default it to an empty list.

Signed-off-by: Tim Serong <tserong@suse.com>
2019-11-28 16:26:15 +11:00
Neha Ojha
0cd95b9f0f
Merge pull request #31588 from usefulalgorithm/patch-1
doc/rados/operations: OSD_OUT_OF_ORDER_FULL fullness order is wrong

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-11-27 17:33:38 -08:00
Sage Weil
6a1c1a120c Merge PR #31870 into master
* refs/pull/31870/head:
	ceph-daemon: fix `systemctl is-enabled` bool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-27 14:20:33 -06:00
Sage Weil
006b789148 Merge PR #31886 into master
* refs/pull/31886/head:
	ceph-daemon: error out if not root
	ceph-daemon: user-friendly exception/error messages
	ceph-daemon: user-friendly exception/error messages

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2019-11-27 14:20:04 -06:00
Jan Fajerski
b9578b407b
Merge pull request #31883 from jan--f/ceph-volume-code-owner
github/codeowners: add ceph-volume
2019-11-27 16:36:23 +01:00
Sage Weil
b2d9e1a219 Merge PR #31892 into master
* refs/pull/31892/head:
	ceph-daemon: seek relative to the start of file

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-27 08:36:12 -06:00
Sage Weil
e4930055c1 Merge PR #31899 into master
* refs/pull/31899/head:
	mgr: drop session with Ceph daemon when not ready
	mgr: improve debug message information

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-27 08:04:14 -06:00
Sage Weil
c8fa419326 ceph-daemon: error out if not root
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-27 08:01:45 -06:00
Michael Fritch
239f820112 ceph-daemon: user-friendly exception/error messages
- Rename `CDError` to `Error`
- Display traceback on console when `-v` is specified
- Other misc clean-up

Signed-off-by: Michael Fritch <mfritch@suse.com>
2019-11-27 08:01:26 -06:00
Sebastian Wagner
fc3fdece30
Merge pull request #30262 from sebastian-philipp/orchestrator-pomise-future
mgr/orchestrator: Make Completions composable

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Joshua Schmid <jschmid@suse.de>
2019-11-27 14:58:21 +01:00
Sebastian Wagner
7a801cb13f mgr/ssh: Disable host labels.
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:49:02 +01:00
Kefu Chai
0abd3f4a11
Merge pull request #31896 from rsevero/missing_virtualenv
doc: add missing virtualenv for build-doc

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-27 20:48:40 +08:00
Tim Serong
0eaa7710c0 mgr/orchestrator: use finalize to set TrivialReadCompletion result
This is needed to correctly set the state of the completion, so that
Completion.has_result returns true.  Without this, _orchestrator_wait()
will spin forever if given a TrivialReadCompletion.

Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:39:12 +01:00
Sebastian Wagner
7b95f0316d mgr/orchestrator: add pretty_print()
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:39:11 +01:00
Sebastian Wagner
e58885dc98 mgr/ssh: Fix Promises
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:39:11 +01:00
Sebastian Wagner
30437ba2eb import typing optionally
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
431e801f89 Fix testing error
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
cf38941628 mgr/deepsea: Fixed DeepSeaReadCompletion arguments
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
65a9c9aa6d mgr/orchestrator: fix tests
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
07121b9b4f make check fixes
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
310f5090ab mgr/orchstrator: Removed all type anotations incompatible to Python 2
* Reduce mypy's type checking capability
* Remove useful code documentation

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
a74d57bcb2 doc/orchestrator: Adapted to new Completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
de0c198932 mgr/orchestrator: add cancel
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
6abc9e95bd qa/orchestrator: Adapt teuthology test to new completions
Also: Adapt mgr/test_orchestrator to new completions

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
d15aba9039 mgr/deepsea: Adapt to new orchestrator completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
5191e82a88 mgr/ansible: Adapt to new orchestrator completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
f3ea1f18e2 mgr/ssh: Adapt ssh orch to new Completions interface
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
bf552615f2 mgr/rook: Adapt to new completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:35:24 +01:00
Sebastian Wagner
7a432a0225 mgr/orchestrator: Introduce composable completions
Also:

* unify Read and Write completions
* Distinguish should_wait and is_finished
* Removed `all_hosts` parameter to `osd_create`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:35:24 +01:00
Sebastian Wagner
8fa14ad3b8 mgr/orchestrator: rename wait() -> process()
Because wait() should actually not wait!

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:35:24 +01:00
Kefu Chai
f16d664749
Merge pull request #31904 from tchaikov/wip-crimson-stop-msgr-after-stopping-osd
crimson: stop osd before stopping messengers

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-11-27 19:46:42 +08:00
Volker Theile
c82901632f mgr/dashboard: Remove unused variable
Signed-off-by: Volker Theile <vtheile@suse.com>
2019-11-27 12:12:55 +01:00
Volker Theile
2ad2763469 mgr/dashboard: Rename pipe list -> join
Signed-off-by: Volker Theile <vtheile@suse.com>
2019-11-27 11:33:33 +01:00
Kefu Chai
642f68159e crimson: stop osd before stopping messengers
so we can drain all pending tasks referencing messenger before
destroying it, otherwise they will be using a already-stopped
messenger when they are still alive.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-11-27 17:35:20 +08:00
Patrick Donnelly
22a9a28e28
Merge PR #31756 into master
* refs/pull/31756/head:
	pybind / cephfs: remove static typing in LibCephFS.chown

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-11-26 15:53:48 -08:00