Commit Graph

130119 Commits

Author SHA1 Message Date
Yuri Weinstein
42053fbd43
Merge pull request #45468 from idryomov/wip-pool-reverse-lookup-osdmap
librados: check latest osdmap on ENOENT in pool_reverse_lookup()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2022-03-23 07:45:42 -07:00
Ernesto Puerta
9aa5c79363
Merge pull request #45429 from votdev/issue_54591_language_dropdown
mgr/dashboard: Language dropdown box is partly hidden on login page

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-03-23 12:50:41 +01:00
Jos Collin
8e0ce34ea5
Merge pull request #45577 from wxypro/mgr-stat-fix
mgr/stats: fix a typo in comment

Reviewed-by: Jos Collin <jcollin@redhat.com>
2022-03-23 16:36:42 +05:30
Ilya Dryomov
cb0d0fec3f
Merge pull request #44579 from asm0deuz/fix_pids_limits_bug_52898
cephadm: Remove containers pids-limit

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-23 08:44:13 +01:00
wangxinyu
1dda0aa686 mgr/stats: fix an typo in comment
fix an typo in comment

Signed-off-by: wangxinyu <wangxinyu@inspur.com>
2022-03-23 15:31:01 +08:00
Josh Durgin
fe41f0bf7d
Merge pull request #45512 from zdover23/wip-doc-2022-03-18-master-to-main
ceph/admin: s/master/main

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2022-03-22 16:38:40 -07:00
Adam King
73f8d0fdcd
Merge pull request #45286 from adk3798/ssh-offline
mgr/cephadm: add keep-alive requests to ssh connections

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2022-03-22 18:00:22 -04:00
Adam King
5301c3737c
Merge pull request #45333 from s0nea/config-fqdn
mgr/cephadm: try to get FQDN for configuration files

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2022-03-22 17:58:28 -04:00
Ilya Dryomov
f0ade57458 qa/suites/orch/cephadm: restrict test_iscsi_pids_limit to CentOS
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-22 21:42:41 +01:00
Teoman ONAY
de8b3c2676 cephadm: remove containers pids-limit
The default pids-limit (docker 4096/podman 2048) prevent some
customization from working (http threads on RGW) or limits the number
of luns per iscsi target.

Fixes: https://tracker.ceph.com/issues/52898
Signed-off-by: Teoman ONAY <tonay@redhat.com>
2022-03-22 21:41:26 +01:00
Ernesto Puerta
31699a99cf
Merge pull request #45269 from kalaspuffar/table_fix
mgr/dashboard: Table columns hiding fix

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: kalaspuffar <NOT@FOUND>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-03-22 19:35:43 +01:00
Ernesto Puerta
c90c92a776
Merge pull request #45510 from ceph/fix-github_workflow-master
.github: continue on error

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-03-22 18:35:50 +01:00
Daniel Gryniewicz
115c8b2398
Merge pull request #44616 from dang/wip-dang-zipper-objctx
RGW - Zipper - remove RGWObjectCtx from SAL API

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
2022-03-22 12:17:24 -04:00
Ernesto Puerta
dc2384b23d
Merge pull request #45533 from rhcs-dashboard/update-grafana-version
mgr/dashboard/monitoring: update grafana version

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-03-22 16:27:25 +01:00
Adam King
9671f179be
Merge pull request #45420 from mgfritch/cephadm-infer-image-pull
cephadm: infer the default container image during pull

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-03-22 08:51:57 -04:00
Daniel Gryniewicz
db6104af8d
Merge pull request #45506 from dang/wip-dang-53614
RGW - Make admin bucket chown accept marker

reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-22 08:36:20 -04:00
Ernesto Puerta
c3127f3a13
Merge pull request #45360 from rhcs-dashboard/fix-54481-master
mgr/dashboard: fix wrong pg status processing

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-03-22 13:07:58 +01:00
Ilya Dryomov
acf835db03
Merge pull request #45353 from PepperJo/readv_writev_overflow_v2
librbd: readv/writev fix iovecs length computation overflow

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-22 11:13:46 +01:00
Ilya Dryomov
7a6ddd5d1e
Merge pull request #45285 from chrisphoffman/wip-rbd-du-validate
test/librbd: add test to verify diff_iterate size

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-22 11:11:53 +01:00
Yuri Weinstein
622f197448
Merge pull request #45221 from rzarzynski/wip-core-drop-unused-aiocompletion-in-librados
core, test: fix compile-time warnings

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-21 14:12:39 -07:00
Samuel Just
155e739cae
Merge pull request #45415 from Matan-B/wip-matanb-watch-r-buffer
crimson/osd: fix osd crash due to buffer reference binding

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-21 11:31:42 -07:00
Casey Bodley
217c328513
Merge pull request #45050 from hualongfeng/qatchange
common/compressor: fix the issue that cannot processed concurrently

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-21 09:40:55 -04:00
Venky Shankar
88ddf3350e
Merge pull request #44491 from nmshelke/fix-46075
ceph-fuse: ignore fuse mount failure if path is already mounted

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-21 18:39:35 +05:30
Aashish Sharma
c306778889 mgr/dashboard/monitoring: update grafana version
Fixes: https://tracker.ceph.com/issues/54311

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2022-03-21 17:40:03 +05:30
Venky Shankar
1bc4cc5d44
Merge pull request #45406 from wxypro/fix-typos
docs,options: fix typos 

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-21 15:29:19 +05:30
Ilya Dryomov
df0506fd3d
Merge pull request #45525 from idryomov/wip-rbd-trash-purge-schedule-relax-assert
qa/workunits/rbd/cli_generic.sh: relax trash purge schedule status assert

Reviewed-by: Mykola Golub <mgolub@suse.com>
2022-03-21 10:22:53 +01:00
Liu-Chunmei
00b9fb6263
Merge pull request #45517 from liu-chunmei/crimson-fix-cmpxattr
crimson: let read operation return result in MOSDOpReply

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-03-20 22:40:28 -07:00
Feng Hualong
aba2ac13fc common/compressor: fix the issue that cannot processed concurrently
Now, one session cannot support concurrent and it will lead to crash.
So there are mutil session using. At same time, it also can improve
the performance.

Fixes: https://tracker.ceph.com/issues/54361

Signed-off-by: Feng Hualong <hualong.feng@intel.com>
2022-03-21 09:22:57 +08:00
Ilya Dryomov
90a90ad47d qa/workunits/rbd/cli_generic.sh: relax trash purge schedule status assert
Commit 08df6e0fd0 ("qa/workunits/rbd: expand LevelSpec parsing
coverage") didn't account for images with a separate data pool.  This
was missed because of small-cache-pool.yaml breakage.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-19 14:54:00 +01:00
Chunmei Liu
3b5e838691 crimson: let read operation return result in MOSDOpReply
otherwise cmp_xattr will failed,
only check if return result for write operation.

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-18 19:58:43 -07:00
Liu-Chunmei
a43b68294c
Merge pull request #45518 from liu-chunmei/crimson-fix-read-length
crimson: set returned read length in op.extent.length not in rval

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-03-18 19:55:31 -07:00
Kefu Chai
ad0742365d
Merge pull request #45520 from rzarzynski/wip-crimson-rvalue-in-future-set_callback
crimson/common, seastar: bump up to a newer version. Fix a FTBFS

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-19 09:46:51 +08:00
Ernesto Puerta
7cad69fd93
Merge pull request #44835 from rhcs-dashboard/cypress-cucumber
mgr/dashboard: BDD approach for the dashboard cephadm e2e

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-03-18 18:12:16 +01:00
Casey Bodley
26cc3fd6b5
Merge pull request #45345 from cbodley/wip-cls-rgw-suggest-version
cls/rgw: rgw_dir_suggest_changes detects race with completion

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2022-03-18 11:42:50 -04:00
Casey Bodley
72d0675094
Merge pull request #45300 from soumyakoduri/wip-skoduri-lc-sync
rgw: Update "CEPH_RGW_DIR_SUGGEST_LOG_OP" for remove entries

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
2022-03-18 11:41:35 -04:00
Tatjana Dehler
4f14993b16
mgr/cephadm: try to get FQDN for inventory address
Fixes: https://tracker.ceph.com/issues/54502
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2022-03-18 15:56:54 +01:00
Tatjana Dehler
30385068ee
mgr/cephadm: unify way to get the host address
There are two different ways to get the host address. From the
inventory of the mgr object directly or via the `_inventory_get_addr`
method of `CephadmService`. Update the code in order to use the
`_inventory_get_addr` method only.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2022-03-18 15:54:49 +01:00
Radosław Zarzyński
4830f33b56 seastar: bump up to a newer version.
It's needed to addresses a FTBFS due to the Seastar's
no-locking-when-throwing hack.

Tags: seastar submodule
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-03-18 15:50:44 +01:00
Radosław Zarzyński
873b5edf40 crimson/common: pass rvalue reference to future::set_callback().
It's necessary since 710a1bfdc02202fe9e59df8ea31de5b82b893fb4
in Seastar.

This change is a part of ongoing upgrade of Seastar which will
be completed in a follow-up PR, after merging another change
with the Seastar's upstream.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-03-18 15:50:44 +01:00
Jonas Pfefferle
e50405ef85 librbd: readv/writev fix iovecs length computation overflow
iovec have unsigned length (size_t) and before this patch the
total length was computed by adding iovec's length to a signed
length variable (ssize_t). While the code checked if the resulting
length was negative on overflow, the case where length is positive
after overflow was not checked. This patch fixes the overflow check
by changing length to unsigned size_t.

Additionally, this patch fixes the case where some iovecs have been
added to the bufferlist and the aio completion has been blocked, but
adding an additional iovec fails because of overflow. This leads to
the UserBufferDeleter trying to unblock the completion on destruction
of the bufferlist but asserting because the completion was never
armed. We avoid this by first computing the total length and checking
for overflows and iovcnt before adding them to the bufferlist.

Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
2022-03-18 09:26:48 +01:00
Chunmei Liu
7b96ba484f crimson: set returned read length in op.extent.length not in rval
rval set to be zero, means read success.
otherwise CReadOpsTest failed.

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-17 22:47:00 -07:00
Kefu Chai
e2c1101b69
Merge pull request #45419 from tchaikov/wip-cxx20-fixes-core
osd, common: C++20 related fixes

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2022-03-18 11:18:34 +08:00
Zac Dover
6a1dd3a8a2 ceph/admin: s/master/main
This PR changes the name "master" to "main" so
that builds (and, I assume, a great many other
things) will not fail.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-03-18 09:05:45 +10:00
Casey Bodley
228b7f6658
Merge pull request #45391 from mkogan1/wip-fix-lc-alloc
rgwlc: fix segfault during lc

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-17 17:12:25 -04:00
Yuri Weinstein
688e463a0d
Merge pull request #45103 from jtlayton/wip-54280
osd: allow sparse reads with a non-zero truncate-seq

Reviewed-by: Xiubo Li <xiubli@redhat.com>
2022-03-17 12:55:49 -07:00
Ernesto Puerta
b6791ee09a
.github: continue on error
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-03-17 20:53:31 +01:00
Matt Benjamin
73ef518b2b
Merge pull request #40703 from linuxbox2/wip-rgwlc-noreset
rgwlc: remove explicit lc shard resets at start-of-run
2022-03-17 14:03:19 -04:00
Yuri Weinstein
53df8bafed
Merge pull request #45392 from sseshasa/wip-snaptrim-qos-with-mclock
mon, osd: Add snaptrim stats to the existing PG stats.

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-03-17 09:48:12 -07:00
Matt Benjamin
0c42370d60 rgwlc: restore already_run_today guard
On review, this constraint was correct--it does reliably prevent
same-cycle re-runs when a lc threads rendezvous on a bucket.

Also, for concurrent (or stale) and already processed buckets,
remember to advance head past the corresponding buckets.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2022-03-17 11:08:12 -04:00
Matt Benjamin
0ecc2b8fc0 rgwlc: prevent multiple runs per scheduling cycle
Restore (and robustify) the assertion that, in general, each bucket
shard should be processed once per scheduling cycle.

If the prior cycle did not finish, processing in the current cyhcle
will continue from the marker where the last cycle left off.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2022-03-17 11:08:03 -04:00