Commit Graph

137270 Commits

Author SHA1 Message Date
Zac Dover
41684ebd33 doc/rados: edit ops/monitoring.rst (2 of 3)
Line-edit the second third of doc/rados/operations/monitoring.rst.

Follows https://github.com/ceph/ceph/pull/50670.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-04-04 05:24:33 +10:00
Anthony D'Atri
66552a560f
Merge pull request #50818 from anthonyeleven/anthonyeleven/tweak-fs-volumes.rst
doc/cephfs: Improve fs-volumes.rst
2023-04-02 01:47:36 -04:00
Anthony D'Atri
c8e1f3ac3d doc/cephfs: Improve fs-volumes.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2023-04-01 01:05:20 -04:00
zdover23
b682861f86
Merge pull request #50670 from zdover23/wip-doc-2023-03-26-rados-operations-monitoring-1-of-3
doc/rados: edit ops/monitoring.rst (1 of 3)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-04-01 05:48:39 +10:00
Zac Dover
bc5f404a78 doc/rados: edit ops/monitoring.rst (1 of 3)
Line-edit the first third of doc/rados/operations/monitoring.rst.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-04-01 05:23:01 +10:00
Rishabh Dave
989f7ecee5
Merge pull request #46905 from lxbsz/wip-quota
mds: align quota.max_bytes to 4MB or 4KB

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2023-04-01 00:12:19 +05:30
Rishabh Dave
75b12e4c00
Merge pull request #49882 from zhsgao/dump_resolve_status
mds: fix bug of dump_resolve_status

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2023-04-01 00:10:05 +05:30
Rishabh Dave
0e1e26e27a
Merge pull request #50024 from kotreshhr/mds-unused-function-removal
mds: Remove unused declaration of the function

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2023-04-01 00:06:49 +05:30
Casey Bodley
6a46f9f2e9
Merge pull request #50746 from cbodley/wip-rgw-bucket-full-sync-compat
rgw: set init_check_compat when bucket sync status doesn't exist

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
2023-03-31 14:34:42 -04:00
Ali Maredia
1d1672e854
Merge pull request #50644 from cbodley/wip-59135
qa/rgw: upgrade tests restrict supported distros
2023-03-31 14:27:26 -04:00
Casey Bodley
01096e840a
Merge pull request #50690 from cbodley/wip-59174
rgw/admin: 'data sync status' formats binary error repo entries

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2023-03-31 13:48:52 -04:00
Casey Bodley
df21f6d37b
Merge pull request #50462 from matutter/main
sts: Fixes get_cert_url improper url path concatenation

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
2023-03-31 13:47:48 -04:00
Casey Bodley
12f9cb5e88
Merge pull request #50623 from VVoidV/fix-rgw_admin
[RGW]fix minor bug in rgw_admin

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2023-03-31 13:47:18 -04:00
Casey Bodley
8fb26b219d
Merge pull request #50648 from cbodley/wip-58035
rgw: fix CopyObj crash after admin override

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
2023-03-31 13:43:01 -04:00
Anthony D'Atri
cf40777309
Merge pull request #50817 from bluikko/patch-10
doc/cephfs: refer to placement of MDS and not NFS in fs-volumes.rst
2023-03-31 09:18:15 -04:00
Ville Ojamo
d5343396aa
doc/cephfs: refer to MDS and not NFS in fs-volumes.rst
Placement should talk about MDS placement and not NFS Ganesha placement.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2023-03-31 19:01:39 +07:00
Ilya Dryomov
e1c5ea5420
Merge pull request #50793 from petrutlucian94/allperms
include: move ALLPERMS definition to compat.h

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-03-31 10:54:45 +02:00
Lucian Petrut
a2966c0817 include: move ALLPERMS definition to compat.h
The Windows CI job started to fail as some libcephfs tests that use
ALLPERMS have been moved [1] to a separate file which doesn't have
the ALLPERMS definition.

  /ceph/src/test/libcephfs/suidsgid.cc:240:36: error: ‘ALLPERMS’ was
  not declared in this scope
  240 |   ASSERT_EQ(stx.stx_mode & (mode_t)ALLPERMS, before_mode);

We'll move this definition to compat.h so that we won't have to
redefine it in each file that uses it.

Note that we're moving the Windows "fs_compat.h" include up,
ensuring that the constants used by ALLPERMS are defined.

[1] 254eeb2730

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-03-31 07:09:37 +00:00
Guillaume Abrioux
b538d6adb6
Merge pull request #49586 from mohan7427/mohan/batch_args-issue
ceph-volume: fix drive-group issue that expects the batch_args to be a string
2023-03-31 09:07:43 +02:00
zdover23
60195779a7
Merge pull request #50554 from zdover23/wip-doc-2023-03-16-rados-operations-pg-repair
doc/rados: line-edit pg-repair.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-31 16:45:06 +10:00
zdover23
f66bdb87f7
Merge pull request #45354 from dvanders/dualdoc
doc/msgr2: update dual stack status

Reviewed-by: Zac Dover <zac.dover@proton.me>
2023-03-31 16:25:31 +10:00
Nizamudeen A
7a7ab80e42
Merge pull request #50426 from rhcs-dashboard/role-create
mgr/dashboard: creation of rgw roles

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-03-31 10:42:09 +05:30
Venky Shankar
365895fb2d Merge PR #49460 into main
* refs/pull/49460/head:
	qa: fix issue with fn unable to fetch port and ip
	qa: fix helper function _check_nfs_cluster_status()
	qa: fix testcase 'test_cluster_set_user_config_with_non_existing_clusterid'
	qa: fix cluster creation failure in test_nfs.py
	qa: test export creation at filepath and symlink
	qa: added test case test_nfs_export_with_invalid_path
	mgr/nfs: disallow non-existent paths when creating export
	mgr/nfs/tests: mock check_cephfs_path
	mgr/nfs/utils: add helper func to check cephfs path

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2023-03-31 09:32:37 +05:30
zdover23
37280a387d
Merge pull request #50674 from zdover23/wip-doc-2023-03-26-rados-operations-health-checks-1-of-5
doc/rados/ops: edit health-checks.rst (1 of 5)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-31 09:38:03 +10:00
Laura Flores
8bf4784c5a
Merge pull request #50794 from ljflores/wip-crontab
qa/crontab: check older builds on teuthology/nop when necessary
2023-03-30 15:42:28 -05:00
Adam King
c36a07d425
Merge pull request #49824 from adk3798/iscsi-etc-hosts
cephadm: mount host /etc/hosts for daemon containers in podman deployments

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-03-30 12:24:32 -04:00
Adam King
0022f3f952
Merge pull request #50328 from adk3798/maintenance-mode-force
mgr/cephadm: add more aggressive force flag for host maintenance enter

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-03-30 12:20:58 -04:00
Adam King
7f2dec6312
Merge pull request #50547 from adk3798/ssh-denied-error-handling
mgr/cephadm: handle HostConnectionError when checking for valid addr

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2023-03-30 12:18:53 -04:00
Adam King
9f5af55ac2
Merge pull request #50607 from adk3798/keepalive-2-2-4
cephadm: bump default keepalived image to 2.2.4

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2023-03-30 12:16:29 -04:00
Adam King
5eee6d0b77
Merge pull request #50655 from rkachach/fix_issue_58158
mgr/cephadm: increasing container stop timeout for OSDs

Reviewed-by: Adam King <adking@redhat.com>
2023-03-30 12:14:33 -04:00
Adam King
70b53ba4b8
Merge pull request #50685 from rkachach/fix_issue_59170
mgr/cephadm: fixing ceph-exporter prometheus's job section

Reviewed-by: avanthakkar <avanjohn@gmail.com>
2023-03-30 11:54:52 -04:00
Laura Flores
7f6c3f393e qa/crontab: check older builds on teuthology/nop when necessary
Today's scheduled run failed since the newest build of main
had failed. If we add `-n 10` to the command, this will
make it so we start at the newest build and backtrack
up to 10 older builds if necessary.

A higher number than that is not necessary, as the suite
failing to run will signal to us that more than the last
10 main builds are broken in Shaman.

Signed-off-by: Laura Flores <lflores@redhat.com>
2023-03-30 10:38:14 -05:00
Casey Bodley
3c0d618311 test/rgw: ceph_test_librgw_file target also builds associated tests
this just makes it easier to build all of the tests needed by the
test_librgw_file.sh workunit

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-30 11:13:42 -04:00
Matt Benjamin
de776bcc31
Merge pull request #50684 from yuvalif/wip-yuval-fix-59136
rgw/notifications: support bucket notification with bucket policy
2023-03-30 10:25:16 -04:00
dparmar18
310286fa18 qa: fix issue with fn unable to fetch port and ip
_get_port_ip_info() fails to fetch port and ip due to empty 'backend' key:

2023-02-24T20:49:09.084 DEBUG:teuthology.orchestra.run.smithi042:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph nfs cluster info test
2023-02-24T20:49:09.471 INFO:teuthology.orchestra.run.smithi042.stdout:{
2023-02-24T20:49:09.472 INFO:teuthology.orchestra.run.smithi042.stdout:  "test": {
2023-02-24T20:49:09.472 INFO:teuthology.orchestra.run.smithi042.stdout:    "backend": [],
2023-02-24T20:49:09.472 INFO:teuthology.orchestra.run.smithi042.stdout:    "virtual_ip": null
2023-02-24T20:49:09.472 INFO:teuthology.orchestra.run.smithi042.stdout:  }
2023-02-24T20:49:09.472 INFO:teuthology.orchestra.run.smithi042.stdout:}

it then raises:

2023-02-24T20:49:10.323 INFO:tasks.cephfs_test_runner:    info_output = json.loads(self._nfs_cmd('cluster', 'info', self.cluster_id))['test']['backend'][0]
2023-02-24T20:49:10.323 INFO:tasks.cephfs_test_runner:IndexError: list index out of range

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
dparmar18
503f8679ed qa: fix helper function _check_nfs_cluster_status()
Comment in the code says to wait for two minutes as cluster
creation takes time but actually it's waiting for thirteen
minutes, it's not required to wait this long, i think a minute
here is more than enough, also switched to using safe_while().

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
dparmar18
3b3fa71edf qa: fix testcase 'test_cluster_set_user_config_with_non_existing_clusterid'
Fixes: https://tracker.ceph.com/issues/58758
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
dparmar18
7cb3e58ecb qa: fix cluster creation failure in test_nfs.py
Also adds a function _nfs_complete_cmd() that returns process obj so that stdout/stderr
can be used for evaluation(_nfs_cmd() uses raw_cluster_cmd() that returns just stdout
and it became difficult to time cluster creation errors in _test_create_cluster()).

It takes sometime to update the cluster data, therefore running the command set
(check nfs server status -> nfs cluster create test -> check cluster status) in
a loop (max six iteration with sleep of 5 secs at each iteration) fixes the issue.

Fixes: https://tracker.ceph.com/issues/58744
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
dparmar18
afaf251d21 qa: test export creation at filepath and symlink
Fixes: https://tracker.ceph.com/issues/58228
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
dparmar18
b0bb25024d qa: added test case test_nfs_export_with_invalid_path
Fixes: https://tracker.ceph.com/issues/58228
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
dparmar18
992c686a3d mgr/nfs: disallow non-existent paths when creating export
Fixes: https://tracker.ceph.com/issues/58228
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
Dhairya Parmar
6334e10fa5 mgr/nfs/tests: mock check_cephfs_path
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-30 19:29:15 +05:30
Casey Bodley
c0186fe5eb
Merge pull request #45693 from cbodley/wip-qa-rgw-scrub
qa/rgw: reenable wait-for-scrub

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2023-03-30 08:50:30 -04:00
Venky Shankar
aa9a83029a Merge PR #47649 into main
* refs/pull/47649/head:
	mds: adjust MDSRank::command_tag_path invocation of enqueue_scrub()
	doc/scrub: documented stray evaluation using recursive scrub
	qa: added testcases
	mds: make `scrub status` print flag `scrub_mdsdir`
	mds: add scrub_mdsdir to ScrubHeader
	mds: do not dump multiple JSON obj
	mds: evaluate strays while performing scrub on root path
	mds: remove inode from scrub_stack if being purged
	mds: do not scrub inode if it is purging

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-30 16:13:48 +05:30
Venky Shankar
e84f319c66 Merge PR #50053 into main
* refs/pull/50053/head:
	libcephfs: move ClearSetuid to suidsgid.cc
	libcephfs: add test cases for dropping the suid/sgid in write/truncate
	libcephfs: add test cases for dropping the suid/sgid in fallocate
	libcephfs: fix ClearSetuid incorrectly using SETATTR_MODE mask
	client: switch to clear_suid_sgid for ftruncate
	client: switch to clear_suid_sgid for _write()
	mds/client: clear the suid/sgid in fallocate path
	client: allow unprivileged users to clear suid/sgid

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2023-03-30 14:48:26 +05:30
Rishabh Dave
96f4886dc6
Merge pull request #50687 from rishabh-d-dave/fs-qa-kernel-untar-tar
qa/workunit/fs: print commands for making debugging easier

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-30 14:43:49 +05:30
Anthony D'Atri
880b0fcca1
Merge pull request #50764 from zdover23/wip-doc-2023-03-230-start-documenting-ceph-squash-formatting
doc/start: format procedure in documenting-ceph
2023-03-30 00:59:11 -04:00
Patrick Donnelly
3c434884ce
Merge PR #50692 into main
* refs/pull/50692/head:
	tools/cephfs: include lost+found in scan_links

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-29 23:01:33 -04:00
Zac Dover
cb1e20f879 doc/rados/ops: edit health-checks.rst (1 of x)
Edit docs/rados/operations/health-checks.rst (1 of x).

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-30 11:28:33 +10:00
zdover23
8dacbe191b
Merge pull request #50742 from zdover23/wip-doc-2023-03-29-start-documenting-ceph-notify-us
doc/start: update "notify us" section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-30 11:01:29 +10:00