Kefu Chai
3f0b358cc3
crimson/osd: add RecoveryBackend:add_recovering()
...
before this change, get_recovery() can also be used for adding a
recovery instance to `recovering`. this behavior is error-prone and
confusing.
after this change, add_recovery() is used in the place where we
want to add a new instance of recovery instance.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-23 12:20:16 +08:00
Sebastian Wagner
9899c6c987
Merge pull request #37106 from sebastian-philipp/cephadm-overwritable-templates
...
mgr/cephadm: make j2 teamplates overwritable
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
2020-09-23 01:34:57 +02:00
Jason Dillaman
1f31e8bdb3
Merge pull request #37121 from Songweibin/wip-rbd-metadata
...
librbd: async version of metadata_set/remove
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-22 19:14:24 -04:00
Jason Dillaman
3baecb8614
Merge pull request #37083 from orozery/librbd-data-cryptor
...
librbd: add data encryptor/decryptor using openssl
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-22 19:14:07 -04:00
Jason Dillaman
78d630d4a5
Merge pull request #37110 from CongMinYin/qa_immutable_object_cache_check
...
qa: check immutable object cache content
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-22 19:12:42 -04:00
Jason Dillaman
d6dc783e83
Merge pull request #37237 from MahatiC/wip-fix-rwl-path
...
librbd/cache: Fix pwl_path read issue
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-09-22 19:11:47 -04:00
Michael Fritch
72b10c43c5
Merge pull request #37206 from bk201/wip-47387
...
mgr/rook: fix listing daemons
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
2020-09-22 16:37:09 -06:00
Lenz Grimmer
75763e67ed
Merge pull request #37043 from s0nea/wip-dashboard-47331
...
mgr/dashboard: log in non-admin users successfully if the telemetry notification is shown
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2020-09-22 13:55:47 +02:00
Kefu Chai
b33e414000
Merge pull request #37293 from changchengx/osd_comment
...
osd: fix wrong comment about setting auth_client for messenger
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-22 17:46:09 +08:00
Changcheng Liu
072b552173
osd: correct comment about setting auth_client for messenger
...
client_messenger's auth_client has not been set until call
monc->init();
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-22 15:41:34 +08:00
Lenz Grimmer
ab53b20db6
Merge pull request #37152 from rhcs-dashboard/bottom-links-component
...
mgr/dashboard: Creating a new Login Page Legal Links Component
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-09-22 09:23:32 +02:00
Kefu Chai
597ef5ea9a
Merge pull request #37291 from badone/wip-docker-test-helper-fixes
...
test/docker-test: helper fixes and support more distro releases
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-22 14:17:23 +08:00
Brad Hubbard
063763665f
test: Add support for fedora 32, 33 and Ubuntu 20.04
...
Enable creation and use of these OS images in docker-test.
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-09-22 13:24:26 +10:00
Brad Hubbard
c0e6c64fba
tests: Make sure install-deps is run noninteractively
...
This gets past things like tzconfig stopping for user input.
Remove redundant install of python-virtualenv.
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-09-22 13:24:26 +10:00
Kefu Chai
e806c4085d
Merge pull request #37200 from tchaikov/wip-crimson-with-lock
...
crimson/common: add helpers for seastar::with_lock()
Reviewed-by: Samuel Just <sjust@redhat.com>
2020-09-22 10:53:48 +08:00
Kefu Chai
4aced0cba9
Merge pull request #37211 from tchaikov/wip-zbd
...
rpm,install-deps,run-make-check: enable WITH_ZBD build on demand
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-22 09:42:09 +08:00
Brad Hubbard
d5cbf38dbc
test/centos-8: Install git before running install-deps
...
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-09-22 10:30:01 +10:00
Brad Hubbard
ac20919c6c
test/docker-test: Fix permissions issue when using podman
...
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-09-22 10:28:09 +10:00
Patrick Donnelly
e15e825f85
Merge PR #36776 into master
...
* refs/pull/36776/head:
systemd: Support Graceful Reboot for AIO Node
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
2020-09-21 15:26:22 -07:00
Patrick Donnelly
6547276ec3
Merge PR #37227 into master
...
* refs/pull/37227/head:
qa/cephfs: don't pass args to destroy() in recreate()
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-21 14:04:06 -07:00
Patrick Donnelly
c46bf97646
Merge PR #37233 into master
...
* refs/pull/37233/head:
qa/mgr: revert a patch from commit 04ed58f
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-09-21 14:03:32 -07:00
Samuel Just
d257bf0e04
Merge pull request #37271 from cyx1231st/wip-seastore-fix-non-repeatable-read
...
crimson/seastore: fix potential non-repeatable-read from RootBlock
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2020-09-21 10:57:43 -07:00
Ilya Dryomov
6827bbbcfb
Merge pull request #36927 from idryomov/wip-krbd-noudev
...
krbd: optionally skip waiting for udev events
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
2020-09-21 19:39:30 +02:00
Patrick Donnelly
24e2e668e1
Merge PR #37213 into master
...
* refs/pull/37213/head:
mgr/rook: Pass pod namespace to list_namespaced_pod()
Reviewed-by: Travis Nielsen <tnielsen@redhat.com>
2020-09-21 09:48:28 -07:00
Lenz Grimmer
1c4f3478fc
Merge pull request #37101 from LenzGr/master-documentation
...
doc: Updated `HACKING.rst` and `README.rst`
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-09-21 17:58:03 +02:00
Lenz Grimmer
6279196e05
Merge pull request #37137 from tspmelo/wip-fix-iscsi-tests
...
mgr/dashboard: Fix iSCSI backend unit-test
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2020-09-21 14:33:19 +02:00
Jason Dillaman
58db5bfa6f
Merge pull request #37262 from trociny/wip-rbd-nbd-quiesce-hook
...
rbd-nbd: fix typo in mini help
Reviewed-by: Jason Dillaman <dillaman@rehdat.com>
2020-09-21 08:19:08 -04:00
Lenz Grimmer
529ff10c1d
Merge pull request #35785 from rhcs-dashboard/wip-45957-consolidate_Osd_Endpoints
...
mgr/dashboard: Consolidate Osd mark endpoints
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2020-09-21 13:59:48 +02:00
Ilya Dryomov
d2884adb15
qa: add test for mapping and unmapping from a network namespace
...
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2020-09-21 13:54:08 +02:00
Guillaume Abrioux
888998f886
Merge pull request #37234 from guits/guits-quick-fix
...
ceph-volume: fix wrong type passed in terminal.warning()
2020-09-21 13:41:41 +02:00
Mykola Golub
9548fb02a9
Merge pull request #37222 from dillaman/wip-librbd-image-dispatch
...
librbd: bug fixes and cleanup for IO dispatch path
Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-09-21 14:05:21 +03:00
Kefu Chai
0ef2a830b5
Merge pull request #37215 from uweigand/fix-librados-test-endian
...
test/librados: fix endian bugs in checksum test cases
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-21 17:49:08 +08:00
Lenz Grimmer
73803fed07
Merge pull request #36900 from wjwithagen/wjw-enhance-mgr_module.py
...
mgr/dashboard: Report the missing path in error message
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-09-21 11:48:28 +02:00
Lenz Grimmer
0c9e31cf6d
Merge pull request #37087 from tspmelo/wip-iscsi-logged-in
...
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
2020-09-21 11:45:19 +02:00
Kefu Chai
983e28b46b
Merge pull request #37261 from tchaikov/wip-47552
...
common/BackTrace: do not use len for length of demangled symbol
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-21 17:43:17 +08:00
Kefu Chai
c2af45b659
Merge pull request #37185 from david-z/wip-fix-osdmaptool
...
tools/osdmaptool.cc: fix inaccurate pg map result when simulating osd out
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-21 17:38:56 +08:00
Kefu Chai
c2a94678a0
Merge pull request #37210 from changchengx/no_tune_message
...
messenger: remove unused variable
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-21 17:37:21 +08:00
Lenz Grimmer
f0fb21ada0
Merge pull request #37183 from rhcs-dashboard/fix-47434-master
...
mgr/dashboard: table detail rows overflow
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2020-09-21 10:42:19 +02:00
Guillaume Abrioux
a1f42c8d7b
ceph-volume: fix wrong type passed in terminal.warning()
...
`terminal.warning()` excepts a `str`.
Passing `e` means we pass a type `exceptions.RuntimeError`
Changing to `terminal.warning(e.message)` fixes the issue.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1877672
Resolves: rhbz#1877672
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-09-21 09:36:27 +02:00
Kefu Chai
35613d091a
Merge pull request #37268 from anthonyeleven/anthonyeleven/doc-fixes
...
doc/man: Add optional reweight-by-utilization args
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-21 14:41:35 +08:00
Anthony D'Atri
815263b583
doc/man: Add optional reweight-by-utilization args
...
doc/mgr: Grammar and wording for Prometheus labels
doc/rados: Spelling and clarity
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-09-20 22:47:01 -07:00
Yingxin Cheng
9f7b7fdced
crimson/seastore: fix potential non-repeatable-read from RootBlock
...
Load root block into the transaction when read it.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-09-21 10:18:55 +08:00
songweibin
7bc663dbe3
librbd: async version of metadata_set/remove
...
In iSCSI scenario (via tcmu-runner), after a client has acquired exclusive
lock on an image, users will no longer be able to set metadata on the image.
This commit try to fix it by forward the request to the lock owner.
Steps to reproduce:
1. Client A:
```
>>> import rbd, rados;client=rados.Rados(conffile='');client.connect();ioctx=client.open_ioctx('rbd');rbd_inst=rbd.RBD();image=rbd.Image(ioctx, 'img1')
>>> from rbd import RBD_LOCK_MODE_EXCLUSIVE
>>> image.lock_acquire(RBD_LOCK_MODE_EXCLUSIVE)
>>>
```
2. Client B:
```
$ rbd image-meta set img1 conf_rbd_qos_iops_limit 10000
2020-09-12T15:19:58.325+0800 7f161affd700 -1 librbd::ManagedLock: 0x7f15f4001d48 handle_acquire_lock: failed to acquire exclusive lock:(30) Read-only file system
failed to set metadata conf_rbd_qos_iops_limit of image : (30) Read-only file system
rbd: setting metadata failed: (30) Read-only file system
$
```
Signed-off-by: songweibin <song.weibin@zte.com.cn>
2020-09-21 09:42:55 +08:00
Brad Hubbard
0a288f6690
Merge pull request #37176 from badone/wip-enable-mgr-client-debug
...
qa: Enable debug_client for mgr tests
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-21 11:34:58 +10:00
Changcheng Liu
4d6b678736
messenger: remove unused variable
...
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-21 09:22:07 +08:00
Or Ozeri
2f4c769e67
librbd: add data encryptor/decryptor using openssl
...
This commit adds the first CryptoInterface implementation
which translates bufferlist encryption to the standard api of crypto libraries,
i.e. using block ciphers operating on C-style arrays.
It defines an abstract DataCryptor interface to allow different crypto libraries implementations.
With this commit, we add an OpenSSL based implementation.
Lastly, we implement a context-pool wrapper implementation to optimize performance.
Signed-off-by: Or Ozeri <oro@il.ibm.com>
2020-09-20 21:23:45 +03:00
Yin Congmin
f18aca8746
qa: check immutable object cache content
...
fix check immutable cache does not work
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
2020-09-21 01:36:56 +08:00
Mykola Golub
d3fa8d01dc
rbd-nbd: fix typo in mini help
...
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-09-20 08:19:30 +01:00
Kefu Chai
14b6d35b17
common/BackTrace: do not use len for length of demangled symbol
...
it turns out `len` is longer than the length of demangled symbol,
let's rely on the `\0` sentry in the returned char* string instead.
in this change, use `status` to tell if the demangle is successful or
not.
Fixes: https://tracker.ceph.com/issues/47552
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-20 11:34:53 +08:00
Ilya Dryomov
240c46a75a
Merge pull request #37072 from idryomov/wip-kcephfs-blacklisted-string
...
mds: add " (blacklisted)" to session reject error string
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-19 11:36:43 +02:00