Commit Graph

116966 Commits

Author SHA1 Message Date
Jason Dillaman
365cb2f9ee github/labeler: add rbd label to pybind/mgr/rbd_support
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 16:13:28 -05:00
Casey Bodley
aaf644daa9
Merge pull request #37914 from IlsooByun/rgw_invalid_resp
rgw: fix invalid payload issue when serving s3website error page

Reviewed-by: Or Friedmann <ofriedma@redhat.com>
2020-11-19 10:23:22 -05:00
Jason Dillaman
e60ff50052
Merge pull request #38182 from orozery/librbd-crypto-image-dispatch-fixes
librbd: fix crypto prepare_copyup to use new remap_extents api

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-11-19 10:01:17 -05:00
Ernesto Puerta
dc42564807
Merge pull request #38158 from rhcs-dashboard/fix-labeler-master
github/labeler: disable sync-labels

Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: neha-ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-19 12:33:09 +01:00
Kefu Chai
ba99f56f52
Merge pull request #38146 from ljishen/peering_state_model
doc: increase visibility of the peering state diagram

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-19 16:09:14 +08:00
Or Ozeri
bb987178c1 librbd: fix crypto prepare_copyup to use new remap_extents api
This commit changes the crypto prepare_copyup implementation to correctly
translate object extents to image extents, via the remap_extents api.
Additionally, we fix relevant unit tests that call this api to correctly expect these calls.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
2020-11-19 10:03:54 +02:00
Jianshen Liu
909bfa34e6 doc: increase visibility of the peering state diagram
Signed-off-by: Jianshen Liu <jliu120@ucsc.edu>
2020-11-18 21:26:54 -07:00
Kefu Chai
f9c6629062
Merge pull request #38001 from badone/wip-powertools-repo-name-change
install-deps.sh: Make powertools repo case insensitive

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-19 12:12:08 +08:00
Neha Ojha
a24f40bb8d
Merge pull request #38172 from zdover23/wip-doc-dev-unit-test-list-update
doc/dev: update list in unit test section

Reviewed-By: Nathan Cutler <ncutler@suse.com>
2020-11-18 15:50:01 -08:00
Jason Dillaman
eb733e9411
Merge pull request #38114 from orozery/librbd-crypto-prepare-copyup
librbd: add encryption support for copyup

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-11-18 17:55:16 -05:00
Jason Dillaman
be72ffdfec
Merge pull request #37935 from orozery/librbd-image-address-remap
librbd: add crypto image dispatch layer

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-11-18 17:55:00 -05:00
Neha Ojha
becb9b6db2
Merge pull request #38133 from zdover23/wip-doc-dev-unit-tests-1-of-7
doc/dev: update unit test 1 of 7

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-18 12:19:42 -08:00
Neha Ojha
42c599bd1f
Merge pull request #38134 from zdover23/wip-doc-dev-unit-tests-2-of-7
doc/dev: update unit tests 2 of 7

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-18 12:18:55 -08:00
Patrick Donnelly
50a2c7ead0
Merge PR #38126 into master
* refs/pull/38126/head:
	doc/cephfs/health-messages: add dot between mds identifier and it's name

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-18 12:15:22 -08:00
Neha Ojha
020cd51d00
Merge pull request #38174 from neha-ojha/wip-fix-label
.github/labeler.yml: fix bluestore rule, add label for tests and classify core tests 

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-18 12:12:00 -08:00
pcuzner
9ba45ee661
Merge pull request #37607 from pcuzner/docs-cephadm-host-maintenance
doc/dev/cephadm: Doc defining the design for host maintenance
2020-11-19 09:03:19 +13:00
Or Ozeri
3c11d5a2eb librbd: add encryption support for copyup
This commit implements the prepare_copyup api by the crypto object dispatch layer.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
2020-11-18 21:08:30 +02:00
Neha Ojha
0dfcba1969 .github/labeler.yml: add label for tests and classify core tests
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-11-18 18:42:23 +00:00
Neha Ojha
2e99863077 .github/labeler.yml: fix bluestore rule
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-11-18 18:32:31 +00:00
Zac Dover
491a2fa8dc doc/dev: update list in unit test section
This commit removes an unwanted extra
nested list layer from a list.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-11-19 03:35:19 +10:00
zdover23
ff5f9e155e
Merge pull request #38150 from zdover23/wip-doc-dev-unit-tests-3-of-7
doc/dev: update unit test declaration

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2020-11-19 03:16:44 +10:00
David Zafman
89af82bf4f
Merge pull request #38054 from dzafman/wip-test-fixes
test: Fix osd-scrub-test.sh and ver-health.sh tests

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-18 08:52:28 -08:00
rakeshgm
672c4844ef
Merge pull request #38132 from ceph/rhel_8_distros
qa/distros: add RHEL 8.3 and use RHEL 8.3 as default
2020-11-18 21:39:25 +05:30
Patrick Donnelly
cfabba6668
Merge PR #34552 into master
* refs/pull/34552/head:
	tests: add snap schedule tests
	snap-schedule: reject invalid retention specs
	mgr/snap_schedule: log snapshot name on creation
	pybind / snap_schedule: sanely dump schedules and retention specs
	pybind/snap_schedule: config option to allow minute granularity snaps
	pybind / snap_schedule: remove 'SNAP_SCHED_TESTING' check

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-18 07:54:15 -08:00
Neha Ojha
1523bf9bdb
Merge pull request #38107 from ceph/wip-mgr-progress-fix-48217
qa/mgr/test_progress: add _get_osd_in_out_events to account for osd marked in/out events

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-11-18 07:15:22 -08:00
Zac Dover
0dd7b26fb3 doc/dev: update unit test declaration
This commit updates the text in the "How
Unit Tests Are Declared" section of
tests-unit-tests.rst. This commit breaks
long sentences into shorter sentences and
breaks a sentence into a bulleted list that
might reduce the reader's cognitive load.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-11-19 01:13:37 +10:00
Kefu Chai
fc2c5bab55
Merge pull request #38129 from jan--f/add-ceph-volume-autolabel
github: add ceph-volume autolabel

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-18 21:21:51 +08:00
Ernesto Puerta
59702b6198
github/labeler: disable sync-labels
Yaml syntax cleaned too.

Fixes: https://github.com/ceph/ceph/pull/38107#issuecomment-729300615
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2020-11-18 13:15:41 +01:00
Jan Fajerski
1014354846 github: add ceph-volume autolabel
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-11-18 13:06:51 +01:00
Kefu Chai
50f580c6e3
Merge pull request #37606 from ifed01/wip-ifed-fix-mempool-and-others
os/bluestore: a bunch of minor fixes

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-18 18:53:01 +08:00
Kefu Chai
ca77787c81
Merge pull request #38152 from tchaikov/wip-crimson-clang-cleanup
crimson/os: do not capture unused variables

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-18 18:48:36 +08:00
Kefu Chai
c119f48ed1
Merge pull request #38022 from tchaikov/wip-crimson-with-lock
crimson/os: use with_lock() to guard obc

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-18 18:18:35 +08:00
Kefu Chai
4f18781241 crimson/os: do not capture unused variables
silences warnings reported by clang iike:

btree_lba_manager.cc:439:50: warning: lambda capture 't' is not used [-Wunused-lambda-capture]
        lba_node->get_node_meta().depth).safe_then([=, &t](LBANodeRef c) {
                                                     ~~~^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 18:05:29 +08:00
Kefu Chai
c2dc437f78 crimson/osd/object_context: drop unused methods
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
b4bb0d45f3 crimson/osd: add PG::with_clone_obc()
this method replaces `PG::get_or_load_clone_obc()`. so we can
with `seastar::with_lock()` to ensure that `lock.unlock()` is always
called when accessing clone obc.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
ce8c0f363d crimson/osd: drop PG::get_or_load_head_obc()
as it is not used anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
a4e79ba67a crimson/osd: use with_head_obc() to replace get_or_load_head_obc
for better readability, and ensure that `lock.unlock()` is called when
an error is returned after the lock is acquired.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
b0d3d2a392 crimson/osd: add PG::with_head_obc()
this method replicates `PG::get_or_load_head_obc()`. but uses a different
way to ensure that the "lock" on obc is always released even if the
called func throws. it always guard the called func with a
`with_lock()`, so `lock.unlock()` is always called. the plan is to
replace `PG::get_or_load_head_obc()` with `PG::with_head_obc()` in
the following changes piecemeal.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
6811578137 crimson/osd: pass RWState using template parameter
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
aeeba7134e crimson/osd: mark PG::get_locked_obc() private
this methods is used by PG::with_locked_obc(). so mark it private.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
90f035629f crimson/osd: move PG::with_locked_obc() into .cc
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:37:59 +08:00
Kefu Chai
e3243c76ae
Merge pull request #38151 from tchaikov/wip-seastar-api-v6
crimson/common: correct template parameter of seastar::future<>

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-11-18 17:35:43 +08:00
Kefu Chai
6988d76aa5 crimson/common: correct template parameter of seastar::future<>
it's a leftover of 688b95798b

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-18 17:33:03 +08:00
Ernesto Puerta
5a0090a38b
Merge pull request #37742 from rhcs-dashboard/update-QoS-fields
mgr/dashboard: update QoS values when editing a Pool/RBD image

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-11-18 10:28:16 +01:00
Ernesto Puerta
20d915a75e
Merge pull request #35039 from bk201/wip-45301
mgr/dashboard: displaying deleting status in the OSD list

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-11-18 10:24:09 +01:00
Igor Fedotov
7801dc2909 os/bluestore: fix lack of blob unshare if 'root' onode is not present
in cache.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2020-11-18 12:15:44 +03:00
Igor Fedotov
2e9a804d9e test/store_test: add unshare blob tests cases
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2020-11-18 12:14:49 +03:00
Igor Fedotov
14c39d795d os/bluestore: Buffer's flag might be lost if it's partially discarded or
split.

Haven't seen any real issues due to this though.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2020-11-18 12:14:42 +03:00
Zac Dover
19d34666a8 doc/dev: update unit test 1 of 7
This commit updates the language at the beginning
of the Unit Test section of the developer guide.
The language in this edit is more grammatical than
it used to be, and should now reduce the reader's
cognitive load.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-11-18 18:25:05 +10:00
Zac Dover
7425e96c86 doc/dev: update unit tests 2 of 7
This commit updates the "What does 'make
check' mean" section of the "Unit Tests" chapter
of the Developer Guide. It makes the wording a
bit less editorial and attempts to reduce the
reader's cognitive load.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-11-18 18:13:35 +10:00