Commit Graph

129677 Commits

Author SHA1 Message Date
zdover23
3497a47e36
Merge pull request #45033 from anthonyeleven/anthonyeleven/releases-tweaks
doc/releases: Improve capitalization for Octopus

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2022-02-21 15:59:52 +10:00
Laura Flores
b62d7129f9
Merge pull request #44994 from ljflores/wip-telemetry-device-assertion-failure
mgr/telemetry: handle empty device report when "send" is triggered
2022-02-20 18:52:47 -06:00
Kefu Chai
83953dfda6
Merge pull request #44936 from javacruft/build-compress-common-dep
cmake: add dependency compress->common

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-02-21 01:02:44 +08:00
James Page
1b3bfcd4fe cmake: add dependency compression->common
The compression code depends on headers generated during the build
of the common code for Ceph.

Ensure that CMake understands this dependency, avoiding a race
between generation of header files in common and compilation of the
compression module.

Signed-off-by: James Page <james.page@ubuntu.com>
2022-02-20 21:39:13 +08:00
Kefu Chai
1e7e098d55
Merge pull request #44608 from liumiaomiaoIntel/qatchange
common: fix compilation and function issues about compressor and crypto to enable latest QAT driver

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-02-20 01:25:44 +08:00
Ilya Dryomov
c82eeadaa1
Merge pull request #44904 from chrisphoffman/wip_rbd_default_map_override
tools/rbd: expand where option rbd_default_map_options can be set

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-02-19 17:18:42 +01:00
Samuel Just
3fe5bf2632
Merge pull request #45085 from tchaikov/crimson-fmtlib-v8
crimson: fixes for compiling with fmtlib v8

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-02-18 17:38:45 -08:00
Laura Flores
f2b75166a2
Merge pull request #43388 from e337/wip-doc-50499 2022-02-18 18:24:02 -06:00
Kefu Chai
bb9d099ede crimson: specialize fmt::formatter<>() for crimson types
otherwise we'd have FTBFS like

/usr/include/fmt/core.h:1727:3: error: static_assert failed due to requirement 'formattable' "Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api$
  static_assert(
  ^
/usr/include/fmt/core.h:1853:23: note: in instantiation of function template specialization 'fmt::detail::make_arg<true, fmt::basic_format_context<fmt::appender, char>, fmt::detail::type::custom_type, crimson::os:$
        data_{detail::make_arg<

please note, delta_op_t is lifted out of the templated outer class
to avoid the headache of specialization of template of template in
another namespace.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-02-19 00:22:37 +08:00
Christopher Hoffman
19d46b9181 qa/suites/krbd: add rbd_default_map_options override coverage
Add coverage to test precedence, override, and option merge on rbd map.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>
2022-02-18 17:19:45 +01:00
Ilya Dryomov
7f391c5688 qa/suites/krbd: rename rxbounce subsuite
A new job that doesn't want ms_mode to be set underneath it is about to
be added.  Rename rxbounce to ms_modeless to make this purpose obvious.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-02-18 17:19:45 +01:00
Christopher Hoffman
9afc971282 rbd: support pool and image level overrides for rbd_default_map_options
Fixes: https://tracker.ceph.com/issues/52850
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
2022-02-18 17:19:45 +01:00
Kefu Chai
3fd91d7e6d crimson/os/seastore: drop compile-time fmt validation
_format() was deprecated in fmtlib v8, see also
https://github.com/fmtlib/fmt/pull/2646

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-02-18 23:31:51 +08:00
Miaomiao Liu
9a9001a08f compressor: fix compilation issues about QATzip
Signed-off-by: Miaomiao Liu <miaomiao.liu@intel.com>
Signed-off-by: Hualong Feng <hualong.feng@intel.com>
2022-02-18 17:45:30 +08:00
Samuel Just
cee3cae9b2
Merge pull request #44933 from liu-chunmei/seastore-support-sparse-read
crimson/seastore: support sparse_read

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-02-17 14:40:27 -08:00
Neha Ojha
e3463e286d
Merge pull request #44955 from aclamk/wip-vselector-check-fix
os/bluestore/bluefs: Fix improper vselector tracking in _flush_special()

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
2022-02-17 10:26:10 -08:00
chunmei-liu
bc1e1116f5 crimson/seastore: put ObjectDataHandler instance into do_with
make ObjectDataHandler instance alive before sub functions are resolved.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-02-17 09:18:55 -08:00
chunmei-liu
f4e20eec8e crimson/seastore:: add fiemap and sparse read unit test
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-02-17 09:18:49 -08:00
chunmei-liu
2baabdaf12 crimson/seastore: support sparse_read
add fiemap and readv functions.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-02-17 07:57:57 -08:00
zdover23
d11d2e72da
Merge pull request #45057 from zdover23/wip-doc-2022-02-17-os-recs-nautilus-and-luminous-table-removal
doc/start: remove L and N release-related tables

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2022-02-17 20:19:35 +10:00
Samuel Just
74b7fe8264
Merge pull request #45049 from liu-chunmei/crimson-clang-warning-cleanup
crimson: eliminate clang build warning in crimson

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-02-16 12:07:56 -08:00
Laura Flores
54e0e58f1b mgr/telemetry: handle empty device report when "send" is triggered
On certain environments, such as the "ceph-dev-docker" environment
(https://github.com/ricardoasmarques/ceph-dev-docker), the mgr
module is unable to fetch device metrics. As a result, the device
report generated by "gather_device_report()" returns an empty dict.
This causes an AssertionError when the "send" function is triggered
(i.e. by running `ceph telemetry status` or `ceph telemetry send`),
and the module crashes.

The fix in this commit checks that the generated device report
contains metrics before trying to send it. If the device report
does not contain metrics (it returns an empty dict), the module
will log an appropriate message in the mgr log and not send the
device report.

If this scenario happens when running the `ceph telemetry send` command,
the user will additionally see this message:
```
Ceph report sent to https://telemetry.ceph.com/report
Unable to send device report: channel is on, but generated report was empty.
```

I also added a few more debug messages in gather_device_report() to make
future debugging easier.

Fixes: https://tracker.ceph.com/issues/54250
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-16 19:38:53 +00:00
chunmei-liu
3d7d6dbd05 crimson: eliminate clang build warning in crimson
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-02-16 08:20:35 -08:00
Zac Dover
cc6d3871ec doc/start: remove L and N release-related tables
This PR removes the tables for Luminous and Nautilus,
in order to keep the documentation as current as possible.
This is one a series of PRs intended to update the OS
Recommendations page. The scope of this PR is confined to
the removal of these two tables. Other PRs will update the
information elsewhere on the OS Recommendations page.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-02-17 01:21:44 +10:00
Ilya Dryomov
88eb23e585
Merge pull request #45045 from idryomov/wip-qemu-task-rbd-package
qa/tasks/qemu: make sure block-rbd.so is installed

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-02-16 14:15:24 +01:00
Ilya Dryomov
8f0fd0af3d qa/suites/rbd: make sure block-rbd.so is installed
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-02-16 12:20:44 +01:00
Ilya Dryomov
e1e9ee61af
Merge pull request #45021 from idryomov/wip-groupsnapns-operator-less
cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
2022-02-16 11:32:10 +01:00
Avan
fd5f5f3aa5
Merge pull request #45020 from rhcs-dashboard/snmp-priv-protocol-fix
mgr/dashboard: change privacy protocol field from required to optional
2022-02-16 15:22:26 +05:30
Igor Fedotov
2e2513decc
Merge pull request #44659 from ifed01/wip-ifed-alloc-replay-boind-size
test/alloc_replay_test: be able to cap allocator space with capacity …

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2022-02-16 12:50:08 +03:00
Adam Kupczyk
3813416e6a os/bluestore/bluefs: Fix vselector
Fix bluefs volume selector in device_migrate_to_existing.
Fix bluefs volume selector in _rewrite_log_and_layout_sync_LNF_LD.

Fixes: https://tracker.ceph.com/issues/54248

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2022-02-15 23:31:53 +01:00
Adam King
9d0d7a489e
Merge pull request #44997 from pcfe/pcfe-add-cos9-instructions
doc/cephadm: Add CentOS Stream install instructions

Reviewed-by: Adam King <adking@redhat.com>
2022-02-15 14:09:31 -05:00
Patrick C. F. Ernzer
7f243262f9 doc/cephadm: Add CentOS Stream install instructions
Signed-off-by: Patrick C. F. Ernzer <pcfe@pcfe.net>.
2022-02-15 17:28:07 +01:00
Casey Bodley
29c9d21d26
Merge pull request #44988 from caisan/FixRGWLogStringError
Fix rgw data sync log info error

Reviewed-by: Yehuda Sadeh <ysadehwe@redhat.com>
2022-02-15 09:29:12 -05:00
Avan Thakkar
2866db1eac mgr/dashboard: add validation for snmp v3 engine id
Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2022-02-15 19:42:57 +05:30
Ilya Dryomov
525ff61cfc qa/tasks/qemu: make sure block-rbd.so is installed
Fixes: https://tracker.ceph.com/issues/54286
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-02-15 14:57:51 +01:00
David Galloway
bcb67715df
Merge pull request #45032 from ceph/revert-45018
Revert "admin/doc-requirements: pin breathe to 4.32.0"
2022-02-15 08:55:31 -05:00
Ernesto Puerta
c28fb3165b
Merge pull request #44951 from votdev/issue_54215_expand_cluster
mgr/dashboard: "Please expand your cluster first" shouldn't be shown if cluster is already meaningfully running

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2022-02-15 11:58:49 +01:00
Venky Shankar
1a762893e3
Merge pull request #43588 from lxbsz/fsize_support
mds: add truncate size handling support for fscrypt

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-02-15 14:48:34 +05:30
Ilya Dryomov
a3e632a322
Merge pull request #45011 from tchaikov/librados/cleanup
include/rados/librados.h: drop duplicated function declaration

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-02-15 00:16:14 +01:00
Anthony D'Atri
f499504ef6 doc/releases: Improve capitalization for Octopus
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-02-14 14:53:17 -08:00
David Galloway
df2d7b29ec admin/doc-requirements.txt: Not breathe=4.33
See https://github.com/michaeljones/breathe/issues/803

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-02-14 15:11:58 -05:00
David Galloway
f459ada4be Revert "admin/doc-requirements: pin breathe to 4.32.0"
This reverts commit d020d07be9.

Fixed upstream https://github.com/michaeljones/breathe/issues/803#issuecomment-1039341857

Signed-off-by: David Galloway <dgalloway@redhat.com>
2022-02-14 14:38:26 -05:00
Adam King
2f2061810a
Merge pull request #44779 from rkachach/fix_issue_53010
mgr/cephadm: Adding logic to cleanup several ceph dirs (rm-cluster)

Reviewed-by: Adam King <adking@redhat.com>
2022-02-14 12:35:15 -05:00
Adam King
f98f4de03c
Merge pull request #45014 from guits/fix-cephadm-ingress
cephadm/ingress: make frontend stats bind on localhost

Reviewed-by: Adam King <adking@redhat.com>
2022-02-14 12:29:36 -05:00
Yuri Weinstein
f6fff9ba6c
Merge pull request #44794 from rzarzynski/wip-common-fix-numa-warning
common: fix compilation warnings in numa.cc

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-02-14 09:06:28 -08:00
Yuri Weinstein
ddeec8d88a
Merge pull request #44781 from ljflores/wip-basic-channel-additions
mgr/telemetry: add `basic_pool_usage` and `basic_usage_by_class` collections to the telemetry module

Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>
2022-02-14 09:06:00 -08:00
Yuri Weinstein
d81cc0cd76
Merge pull request #44746 from ljflores/wip-telemetry-down-osd-fix
mgr/telemetry: collect what we can from histograms, mempools, and heap stats

Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>
2022-02-14 09:04:33 -08:00
Yuri Weinstein
adb2e71aec
Merge pull request #44670 from rzarzynski/wip-common-dout-gcc12-ftbfs
common: fix FTBFS due to dout & need_dynamic on GCC-12

Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-02-14 09:03:51 -08:00
Yuri Weinstein
0de42e61e4
Merge pull request #44983 from cbodley/wip-52673
rgw: remove rgw_rados_pool_pg_num_min and its use on pool creation

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-02-14 09:02:51 -08:00
Adam Kupczyk
4bc0f61d23 os/bluestore/bluefs: Fix improper vselector tracking in _flush_special()
Moves vselector size tracking outside _flush_special().
Function _compact_log_async...() updated sizes twice.
Problem could not be solved by making second modification of size just update,
as it will possibly disrupt vselector consistency check (_vselector_check()).
Feature to track vselector consistency relies on the fact that either log.lock or nodes.lock
are taken when the check is performed. Which is not true for _compact_log_async...().

Now _flush_special does not update vselector sizes by itself but leaves the update to
the caller.

Fixes: https://tracker.ceph.com/issues/54248

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2022-02-14 16:59:03 +01:00