Commit Graph

97540 Commits

Author SHA1 Message Date
Sage Weil
31d71e8597 auth: kill AuthUnknown* (except AuthUnknownSessionHandler)
These are unreferenced by any other code.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-24 13:46:04 -05:00
Sage Weil
91c6016dd9 msg: remove old ms_* auth methods from Dispatcher interface
In the mon there is an opportunity to further clean up the code around
get_authorizer().

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-24 13:46:04 -05:00
Sage Weil
fc8d9c1135 mon/MonClient: discard old challenge if authorizer is bad
If we are a server/accepter, and we get a bad authorizer, discard our old
challenge, since the previous exchange has failed.  This way if the client
retries, their new authorize attempt won't conflict with our old challenge.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-24 13:46:04 -05:00
Sage Weil
c58c5754df msg/async/ProtocolV1: use AuthServer and AuthClient
Stop using the old ms_* auth methods and instead use the new interfaces
(like V2).

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-24 13:46:04 -05:00
Sage Weil
6578fd6248 mon/Monitor: handle v1 call into handle_auth_request
A v1 connection should "succeed" at this point because the authentication
happens via MAuth messages.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-22 07:07:37 -05:00
Sage Weil
d65d0c77d0 msg/Connection: add is_msgr2()
Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-22 07:07:36 -05:00
Sage Weil
64eddc4d75 mon/MonClient: tolerate lack of authorizer for some dispatchers
This is the equivalent of b8d1c80370, but
in the new auth framework.  OSD heartbeats prior to nautilus do not
add authorizers to the heartbeat channel.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-22 07:07:36 -05:00
Sage Weil
cac90d0fd9 Merge PR #27605 into master
* refs/pull/27605/head:
	mon/OSDMonitor: osd add-no{up,down,in,out} - remove state checker

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-22 07:04:11 -05:00
Mykola Golub
b098cc9fd8
Merge pull request #27695 from dillaman/wip-39072
test/librbd: drop 'ceph_test_librbd_api' target

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-04-22 08:22:20 +03:00
Sage Weil
191ab33faf Merge PR #27288 into master
* refs/pull/27288/head:
	osd/PG: discover missing objects when an OSD peers and PG is degraded

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-04-21 21:28:02 -05:00
Sage Weil
762e2e9c5f Merge PR #27571 into master
* refs/pull/27571/head:
	mgr/telemetry: add report_timestamp to sent reports

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-21 21:26:04 -05:00
Sage Weil
de49f345d5 Merge PR #27572 into master
* refs/pull/27572/head:
	denc: fix build error by calling global snprintf

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-21 21:20:37 -05:00
Sage Weil
f9ab80499c Merge PR #27622 into master
* refs/pull/27622/head:
	mon: fix INCOMPAT_OCTOPUS feature number
	mon/Elector: format mon_release correctly

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-04-21 21:20:12 -05:00
Mykola Golub
47bf240939
Merge pull request #27577 from dillaman/wip-rbd-suite-distros
qa/suites/rbd: add random distro selection to librbd tests

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-04-21 20:19:15 +03:00
Kefu Chai
d912f0b461
Merge pull request #27690 from tchaikov/wip-crimson-one-safeguard-is-better-than-two
crimson: pass `Connection*` to Dispatch::ms_dispatch()

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-04-21 11:17:27 +08:00
Sage Weil
755e8c4ef2 Merge PR #27595 into master
* refs/pull/27595/head:
	osd: add 'ceph osd stop <osd.nnn>' command

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-20 08:52:01 -05:00
Sage Weil
df9d1b92a9 Merge PR #27619 into master
* refs/pull/27619/head:
	mgr/BaseMgrModule: run MonCommandCompletion on the finisher
	mgr/BaseMgrModule: fix leak

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Tim Serong <tserong@suse.com>
2019-04-20 08:48:30 -05:00
Sage Weil
b2eae023bc Merge PR #27651 into master
* refs/pull/27651/head:
	test/osd/safe-to-destroy.sh: fix typo

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-20 08:48:14 -05:00
Sage Weil
542b4a21da Merge PR #27663 into master
* refs/pull/27663/head:
	osd/OSDMap: Replace get_out_osds with get_out_existing_osds

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-20 08:47:48 -05:00
Kefu Chai
176bfb9b33
Merge pull request #27631 from dmick/wip-telemetry-crasharray
mgr/telemetry: change crash dict to a list

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-20 14:18:28 +08:00
Kefu Chai
b5e5642c12
Merge pull request #27599 from gregsfortytwo/wip-stale-prs
Miscellaneous lost fixes

Reviewed-by: Ricardo Dias <rdias@suse.com>
2019-04-20 14:16:33 +08:00
Kefu Chai
a319182b84
Merge pull request #27615 from ifed01/wip-ifed-verbose-bluefs-replay
os/bluestore: be more verbose doing bluefs log replay.

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-20 14:12:20 +08:00
Kefu Chai
ebc6db7fa9
Merge pull request #27509 from Aran85/fix-pg-dout
osd/PG: the warning seems more serious than what it wanna transmit

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-04-20 14:10:39 +08:00
Kefu Chai
d1f5ea7003
Merge pull request #27592 from tchaikov/wip-ref
message,mgr: drop MessageFactory and friends and use ref_t<> in mgr

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-04-20 14:09:51 +08:00
Kefu Chai
da35dff9db
Merge pull request #27633 from xiexingguo/wip-39340
osd/osd_types: pool_stat_t::dump - fix 'num_store_stats' field

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-20 14:05:24 +08:00
Kefu Chai
3e977292ef
Merge pull request #27658 from gregsfortytwo/wip-39367-crc-peer
msg: output peer address when detecting bad CRCs

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-04-20 14:04:33 +08:00
Kefu Chai
c69bf0c002 crimson: pass Connection* to Dispatch::ms_dispatch()
currently, we use a `with_gate()` in `ProtocolV2::read_message()` for
ensuring that `this` (or `Connection` holding this protocol instance)
will outlive the continuation of `dispatcher.ms_dispatch()` which
references `this->dispatcher`. but we also pass a strong reference of
connection to dispatcher. in short, we have *two* safeguards for the
same purpose.

in this change, one of these safeguards is removed -- to pass the raw
pointer of `Connection` to `Dispatch::ms_dispatch()`. the reason why
the `with_gate()` is kept is that, if we have removed `with_gate()` in
Protocol, we need to

1. let `Dispatcher::ms_dispatch()` return `void`, as it should not block
any succeeding calls.
2. add a `with_gate()` in `Dispatcher::ms_dispatch()` to ensure that
`this` is alive during the lifecycle of the continuation(s) in
`Dispatcher::ms_dispatch()`.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-04-20 13:58:32 +08:00
Xie Xingguo
0038724cfa
Merge pull request #27657 from anthonyeleven/patch-1
doc: operations: improve reweight-by-utilization

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-04-20 08:50:29 +08:00
Anthony D'Atri
8c2b2fdd27
doc: operations: reweight-by-utilization typo
Add a missing backquote delimiter.

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2019-04-19 15:15:12 -07:00
Jason Dillaman
5b0a611a48 test/librbd: drop 'ceph_test_librbd_api' target
This was used for API backwards compatibility testing, but now that
the C++ API will not remain stable, it serves no purpose.

Fixes: http://tracker.ceph.com/issues/39072
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-04-19 14:18:00 -04:00
Sage Weil
b8f2bc43b4 mgr/BaseMgrModule: run MonCommandCompletion on the finisher
The completion takes the ActivePyModules::lock, but the caller may be
holding an internal lock for Objecter and/or MonClient.  Avoid deadlock
by putting the completion on our finisher.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-19 09:09:36 -05:00
Sage Weil
36ff938014 mgr/BaseMgrModule: fix leak
Signed-off-by: Sage Weil <sage@redhat.com>
2019-04-19 09:09:36 -05:00
Patrick Donnelly
bdaac2d619
Merge PR #27685 into master
* refs/pull/27685/head:
	doc: fix boot transition in mds state diagram

Reviewed-by: Sage Weil <sage@redhat.com>
2019-04-18 15:36:17 -07:00
David Zafman
3ae26e2fc3
Merge pull request #27686 from dzafman/wip-39383
osd: Increase log level of messages which unnecessarily fill up logs

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-04-18 14:52:30 -07:00
David Zafman
405764bf79 osd: Increase log level of messages which unnecessarily fill up logs
Caused by: 834d3c19a7

Fixes: https://tracker.ceph.com/issues/39383

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-04-18 14:03:17 -07:00
Casey Bodley
6fe5907081
Merge pull request #27037 from alimaredia/wip-rgw-dpp-rest-s3-swift
rgw: log refactoring for rgw_rest_s3/swift ops

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-04-18 15:57:23 -04:00
Patrick Donnelly
06e0a312d4
doc: fix boot transition in mds state diagram
MDSMonitor assigns a booting MDS immediately to standby. From there, the
standby may be promoted to standby-replay or some state leading to active.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-04-18 12:51:23 -07:00
Sage Weil
11f439c9a9 Merge PR #27375 into master
* refs/pull/27375/head:
	rgw: pass mostly_omap flag when opening/creating pools
	rgw/rgw_rados: pass mostly_omap flag when opening/creating pools
	rgw: move rgw_init_ioctx() to rgw_tools.cc

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-04-18 14:09:51 -05:00
Casey Bodley
77e85bd355
Merge pull request #27576 from cbodley/wip-39287
rgw: RGWPeriodPusher uses zone system key for inter-zonegroup messages

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-04-18 14:02:13 -04:00
jtlayton
ce0c960ada
Merge pull request #27518 from jtlayton/vstart
vstart: add new option to pass list of block devices to bluestore
2019-04-18 13:16:02 -04:00
Casey Bodley
42e129cd3a
Merge pull request #27567 from cbodley/wip-39283
rgw: multisite log trimming only checks peers that sync from us

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2019-04-18 09:31:41 -04:00
Jason Dillaman
83c11efb98 qa/tasks/rbd_fio: fixed missing delimiter between 'cd' and 'configure'
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-04-18 08:57:04 -04:00
Jason Dillaman
d83d598c12 qa/suites/rbd: add random distro selection to librbd tests
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-04-18 08:57:04 -04:00
Lenz Grimmer
58e9931900
Merge pull request #27275 from Devp00l/issue-39037
mgr/dashboard: Localization for date picker module

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-04-18 10:58:43 +02:00
xie xingguo
5dbae13ce0 osd: add 'ceph osd stop <osd.nnn>' command
stop command can be used to force stopping a specified osd daemon, e.g.,
you don't have to pre-figure out where it located.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-04-18 13:55:02 +08:00
Brad Hubbard
adfb6a5953 osd/OSDMap: Replace get_out_osds with get_out_existing_osds
Fixes: http://tracker.ceph.com/issues/39154

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2019-04-17 22:02:48 -04:00
Patrick Donnelly
59c99f9fc5
Merge PR #27235 into master
* refs/pull/27235/head:
	cephfs-shell: support non-octal mode
	cephfs-shell: fix rm command
	cephfs-shell: fix lls command
	cephfs-shell: fix lcd command
	cephfs-shell: fix umask command
	cephfs-shell: fix cat command
	cephfs-shell: fix chmod command
	cephfs-shell: fix chdir command
	cephfs-shell: fix mv command
	cephfs-shell: fix rmdir command
	cephfs-shell: fix ls command
	cephfs-shell: fix get command
	cephfs-shell: fix put command
	cephfs-shell: fix mkdir command
	cephfs-shell: helper functions and infra changes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-04-17 17:06:22 -07:00
Kefu Chai
f78bc1a8cb msg/Message: add SafeMessage which forbids put/get
This is an opt-in wrapper around Message inheritance to prevent
undesired get/put calls on the object. Instead, you must/should use a
smart ptr to adjust the reference count.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-04-18 06:59:42 +08:00
Kefu Chai
78e7d9051a mgr/MgrClient: use ref_t<M>
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-04-18 06:59:42 +08:00
Kefu Chai
a50a91d243 mgr/{Mgr,MgrStandby}: use ref_t<M>
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-04-18 06:59:42 +08:00