Commit Graph

136839 Commits

Author SHA1 Message Date
Casey Bodley
31846942ed qa/distros/all: add ubuntu_latest.yaml symlink to ubuntu_22.04.yaml
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-08 10:28:28 -05:00
Ronen Friedman
9c52fbd7ac
Merge pull request #50402 from ronen-fr/wip-rf-operator-log
osd: ECTransactions.cc: remove __func__ used inside a lambda

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-03-08 14:52:55 +02:00
Anthony D'Atri
f021748e45
Merge pull request #50437 from Svelar/rados-doc
doc/rados: fix grammar mistake
2023-03-08 06:45:08 -05:00
Rongqi Sun
9d107ac3bb doc/rados: fix grammar mistake
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
2023-03-08 15:33:59 +08:00
Venky Shankar
2e2e7b9186 Merge PR #49008 into main
* refs/pull/49008/head:
	doc/quota: accept human readable quota value documented
	qa/workunits/fs/quota.sh: use human readable format for ceph.quota.max_bytes
	qa: added three testcases
	mds: accept human readable values for quotas

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
2023-03-08 12:36:21 +05:30
zdover23
3fa3cd08c5
Merge pull request #50430 from zdover23/wip-doc-2023-03-08-install-minor-grammar-fix
doc/install: update index.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-03-08 13:31:04 +10:00
Venky Shankar
9623dd2539 Merge PR #46357 into main
* refs/pull/46357/head:
	PendingReleaseNotes: add reference to the new mdsmap max_xattr_size field
	qa/tasks/mgr/dashboard/test_health: Add 'max_xattr_size' to the mdsmap schema
	mds: prevent exceeding xattrs limits on initial set
	mds: prevent clients from exceeding the xattrs key/value limits
	mon: add new configuration to limit filesystem xattrs size

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-03-08 08:12:02 +05:30
Venky Shankar
c3ffbd5ecd Merge PR #49766 into main
* refs/pull/49766/head:
	mds: record and dump last tid for trimming completed requests (or flushes)

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-03-08 08:09:36 +05:30
Venky Shankar
d78b2305c3 Merge PR #49844 into main
* refs/pull/49844/head:
	qa: enforce string client-id check for testing oldest client tid warning
	qa: optionally check pattern string match in `health detail`

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2023-03-08 08:08:17 +05:30
Venky Shankar
8f55abb330 Merge PR #49912 into main
* refs/pull/49912/head:
	qa: avoid explicit set to client mountpoint as "/"

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2023-03-08 08:07:04 +05:30
Zac Dover
82d748ff59 doc/install: update index.rst
Update index.rst by making minor grammar improvements. This file was
long overdue for a backport to Reef, Quincy, and Pacific, so this commit
was a good way to pass a human eyeball over the text before making those
backports.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-03-08 11:52:12 +10:00
Adam King
8cb83413a6
Merge pull request #50146 from adk3798/container-selinux-conflict
qa/distros: pass --allowerasing --nobest when installing container-tools

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2023-03-07 17:06:46 -05:00
Adam King
fc85d0f262
Merge pull request #50133 from adk3798/fqdn-stray
mgr/cephadm: be aware of host's shortname and FQDN

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2023-03-07 17:05:22 -05:00
Adam King
59965ec6b2
Merge pull request #50244 from phlogistonjohn/jjm-cephadm-test-call
cephadm: test call function & fix timeout argument

Reviewed-by: Adam King <adking@redhat.com>
2023-03-07 16:34:20 -05:00
Adam King
b450283a01
Merge pull request #50101 from adk3798/all-devices-raw
mgr/orchestrator: allow deploying raw mode OSDs with --all-available-devices

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
2023-03-07 14:50:29 -05:00
Casey Bodley
b7ee62d781
Merge pull request #45469 from zaitcev/srbac-bz1901857-3
RGW: Add a reader feature

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-03-07 14:38:12 -05:00
John Mulligan
05304675f7 cephadm/tests: enable timeout test cases for call function
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-03-07 13:56:42 -05:00
John Mulligan
cefe44cde8 cephadm: fix timeout argument to call function
The timeout argument to call function, for executing sub-processes, did
not function - this patch makes timeout work as (probably) intended.
Use the `process.communicate()` method rather than `tee` functions to
handle IO collection. Since no logging is done until after the exit code
is known the tee calls are not necessary. Add calls to kill the child
process when the time out occurs. This helps prevent event loop "leaks"
that generate python warnings.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-03-07 13:56:42 -05:00
Adam King
e597e8785b
Merge pull request #50270 from mnasiadka/cephadm_ulimit_docker
cephadm: set --ulimit nofiles with Docker

Reviewed-by: Adam King <adking@redhat.com>
2023-03-07 13:56:02 -05:00
Adam King
6443cf15d5 mgr/cephadm: be aware of host's shortname and FQDN
The idea is to gether the shortname and FQDN as part
of gather-facts, and then if we ever try to check if a certain
host is in our internal inventory by hostname, we can check
these other known names. This should avoid issues where
we think a hostname specified by FQDN is not in our
inventory because we know the host by the shortname
or vice versa.

Fixes: https://tracker.ceph.com/issues/58738

Signed-off-by: Adam King <adking@redhat.com>
2023-03-07 13:50:47 -05:00
Adam King
39d3ce94a0
Merge pull request #50100 from adk3798/set-unmanaged
mgr/cephadm: add commands to set services to managed/unmanaged

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2023-03-07 13:25:17 -05:00
Adam King
a42a673056
Merge pull request #50167 from trociny/wip-58792
mgr/cephadm: don't add mgr into iscsi trusted_ip_list if it's already there

Reviewed-by: Adam King <adking@redhat.com>
2023-03-07 13:22:53 -05:00
Adam King
251c3d44c0
Merge pull request #50275 from rkachach/fix_issue_58856
mgr/rgw: adding mgr rgw module to ceph image

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-03-07 13:21:15 -05:00
Yuval Lifshitz
4aa930e9f9
Merge pull request #48911 from yuvalif/test-kafka-sasl-scram
rgw: test kafka sasl scram

reviewed-by: anthonyeleven, cbodley
2023-03-07 20:20:28 +02:00
Adam King
3019cf00f4
Merge pull request #50311 from trociny/wip-58051-1
mgr/cephadm: try to avoid pull when getting container image info

Reviewed-by: Adam King <adking@redhat.com>
2023-03-07 13:18:41 -05:00
Yuval Lifshitz
430edd3fc6
Merge pull request #50403 from yuvalif/wip-yuval-dont-start-notif-thread
rgw: don't start the bucket notification thread in radosgw-admin

reviewewd-by: cbodley
2023-03-07 19:04:19 +02:00
Matan
5841654405
Merge pull request #49116 from Matan-B/wip-matanb-c-balanced-reads
crimson/osd: Support balance reads

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-03-07 18:58:58 +02:00
Laura Flores
f96dd0dda6
Merge pull request #50410 from ljflores/wip-tracker-58925
qa: suppress memory leak in rocksdb
2023-03-07 09:56:38 -06:00
Matan
274adef5ee
Merge pull request #49779 from Matan-B/wip-matanb-c-lru-comments
common/intrusive_lru: Improve readability

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
2023-03-07 17:10:03 +02:00
Yuval Lifshitz
a94f5b36b1 rgw: unify data member initialization in RGWRados
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c48-prefer-in-class-initializers-to-member-initializers-in-constructors-for-constant-initializers

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-03-07 16:40:28 +02:00
Yuval Lifshitz
ff1f68e4a4 rgw: don't start the bucket notification thread in radosgw-admin
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-03-07 14:18:17 +02:00
Matan Breizman
b1632dbf17 crimson/osd/object_context_loader: Hide private methods
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 09:04:07 +00:00
Matan Breizman
3ea1d8e09d crimson/osd: Introduce with_head_and_clone_obc()
In continuation to 7ca2690be956a36f61c7729946b94ccd970dd9c7:
Now that the head ref is no longer a member of obc, we need a new
substitute way to get the head when needed.

When loading a clone object, the head object is loaded
first (See with_clone_obc). Therefore we can make use of this design
to move the loaded head forward to the relevant func (See with_head_and_clone_obc).
Usually, we wouldn't need to make use of both the head and the clone obc in the
same function. However, SnapTrimObjSubEvent::remove_or_update is an abnormal usage.

Note: We want to avoid holding any unneeded references to obcs
to allow the obc_registery to evict no longer valid obc.
Therefore, with_obc() which references only a single obc is the
preferred entry point for loading obcs.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 09:04:07 +00:00
Matan Breizman
4bf99c69f2 crimson/osd/object_context_loader: with_clone_obc to move head
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 09:04:07 +00:00
Matan Breizman
efcf292905 crimson/osd/object_conetxt*: Rename get_ro_ss to get_head_ss
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 09:04:07 +00:00
Matan Breizman
e702dc3960 crimson/osd: Remove head memeber from ObjectContext
Before this patch, ObjectContext had a head member which was used
to get the head obc of a clone object.
This member caused the head object to being referenced while
attempting to 'clear_replica_obc' (Since we only evict un-referenced
obc from the obc_registery).
This mechanism, of obtaining the head, is no longer needed since
'with_clone_obc' loads the head object context first (using
oid.get_head).

In this commit, head is removed from ObjectContext class and users
are removed as well.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 09:04:07 +00:00
Matan Breizman
c6ab217915 crimson/osd/pg: Add can_discard_op case
discard op in the case where same_primary_since is later than
the MOSDOp's map epoch

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 09:04:07 +00:00
Matan Breizman
f468c67325 crimson/osd/pg: Implement context_registry_on_change()
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 09:04:04 +00:00
Matan Breizman
9f8e232988 common/instrusive_lru: Implement for_each
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:03 +00:00
Matan Breizman
b73d8fd860 qa/*/crimson: Seperate Crimson's rbd api testing
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:03 +00:00
Matan Breizman
cc53ae6512 crimson/osd/osd_operations: Add RepRequest::with_pg() to the pipeline
Wait on a PG to advance to the request's map epoch.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:03 +00:00
Matan Breizman
91cbe88139 crimson/osd/pg: add replica_clear_repop_obc() and log_operation()
Clear invalid obc from cache.

Fixes: https://tracker.ceph.com/issues/58089

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:03 +00:00
Matan Breizman
c4d996e0b7 common/intrusive_lru: Add clear_range()
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:03 +00:00
Matan Breizman
f4300d4aa4 osd/osd_types_fmt: Add fmt::formatter<pg_log_entry_t>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:03 +00:00
Matan Breizman
5b457365fa qa/suites/crimson-rados/thrash/workloads: Enable small-objects-balanced/localized
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:03 +00:00
Matan Breizman
b1d7584931 crimson/osd/osd_operation/client_request: do_process() reorder
* Move error checking to the beginning of do_process()

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:57:01 +00:00
Matan Breizman
b63ab1f4ae crimson/osd/osd_operations/client_request: fix is_misdirected()
In the case of balanced read the op is not misdirected.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:11:38 +00:00
Matan Breizman
2f77bbb79c crimson/osd/osd_operations/client_request: Add logs around do_process()
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:11:38 +00:00
Matan Breizman
7fd0b34521 crimson/osd/osd_operations/client_request: Skip do_recover_missing() on replica
* assert internal_client_request is on primary since
  do_recover_missing is also called by internal requests.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-03-07 08:11:34 +00:00
Nizamudeen A
c05ab3eab9
Merge pull request #50380 from rhcs-dashboard/script-reef-fix
script: update backport scripts for reef

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: neha-ojha <NOT@FOUND>
2023-03-07 11:36:12 +05:30