Commit Graph

28844 Commits

Author SHA1 Message Date
Samuel Just
3148b12141 PG,ReplicatedPG: handle do_request in ReplicatedPG,PGBackend
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:24:25 -07:00
Samuel Just
30ac934e22 ReplicatedPG: pass on dump_recovery_info to PGBackend
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:24:25 -07:00
Samuel Just
138ccbee73 OSD,ReplicatedPG: let PGBackend handle the temp collection
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:24:25 -07:00
Samuel Just
62a1eb6f69 osd/: add PGBackend interfaces and stubs
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:24:25 -07:00
Samuel Just
f94e6a30a7 ReplicatedPG: Allow get_object_context caller to provide attributes
This will be used by PGBackend implementers to get the SnapSet
and ObjectInfo for newly recovered objects on the primary.

get_object_context may be called on a missing object for a lost_revert

Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:24:17 -07:00
Samuel Just
5b7fa6272a ReplicatedPG: send_push is unused
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:21:15 -07:00
Samuel Just
de4cc8717e FileStore: ping tphandle between each operation within a transaction
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:21:15 -07:00
Samuel Just
5f44a949ef WorkQueue: add a workqueue which simply runs queued GenContexts
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-26 11:21:11 -07:00
Samuel Just
fde0f864a6 Context: add GenContext templated on the callback argument
Signed-off-by: Samuel Just <sam.just@inktank.com>
2013-09-25 19:18:42 -07:00
Sage Weil
52c7f27963 Merge pull request #640 from ceph/wip-mon-pgmap
fix mon crash when osdmap and pgmap aren't yet synced

Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
2013-09-25 16:08:05 -07:00
Sage Weil
4d8f78bc65 mon/PGMonitor: fix segfault when osdmap and pgmap stats are out of sync
The leader mon is responsible for propagating changes in the osdmap
into the pgmap (e.g., when a pool or osd goes away).  If that hasn't
happened yet, the pg_map map will be out of sync with the current set
of pools.  We shouldn't crash.

Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-25 15:47:39 -07:00
Sage Weil
aead63cf0b Merge pull request #637 from dachary/master
mailmap: add Matthew Roy, Matthew Wodrich
2013-09-25 15:39:22 -07:00
Sage Weil
9a9e4ca284 Merge pull request #639 from ceph/wip-gtest
Makefile: don't use srcdir in TESTS

Reviewed-by: Roald J. van Loon <roaldvanloon@gmail.com>
2013-09-25 15:39:01 -07:00
Sage Weil
479936806e Makefile: don't use srcdir in TESTS
src/Makefile-env.am:31: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/unittest_bufferlist.sh'
src/Makefile.am:1:   'src/Makefile-env.am' included from here
src/Makefile-env.am:31: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/test/encoding/check-generated.sh'
src/Makefile.am:1:   'src/Makefile-env.am' included from here

on my (raring) laptop.

Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-25 13:37:13 -07:00
Loic Dachary
7bbadf1959 mailmap: add Matthew Roy, Matthew Wodrich
Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-25 19:46:27 +02:00
Sage Weil
60d541d36d Merge pull request #615 from dachary/wip-jerasure-copy
ErasureCode: get rid of extra copy when encoding

Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-25 09:31:58 -07:00
Sage Weil
cea343d078 Merge pull request #634 from dachary/master
git: consolidate mails in commit logs

Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-25 09:23:48 -07:00
Sage Weil
81e571fb95 Merge pull request #636 from dachary/wip-get_command_description
autoconf: remove get_command_descriptions  dependency to gtest

Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-25 09:23:21 -07:00
Loic Dachary
812234cb09 ErasureCode: get rid of extra copy when encoding
The substr_of bufferlist method is used to reduce the copies to the
strict minimum. It is both able to split bufferptr when they are larger
than a chunk and to concatenate them when they are smaller.

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-25 16:26:49 +02:00
Loic Dachary
2422b2aefb autoconf: remove get_command_descriptions dependency to gtest
It is not required and a leftover of the time when it was a unit test
which was a mistake to begin with. It has been reported to create
dependencies problems in some cases, when gest is not available at the
time get_command_descriptions is compiled.

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-25 14:11:19 +02:00
Loic Dachary
04c7207aaa git: consolidate mails in commit logs
Map duplicate mails / names in commit logs to a single canonical names.
Useful to report to management with git shortlog -nes

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-25 08:07:57 +02:00
Sage Weil
952b39d4c4 Merge remote-tracking branch 'gh/next'
Conflicts:
	src/osd/ReplicatedPG.cc
2013-09-24 21:46:47 -07:00
David Zafman
c9e7e2f750 Merge pull request #633 from ceph/wip-repop-leaks
fix a copule of leaks of RepGather structs

Reviewed-by: David Zafman <david.zafman@inktank.com>
2013-09-24 15:39:26 -07:00
John Wilkins
ac0faaa359 doc: Removed service ops language and added reference to operations.
fixes: #6374

Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-09-24 15:26:35 -07:00
Sage Weil
3de32562b5 mon/OSDMonitor: fix 'ceph osd crush reweight ...'
The adjust method returns a count of adjusted items.

Add a test.

Fixes: #6382
Backport: dumpling
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
2013-09-24 15:26:03 -07:00
Sage Weil
0061363e34 Merge pull request #477 from jpfrancois/patch-1
Fix for Swift key command
2013-09-24 15:22:56 -07:00
Sage Weil
1c12eefcb5 osd/ReplicatedPG: fix leak of RepGather on watch timeout
new_repop() gives us a ref; we need to release it, just as we do in
execute_ctx().

Backport: dumpling
Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-24 13:49:59 -07:00
Sage Weil
1d67e1521c osd/ReplicatedPG: fix leak of RepGather on large-object COPY_FROM
new_repop() gives us a ref; we need to release it, just as we do in
execute_ctx().

Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-24 13:48:43 -07:00
Loic Dachary
f6510c7665 osd: change warn_interval_multiplier to uint32_t
to prevent overflow in OpTracker::check_ops_in_flight when
multiplying warn_interval_multiplier *= 2

Backport: cuttlefish, dumpling

http://tracker.ceph.com/issues/6370 fixes #6370

Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit 1bce1f009b)
2013-09-24 10:27:48 -07:00
Sage Weil
b0fee96078 Merge pull request #630 from dachary/master
osd: change warn_interval_multiplier to uint32_t

Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-24 10:27:05 -07:00
Sage Weil
84e1f09626 arch/intel: fix old comment
Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-24 10:18:44 -07:00
Sage Weil
366b608f54 arch/intel: use intel probe instructions for x86_64 only
Not LP64, which includes ppc64 and clearly does not build.

Fixes: #6283
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
2013-09-24 10:17:37 -07:00
Loic Dachary
1bce1f009b osd: change warn_interval_multiplier to uint32_t
to prevent overflow in OpTracker::check_ops_in_flight when
multiplying warn_interval_multiplier *= 2

Backport: cuttlefish, dumpling

http://tracker.ceph.com/issues/6370 fixes #6370

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-24 19:12:35 +02:00
Sage Weil
2cbe93b840 Merge pull request #628 from dachary/wip-erasure-fix-thread-test
ErasureCode: fix plugin loading threaded test

Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-24 08:42:49 -07:00
Yehuda Sadeh
e1d7c32d8a Merge pull request #627 from dachary/master
rgw: fix rgw test to reflect usage change

Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
2013-09-24 07:38:36 -07:00
Loic Dachary
4bc18189b1 ErasureCode: fix plugin loading threaded test
The TEST_F(ErasureCodePluginRegistryTest, factory_mutex) was bugous and
only succeeded by chance. The sleep was on the factory constructor which
was never called. An erasure code plugin that hangs forever on load is
created instead.

The sleep_forever.detach is replaced by pthread_cancel to interrupt the
thread that hangs forever. If not, gtest will try to join the thread and
never exit.

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-24 16:07:31 +02:00
Loic Dachary
e50343e442 rgw: fix rgw test to reflect usage change
otherwise src/test/cli/radosgw-admin/help.t fails when running make
check when run after a configure --with-radosgw

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-24 08:05:38 +02:00
Sage Weil
08c386f542 Merge pull request #588 from dachary/wip-6274
mon: unit tests to protect against some MonCommands.h typos
2013-09-23 16:42:26 -07:00
Sage Weil
abb88d7064 osd: revert 'osd max xattr size' limit
Set it to 0 (unlimited) for now.

Backport: dumpling

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
2013-09-23 16:23:33 -07:00
Sage Weil
286a699190 Merge pull request #566 from ceph/wip-purge-stray
Fixes for purging stray

Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-23 16:16:48 -07:00
Gregory Farnum
6200eeca59 Merge pull request #591 from ceph/wip-misc
Reviewed-by: Greg Farnum <greg@inktank.com>
2013-09-23 15:48:04 -07:00
Greg Farnum
7741de0ba4 Merge branch 'master' of github.com:ceph/ceph 2013-09-23 15:41:14 -07:00
Sage Weil
1425119b9a Merge pull request #625 from ceph/wip-warn-pg
mon: warn when pg_num is too low or appears out of whack wrt the cluster size

Reviewed-by: Greg Farnum <greg@inktank.com>
2013-09-23 15:40:14 -07:00
Greg Farnum
73289b34b0 mds: be more careful about decoding LogEvents
We need to wrap the full decode section or we can abort the process
if there's an issue (which we may want to just skip by).

Signed-off-by: Greg Farnum <greg@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-23 15:31:56 -07:00
Sage Weil
816cbbfea3 Merge pull request #619 from dachary/wip-erasure-pad
ErasureCode: optimize padding calculation 

Reviewed-by: Sage Weil <sage@inktank.com>
2013-09-23 15:14:22 -07:00
Loic Dachary
c32c51a3f3 ErasureCode: optimize padding calculation
Andreas-Joachim Peters pointed out that the ErasureCodeJerasure method
pad_in_length is very inefficient for no reason. It is replaced by the
alignment method and the calculation is inlined in the encode method.

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-09-24 00:08:36 +02:00
Sage Weil
60e9e85461 vstart: set 'mon pg min per osd'
We need to tweak this since we create relatively few pgs per osd.

Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-23 14:57:23 -07:00
Sage Weil
befdcfd658 mon/PGMonitor: health warn if pool has relatively high objects/pg
If there is a pool that has a high objects/pg relative to the rest of the
cluster, warn, as this suggests this particular pool may have too few
PGs.

Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-23 14:57:22 -07:00
Sage Weil
a684ac8220 mon/PGMonitor: health warn if pg_num != pgp_num
Users need to adjust pg_num *and* pgp_num for split but may forget to do
both.

Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-23 14:56:48 -07:00
Sage Weil
dc7114e060 mon: warn if pg to osd ratio is too low
If there are not enough PGs relative to the number of in osds, warn.

Signed-off-by: Sage Weil <sage@inktank.com>
2013-09-23 14:56:45 -07:00