Commit Graph

135324 Commits

Author SHA1 Message Date
Adam King
2ecd74cdac pybind/mgr: fix tox autopep8 args
Similar to mypy, we now need a backslash to signal
a newline doesn't mean to start a new command

Signed-off-by: Adam King <adking@redhat.com>
2022-12-09 11:25:01 -05:00
Adam King
8e5840ff2c mgr/pybind: fix mypy arg parsing
On the new tox version it is treating each line as a new command
so it will do something like "mypy --config-file=../../mypy.ini"
as one command and then "-m balancer" as a totally separate command.
The first one immediately fails as it doesn't include any modules
to test. Adding backslashes to the ends of the lines gets it to
handle the lines as one long command

Signed-off-by: Adam King <adking@redhat.com>
2022-12-09 11:19:43 -05:00
Yingxin
94a142f227
Merge pull request #48691 from zhscn/wip-reserve
crimson/os/seastore: correct the behavior of reserving space

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-12-09 18:01:52 +08:00
Pere Diaz Bou
92168eac67
Merge pull request #47842 from trociny/wip-rbd-rest-api-metadata
mgr/dashboard: allow to get/update RBD image metadata via REST API

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-12-09 09:34:06 +01:00
colemitchell
7c8617423d
Merge pull request #49342 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-removing-a-block-device-semantics
doc/rbd: refine "Removing a Block Device Image"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-12-09 01:45:28 -05:00
Zac Dover
3a6284a49b doc/rbd: refine "Removing a Block Device Image"
Refine and add unselectable prompts to "Removing a Block Device Image"
in doc/rbd/rados-rbd-cmds.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-09 16:38:46 +10:00
colemitchell
9ccf87c165
Merge pull request #49341 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-resizing-a-block-device-image-semantics
doc/rbd: refine "Resizing a Block Device Image"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-12-09 01:17:17 -05:00
colemitchell
10505022c7
Merge pull request #49343 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-restoring-a-block-device-image-semantics
doc/rbd: refine "Restoring a Block Device Image"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2022-12-09 01:16:43 -05:00
Zac Dover
8fb4edb92d doc/rbd: refine "Restoring a Block Device Image"
Refine and add unselectable prompts to "Restoring a Block Device Image"
in doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-09 16:07:19 +10:00
Zac Dover
078bec94d0 doc/rbd: refine "Resizing a Block Device Image"
Refine and add unselectable prompts to "Resizing a Block Device Image"
in doc/rbd/rados/rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-09 15:19:54 +10:00
colemitchell
19426975b2
Merge pull request #49338 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-creating-a-block-device-image-semantics
doc/rbd: refine "Creating a Block Device Image"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-08 23:50:23 -05:00
colemitchell
7c1191da75
Merge pull request #49340 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-retrieving-image-information-semantics
doc/rbd: refine "Retrieving Image Information"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-08 23:50:07 -05:00
colemitchell
2d50caa884
Merge pull request #49339 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-listing-block-device-images-semantics
doc/rbd: refine "Listing Block Device Images"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-08 21:50:05 -05:00
Zac Dover
d418037b38 doc/rbd: refine "Retrieving Image Information"
Refine the text and prompts in "Retrieving Image Information" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-09 10:45:19 +10:00
Kefu Chai
af7d7d386b
Merge pull request #49321 from tchaikov/wip-qa-install-with-utf-8
qa: set locale to C.UTF-8 in tox.ini

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
2022-12-09 08:31:05 +08:00
Zac Dover
ad3c93535f doc/rbd: refine "Listing Block Device Images"
Refine the text and prompts in "Listing Block Device Images" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-09 10:21:47 +10:00
Zac Dover
20b14437d6 doc/rbd: refine "Creating a Block Device Image"
Refine the English and prompts in "Creating a Block Device Image" in
doc/rbd/rados-rbd-cmds.rst.

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-09 09:53:14 +10:00
Kefu Chai
c67106b120 pybind/mgr: do not test with py37
as we always test with ubuntu jammy, which does not provide python3.7:

py37: skipped because could not find python interpreter with spec(s): py37

so there is no point testing with python3.7.

also, in tox v4, it is not able to handle "key = value" anymore, where
value has newlines in it. so we need to find a better way passing
command line options to the test command.

this change partially reverts 2dd86c9e3eca6e14a04a821edf3a654f31da7a21

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-12-09 01:07:19 +08:00
Kefu Chai
da40d84640 cmake: temporarily disable py3 test
py3 tries to import all python modules to ensure that they are
python3 compatible. but the installation fails on jenkins test node:

  Resolved https://github.com/ceph/teuthology.git to commit 4da97cf64e542f347ec47b7bdbe5eca99759f9b7
  Installing build dependencies: started
  error: subprocess-exited-with-error

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-12-09 01:07:19 +08:00
Yuri Weinstein
dc61eb4372
Merge pull request #48375 from lbausch/mgr/balancer-fix_end_weekday_being_exclusive
mgr/balancer: Fix `end_weekday` being exclusive

Reviewed-by: Laura Flores <lflores@redhat.com>
2022-12-08 08:49:17 -08:00
Yuri Weinstein
006e228f71
Merge pull request #48318 from gregsfortytwo/wip-17170
osd: mds: suggest clock skew when failing to obtain rotating service keys

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2022-12-08 08:48:23 -08:00
Kefu Chai
127dd54db8 qa: add pytest to deps of py3 env
otherwise it is mising when running test, and we'd have following
failure:

py3: exit 2 (0.00 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/qa> pytest --assert=plain test_import.py

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-12-08 23:57:59 +08:00
Kefu Chai
bc2b551e9f qa: set locale to C.UTF-8 in tox.ini
as ansible is using UTF-8 encoded characters in the file names, so,
to avoid failures like:

  File "/home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/py3/lib/python3.10/site-packages/pip/_internal/utils/unpacking.py", line 217, in untar_file
    with open(path, "wb") as destfp:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256)

we have to set a locale which is able to handle UTF-8.

see also https://github.com/ceph/teuthology/pull/1671

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-12-08 22:39:57 +08:00
Casey Bodley
bc01d2ed31
Merge pull request #49236 from yuvalif/wip-yuval-missing-init
rgw/notification: initialize member in reservation ctor

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2022-12-08 09:24:22 -05:00
Casey Bodley
4f5c9f3a62
Merge pull request #49290 from inspur-wyq/wip-rgw-svc-doc
src/rgw/services/svc_finisher.cc: fix typos

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-12-08 09:04:25 -05:00
Kefu Chai
cf6442b330
Merge pull request #49322 from tchaikov/wip-allowlist_externals
*: s/whitelist_externals/allowlist_externals/

Reviewed-by: Adam King <adking@redhat.com>
2022-12-08 21:33:38 +08:00
Kefu Chai
c9cc795d02 pybind/mgr: drop cython from requires
cython is not required for running tox commands.

this should address the test failure like:

ROOT: will run in automatically provisioned tox, host /home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-virtualenv/bin/python3.10 is missing [requires (has)]: cython

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-12-08 18:26:42 +08:00
Kefu Chai
8b20bb8ca2 cephadm: drop cython from requires
cython is not required for launching the tox environment.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-12-08 18:23:57 +08:00
Kefu Chai
34e2e33870 *: s/whitelist_externals/allowlist_externals/
as allowlist_externals was introduced in
tox v4.0. see
5e33fda1a4 , but
this option was backported to 3.18 as an alias of whitelist_externals, so we don't need
to specify the minversion to 4.0 in this change.

as we started using tox 4.0 and up (v4.0.2 in specific). tox complains
and fails like:

alerts-lint: failed with promtool is not allowed, use allowlist_externals to allow it
  alerts-lint: FAIL code 1 (9.25 seconds)

see https://tox.wiki/en/latest/faq.html#tox-4-removed-tox-ini-keys
and https://tox.wiki/en/latest/config.html#allowlist_externals

it'd be nice to use a more inclusive language also. so, in this change,
s/whitelist_externals/allowlist_externals/ in all tox.ini in this
project.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-12-08 15:07:00 +08:00
zdover23
70a1011d18
Merge pull request #49306 from zdover23/wip-doc-2022-12-08-rbd-rados-rbd-cmds-create-a-block-device-user-semantics
doc/rbd: refine "Create a Block Device User"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-12-08 15:21:24 +10:00
Anthony D'Atri
dad9f9409f
Merge pull request #49288 from BryceCao/wip-update-doc-ubuntu-deps-install
doc/start: update "apt install" command in documenting-ceph.rst
2022-12-07 23:24:42 -05:00
cao.leilc
85a11ed22c doc/start: update "apt install" command in documenting-ceph.rst
Signed-off-by: caolei <cao.leilc@inspur.com>
2022-12-08 10:07:51 +08:00
Zac Dover
b6cc04e0bc doc/rbd: refine "Create a Block Device User"
Refine "Create a Block Device User", after suggestions made by Ilya
Dryomov in https://github.com/ceph/ceph/pull/49301#pullrequestreview-1208285685

https://tracker.ceph.com/issues/57001

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-12-08 10:38:52 +10:00
Laura Flores
4f693d8a57
Merge pull request #48943 from yaarith/fix-telemetry-ident
qa/workunits: identify ceph test clusters
2022-12-07 16:40:03 -06:00
Casey Bodley
d597c34fbb
Merge pull request #49121 from tchaikov/wip-cmake-cares
cmake: add c-ares::cares as a global visible library

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-12-07 15:07:27 -05:00
Casey Bodley
8b0acb2c0f
Merge pull request #48679 from cfsnyder/wip-rgw-multi-obj-del-perf
rgw: concurrency for multi object deletes

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-12-07 14:09:10 -05:00
Yuri Weinstein
85c412feae
Merge pull request #48265 from pdvian/wip-fix-mmgrupdate
mon: Fix condition to check for ceph version mismatch

Reviewed-by: Laura Flores <lflores@redhat.com>
2022-12-07 10:52:58 -08:00
Yuri Weinstein
17f18258e2
Merge pull request #48138 from sseshasa/wip-fix-osd-bench
osd: Randomize osd bench buffer data before submitting to objectstore

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-12-07 10:52:32 -08:00
Yuri Weinstein
f17d3f0cc4
Merge pull request #48136 from shreyanshjain7174/fix_versions
mon: remove empty list entries from ceph versions

Reviewed-by: Prashant D <pdhange@redhat.com>
2022-12-07 10:49:37 -08:00
zdover23
91bef1188b
Merge pull request #49282 from zdover23/wip-doc-2022-12-06-rbd-rados-rbd-cmds-create-a-block-device-pool-semantics
doc/rbd: refine "Create a Block Device Pool"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2022-12-08 02:51:20 +10:00
Casey Bodley
ac43fb4a4d
Merge pull request #49293 from BryceCao/wip-fix-rgw.yaml.in-spelling-mistake
src/common/options/rgw.yaml.in: fix spelling mistake

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-12-07 11:30:26 -05:00
Adam King
08718ae283
Merge pull request #47708 from rkachach/fix_issue_57160
mgr/rgw: adding support for rgw multisite

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
2022-12-07 10:43:44 -05:00
Adam King
62a3289df9
Merge pull request #48074 from adk3798/client-removal-fixing
mgr/cephadm: write client files after applying services

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-12-07 10:37:31 -05:00
Adam King
5bf1e01908
Merge pull request #48213 from adk3798/migration-too-high
mgr/cephadm: don't say migration in progress if migration current > migration last

Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-12-07 10:33:43 -05:00
Adam King
869a765abd
Merge pull request #48304 from rhcs-dashboard/iscsi-default-user-pwd
mgr/cephadm: iscsi username and password defaults to admin

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-12-07 10:32:07 -05:00
Kefu Chai
14720ac564
Merge pull request #49127 from Matan-B/wip-matanb-c-seq_mode_t
crimson/osd/osd_operations/client_request: Remove seq_mode_t

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-12-07 23:30:44 +08:00
Adam King
514895cdfa
Merge pull request #48306 from alimaredia/wip-ceph-adm-force-asok-removal
cephadm: force .asok file removal after daemon stoppage

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2022-12-07 10:27:25 -05:00
Adam King
af71b62986
Merge pull request #48389 from adk3798/staggered-start-update
qa/cephadm: update staggered upgrade test to use --image when redeploying mgr

Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-12-07 10:25:51 -05:00
Adam King
daf5491c93
Merge pull request #48391 from adk3798/iscsi-ports
mgr/cephadm: specify ports for iscsi

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-12-07 10:22:42 -05:00
Adam King
c2d9df5d1b
Merge pull request #48489 from rkachach/fix_issue_57816
mgr/cephadm: making grafana protocol configurable

Reviewed-by: Adam King <adking@redhat.com>
2022-12-07 10:20:56 -05:00