Commit Graph

42113 Commits

Author SHA1 Message Date
Loic Dachary
2d76e2cbba tests: erasure-code non regression tests must skip isa on i386
When the isa plugin is not present, the isa plugin payloads are not
tested. When that happens, remember that it was intentional by storing
the path that would have been tested so that the inventory is complete.

http://tracker.ceph.com/issues/11949 Fixes: #11949

Signed-off-by: Loic Dachary <loic@dachary.org>
2015-06-10 15:26:37 +02:00
Loic Dachary
e4011158e7 tests: ceph_erasure_code_non_regression s/stipe/stripe/
Synchronize withe the ceph-erasure-code-corpus submodule in which all
file names were modified to fix the typo.

http://tracker.ceph.com/issues/11932 Fixes: #11932

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-09 16:35:02 +02:00
Loic Dachary
7e0536af25 Merge pull request #4815 from dachary/wip-9720-erasure-code-corpus-variants
tests: sync ceph-erasure-code-corpus to verify jerasure variants 

Reviewed-by: Andreas Peters <andreas.joachim.peters@cern.ch>
2015-06-09 16:28:48 +02:00
Loic Dachary
b239945374 Merge pull request #4908 from dachary/wip-11931-parallel-tests
tests: automake 1.11 needs parallel-tests

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2015-06-09 15:50:12 +02:00
Loic Dachary
9193afd3d2 tests: automake 1.11 needs parallel-tests
Prior to automake 1.13 the default behavior was serial-tests meaning
tests from make check were run one after the other and their output sent
to stdout/stderr. From automake 1.13 up the default became
parallel-tests which logs the output of each individual test in a
separate .log file and allows them to run in parallel.

http://lists.gnu.org/archive/html/automake/2012-12/msg00038.html

Enable parallel-tests so that tests can always run in parallel, even
with automake 1.11 which is the version found in CentOS 6.5 and Ubuntu
12.04 precise.

A nice side effect of always having the logs in separate files is that
tests do not need to worry about being too verbose because their output
will only be read for diagnostic purposes.

http://tracker.ceph.com/issues/11931 Fixes: #11931
http://tracker.ceph.com/issues/11906 Fixes: #11906

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-09 14:56:49 +02:00
Loic Dachary
bfb92bd14b Merge pull request #4879 from SUSE/wip-master-specfile-cleanup
ceph.spec.in: remove duplicate BuildRequires

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-06-09 07:32:17 +02:00
Samuel Just
228ee47cfd Merge pull request #4784 from ceph/wip-10794
ceph-objectstore-tool improvements

Reviewed-by: Samuel Just <sjust@redhat.com>
2015-06-08 19:04:33 -07:00
Josh Durgin
ebc38f4a4b Merge pull request #4903 from theanalyst/doc/arch-watch-notify
doc: architecture minor fixes in watch notify

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-06-08 12:36:35 -07:00
Abhishek Lekshmanan
437c9e1e25 doc: architecture minor fixes in watch notify
Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>
2015-06-09 00:21:58 +05:30
Nathan Cutler
21f9e1f66c ceph.spec.in: remove duplicate BuildRequires
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2015-06-08 20:11:15 +02:00
Ken Dreyer
142a6ce711 Merge pull request #4880 from SUSE/wip-master-specfile-cleanup2
ceph.spec.in: move specific BuildRequires to where they belong

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
2015-06-08 10:27:44 -06:00
Kefu Chai
2c1f4d4afb Merge pull request #4893 from dachary/wip-11272-ceph-disk-false-negative
tests: ceph-disk.sh test zap gitbuilder false negative

Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-06-08 22:12:46 +08:00
Kefu Chai
66f3b192ae Merge pull request #4888 from dachary/wip-11905-test-isa
tests: skip isa tests if the plugin is not available

Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-06-08 10:38:52 +08:00
Loic Dachary
3e12863784 tests: ceph-disk.sh test zap gitbuilder false negative
When looking for an error message and testing ceph disk zap, use grep -q
to not display the error message that will be mistaken for a real error
by the gitbuilder parser.

http://tracker.ceph.com/issues/11272 Refs: #11272

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-07 13:52:01 +02:00
Loic Dachary
4d58c07490 tests: skip isa tests if the plugin is not available
http://tracker.ceph.com/issues/11905 Fixes: #11905

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-07 10:53:49 +02:00
Loic Dachary
90baef866f tests: use erasure_code_plugin_exists from ceph-helpers.sh
Instead of the local plugin_exists helper that does the same.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-07 10:52:31 +02:00
Loic Dachary
deb651b61c tests: implement erasure_code_plugin_exists in ceph-helpers.sh
Return 0 if the erasure code *plugin* is available, 1 otherwise.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-07 10:51:07 +02:00
Loic Dachary
2beba7c9d1 Merge pull request #4713 from dachary/wip-10358-erasure-code-k-1-m-1
ceph osd erasure-code-profile set myprofile k=1 should fail

Reviewed-by: Andreas Peters <andreas.joachim.peters@cern.ch>
2015-06-07 09:58:26 +02:00
Loic Dachary
fda586f5f8 tests: sync ceph-erasure-code-corpus to verify jerasure variants
http://tracker.ceph.com/issues/9720 Refs: #9720

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-07 00:15:05 +02:00
Loic Dachary
864e2007d9 tests: add --{show_,}path to ceph_erasure_code_non_regression
The directory in which the payload is stored is created from the plugin
parameters. The --show-path shows the directory and exits. This
directory can then be used with --path to override the path created from
the plugin parameters. This is useful to verifying that the jerasure
variant optimized with AVX, SSE4 etc. instructions can be used on the
same payload and show no difference at all. In this case the directory
used by the default jerasure variant is used for each variant and the
parameter that sets the variant to use ( --parameters jerasure-variant )
must not be taken into account to figure out the location of the
payload.

http://tracker.ceph.com/issues/9720 Refs: #9720

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-07 00:15:05 +02:00
Loic Dachary
1d60786c39 Merge pull request #4811 from dachary/wip-11346-isa
ceph-erasure-code-corpus: isa: add k=10 m=4

Reviewed-by: Yuan Zhou <yuan.zhou@intel.com>
2015-06-07 00:12:11 +02:00
Loic Dachary
3ec41030cc erasure-code: add sanity check to guard against k=1
Add a call to ErasureCode::sanity_check_k for the isa and jerasure
plugins, with associated tests.

http://tracker.ceph.com/issues/10358 Fixes: #10358

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 23:51:57 +02:00
Sage Weil
efededa010 Merge pull request #4882 from SUSE/wip-submitting-patches-clarification
SubmittingPatches: clarify how Reviewed-by lines are added

Reviewed-by: Sage Weil <sage@redhat.com>
2015-06-06 06:24:17 -07:00
Nathan Cutler
85b327f85a SubmittingPatches: clarify how Reviewed-by lines are added
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2015-06-06 15:16:16 +02:00
Loic Dachary
eefdeb6b79 Merge pull request #4878 from dachary/wip-11901-spec
ceph.spec.in: add missing BuildRequires from SUSE block

Reviewed-by: Nathan Cutler <ncutler@suse.cz>
2015-06-06 14:37:23 +02:00
Nathan Cutler
e1cb7e5104 ceph.spec.in: move specific BuildRequires to where they belong
Move distro-specific BuildRequires out of "common" section and
into the appropriate %if statement in the "specific" section.
Also remove a duplicated "Requires: gdisk".

Signed-off-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 14:14:50 +02:00
Loic Dachary
739ef0f9a3 install-deps.sh: detect yum-builddep errors
yum-builddep does not exit on error when an error happens: grep the
output for the error: string instead.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 12:31:56 +02:00
Loic Dachary
34e4dd9c8a ceph.spec.in: add missing BuildRequires from SUSE block
The %endif removed by f94f23297c is restored.
The %else removed by 75e87a20da is restored.
The stray %endif added by d8abde3338 is removed.

May 29th, in d8abde3338 Owen added a stray
%endif after

   BuildRequires: gperftools-devel

around line 133. June 3rd, in f94f23297c
Ken correctly attributed the error

     "error: /srv/autobuild-ceph/gitbuilder.git/build/ceph.spec:140: Got a
      %endif with no %if"

to a stray %endif but did not remove the one causing problem and in
doing so created another problem. June 4th, in
75e87a20da Owen incorrectly fixed
this new problem by removing the %else that is near

   BuildRequires: gperftools-devel

around line 116, instead of reverting
f94f23297c. As a consequence the
ceph.spec.in became syntactically correct but implemented an if/else
logic different from what was intended originally and a number of
BuildRequires became exclusive to SUSE and were not installed for CentOS
7 etc.

http://tracker.ceph.com/issues/11901 Fixes: #11901

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 12:05:19 +02:00
Loic Dachary
37f7360760 erasure-code: implement ErasureCode::sanity_check_k
Implement the ErasureCode::sanity_check_k helper for plugins
that need to verify k >= 2.

http://tracker.ceph.com/issues/10358 Fixes: #10358

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 09:43:49 +02:00
Noah Watkins
a8500ce981 Merge pull request #4834 from liewegas/wip-11461
fix build on arm w/ old kernels

Signed-off-by: Noah Watkins <nwatkins@redhat.com>
2015-06-05 12:12:13 -07:00
Greg Farnum
905a867043 Merge remote-tracking branch 'origin/wip-client-fsync'
Conflicts:
	src/client/Client.cc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:25:21 -07:00
Gregory Farnum
3f4dfb80e3 Merge pull request #4831 from ceph/wip-11807
qa: fix multiple_rsync.sh to avoid using /usr/ directly

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2015-06-05 11:22:53 -07:00
Gregory Farnum
7dc602aff7 Merge pull request #4743 from ceph/wip-client-oldest-tid
Wip client oldest tid

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:21:20 -07:00
Gregory Farnum
3673c8be10 Merge pull request #4723 from ceph/wip-snap-misc
Wip snap misc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:16:50 -07:00
Gregory Farnum
5e99022fc6 Merge pull request #4702 from tchaikov/wip-fix-11590
mon: always reply mdsbeacon

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:15:25 -07:00
Gregory Farnum
5a3da7b891 Merge pull request #4602 from ceph/wip-11504
mon: refine check_remove_tier checks

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:13:42 -07:00
Josh Durgin
788542cc05 Merge pull request #4781 from ceph/wip-librbd-perf-counters
librbd: re-add missing discard perf counters

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-06-05 08:59:15 -07:00
Loic Dachary
f2897886b0 Merge pull request #4870 from joaquimrocha/extra_doc_info_for_debug_option
build: Add info about tests to --with-debug option

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-06-05 15:22:48 +02:00
Joaquim Rocha
63aa2e6a95 build: Add info about tests to --with-debug option
The configure's --with-debug option builds also some of the tests
so this should be mentioned in its doc string in order to let users
know how to build all the tests.

Signed-off-by: Joaquim Rocha <joaquim.rocha@cern.ch>
2015-06-05 15:17:42 +02:00
Loic Dachary
3a562b44f9 Merge pull request #4866 from ddiss/fix_test_ceph_disk_dmcrypt_uuid_only
tests: fix test_activate_dmcrypt uuid usage

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-06-05 11:56:37 +02:00
David Disseldorp
7bef2d8897 tests: fix test_activate_dmcrypt uuid usage
4601e10800 introduced a regression in that
an empty (uninitialised) OSD uuid is passed to test_pool_read_write for
IO. As a result, the "rados put" request times out causing test failure.

This change ensures that a correct OSD uuid is passed to
test_pool_read_write.

Signed-off-by: David Disseldorp <ddiss@suse.de>
2015-06-05 11:39:31 +02:00
Josh Durgin
792e94822f Merge pull request #4528 from ceph/wip-librbd-helgrind
librbd: correct issues discovered via lockdep / helgrind

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-06-04 18:55:43 -07:00
Jason Dillaman
c1b2783bc0 Merge pull request #4857 from jdurgin/wip-rbd-features-constants
update rbd features constants for python usage

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 20:37:39 -04:00
Jason Dillaman
3d5cef38c3 librbd: flush pending ops while not holding lock
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00
Jason Dillaman
742a85d667 tests: fix possible deadlock in librbd ImageWatcher tests
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00
Jason Dillaman
45cb9cb598 tests: enable lockdep for librbd unit tests
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00
Jason Dillaman
c9142fe353 librbd: owner_lock should be held during flush request
Flush might result in the cache writing out dirty objects, which
would require that the owner_lock be held.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00
Jason Dillaman
a38f9e5104 osdc: ObjectCacher flusher might needs additional locks
librbd requires the ObjectCacher flusher thread to acquire
an additional lock in order to maintain lock ordering
constraints.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00
Jason Dillaman
1b57cc1da7 librbd: fix recursive locking issues
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00
Jason Dillaman
d6b733dbdd librbd: simplify state machine handling of exclusive lock
It is expected that all IO is flushed and all async ops are cancelled
prior to releasing the exclusive lock.  Therefore, replace handling of
lost exclusive locks in state machines with an assertion.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00