Kefu Chai
af3f49d981
pybind/mgr/balancer: define options using Option
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:18:42 +08:00
Kefu Chai
376939d8d8
pybind/mgr/balancer: add type annotations
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:18:41 +08:00
Kefu Chai
46f00b3da2
pybind/mgr/balancer: define commands using CLICommand
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:17:58 +08:00
Kefu Chai
e06bf9157e
Merge pull request #39336 from AlexWangD/patch-4
...
doc: fix the spelling mistake of “Topicd”
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-07 20:07:01 +08:00
Alex Wang
357e1b2c84
doc: fix the spelling mistake of “Topicd”
...
“Topicd” is a spelling mistake of "Topics".
2021-02-07 15:26:04 +08:00
Kefu Chai
b3e1a0c122
Merge pull request #37566 from AmnonHanuhov/wip-ObjectStore_EIO_Handling
...
crimson/osd: Recover missing object on read error
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-07 12:18:01 +08:00
Yingxin Cheng
4f556014b0
crimson/onode-staged-tree: cleanup -- switch to get_*_slot() interfaces
...
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-02-07 10:19:41 +08:00
Mykola Golub
7bafcfbb01
Merge pull request #39303 from dillaman/wip-49173
...
librbd/io: conditionally disable move optimization
Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-02-06 11:23:45 +02:00
J. Eric Ivancich
36a208f287
Merge pull request #39312 from ivancich/wip-orphan-list-binary-data
...
rgw: allow rgw-orphan-list to handle intermediate files w/ binary data
Reviewed-by: Michael Kidd <linuxkidd@gmail.com>
2021-02-05 14:46:56 -05:00
Michael Fritch
80990f5bdc
mgr/cephadm: Redefinition of unused name from line n (F811)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:58 -07:00
Michael Fritch
2e2b419daf
mgr/cephadm: Module imported but unused (F401)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:58 -07:00
Michael Fritch
6658c53d6f
mgr/cephadm: Local variable name is assigned to but never used (F841)
...
add error handling when `CompletedProcess` fails during rgw relam,
zongroup create et al.
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
97c6a8564e
mgr/cephadm: Local variable name is assigned to but never used (F841)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
4e4d4c5e4b
mgr/cephadm: Line break occurred after a binary operator (W504)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
8e093a5993
mgr/cephadm: Trailing whitespace (W291)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:57 -07:00
Michael Fritch
867c7423e5
mgr/cephadm: undefined name 'channel' (F821)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:56 -07:00
Michael Fritch
b40d28ce90
mgr/cephadm: use ==/!= to compare constant literals (F632)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:56 -07:00
Michael Fritch
22d6a1b7d8
mgr/cephadm: f-string is missing placeholders (F541)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:56 -07:00
Michael Fritch
fb73d8e5c2
mgr/cephadm: Do not use variables named 'I', 'O', or 'l' (E741)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:55 -07:00
Michael Fritch
e26db8c210
mgr/cephadm: Do not assign a lambda expression, use a def (E731)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:55 -07:00
Michael Fritch
9b0a3e6239
mgr/cephadm: Do not use bare except, specify exception instead (E722)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:55 -07:00
Michael Fritch
5136f4b1d0
mgr/cephadm: Comparison to true should be 'if cond is true:' or 'if cond:' (E712)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:54 -07:00
Michael Fritch
1738e22ec0
mgr/cephadm: Multiple statements on one line (def) (E704)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:54 -07:00
Michael Fritch
bed9be73ee
mgr/cephadm: statement ends with a semicolon (E703)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:32 -07:00
Michael Fritch
d76324ea38
mgr/cephadm: Expected 1 blank line before a nested definition (E306)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:02 -07:00
Michael Fritch
7e73af4b98
mgr/cephadm: Expected 2 blank lines, found 0 (E302)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:20:01 -07:00
Michael Fritch
46a322ba01
mgr/cephadm: at least two spaces before inline comment (E261)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:19:26 -07:00
Michael Fritch
ae76ba8a54
mgr/cephadm: multiple spaces after ':' (E241)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:54 -07:00
Michael Fritch
cf4d666573
mgr/cephadm: Missing whitespace after ',', ';', or ':' (E231)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:24 -07:00
Michael Fritch
ef45cc50b5
mgr/cephadm: Missing whitespace around arithmetic operator (E226)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:24 -07:00
Michael Fritch
17c7c4ae73
mgr/cephadm: Missing whitespace around operator (E225)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:24 -07:00
Michael Fritch
918eec7d1b
mgr/cephadm: Continuation line under-indented for visual indent (E128)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:23 -07:00
Michael Fritch
b04fb5f262
mgr/cephadm: Continuation line over-indented for hanging indent (E126)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:23 -07:00
Michael Fritch
bb28ad2b5b
mgr/cephadm: closing bracket does not match visual indentation (E124)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:23 -07:00
Michael Fritch
b025081f8e
mgr/cephadm: Continuation line missing indentation or outdented (E122)
...
also resolves:
continuation line unaligned for hanging indent (E131)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:22 -07:00
Michael Fritch
144ff982d2
mgr/cephadm: Continuation line under-indented for hanging indent (E121)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:22 -07:00
Michael Fritch
4005d606c0
mgr/cephadm: Indentation is not a multiple of four (comment) (E114)
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:21 -07:00
Michael Fritch
baacb36be0
mgr/cephadm: introduce flake8
...
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:18:17 -07:00
Michael Fritch
7c44f21bbb
cephadm: configure journald as the logdriver
...
Introduced by e6792f306a
podman containers running in a detached `-d` state need to have a
configured logdriver for `cephadm logs` to be able to gather the daemon
output from journald
Fixes: https://tracker.ceph.com/issues/47916
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 08:05:41 -07:00
Michael Fritch
575058904a
cephadm: extend --container-init
to the shell command
...
allow for the `--init` flag to be passed during `cephadm shell`
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 08:03:56 -07:00
Michael Fritch
9ac2ab85cb
cephadm: run containers using --init
by default
...
generally all ceph containers need an init process to both reap any
zombie pids and/or perform signal handling (e.g. coredumps, etc.)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 08:03:49 -07:00
Michael Fritch
d89fae5c9d
doc/man/cephadm: add missing --container-init
flag
...
adopt command allows for the `--container-init` flag
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-05 08:03:43 -07:00
Sebastian Wagner
511cde8ced
Merge pull request #39261 from adk3798/applytest
...
mgr/orchestrator: useful message when no service type in "ceph orch apply"
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-02-05 12:17:11 +01:00
Sebastian Wagner
60c07c0724
Merge pull request #39238 from liewegas/cephadm-conditional-osd-apply
...
mgr/cephadm: only apply osd specs if the devices have changed
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-05 11:47:58 +01:00
Sebastian Wagner
0d0572ba93
Merge pull request #39259 from sebastian-philipp/cephadm-execnet-chmod-600
...
mgr/cephadm: on ssh connection error, advice chmod 0600
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-02-05 11:46:43 +01:00
Kefu Chai
bc9e6fef12
Merge pull request #39318 from AlexWangD/patch-3
...
doc: fix the spelling mistake of “Rersult”
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-05 18:10:06 +08:00
Alex Wang
1b315a15fa
doc: fix the spelling mistake of “Rersult”
...
“Rersult” is a spelling mistake of "Result".
Signed-off-by: Alex Wang wangdashuai@inspur.com
2021-02-05 16:03:47 +08:00
Yingxin Cheng
5bd34cf1b3
crimson/onode-staged-tree: cleanup -- implement and use get_next_slot()
...
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-02-05 13:50:07 +08:00
Kefu Chai
72dee5d0d3
Merge pull request #39258 from Rethan/doc-remove-ms-options
...
doc/rados: remove some invalid ms option
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-05 13:48:10 +08:00
J. Eric Ivancich
b520cc5a91
rgw: allow rgw-orphan-list to handle intermediate files w/ binary data
...
Updates the grep commands with the --text command-line option since
there are cases where rados object names contain NUL characters.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2021-02-04 18:38:11 -05:00