Commit Graph

119548 Commits

Author SHA1 Message Date
Samuel Just
ac9e308c3a
Merge pull request #39239 from athanatos/sjust/wip-49114
crimson/os/seastore: fix staged-fltree build problems

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-02-02 19:11:41 -08:00
Paul Cuzner
81caa2643e mgr/cephadm:updates to support orch status changes
The available function definition has been updated in
cephadm/rook and Orchestrator base class to provide a
module specific dictionary holding any specific info that
would be pertinent to share with the user. This in turn
changed the _status method for cephadm, but the UX
remains the same (i.e. admin must use --detail to see
the worker pool size).

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-03 14:45:15 +13:00
Samuel Just
ad1cc8875b crimson/.../staged-fltree: propogate eagain in node, value
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-02-02 16:58:54 -08:00
Samuel Just
83a8d5d98e crimson/.../staged-fltree: fix tree_cursor_t::(trim|extend)_value
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-02-02 16:58:28 -08:00
Sage Weil
b129c13121 mgr/cephadm: only reapply osd spec if devices have changed
This avoids a lot of useless work when the devices have not changed.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-02-02 17:10:01 -06:00
Sage Weil
821f7e9d5b mgr/cephadm: use datetime_now() for last_facts_update
Be consistent!

Signed-off-by: Sage Weil <sage@newdream.net>
2021-02-02 17:10:01 -06:00
Sage Weil
2b7d8e1630 mgr/cephadm: track last_device_change
Keep track of when the device inventory and/or state *changes*.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-02-02 17:10:01 -06:00
Sage Weil
197a8ba22f mgr/cephadm: track last_applied by host for osd specs
For each host, note when we last applied each osdspec.  Log the start
time, not the end time.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-02-02 17:10:01 -06:00
Sage Weil
cced65aab7 Merge PR #39206 into master
* refs/pull/39206/head:
	mgr/MetricTypes: condition encoding on feature bits

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2021-02-02 17:47:52 -05:00
Paul Cuzner
7bed9ccf09 mgr/orchestrator: resolve rebase issue
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-03 11:47:49 +13:00
Paul Cuzner
83a25c5e23 mgr/orchestrator: rebase including the --detail
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-03 11:47:49 +13:00
Paul Cuzner
8c9cd764ee mgr/orchestrator: removed worker_pool method
The worker_pool_size method has been removed and its
functionality replaced by the cephadm 'available' function to
help keep the interface model generic.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-03 11:47:49 +13:00
Paul Cuzner
a4f4a67fe7 mgr/orchestrator: doc updated to show optional parameter
Updated the orch status document to show the --detail option

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-03 11:47:49 +13:00
Paul Cuzner
4588ad184c mgr/orchestrator: rebase patch
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-03 11:47:49 +13:00
Samuel Just
b6d9806477
Merge pull request #38924 from cyx1231st/wip-seastar-onode-tree-onode_t
crimson/onode-staged-tree: implement an extensive Value framework

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-02 13:05:39 -08:00
J. Eric Ivancich
81d6260c1a rgw: add radosgw-admin bucket radoslist bucket/obj mapping
A new command-line option "--rgw-obj-fs" is added to
radosgw-admin. When used with the "bucket radoslist" subcommand, will
output lines with a rados object, bucket name, and object name,
separated by the field separator specified. Without this command-line
option, only the rados object is output, which is the previous
behavior.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2021-02-02 15:42:22 -05:00
Neha Ojha
f02cd4d8b0 qa/*/test_envlibrados_for_rocksdb: use osd_client_message_cap to prevent slow requests
EnvLibradosMutipoolTest.DBBulkLoadKeysInRandomOrder can overload OSDs and cause
heartbeat timeouts. Tests in test_envlibrados_for_rocksdb also generate slow
requests on OSDs. Use osd_client_message_cap to prevent this.
Since this option is disabled by default, this may be a good way to exercise it.

Fixes: https://tracker.ceph.com/issues/49064
Signed-off-by: Neha Ojha <nojha@redhat.com>
2021-02-02 18:40:50 +00:00
Ilya Dryomov
fab4c2a9ea
Merge pull request #39209 from idryomov/wip-unbreak-rbd-task
qa/tasks/rbd: fix regressions introduced with rbd encryption support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-02-02 18:16:56 +01:00
Sage Weil
e74df78368 Merge PR #39212 into master
* refs/pull/39212/head:
	cpatch: python 3.6 -> 3.8
	cpatch: new default base image

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-02-02 11:49:07 -05:00
zdover23
42d3352f30
Merge pull request #39207 from zdover23/wip-doc-removing-workbench-docs
doc/dev: remove workbench sections

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-02-03 02:14:24 +10:00
Kefu Chai
085723b4b8
Merge pull request #39227 from tchaikov/wip-48825
mgr/zabbix: format ceph.[{#POOL},percent_used as float

Reviewed-by: Wido den Hollander <wido@widodh.nl>
2021-02-03 00:11:41 +08:00
Kefu Chai
5329cb4839
Merge pull request #39225 from tchaikov/wip-crimson-seastore-dec-ref
crimson/os/seastore: don't use variadic template for dec_ref()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-02-03 00:06:03 +08:00
Nizamudeen A
8c5e31ec1a mgr/dashboard: Add badge to the Label column in Host List
Fixes: https://tracker.ceph.com/issues/49105
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-02-02 20:42:02 +05:30
Igor Fedotov
07f136a2f7
Merge pull request #38050 from ifed01/wip-ifed-fsck-spanning-blob
os/bluestore: detect and fix "zombie" spanning blobs using fsck.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2021-02-02 18:09:08 +03:00
Varsha Rao
01db81e2bc doc/cephfs/nfs: Add rook pod restart note, export and log block example
Fixes: https://tracker.ceph.com/issues/48914
Signed-off-by: Varsha Rao <varao@redhat.com>
2021-02-02 20:07:43 +05:30
Sebastian Wagner
582f7c1657 python-common: Set disallow_untyped_defs = True
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-02 15:16:54 +01:00
Sebastian Wagner
16dfa60b9f python-common: removed unused exeption.py
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-02 15:16:54 +01:00
Sebastian Wagner
7a297262aa python-common: Type annotation for ServiceSpec.from_json
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-02 15:16:54 +01:00
Kefu Chai
c8e5a051a0 mgr/zabbix: format ceph.[{#POOL},percent_used as float
also, multiply it with 100, as we are using 1.0 for 100% here.

for more details regarding the mapping from value_type to its values.
see
https://www.zabbix.com/documentation/4.0/manual/api/reference/item/object

Fixes: https://tracker.ceph.com/issues/48825
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-02 21:39:57 +08:00
Igor Fedotov
18d120dc2c os/bluestore: detect and fix "zombie" spanning blobs using fsck.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2021-02-02 15:49:31 +03:00
Kefu Chai
f256086bd2 crimson/os/seastore: don't use variadic template for dec_ref()
simpler this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-02 20:09:48 +08:00
Igor Fedotov
f6b18055ab
Merge pull request #39041 from ifed01/wip-ifed-fix-48966
os/bluestore: fix a bug causing unexpected Onode's unpinned state.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-02 14:10:01 +03:00
Kefu Chai
4e76cdb468 osd: let object_info_t() decode const bufferlist.
so we can decode a const bufferlist without creating a copy of it
beforehand.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-02 19:02:33 +08:00
Jan Fajerski
e332eae077 Merge PR #38869 into master
* refs/pull/38869/head:
	ceph-volume: Fix usage of is_lv

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2021-02-02 10:46:35 +01:00
Kefu Chai
11dc14e1bf
Merge pull request #38975 from athanatos/sjust/wip-seastore-pipelines
seastore: update to support pipelined write operations

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-02 17:40:37 +08:00
Igor Fedotov
ea0fc57ef5 os/bluestore: fix a bug causing unexpected Onode's unpinned state.
There could be a race for Onodes put() and get() methods:

put()(pinned, nref=3)
  int n = --nref; (nref = 2)
  if (n == 2) {
    ..
    std::lock_guard l(ocs->lock);
    ...
    pinned = pinned && nref > 2; (= false)
    ...                                     get()
    if (r) {                                ++nref; (=3)
      n = --nref; (nref = 2)                return;
    }
    ...
    return

As a result nref = 2, pinned = false which is wrong

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2021-02-02 12:25:00 +03:00
Kefu Chai
cb76a62a91 crimson/osd: consume the push payload
by moving away from it, we consume the payload in the push requests,
save the overhead of copying the payloads. this also allows us to avoid
memcopy when passing the payload down to seastore in future. we need to
revise the interface of FuturizedStore for this though.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-02 17:24:05 +08:00
myoungwon oh
88b364ba44 osd: fix to call nullptr when cancel_manifest_ops
Segmentation fault can occur because
cancel_manifest_ops must call callback without checking
nullptr even though ManifestOp can be used with null callback
in start_dedup()

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsumg.com>
2021-02-02 15:43:14 +09:00
Kefu Chai
391cd0cd46
Merge pull request #39205 from rzarzynski/wip-crimson-configurable-alien-threads-num
crimson: make the number of alien threads configurable.

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
2021-02-02 14:04:59 +08:00
Kefu Chai
9e16acc8f0 crimson/osd: consolidate shared code
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-02 12:45:42 +08:00
Kefu Chai
d34432fbfa crimson/osd: clone local object only if we can
there is no need to stat local object if we don't plan to clone local
object to target object.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-02 12:45:42 +08:00
Kefu Chai
2417f50d2b crimson/osd: extract prep_push_target() out
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-02 12:45:42 +08:00
Xiubo Li
6d0d1d96c2 qa: add REST API method support for ceph-iscsi
Fixes: https://tracker.ceph.com/issues/48529
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-02-02 11:06:07 +08:00
Paul Cuzner
804f34e475 cephadm:updates following bootstrap code clean up
Patch to align to new(ish) bootstrap code changes

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-02 15:42:00 +13:00
Paul Cuzner
af00a33322 cephadm: updated doc text
The phrase "recommended"  has been removed.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-02 14:22:43 +13:00
Paul Cuzner
bbe4fd83c5 cephadm: unit test updates for cluster-network handling
Tests updated to handle comma separated subnet lists

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-02 14:22:43 +13:00
Paul Cuzner
abd9287db0 cephadm: updated handling of cluster_network parameter
Parameter now supports a comma separated list of subnets and
detects the ipv4 or ipv6 setting on the cluster network to enable
osds to bind correctly.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-02 14:22:43 +13:00
Paul Cuzner
509f171a08 cephadm: install doc updated to include cluster-network parameter
Install guide updated to include a description of the --cluster-network
parameter. The text also links to the complete definition for cluster-network
on the rados/configuration/network-config-ref page.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-02 14:22:43 +13:00
Paul Cuzner
3f352c8af4 cephadm: unit test updates for new subnet function
Adds tests to validate the check_subnet function will work as
expected with various inputs

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-02 14:22:42 +13:00
Paul Cuzner
c391ccb97f cephadm: Add cluster network parameter to bootstrap cmd
Adds a --cluster-network parameter to the bootstrap cmd to
set the internal cluster network.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-02-02 14:22:42 +13:00