Commit Graph

114040 Commits

Author SHA1 Message Date
Mykola Golub
27e237c137
Merge pull request #36479 from dillaman/wip-46669
test/rbd-mirror: pool watcher registration error might result in race

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-08-15 18:31:10 +03:00
Kefu Chai
0fb54fbcf0
Merge pull request #36639 from tchaikov/wip-crimson-build-push-op
crimson/osd: clear data_included if fiemap fails

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-08-15 18:47:46 +08:00
Kefu Chai
d11ed390ae
Merge pull request #36505 from rzarzynski/wip-crimson-bump-up-seastar
crimson: bump up seastar version to freshest master

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-08-15 18:41:42 +08:00
Kefu Chai
7eb38b8a8d
Merge pull request #36529 from tchaikov/wip-crimson-dts-9
ceph.spec.in: use devtoolset-9 for building crimson

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2020-08-15 18:39:48 +08:00
Kefu Chai
10086983d9 install-deps.sh: add tchaikov's copr repo for crimson build on el8
we need it before the updated version of gcc-toolset9 addressing
https://bugzilla.redhat.com/show_bug.cgi?id=1853900 is available in
RHEL8/CentOS8.

see https://copr.fedorainfracloud.org/coprs/tchaikov/gcc-toolset-9

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-15 17:43:40 +08:00
Kefu Chai
5c038b99b3 ceph.spec.in: use gcc-toolset-9 for building crimson
since seastar dropped support from C++14, we have to move to a compiler
with a decent C++17 support.

in this change, gcc-toolset-9 is used for compiling ceph if seastar is
enabled. use version >= 9.2.1-2.2, because of
https://bugzilla.redhat.com/show_bug.cgi?id=1853900

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-15 17:43:40 +08:00
Kefu Chai
4ac4f69b4b crimson/osd: clear data_included if read fails
* extract read_object_for_push_op() out of build_push_op().
  build_push_op() is composed of multiple steps. would be better
  if we can split and extract them into separated method for better
  readability
* clear push_op->data_included() if fiemap fails. before this change,
  a local copy of `copy_subset` is cleared if fiemap fails, but
  push_op->data_included is not updated in this case. we should
  clear the latter if no data is returned in push_op->data. so,
  in this change, push_op->data_included is cleared if fiemap
  fails. the same applies to other cases where no data is returned in
  push_op
* add comments to outline the steps in read_object_for_push_op().

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-15 17:27:02 +08:00
Kefu Chai
03ab02c8ee crimson/osd: print detailed info of object being recovered
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-15 11:09:13 +08:00
Kefu Chai
fbfc0f9f27 crimson/osd: remove stale comment
CyanStore supports readv() now, so remove this comment.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-15 11:09:13 +08:00
Kefu Chai
96e12dc4e4 crimson/osd: do not use __func__ in a lambda
otherwise we would have logging messages like

operator(): returning obc ...

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-15 11:09:13 +08:00
Nathan Cutler
e5e1e3006a
Merge pull request #36618 from tspmelo/wip-backport-jq
script/ceph-backport.sh: Check if jq is installed
2020-08-14 20:07:06 +02:00
Lenz Grimmer
b539ea6003
Merge pull request #36609 from tspmelo/wip-doc-browsers
mgr/dashboard: Update list of supported browsers

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-08-14 15:31:40 +02:00
Jason Dillaman
17b6b0ca41
Merge pull request #36624 from lixiaoy1/fix_config
rbd/rwl: fix the config issue

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-08-14 08:29:35 -04:00
Jason Dillaman
148c18c6d6
Merge pull request #36466 from lixiaoy1/rbd_image_info_br
rbd/status: get image cache state

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-08-14 08:21:11 -04:00
Jason Dillaman
029f864d3e
Merge pull request #36422 from orozery/object_dispatch_assert_version_write
librbd: support writing with version assertion on object dispatch

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-08-14 08:20:49 -04:00
Jason Dillaman
99ee943631
Merge pull request #36366 from runsisi/wip-fix-free
librbd: fix possible use after free error while shuting down exclusive lock

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-08-14 08:20:30 -04:00
Jason Dillaman
2648c087fa
Merge pull request #36561 from lixiaoy1/fix_queue
rbd/rwl: fix the construction of ContextWQ

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-08-14 08:20:10 -04:00
Tiago Melo
bc0650b057 mgr/dashboard: Update list of supported browsers
Fixes: https://tracker.ceph.com/issues/46923

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-08-14 11:53:48 +00:00
lixiaoy1
ad98989466 rbd/rwl: fix the config issue
Include acconfig.h to the librbd/cache/Util.h.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
2020-08-14 07:09:57 -04:00
Tiago Melo
d5730371d7 script/ceph-backport.sh: Check if jq is installed
If you tried to setup ceph-backport.sh without having 'jq' installed, you would
get a totally unrelated error message and it was hard to figure out the problem.

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-08-14 09:01:57 +00:00
Lenz Grimmer
26ebb5aa31
Merge pull request #36604 from tspmelo/wip-favicon-circle
mgr/dashboard: Fix favicon white circle

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-08-14 10:22:12 +02:00
Lenz Grimmer
fd090b1df7
Merge pull request #36602 from tspmelo/wip-spell-check
mgr/dashboard: Fix spell errors

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2020-08-14 10:19:46 +02:00
Lenz Grimmer
11aa337814
Merge pull request #36585 from votdev/proper_format_portals
mgr/dashboard: Proper format iSCSI target portals

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-08-14 10:16:56 +02:00
Lenz Grimmer
e8c81f2330
Merge pull request #36566 from votdev/issue_46900_autocomplete
mgr/dashboard: Strange iSCSI discovery auth behavior

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-08-14 10:13:30 +02:00
Lenz Grimmer
3d74ae7ee9
Merge pull request #36567 from votdev/issue_46901_hide_limit_action_field
mgr/dashboard: Hide table action input field if limit=0

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-08-14 10:06:30 +02:00
Kefu Chai
4fea9a8be3
Merge pull request #36510 from athanatos/sjust/wip-tm-decref
crimson: remove extent from cache in TransactionManager::dec_ref

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-08-14 03:47:55 +08:00
Samuel Just
bb3a7f3515 crimson/os/seastore/transaction_manager: complete dec_ref
Previously, dec_ref didn't handle actually retiring the
extent from the cache.  dec_ref will now reach into the
cache and mark the extent retired if it exists either
in the cache or in the current transaction.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-08-13 11:32:31 -07:00
Samuel Just
3af6617673 crimson/os/seastore/lba_manager: clarify ref count operation return
Previously, we returned a refcount from inc_ref and dec_ref.  Now,
return the paddr as well for future code accounting for released
extents.

In addition, replumb btree_lba_manager to return an enoent error if
the mapping does not exist, and the resulting refcount, paddr
otherwise with a refcount of 0 indicating that the mapping has
been removed.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-08-13 11:32:31 -07:00
Samuel Just
8cd2dfaa77 crimson/os/seastore/cache: don't mark invalid extents clean
In the event that an extent is created and removed in the same
transaction (invalid extent in fresh_block_list), update
block specific metadata but don't add to cache and especially
do not mark clean.  LBAManager::complete_commit implementations
are meant to use skip based on state in the same way.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-08-13 11:32:31 -07:00
Samuel Just
4943d14644 crimson/os/seastore/cached_extent: add print_detail for logical extents
This way we can always see laddr in debug output.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-08-13 11:32:28 -07:00
Ilya Dryomov
e66dc2fc00
Merge pull request #36591 from idryomov/wip-snap-create-progress
qa: update krbd tests for snap create

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-08-13 16:25:06 +02:00
Lenz Grimmer
beb19d7da9
Merge pull request #36434 from ricardoasmarques/fix-iscsi-logged-in-client-edit
mgr/dashboard: Unable to edit iSCSI logged-in client

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-08-13 15:58:46 +02:00
Lenz Grimmer
fcadcba4ed
Merge pull request #36564 from ceph/46899-log-info-from-unhandled-errors
mgr/dashboard: log useful information from internal server errors

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Fabrizio D'Angelo <fdangelo@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2020-08-13 15:31:38 +02:00
Tiago Melo
4f53b1ddef mgr/dashboard: Fix favicon white circle
A white circle was displayed when the user logged out.

Fixes: https://tracker.ceph.com/issues/46919

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-08-13 11:38:15 +00:00
Tiago Melo
e7dc692312 mgr/dashboard: Fix spell errors
Fixes: https://tracker.ceph.com/issues/46917

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-08-13 10:50:31 +00:00
Volker Theile
ac0b34a267 mgr/dashboard: Proper format iSCSI target portals
Proper format the 'Portals' and 'Images' columns.

Fixes: https://tracker.ceph.com/issues/46908

Signed-off-by: Volker Theile <vtheile@suse.com>
2020-08-13 09:12:07 +02:00
Yan, Zheng
f93105e895
Merge pull request #36532 from simon-rock/crash_on_restart
mds : move start_files_to_recover() to recovery_done
2020-08-13 09:55:16 +08:00
Simon Gao
fafb5b4f84 mds : move start_files_to_recover() to recovery_done
the requests in the queue, named waiting_for_replay, may modify the state of the filelock,
resulting in the wrong lock state when repairing file (start_files_to_recover)

Fixes : https://tracker.ceph.com/issues/46906
Signed-off-by: Simon Gao <simon29rock@gmail.com>
2020-08-13 09:51:45 +08:00
Lenz Grimmer
34a4e1284d
Merge pull request #36119 from votdev/issue_44831_deploy_service
mgr/dashboard: Create Ceph services via Orchestrator by using ServiceSpec

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2020-08-12 18:05:25 +02:00
Ilya Dryomov
f8a9880cbb qa: update krbd tests for snap create
"rbd snap create" now reports progress.  Pass --no-progress, as in
commit b5a5fea9e2 ("test/cli-integration/rbd: tweak after snap create
started to show progress").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2020-08-12 17:49:00 +02:00
Yuri Weinstein
681008a73c
Merge pull request #36569 from yuriw/wip-yuriw-crontab-master
qa/tests: use "-k distro" for all suites (except krbd)

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-08-12 07:43:20 -07:00
Abhishek L
d0a18dd52e
Merge pull request #36570 from theanalyst/doc/releases/v14.2.11
doc: releases: notes for v14.2.11 nautilus

Reviewed-By: Neha Ojha <nojha@redhat.com>
Reviewed-By: Josh Durgin <jdurgin@redhat.com>
Reviewed-By: Patrick Donelly <pdonell@redhat.com>
2020-08-12 16:10:57 +02:00
lixiaoy1
0e4fd58528 rbd/rwl: fix the construction of ContextWQ
Fix the build issue caused by the commit c11594a which changed the constructor
of ContextWQ.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
2020-08-12 07:24:30 -04:00
Alfonso Martínez
01457ef996 mgr/dashboard: log useful information from internal server errors
Fixes: https://tracker.ceph.com/issues/46899
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2020-08-12 13:22:27 +02:00
lixiaoy1
fd8e68fe0f rbd/status: get image cache state
Signed-off-by: Peterson, Scott <scott.d.peterson@intel.com>
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
Signed-off-by: Lu, Yuan <yuan.y.lu@intel.com>
Signed-off-by: Chamarthy, Mahati <mahati.chamarthy@intel.com>
2020-08-12 06:34:15 -04:00
Volker Theile
4e9c88649d mgr/dashboard: Strange iSCSI discovery auth behavior
Disable 'autocomplete' for the user and password form fields.

Fixes: https://tracker.ceph.com/issues/46900

Signed-off-by: Volker Theile <vtheile@suse.com>
2020-08-12 11:58:15 +02:00
Abhishek Lekshmanan
0ceb0beb4d doc: releases: notes for v14.2.11 nautilus
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2020-08-12 11:54:09 +02:00
Lenz Grimmer
4fa1eaf2f6
Merge pull request #36550 from tspmelo/wip-npm-update
mgr/dashboard: Update npm packages

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-08-12 09:48:59 +02:00
Jan Fajerski
0490cd8bb3
Merge pull request #36565 from jan--f/c-v-py3-flake8
ceph-volume: run flake8 in python3
2020-08-12 09:21:17 +02:00
Patrick Donnelly
dc06096a2d
Merge PR #36351 into master
* refs/pull/36351/head:
	qa/tasks/cephfs/nfs: Add tests for cluster config set and reset
	doc/cephfs/nfs: Update the doc about 'reset' and 'set' config interfaces
	mgr/volumes/nfs: Add interface for adding user defined configuration

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-08-11 15:55:52 -07:00