Commit Graph

104870 Commits

Author SHA1 Message Date
Sergio de Carvalho
f9d7b685c1 rgw: improvements to SSE-KMS with Vault
* Minor improvements to Vault documentation
* Add teuthology tests for Transit secrets engine
* Add unit tests for KV secrets engine, minor improvements to Transit
  secrets engine
* use string_view::npos instead of string::npos

Signed-off-by: Andrea Baglioni <andrea.baglioni@workday.com>
Signed-off-by: Sergio de Carvalho <sergio.carvalho@workday.com>
2019-11-28 09:19:39 +00:00
Andrea Baglioni
cebb48bffe rgw: Vault's Transit Secrets updates and docs
* Drop polymorfism for KMS class
  * Fix issue in kms-key selection
  * Update documentation for Vault section

 Signed-off-by: Andrea Baglioni <andrea.baglioni@workday.com>
 Signed-off-by: Sergio de Carvalho <sergio.carvalho@workday.com>
2019-11-28 09:19:39 +00:00
Andrea Baglioni
a41832eb42 rgw: Add support to Vault's Transit Secrets Engine in SSE-KMS
* refactor rgw_kms.cc to support extension to multiple secret engines.
* introduced support to Vault Namesapces
* added support for Vault Agent

Signed-off-by: Andrea Baglioni <andrea.baglioni@workday.com>
Signed-off-by: Sergio de Carvalho <sergio.carvalho@workday.com>
2019-11-28 09:19:39 +00:00
Jianpeng Ma
755c7c2c26 os/bluestore: don't round_up_to in apply_for_bitset_range.
I met the following error messages:
>sceph7: /home/Jianpeng/ceph/src/os/bluestore/bluestore_common.h: In function 'void apply_for_bitset_range(uint64_t, uint64_t, uint64_t, Bitset&, Func) [with Bitset = boost::dynamic_bitset<long unsigned int>; Func = BlueFS::_replay(bool, bool)::<lambda(uint64_t, boost::dynamic_bitset<long unsigned int>&)>; uint64_t = long unsigned int]' thread 7f7d55a3dd40 time 2019-11-27T23:26:05.949827+0800
>sceph7: /home/Jianpeng/ceph/src/os/bluestore/bluestore_common.h: 28: FAILED ceph_assert(end <= bitset.size())
>sceph7:  ceph version 15.0.0-7747-g22a9a28e28 (22a9a28e28) octopus (dev)
>sceph7:  1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x14f) [0x56322c4440ef]
>sceph7:  2: (()+0x50d2d9) [0x56322c4442d9]
>sceph7:  3: (BlueFS::_replay(bool, bool)+0x5639) [0x56322cb51e49]
>sceph7:  4: (BlueFS::mount()+0x269) [0x56322cb53289]
>sceph7:  5: (BlueStore::_open_bluefs(bool)+0x29e) [0x56322ca6e38e]
>sceph7:  6: (BlueStore::_open_db(bool, bool, bool)+0x59b) [0x56322ca6e9cb]
>sceph7:  7: (BlueStore::mkfs()+0x749) [0x56322caaa259]
>sceph7:  8: (OSD::mkfs(CephContext*, ObjectStore*, uuid_d, int)+0x1c8) [0x56322c5099e8]
>sceph7:  9: (main()+0x1787) [0x56322c4ab117]
>sceph7:  10: (__libc_start_main()+0xeb) [0x7f7d55b5fb6b]
>sceph7:  11: (_start()+0x2a) [0x56322c4de71a]
>sceph7: *** Caught signal (Aborted) **
>sceph7:  in thread 7f7d55a3dd40 thread_name:ceph-osd

If bdev[i]->get_size() / alloc_size[i] != 0,  round_up_to(off+lengh,alloc_size[i])/alloc_size is larger than(one)
ownend_blocks[i].size().

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-11-28 16:23:01 +08:00
Thomas Bechtold
45bae8219a ceph-daemon: Allow env var for setting the used image
Instead of always adding "--image my-custom-image" when calling
ceph-daemon with a non-standard image, allow to set the environment
variable called CEPH_DAEMON_IMAGE which will adjust the --image
default.
That way, the command line arguments when using ceph-daemon with a
custom image are a bit shorter.

Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
2019-11-28 09:06:18 +01:00
Tim Serong
49659746e2 mgr/orchestrator: set node labels to empty list if none specified
f06366836f tries to ' '.join(node.labels), which raises an exception
if labels is None, so we need to default it to an empty list.

Signed-off-by: Tim Serong <tserong@suse.com>
2019-11-28 16:26:15 +11:00
Jianpeng Ma
6aa830b5b1 osd: remove useless ceph_assert.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2019-11-28 13:21:49 +08:00
Neha Ojha
0cd95b9f0f
Merge pull request #31588 from usefulalgorithm/patch-1
doc/rados/operations: OSD_OUT_OF_ORDER_FULL fullness order is wrong

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-11-27 17:33:38 -08:00
David Zafman
9d2e0267e1 test: Add test case based on Xie script in commit comment
Other test fixes to reflect changes

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
f38d38398f osd: ceph_pg_upmaps() use any overfull when there are still underfull
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
fe03383e66 osd: Create more_underfull with below target that aren't in underfull
Use more_underfull for finding remaps for overfull OSDs

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
3f132061fd osd: calc_pg_upmaps() pick most overfull remap from try_pg_upmap()
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
7f4ae93123 osd: ceph_pg_upmaps() use max_deviation to determine perfect distribution
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
f165d4ca39 tools: osdmaptool sync with balancer module behavior
This can be backported only to nautilus

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
b946308f03 tools: osdmaptool: Perform upmap calculation as ceph-mgr does
This is the backportable commit that works with older balancer module.py

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
3eb69fd0cb osd: For balancer crush needs the rule passed to get_parent_of_type()
Fixes: https://tracker.ceph.com/issues/42718

Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
91bab14ea0 osdmaptool: Match default max value of 10
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
a49324ceb9 tools: odsmaptool truncate target upmap file
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
David Zafman
0af7e25620 mgr: Fix balancer print
Signed-off-by: David Zafman <dzafman@redhat.com>
2019-11-27 16:29:29 -08:00
Sage Weil
6a1c1a120c Merge PR #31870 into master
* refs/pull/31870/head:
	ceph-daemon: fix `systemctl is-enabled` bool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-27 14:20:33 -06:00
Sage Weil
006b789148 Merge PR #31886 into master
* refs/pull/31886/head:
	ceph-daemon: error out if not root
	ceph-daemon: user-friendly exception/error messages
	ceph-daemon: user-friendly exception/error messages

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2019-11-27 14:20:04 -06:00
Jan Fajerski
b9578b407b
Merge pull request #31883 from jan--f/ceph-volume-code-owner
github/codeowners: add ceph-volume
2019-11-27 16:36:23 +01:00
Sage Weil
b2d9e1a219 Merge PR #31892 into master
* refs/pull/31892/head:
	ceph-daemon: seek relative to the start of file

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-11-27 08:36:12 -06:00
Sage Weil
e4930055c1 Merge PR #31899 into master
* refs/pull/31899/head:
	mgr: drop session with Ceph daemon when not ready
	mgr: improve debug message information

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-27 08:04:14 -06:00
Sage Weil
c8fa419326 ceph-daemon: error out if not root
Signed-off-by: Sage Weil <sage@redhat.com>
2019-11-27 08:01:45 -06:00
Michael Fritch
239f820112 ceph-daemon: user-friendly exception/error messages
- Rename `CDError` to `Error`
- Display traceback on console when `-v` is specified
- Other misc clean-up

Signed-off-by: Michael Fritch <mfritch@suse.com>
2019-11-27 08:01:26 -06:00
Sebastian Wagner
fc3fdece30
Merge pull request #30262 from sebastian-philipp/orchestrator-pomise-future
mgr/orchestrator: Make Completions composable

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Joshua Schmid <jschmid@suse.de>
2019-11-27 14:58:21 +01:00
Ricardo Marques
c797fed2a8 mgr/dashboard: Trim IQN on iSCSI target form
Fixes: https://tracker.ceph.com/issues/43027

Signed-off-by: Ricardo Marques <rimarques@suse.com>
2019-11-27 13:09:00 +00:00
Sebastian Wagner
7a801cb13f mgr/ssh: Disable host labels.
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:49:02 +01:00
Kefu Chai
0abd3f4a11
Merge pull request #31896 from rsevero/missing_virtualenv
doc: add missing virtualenv for build-doc

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-11-27 20:48:40 +08:00
Tim Serong
0eaa7710c0 mgr/orchestrator: use finalize to set TrivialReadCompletion result
This is needed to correctly set the state of the completion, so that
Completion.has_result returns true.  Without this, _orchestrator_wait()
will spin forever if given a TrivialReadCompletion.

Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:39:12 +01:00
Sebastian Wagner
7b95f0316d mgr/orchestrator: add pretty_print()
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:39:11 +01:00
Sebastian Wagner
e58885dc98 mgr/ssh: Fix Promises
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:39:11 +01:00
Sebastian Wagner
30437ba2eb import typing optionally
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
431e801f89 Fix testing error
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
cf38941628 mgr/deepsea: Fixed DeepSeaReadCompletion arguments
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
65a9c9aa6d mgr/orchestrator: fix tests
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
07121b9b4f make check fixes
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
310f5090ab mgr/orchstrator: Removed all type anotations incompatible to Python 2
* Reduce mypy's type checking capability
* Remove useful code documentation

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
a74d57bcb2 doc/orchestrator: Adapted to new Completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
de0c198932 mgr/orchestrator: add cancel
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
6abc9e95bd qa/orchestrator: Adapt teuthology test to new completions
Also: Adapt mgr/test_orchestrator to new completions

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
d15aba9039 mgr/deepsea: Adapt to new orchestrator completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
5191e82a88 mgr/ansible: Adapt to new orchestrator completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
f3ea1f18e2 mgr/ssh: Adapt ssh orch to new Completions interface
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:38:20 +01:00
Sebastian Wagner
bf552615f2 mgr/rook: Adapt to new completions
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:35:24 +01:00
Sebastian Wagner
7a432a0225 mgr/orchestrator: Introduce composable completions
Also:

* unify Read and Write completions
* Distinguish should_wait and is_finished
* Removed `all_hosts` parameter to `osd_create`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:35:24 +01:00
Sebastian Wagner
8fa14ad3b8 mgr/orchestrator: rename wait() -> process()
Because wait() should actually not wait!

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-11-27 13:35:24 +01:00
Kefu Chai
f16d664749
Merge pull request #31904 from tchaikov/wip-crimson-stop-msgr-after-stopping-osd
crimson: stop osd before stopping messengers

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-11-27 19:46:42 +08:00
Volker Theile
c82901632f mgr/dashboard: Remove unused variable
Signed-off-by: Volker Theile <vtheile@suse.com>
2019-11-27 12:12:55 +01:00